mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-07 18:26:17 +00:00
* feat(media-use): color grading — grade/lut resolve, smart-grade, grade-compare CLI Add color grading to media-use as first-class resolve types plus a faithful comparison command. All local, offline, deterministic — no model, no GPU. - resolve -t grade / -t lut: produce a data-color-grading block (or a frozen .cube). Look cascade: core preset (no file) -> bundled .cube library -> parametric buildCube. Emitted .cube is Rec.709 and validated against core's colorLuts constraints (LUT_3D_SIZE <= 64) before it is frozen. - smart grade (grade --for <media>): ffmpeg signalstats -> adjust suggestion (exposure / contrast / white balance), surfaced with the measured evidence on stderr as a starting point; never auto-applied. - hyperframes grade-compare: renders N candidate grades onto a reference frame through the real runtime shader into one labeled comparison PNG, so an agent picks a look without opening Studio. Prepends an "original" baseline cell by default (--no-baseline to omit). Shares the headless-capture pipeline with snapshot via capture/captureCompositionFrame. - media-use SKILL: proactive "media opportunity pass" guidance (grounded signal -> offer, ask once, surface don't mutate). Verified: media-use 116/116, grade-compare 7/7, snapshot 9/9, lint + format clean, full build green, comparison renders end to end. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * test(cli): narrow grade-compare baseline assertion off unknown-typed grading Assert the whole cell via toEqual instead of reaching into .grading.preset / .grading.lut on the unknown-typed field, keeping the test typecheck-clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * feat(media-use): agent-authored LUTs via --params + validate --from cube; never-read-.cube guardrail - resolve -t lut / -t grade --params '<json>': build a parametric .cube from explicit params (bypassing the intent cascade), validate, and freeze in one step. --intent becomes the optional description. Lets an agent commit a look it computed itself. - --from <file.cube> now validates the ingested LUT for lut/grade types and rejects an invalid/oversized cube (no partial write) — the escape hatch for a LUT the agent generated with its own code. - SKILL.md: hard rule to never read a .cube body into context (~size^3 lines, zero legible signal) — inspect via grade-compare (see it) or cube-validate (ok/size), read the manifest description for meaning; plus both authoring paths and the parametric-vs-film-stock ceiling note. Verified: media-use 116/116, lint + format clean; smokes — --params builds a valid frozen cube, grade --params returns a lut block, bad JSON and an oversized --from cube are both rejected with no stray file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(cli): grade-compare validates referenced LUTs, warns on no-op cells, caps candidates Bug-bash follow-ups — grade-compare silently accepted bad input: - Validate LUT *content*, not just existence: each referenced .cube is parsed with core's parseCubeLut (now exported from @hyperframes/core) and rejected with a per-cell error ("LUT for \"<label>\" is not a valid .cube: ..."). A file that exists but isn't a valid cube no longer renders a silent no-op cell. - Warn on inactive cells: a grading that normalizes to inactive (e.g. a malformed {lut:12345}) emits a stderr warning naming the cell; the auto-prepended "original" baseline is intentionally inactive and stays silent. stdout remains valid JSON. - Cap candidates at 16 (excluding baseline): over-cap input renders the first N and reports {truncated:true, total:M} on stdout + a stderr note — no silent drop, no unbounded giant sheet. Verified: grade-compare 10/10; non-cube LUT → clear error; {lut:12345} → warning + ok; 20 cells → cells=17 truncated total=20; valid runs unchanged. Lint/format clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * feat(cli): general `hyperframes compare` visual-variant primitive Generalize grade-compare's "render N variants → one labeled sheet → the agent looks and picks" loop into a standalone command that works on ANY variation (font, layout, motion, grade, whole compositions) — the tool never needs to know what differs. - `hyperframes compare <path...> [--at <sec>] [--labels a,b,c] [--out] [--cols] [--json]`: renders each agent-authored composition variant through the real runtime (captureCompositionFrame) and stitches one labeled comparison sheet + JSON ({ok, sheet, rendered, variants, truncated?/total?}). 2+ paths required; caps at 16 with loud truncation. It presents, it does not judge — choosing is the caller's job. - Factored the shared "render a labeled set → contact sheet" path so compare, grade-compare, and snapshot all sit on it (no duplication). grade-compare is now the first color-specific specialization of this primitive. - New pathArgs util + contactSheet test; hyperframes-cli SKILL documents compare as the agent's "see your own renders and choose" primitive. Verified: 26/26 across compare + grade-compare + snapshot + contactSheet (no regressions); compare renders 3 variants into one visibly-distinct labeled sheet; 2+-path error path clean; lint/format clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(ci): green the skills CI — skip ffmpeg tests when absent, oxfmt markdown The "Test: skills" CI job runs bare `node --test` with no ffmpeg on PATH (by design — skills tests are meant to be node-builtin-only). The grade-analyzer + smart-grade tests shell to ffmpeg and were failing there with ENOENT. Guard them to skip when ffmpeg isn't on PATH; they still run locally / where it is. Also oxfmt README.md + hyperframes/media-use SKILL.md (the whole-repo `oxfmt --check .` Format job caught markdown left unformatted by the rebase conflict resolution). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(ci): skip core-conformance test when tsx is unavailable The "Test: skills" CI job installs no deps, so the normalizeHfColorGrading conformance test (which imports core's TS via `node --import tsx`) failed there. Guard it to skip when tsx can't resolve; runs locally / in the deps-installed Test job. Completes the skills-CI greening (the ffmpeg guards handled the rest). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(cli): escape grade-compare src double-quotes (CodeQL XSS) + Windows-safe compare test - grade-compare built `<img src="...">` (double-quoted) with the single-quote escaper, leaving `"` unescaped — a `"` in the frame path could break out (CodeQL: incomplete HTML attribute sanitization). Use escapeXml for src. - compare label test hard-coded POSIX paths that can't match on Windows; assert the derived labels (the subject); path resolution is covered elsewhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * refactor(media-use): generate LUT library from params (drop committed .cube files) The 3 bundled .cube files were 733 lines each (2,199 total) and were themselves buildCube output — pure repo bloat. Replace with compact per-look params in luts/index.json, generated on resolve; add an optional `url` for future scanned LUTs to be CDN-hosted + downloaded on demand (freezeUrl) instead of committed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * feat(media-use): serve library LUTs from CDN on-demand (static.heygen.ai/luts), params fallback Looks now carry a CDN `url` (hosted at s3://heygen-public/luts → static.heygen.ai/luts/<id>.cube); resolve downloads + validates + freezes on demand, like bgm/image. `params` stays as the deterministic offline fallback (--local-only, or if the download fails), so resolution is never blocked on the network. Provider prefers url, falls back to params. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(media-use): address #2041 review — atomic LUT writes, compare telemetry, follow-ups - Atomic .cube writes: library provider (url + params) and the parametric generator now write to a .tmp path, validate, then rename, so a crash can never orphan an invalid .cube at the final path (was validate-after-write). - track("media_use_resolve") now emits provenance.via (url/params-fallback/params). - grade-compare + compare: --timeout flag (was hardcoded 5000) and a media_use_compare event (cells, truncated, total, render_ready_timed_out); openSettledCompositionPage now surfaces the render-ready timeout. - compare staging skips node_modules/.git; --for gets an upfront existence check. - Rec.709 luma comment; HYPERFRAMES_ANALYZE_TIMEOUT_MS override; measured note uses basename; LUT s3 hosting moved from index.json into luts/README.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
167 lines
6.3 KiB
JavaScript
167 lines
6.3 KiB
JavaScript
import { strict as assert } from "node:assert";
|
|
import { test } from "node:test";
|
|
import { getProviders, getProvider, listTypes, runProviders, runCapability } from "./registry.mjs";
|
|
|
|
// --- registry shape -------------------------------------------------------
|
|
|
|
test("listTypes exposes the v2 media types", () => {
|
|
const types = listTypes();
|
|
for (const t of ["bgm", "sfx", "image", "icon", "logo", "voice", "brand", "grade", "lut"]) {
|
|
assert.ok(types.includes(t), `missing type: ${t}`);
|
|
}
|
|
});
|
|
|
|
test("heygen provider is first for every type it serves", () => {
|
|
for (const t of ["bgm", "sfx", "image", "icon"]) {
|
|
const first = getProviders(t)[0];
|
|
assert.ok(first, `no enabled provider for ${t}`);
|
|
assert.match(first.name, /^heygen/, `${t} first provider is ${first.name}`);
|
|
}
|
|
});
|
|
|
|
test("sanctioned providers only: heygen, local mflux/kokoro, codex, design spec, logo tiers", () => {
|
|
const allowed =
|
|
/^heygen|^mflux\.local$|^kokoro\.local$|^codex\.image_gen$|^design_spec$|^svgl$|^simple-icons$|^github\.avatar$|^favicon\.ddg$|^color_grade\.local$|^cube_lut\.local$/;
|
|
for (const t of listTypes()) {
|
|
for (const p of getProviders(t)) {
|
|
assert.ok(allowed.test(p.name), `${t} lists unsanctioned provider: ${p.name}`);
|
|
}
|
|
}
|
|
});
|
|
|
|
test("image cascade: heygen catalog, then local mflux, then the codex upsell", () => {
|
|
const ps = getProviders("image");
|
|
assert.match(ps[0].name, /^heygen/, "heygen catalog first");
|
|
const names = ps.map((p) => p.name);
|
|
const mflux = ps.find((p) => p.name === "mflux.local");
|
|
const codex = ps.find((p) => p.name === "codex.image_gen");
|
|
assert.ok(mflux && typeof mflux.generate === "function", "local mflux registered");
|
|
assert.ok(codex && typeof codex.generate === "function", "codex upsell registered");
|
|
assert.ok(names.indexOf("mflux.local") < names.indexOf("codex.image_gen"), "local before codex");
|
|
assert.ok(!mflux.network, "local mflux is kept under --local-only");
|
|
assert.ok(codex.network, "codex is network (skipped under --local-only)");
|
|
});
|
|
|
|
test("voice cascade: local Kokoro first (free), HeyGen TTS as the paid upsell", () => {
|
|
const ps = getProviders("voice");
|
|
assert.equal(ps[0].name, "kokoro.local", "local Kokoro comes first now (HeyGen TTS is paid)");
|
|
assert.ok(!ps[0].network, "local Kokoro kept under --local-only");
|
|
assert.ok(!ps[0].paid, "local Kokoro is free");
|
|
const heygen = ps.find((p) => p.name === "heygen.tts");
|
|
assert.ok(heygen && heygen.paid, "HeyGen TTS is the paid upsell");
|
|
assert.ok(heygen.network, "HeyGen TTS is network (skipped under --local-only)");
|
|
});
|
|
|
|
test("ctx.provider forces one generator (e.g. 'make an image WITH codex')", async () => {
|
|
const providers = [
|
|
{ name: "heygen.asset.search", network: true, search: async () => null },
|
|
{ name: "mflux.local", generate: async () => ({ hit: "local" }) },
|
|
{ name: "codex.image_gen", network: true, generate: async () => ({ hit: "codex" }) },
|
|
];
|
|
// no override: local wins (first generate to return non-null)
|
|
assert.deepEqual(await runProviders(providers, "generate", "x", {}), { hit: "local" });
|
|
// override to codex: skip local, use codex even though local would have worked
|
|
assert.deepEqual(await runProviders(providers, "generate", "x", { provider: "codex" }), {
|
|
hit: "codex",
|
|
});
|
|
// override matches the full name too
|
|
assert.deepEqual(
|
|
await runProviders(providers, "generate", "x", { provider: "codex.image_gen" }),
|
|
{ hit: "codex" },
|
|
);
|
|
// --local-only wins even over a forced network provider: no network call,
|
|
// clean miss (the caller surfaces the conflict). A forced LOCAL provider under
|
|
// --local-only still runs.
|
|
assert.equal(
|
|
await runProviders(providers, "generate", "x", { provider: "codex", localOnly: true }),
|
|
null,
|
|
);
|
|
assert.deepEqual(
|
|
await runProviders(providers, "generate", "x", { provider: "mflux", localOnly: true }),
|
|
{ hit: "local" },
|
|
);
|
|
});
|
|
|
|
test("getProvider returns the first provider with its type, throws for unknown", () => {
|
|
const p = getProvider("bgm");
|
|
assert.equal(p.type, "bgm");
|
|
assert.equal(typeof p.search, "function");
|
|
assert.throws(() => getProvider("unknown_type"), /unknown media type/);
|
|
});
|
|
|
|
test("getProviders throws for unknown type", () => {
|
|
assert.throws(() => getProviders("nope"), /unknown media type/);
|
|
});
|
|
|
|
// --- deterministic capability execution (runProviders core) ---------------
|
|
|
|
test("runProviders calls providers in order and returns the first non-null", async () => {
|
|
const calls = [];
|
|
const providers = [
|
|
{
|
|
name: "a",
|
|
enabled: true,
|
|
search: async () => {
|
|
calls.push("a");
|
|
return null;
|
|
},
|
|
},
|
|
{
|
|
name: "b",
|
|
enabled: true,
|
|
search: async () => {
|
|
calls.push("b");
|
|
return { hit: "b" };
|
|
},
|
|
},
|
|
{
|
|
name: "c",
|
|
enabled: true,
|
|
search: async () => {
|
|
calls.push("c");
|
|
return { hit: "c" };
|
|
},
|
|
},
|
|
];
|
|
const res = await runProviders(providers, "search", "x", {});
|
|
assert.deepEqual(res, { hit: "b" });
|
|
assert.deepEqual(calls, ["a", "b"], "must stop at first non-null, never call c");
|
|
});
|
|
|
|
test("runProviders skips providers missing the requested capability", async () => {
|
|
const providers = [
|
|
{ name: "a", enabled: true /* no search */ },
|
|
{ name: "b", enabled: true, search: async () => ({ hit: "b" }) },
|
|
];
|
|
const res = await runProviders(providers, "search", "x", {});
|
|
assert.deepEqual(res, { hit: "b" });
|
|
});
|
|
|
|
test("runProviders returns null when no provider yields a result", async () => {
|
|
const providers = [{ name: "a", enabled: true, search: async () => null }];
|
|
assert.equal(await runProviders(providers, "search", "x", {}), null);
|
|
});
|
|
|
|
test("runCapability('bgm','process') is null — process slot is graceful when unfilled", async () => {
|
|
assert.equal(await runCapability("bgm", "process", "x", {}), null);
|
|
});
|
|
|
|
test("--local-only skips every network provider (even free remote ones)", async () => {
|
|
let remoteRan = false;
|
|
const providers = [
|
|
{
|
|
name: "heygen",
|
|
network: true,
|
|
search: async () => {
|
|
remoteRan = true;
|
|
return { hit: "net" };
|
|
},
|
|
},
|
|
{ name: "local", search: async () => ({ hit: "local" }) },
|
|
];
|
|
assert.deepEqual(await runProviders(providers, "search", "x", { localOnly: true }), {
|
|
hit: "local",
|
|
});
|
|
assert.equal(remoteRan, false, "the remote provider must not be called offline");
|
|
});
|