mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-15 13:58:20 +00:00
* fix(slideshow): address code-review findings #1580-1584
- player: bundle @hyperframes/core into the IIFE/global build (noExternal)
- player: resolve audience mode from ?mode=audience URL query, not just attr
- player: event-driven waitForScenes + loud failure when no slides resolve
- player: scope window keydown so Space/Backspace don't hijack the host page
- player: audience mirrors full position (branch + fragment) via syncTo
- player: next() reveals remaining fragments even at slide end; enterBranch ignores empty sequences
- core: harden extractScenes against null/non-object scene entries
- core: strict manifest validation; error on inverted ranges & empty hotspot targets; dedup fragments
- core/lint: accept data-end/timeline-derived scene durations (match runtime)
- core+studio: share ISLAND_TYPE + island regex from @hyperframes/core/slideshow
- studio: SlideList reflects manifest slide order; branch-slide authoring (notes/fragments/hotspots)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(player): slideshow fullscreen + presenter-view rework
- fullscreen toggle in the nav chrome (button + 'F' key); standard Fullscreen
API on the <hyperframes-slideshow> element, icon reflects state
- presenter console: live slide on top, speaker-notes panel below, with the nav
controls shown in-view; Present button hides once presenting (harness)
- audience (viewer) window: chrome reduced to a fullscreen-only control, no nav
- fix: audience / back() / backToMain() mirror stayed frozen on the first frame —
a bare paused seek does not repaint some compositions. resumeSlide now plays a
brief render-nudge (RENDER_NUDGE) past the target so the composition paints,
then onTime pauses at the hold
- refactor: extract reusable buildNavCluster() + wireChromeButtons(); rework
buildPresenterLayout into the bottom notes panel
- example: airbnb-deck presenter-test.html harness (Present button + 'F')
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(player): slideshow no auto-progress + presenter slide fits/pins
- navigation jumps to a static frame instead of auto-playing the timeline:
playTo() seeks to the hold (+ a brief RENDER_NUDGE to repaint) rather than
sustaining playback, so slides hold until the user advances
- presenter view: pin the live slide to the top and confine the player to the
region above the notes panel, so the player CONTAINS the composition — the
full slide stays visible (letterboxed) at any width and re-fits on resize;
its bottom is no longer cut off by the notes panel
- tests: seek targets updated for the render-nudge offset
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(slideshow): presenter nav flash, slide-1 boundary, branch buttons
Three presenter-mode fixes from testing the airbnb deck: (1) navigation flash — seek to the exact target then play forward to repaint, instead of seeking backward (t-0.2) which painted the previous scene at boundaries; split hold into holdTarget (logical) and holdAt (target+nudge, clamped to slide.end). (2) slide-1 boundary — no-fragment slides rest at the slide midpoint, not slide.end. (3) presenter branch buttons — surface hotspots as buttons in the presenter console (the on-slide pill is lost in the letterboxed view). Also extract paintChrome() to dedupe the three chrome-render sites.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(slideshow): stop presenter nav buttons flickering / dropping clicks
The presenter elapsed clock called render() every second, which rebuilt the
entire chrome (innerHTML) including the nav buttons — they flickered and any
click landing mid-rebuild was lost. The 1s tick now updates only the elapsed
text node; the nav buttons are rebuilt only on actual navigation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(slideshow): CSP-safe nav hover, UUID editor ids, manifest version
Addresses review feedback on the split stack:
- CSP: replace the 8 inline onmouseover/onmouseout handlers on the nav
buttons with a [data-hf-nav-cluster] button:hover CSS rule (injected once
per document). No inline event handlers → works under strict CSP.
- IDs: studio sequence/hotspot id generation used Date.now() (sub-ms
collision on rapid clicks) — now crypto.randomUUID().
- Versioning: stamp version on the persisted manifest island (preserving an
existing one); add the optional version field + SLIDESHOW_MANIFEST_VERSION
to the core schema so future schema changes can migrate older islands.
These live on the review-fixes tip (consistent with the stack's fixup-on-tip
model); the touched code belongs to ss-player-b (#1590), ss-studio-a/b
(#1591/#1592), and ss-core (#1580).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(ci): fix format + fallow gates for slideshow stack
- .prettierignore: exclude generated demo compositions (registry/examples/**/*.html)
from oxfmt — large video-pipeline output (GSAP/Three/WebGL), not hand-authored
source. Was failing 'Format' repo-wide (pre-existing on main via #1584).
- .fallowrc: exempt SlideshowPanel.tsx (health/complexity — section fan-out) and
the slideshowPanelHelpers.ts / SlideshowPanel.test.ts parallel-structure clones
(duplicates.ignore). File-level config, not inline comments — inline shifts line
numbers and breaks fallow's inherited-finding fingerprint (per existing rc note).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(slideshow): address PR review + CodeQL findings
- CodeQL #638 (parseSlideshow): complete the regex metachar escape in
slideshowIslandRegex (was missing backslash); add JSDoc on the factory +
lastIndex caveat (reviewer 5a/16).
- CodeQL #639/#640 + review items 13/17: remove registry/examples/airbnb-deck/
presenter-test.html — a generated test harness (postMessage w/o origin check,
proto-pollution) that was scope-creep into a fix PR and a 3rd duplicate island.
Regenerate locally via the scratchpad script when testing.
- Review item 15 (docs drift in skills/slideshow/SKILL.md): lint resolves scenes
by data-composition-id only (not .clip[id]); fragments are valid INCLUSIVE of
[start,end], not 'strictly inside'.
IIFE bundles core confirmed (0 external @hyperframes/core refs in the slideshow
global build). format/lint/fallow green.
* feat(cli): add 'present' command — serve a deck in presenter mode
hyperframes present [dir] starts a lightweight HTTP server, wraps the
composition in <hyperframes-slideshow> with its island inlined, and opens
the browser. A real HTTP origin is required for presenter mode: present()
opens the audience window via window.open(?mode=audience) and the two sync
over BroadcastChannel — neither works from file://.
- New utils/compositionServer.ts factors the server scaffolding shared with
'play' (resolve runtime/player/slideshow bundles, inject runtime, asset
content-types, bind to a free port); play.ts now uses it too.
- Errors clearly if the deck has no slideshow island.
- .fallowrc: exempt the play/present command entrypoints (validation + server
wiring) and the per-command startup/logging block from the complexity /
duplication gates.
Verified end-to-end against registry/examples/airbnb-deck: server serves the
wrapper + assets, the component binds and renders (counter 1 / 11).
* fix(cli): present renders the deck (player sizing + self-driving serve)
Two bugs caused a black slide area:
- The <hyperframes-player> had no positioning, so its iframe collapsed to
zero size — the (absolutely-positioned) chrome showed but the composition
didn't. Add position:absolute; inset:0 (matches demo.html).
- The composition was served with the engine runtime injected, which leaves
its timelines engine-paused (blank). Slideshow decks self-drive their own
timelines (like demo.html / the standalone harness), so serve them raw.
Verified end-to-end on registry/examples/airbnb-deck: cover renders, Next
advances 1/11 -> 2/11 and slide 2 paints.
* fix(cli): present plays slideshow sound effects
The composition (in the player's sandboxed iframe) posts
{ type: 'hf-sfx', name } to the parent on nav, but the iframe is
autoplay-blocked — audio must play in the parent that owns the user gesture.
Add the parent-side hf-sfx handler (the 4 standard clips advance/fragment/
branch-enter/back, served from the deck's sfx/ under /composition/sfx/),
gesture-unlocked and mute-aware, in both presenter and audience windows.
Verified: sfx serve 200 (audio/mpeg) and Next delivers [advance, fragment]
to the parent handler.
* feat(examples): softer mellow slideshow sfx for airbnb-deck
Replace the aggressive percussive pops with gentle sine-tone cues (warm
pitches C5/G4/E5/F4, 12ms attack + exponential decay, lowpassed) — advance/
fragment/branch-enter/back. Much lighter; fragment is the most subtle.
* feat(examples): whoosh + sparkle slideshow sfx for airbnb-deck
Replace the sine-tone cues with airy, designed sounds:
- advance: a soft whoosh (band-limited pink noise, bell-shaped swell)
- back: that whoosh reversed and darkened
- fragment: a light sparkle (staggered high chime blips)
- branch-enter: whoosh + a trailing sparkle (magical entry)
* feat(examples): directional whoosh + richer branch-enter cue (airbnb-deck)
- Going backward a slide now plays the reverse whoosh (back), not advance —
the sfx logic detects nav direction by scene order instead of firing advance
for every scene change.
- branch-enter is now a more interesting magical cue: a faint whoosh + an
ascending C5-E5-G5-C6 chime arpeggio + a trailing sparkle.
Verified: next then prev fires [advance, fragment, back]; no page errors.
* fix(cli): harden present sfx handler + mute-hover affordance (R2 review)
Addresses Rames R2 items 19-21:
- 20: the present audio handler reintroduced the CodeQL classes removed with
presenter-test.html — add an origin check (same-origin composition iframe)
and an own-property guard so a 'name' like __proto__ can't resolve to and
mutate Object.prototype.
- 21: assetContentType used a bare index lookup (ext='__proto__' -> prototype);
guard with Object.hasOwn.
- 19: the CSP hover rule erased the speaker button's muted color; add a
higher-specificity [data-hf-muted] [data-hf-mute]:hover override.
Verified: hf-sfx origin matches location.origin (guard passes), advance/fragment
still fire, deck renders + advances. Items 14/18/22 deferred (minor, pre-existing).
* fix(slideshow): address remaining R2 items (14/18/22) + re-remove harness
- 14: resumeSlide now mirrors enterSlide — a no-fragment slide resumes at its
midpoint (visible-at-rest), not frame-0; fragmented slides still resume to the
saved fragment or slide.start. Added a dedicated test naming the heuristic.
- 18: fullscreenchange swaps only the fullscreen glyph + aria (hoisted SVGs to
module consts) instead of re-rendering the whole chrome.
- 22: .prettierignore lists the specific generated demo compositions instead of
blanket registry/examples/**/*.html, so hand-authored example HTML still formats.
- presenter-test.html: a stray 54a4460 git add -A had re-added the deleted
harness (reviving CodeQL #639/#640); remove it again.
106 slideshow tests pass; tsc/lint/fallow/format clean; deck still renders.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
126 lines
4.2 KiB
TypeScript
126 lines
4.2 KiB
TypeScript
/**
|
|
* Routes postMessages from the composition iframe to the appropriate handlers.
|
|
*
|
|
* Accepts the raw MessageEvent and delegates through typed callbacks so the
|
|
* web component keeps its state fields private and this module stays stateless.
|
|
*/
|
|
|
|
import {
|
|
applyRuntimeStateMessage,
|
|
type PlaybackState,
|
|
type PlaybackStateCallbacks,
|
|
} from "./playback-state.js";
|
|
import type { ShaderLoaderState } from "./shader-loader-state.js";
|
|
import type { ShaderTransitionState } from "./shader-options.js";
|
|
|
|
const FPS = 30;
|
|
|
|
type SceneRecord = { id: string; start: number; duration: number };
|
|
|
|
function extractScenes(raw: unknown): SceneRecord[] {
|
|
if (!Array.isArray(raw)) return [];
|
|
return raw.filter(
|
|
(s): s is SceneRecord =>
|
|
typeof s === "object" &&
|
|
s !== null &&
|
|
typeof (s as Record<string, unknown>)["id"] === "string" &&
|
|
typeof (s as Record<string, unknown>)["start"] === "number" &&
|
|
typeof (s as Record<string, unknown>)["duration"] === "number",
|
|
);
|
|
}
|
|
|
|
export interface MessageHandlerCallbacks extends PlaybackStateCallbacks {
|
|
getPlaybackState: () => PlaybackState;
|
|
setPlaybackState: (next: PlaybackState) => void;
|
|
getShaderLoadingMode: () => string;
|
|
shaderLoader: ShaderLoaderState;
|
|
setCompositionSize: (width: number, height: number) => void;
|
|
sendControl: (action: string, extra?: Record<string, unknown>) => void;
|
|
getIframeDoc: () => Document | null;
|
|
/** Invoked when the iframe runtime posts `{type: "ready"}` — the player
|
|
* uses it to replay current bridge state (mute, volume, playback rate) so
|
|
* control messages sent before the iframe's listener registered aren't lost. */
|
|
onRuntimeReady: () => void;
|
|
/** Called with the scene list whenever a "timeline" message is received. */
|
|
setScenes: (scenes: SceneRecord[]) => void;
|
|
}
|
|
|
|
// fallow-ignore-next-line complexity
|
|
export function handleRuntimeMessage(
|
|
event: MessageEvent,
|
|
frameWindow: Window | null,
|
|
callbacks: MessageHandlerCallbacks,
|
|
): void {
|
|
if (event.source !== frameWindow) return;
|
|
const data = event.data as Record<string, unknown> | undefined;
|
|
if (!data || data["source"] !== "hf-preview") return;
|
|
|
|
if (data["type"] === "shader-transition-state") {
|
|
const state: ShaderTransitionState =
|
|
data["state"] && typeof data["state"] === "object"
|
|
? (data["state"] as ShaderTransitionState)
|
|
: {};
|
|
callbacks.shaderLoader.update(state, callbacks.getShaderLoadingMode());
|
|
callbacks.dispatchEvent(
|
|
new CustomEvent("shadertransitionstate", {
|
|
detail: { compositionId: data["compositionId"], state },
|
|
}),
|
|
);
|
|
return;
|
|
}
|
|
|
|
if (data["type"] === "ready") {
|
|
callbacks.onRuntimeReady();
|
|
return;
|
|
}
|
|
|
|
if (data["type"] === "state") {
|
|
callbacks.setPlaybackState(
|
|
applyRuntimeStateMessage(
|
|
{ frame: (data["frame"] as number) ?? 0, isPlaying: !!data["isPlaying"] },
|
|
FPS,
|
|
callbacks.getPlaybackState(),
|
|
callbacks,
|
|
),
|
|
);
|
|
return;
|
|
}
|
|
|
|
if (data["type"] === "media-autoplay-blocked") {
|
|
let iframeDoc: Document | null = null;
|
|
try {
|
|
iframeDoc = callbacks.getIframeDoc();
|
|
} catch {
|
|
/* cross-origin */
|
|
}
|
|
callbacks.media.promoteToParentProxy(iframeDoc, (t, opts) =>
|
|
callbacks.media.mirrorTime(t, opts),
|
|
);
|
|
callbacks.sendControl("set-media-output-muted", { muted: true });
|
|
return;
|
|
}
|
|
|
|
if (data["type"] === "timeline" && (data["durationInFrames"] as number) > 0) {
|
|
if (Number.isFinite(data["durationInFrames"])) {
|
|
const pb = callbacks.getPlaybackState();
|
|
const duration = (data["durationInFrames"] as number) / FPS;
|
|
callbacks.setPlaybackState({ ...pb, duration });
|
|
callbacks.updateControlsTime(pb.currentTime, duration);
|
|
}
|
|
callbacks.setScenes(extractScenes(data["scenes"]));
|
|
return;
|
|
}
|
|
|
|
if (
|
|
data["type"] === "stage-size" &&
|
|
// Finite-check like the timeline branch above: `> 0` alone lets
|
|
// Infinity through, which scales the iframe to 0 and blanks it.
|
|
Number.isFinite(data["width"]) &&
|
|
(data["width"] as number) > 0 &&
|
|
Number.isFinite(data["height"]) &&
|
|
(data["height"] as number) > 0
|
|
) {
|
|
callbacks.setCompositionSize(data["width"] as number, data["height"] as number);
|
|
}
|
|
}
|