Files
hyperframes/skills/hyperframes/scripts
Michael WangandClaude Opus 5.5 9a048ac019 fix: find helper programs without a by-name lookup or the Windows working directory (#7562)
* fix(parsers): find helper programs by walking PATH in-process

The trusted lookup ran `which` by name through the full PATH before
applying the trusted-folder rule, so a relative or project-local PATH
entry could supply the lookup program itself. Walk the trusted PATH
folders in-process on every platform, as Windows already did, for
findTrustedExecutable, findFfBinary and the doctor's unzip check.

The walk keeps what `which` did for valid installs: first match in PATH
order, regular files only, and a leading `~` in a PATH entry read as the
home folder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): start the media-use engine with the Windows working-directory lookup off

mediaUseEngineEnv now sets NoDefaultCurrentDirectoryInExePath for the
engine on Windows itself instead of relying on the CLI's own environment,
and keeps a value the person set. When no PATH folder passes the trusted
rule, PATH names a folder that is never created rather than an empty
value, which a shell or execvp reads as the working directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(skills): helper scripts skip the Windows working-directory program lookup

On Windows a program started by name is looked up in the working
directory before PATH. The plugin launcher and the media-use, hyperframes
and figma helper scripts run inside project folders and start ffmpeg,
ffprobe, Python and other tools by name, either through the launcher or
directly from a standalone skill install.

Each skill now ships a small module that sets
NoDefaultCurrentDirectoryInExePath for the process (keeping a value the
person set), and every script that starts programs imports it first, so
the helpers and every program they start skip the working directory.
Tools installed on PATH resolve as before; macOS and Linux are
unaffected. A test checks that each such script loads the module.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): ship the Windows lookup guard with the CLI's media-use scripts

The CLI build replaces the published media-use scripts/lib folder with
packages/cli/src/media-use/lib. That folder had no windows-exe-search.mjs,
so every bundled media-use script that imports it, including the engine
behind `hyperframes media-use`, failed to load on every platform.

The guard is now a generated copy in the CLI lib, next to the skill copies.
A parity test checks that each scripts/lib module a published media-use
script imports exists in the CLI lib.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(skills): load the win32 stub by file URL so the launcher test runs on Windows

On Windows, `node --import D:\...` reads the drive letter as a URL scheme
and fails before the launcher starts. The test now passes a file URL and
reports the child's stderr when it exits non-zero.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(skills): resolve the Python helper's ffmpeg and drop relative PATH entries

extract-audio-data.py ran ffmpeg by bare name, which Windows looks up in
the working directory first. It now runs the absolute path that
trusted_program.find_program finds in absolute PATH folders outside the
working directory. A miss raises the same FileNotFoundError as before.

On macOS and Linux the shared guard now drops relative and empty PATH
entries, which point into the project folder, and leaves absolute ones in
order. If none is absolute, PATH is unset rather than left empty.

The guard census now also requires every skill Python script that imports
subprocess to resolve programs through trusted_program.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(skills): satisfy the Python UTF-8 and ffprobe argv sweeps

trusted_program.py carries the same UTF-8 stdio pin as every skill Python
script. The guard test's planted-program probe uses a literal-only argv,
which the ffprobe argv contract test reads as a capability check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 18:47:16 +00:00
..