Files
hyperframes/packages/studio/src/hooks/useConsoleErrorCapture.ts
T
Miguel ÁngelandMiguel Ángel 7bff49ecf0 refactor(studio): simplify hooks, split contexts, remove dead code (#1416)
* fix(studio): guard Zustand no-op setters and fix useConsoleErrorCapture memory leak

- Guard setIsPlaying to skip set() when value unchanged (eliminates 60
  notifications/sec during reverse playback)
- Guard caption store selectGroup to bail before set() when group missing
  (prevents empty Zustand notifications)
- Guard clearSelection to skip when already empty
- Fix useConsoleErrorCapture: restore original console.error, remove error
  event listener, and delete __hfErrorCapture flag on cleanup

* fix(studio): delete dead files and unused exports

Remove 7 dead files (audioBeatDetection, keyframeSnapping,
timelineInspector, DopesheetStrip, StaggerControls,
TimelineLayerPanel, TimelineEditorNotice) and their test companions.

Delete unused computeFitToChildrenSize export from propertyPanelHelpers.

Fix re-export indirection: useDomEditCommits and studioMotionOps.test
now import patch builders directly from manualEditsDomPatches instead
of the re-export passthrough in manualEditsDom.

* fix(studio): eliminate effect-chain state mirroring for lint findings, hover, and GSAP fetch

Move lint findingsByElement sync from App.tsx into useLintModal where
the value is produced, removing the mirroring useEffect. Consolidate
4 hover-clearing effects in useDomSelection into 2 (one unconditional
on context change, one conditional combining caption mode, selection
match, and disconnected element checks). Fold the GSAP retry effect
into the fetch effect in useGsapTweenCache, scheduling a single retry
via setTimeout when the initial fetch returns 0 animations.

Eliminates 3 unnecessary render cycles from effect chains.

* fix(studio): memoize renderQueue, toolbar, and canvas rect to prevent re-render cascade

- Wrap renderQueue object in useMemo so StudioContext consumers don't
  re-render on every App render
- Memoize timelineToolbar JSX so NLELayout memo isn't defeated
- Move canvasRect getBoundingClientRect() from render-time IIFE to a
  useLayoutEffect-backed ref, eliminating layout thrashing
- Track and clear setTimeout handles in refreshPreviewDocumentVersion
  to prevent stale timer accumulation on rapid calls and unmount

* refactor(studio): consolidate GSAP shared primitives — defaults, iframe access, keyframe parsing

Extract duplicated PROPERTY_DEFAULTS, IframeGsap interface, iframe
accessors (getIframeGsap, queryIframeElement), percentage keyframe
parsing, and toAbsoluteTime into a single gsapShared.ts module.

Removes ~120 lines of copy-pasted logic across 8 hook files, reducing
drift risk between the duplicate implementations.

* fix(studio): remove dead store fields, dead file, duplicate helper, and unsafe assertions

* refactor(studio): deduplicate selector helpers, rounding utils, percentage computation, and iframe access

* fix(studio): split StudioContext into Shell + Playback to prevent cascade re-renders

* refactor(studio): decompose useGsapScriptCommits into focused mutation hooks

* refactor(studio): decompose useFileManager into focused file operation hooks

Extract useFileTree (tree loading, refresh, derived assets/compositions)
and useEditorSave (debounced save with history tracking) from the 508-LOC
useFileManager. The parent hook composes both and retains file I/O,
click-to-source, upload/import, and CRUD — preserving the same public
interface so no consumers change.

* refactor(studio): decompose useDomEditCommits into focused commit hooks

Extract geometry (path offset, box size, rotation) and element lifecycle
(delete, z-index reorder) into useDomGeometryCommits and
useElementLifecycleOps. Parent keeps persistDomEditOperations as core
and composes all sub-hooks — public interface unchanged.

* refactor(studio): simplify useAppHotkeys with declarative command table

* refactor(studio): simplify useAppHotkeys with declarative command table

Replace 15 individual useRef callback refs with a single cbRef object.
Extract keydown dispatch into pure dispatchModifierKey/dispatchPlainKey
functions. Merge duplicate undo/redo logic into shared applyHistory.
Extract cross-origin listener boilerplate into safeAddListener/safeRemoveListener.

Hook body: 204 LOC (down from 445). Public API unchanged.

* fix(studio): remove unused getDomEditTargetKey import

* refactor(studio): decompose useDomEditSession into focused editing hooks

Extract GSAP-aware geometry intercepts (move/resize/rotation) and
animated property commit into useGsapAwareEditing, and selection
wiring, GSAP cache management, preview sync, and selection handlers
into useDomEditWiring. The parent remains a pure composition shell.

* style(studio): fix formatting in 5 files

* fix(studio): trim App.tsx to 598 lines (under 600 limit)

---------

Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
2026-06-13 18:25:11 -04:00

89 lines
3.1 KiB
TypeScript

import { useCallback, useEffect, useRef, useState } from "react";
import type { LintFinding } from "../components/LintModal";
/**
* Captures `console.error` and `window.onerror` events from a preview iframe
* and exposes them as LintFinding[] for the console errors modal.
*/
export function useConsoleErrorCapture(previewIframe: HTMLIFrameElement | null) {
const [consoleErrors, setConsoleErrors] = useState<LintFinding[] | null>(null);
const consoleErrorsRef = useRef<LintFinding[]>([]);
const resetErrors = useCallback(() => {
consoleErrorsRef.current = [];
setConsoleErrors(null);
}, []);
// eslint-disable-next-line no-restricted-syntax
useEffect(() => {
if (!previewIframe) return;
let patchedWin: (Window & typeof globalThis) | null = null;
let origConsoleError: ((...args: unknown[]) => void) | null = null;
let errorHandler: ((e: ErrorEvent) => void) | null = null;
const detachErrorCapture = () => {
const win = patchedWin;
if (!win) return;
patchedWin = null;
try {
// origConsoleError and errorHandler are always set alongside patchedWin
win.console.error = origConsoleError!;
win.removeEventListener("error", errorHandler!);
delete (win as unknown as Record<string, unknown>).__hfErrorCapture;
} catch {
/* cross-origin or destroyed window */
}
origConsoleError = null;
errorHandler = null;
};
const attachErrorCapture = () => {
detachErrorCapture();
try {
const win = previewIframe.contentWindow as (Window & typeof globalThis) | null;
if (!win) return;
if ((win as unknown as Record<string, unknown>).__hfErrorCapture) return;
(win as unknown as Record<string, unknown>).__hfErrorCapture = true;
patchedWin = win;
origConsoleError = win.console.error.bind(win.console);
win.console.error = function (...args: unknown[]) {
origConsoleError!(...args);
const text = args.map((a) => (a instanceof Error ? a.message : String(a))).join(" ");
if (text.includes("favicon")) return;
consoleErrorsRef.current = [
...consoleErrorsRef.current,
{ severity: "error", message: text },
];
setConsoleErrors([...consoleErrorsRef.current]);
};
errorHandler = (e: ErrorEvent) => {
const text = e.message || String(e);
consoleErrorsRef.current = [
...consoleErrorsRef.current,
{ severity: "error", message: text },
];
setConsoleErrors([...consoleErrorsRef.current]);
};
win.addEventListener("error", errorHandler);
} catch {
/* same-origin only */
}
};
attachErrorCapture();
const handleLoad = () => {
consoleErrorsRef.current = [];
setConsoleErrors(null);
attachErrorCapture();
};
previewIframe.addEventListener("load", handleLoad);
return () => {
previewIframe.removeEventListener("load", handleLoad);
detachErrorCapture();
};
}, [previewIframe]);
return { consoleErrors, setConsoleErrors, resetErrors };
}