mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-03 04:38:33 +00:00
* refactor(core): retire recast/babel, route all GSAP mutations to acorn (WS-E/3.F) - Delete gsapParser.ts (2595-line recast-based parser/writer) - Delete gsapParser.test.ts, gsapParser.stress.test.ts, gsapParser.test-helpers.ts - Add gsapParserExports.ts: re-export umbrella for gsap-parser subpath - Move SplitAnimationsOptions/SplitAnimationsResult to gsapSerialize.ts - executeGsapMutation: async->sync, static acorn imports replace loadGsapParser() - Fix 3 function name mismatches in files.ts switch cases - generators/hyperframes.ts: imports from gsapSerialize (blocker resolved) - gsapWriterAcorn.ts: SplitAnimationsOptions from gsapSerialize - Parity tests: recast oracle removed; acorn-only regression (14 pass) - Remove recast and @babel/parser from core/package.json Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(sdk): harden mutation handlers + widen variable API (code-review) Self-contained review fixes for the SDK-hotspot stack (#1569–#1573). The dispatch path (_dispatch → applyOp) never runs validateOp, so the new WS-D/WS-3.C guards were advisory-only; re-enforce them in the handlers. - addElement: null-guard the resolved parent (no more `as Element` masking a null → crash on unknown parent id); reject <script> and multi-root fragments via parseInsertableFragment instead of inserting raw markup / silently dropping extra roots. - addWithKeyframes / replaceWithKeyframes: bail on empty keyframes (no degenerate `keyframes: {}` tween) and when the animationId resolves to nothing (no silent degrade-to-add leaving a duplicate tween). - isObjectVariableValue: exclude arrays so an array override value can't be misclassified as a font/image object and written into the variable model. - Composition.setVariableValue: widen the public interface signature to `… | FontValue | ImageValue` to match the impl + EditOp (B2 object-valued variables were unreachable via the typed API). - mutate.gsap.test.ts: import addKeyframeToScript from gsap-writer-acorn — the gsap-parser subpath no longer re-exports write fns after recast retire, so the test threw at runtime (red suite). - Dedup: export EXCLUDED_TAGS from hfIds.ts and drop the verbatim HF_EXCLUDED_TAGS copy in mutate.ts. Adds guard regression tests. SDK 340/340, core hfIds 13/13, build green, fallow --gate new-only clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(sdk): variable-model dedup + undo/scoped-parent correctness; test honesty (code-review) Second batch of review fixes for the SDK-hotspot stack. - Variable model (#7, #13): extract readVariableDefault/writeVariableDefault into a shared engine/variableModel.ts used by both mutate.ts (forward) and apply-patches.ts (replay), so the model shape can't diverge. Add clearVariableDefault and make a `variable` remove patch DELETE the decl's `default` key — the exact inverse of a first-set on a default-less variable. Previously undo of such a set no-op'd and stranded the value. - addElement scoped parent (#8): record the caller's id verbatim (scoped "hf-host/hf-leaf" path or composition id) as the patch parentId instead of the bare data-hf-id, so redo/replay re-resolves the SAME parent via resolveScoped rather than the canonical top-level dup (or document.body). - resolveTimings honesty (#5): correct the header + test that claimed a live "preview == render" parity — neither path consumes the resolver yet (anchor inputs are Pacific/backend-deferred). It's a pure-function property, not a current guarantee. - GSAP writer parity (#12): the recast oracle was deleted in WS-3.F, leaving the WS-3.C keyframe ops comparing acorn output to itself. Pin them as golden inline snapshots and drop the now-dead recast scaffolding (replaceWithKfRecast, removeAnimRecast alias). Remaining pre-WS-3.C parity blocks noted as follow-up. Adds regression tests (undo of default-less variable; scoped-parent redo). SDK 342/342, core timingResolver+parity green, build + fallow --gate new-only clean. Not changed (need design / out of scope): #9 pre-#1569 persisted-override CSS replay (moot for unreleased data; proper fix is render-time CSS derivation), #11 replaceWithKeyframes stale positional id (mitigated by the missing-id no-op guard + type doc; full fix needs non-positional ids). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(sdk): replay CSS-prop derivation for legacy var overrides; stale-id selector guard (code-review) Final review-fix batch — the two items deferred from the prior pass. - #9 legacy variable-override CSS: applyOverrideSet now derives the `--{id}` CSS custom prop from any scalar `var.{id}` override on replay (and removes it for a null override). Sets written before the model/CSS split carried only `var.{id}`; without this, replaying them updated the JSON model but left `var(--{id})` bindings rendering the schema default. Replay-path only — the undo path (applyOne) is untouched, so #1569's separate-patch undo correctness is preserved. Object (font/image) values are never CSS, so they are skipped. - #11 stale positional id: replaceWithKeyframes now requires the located animation to still target the caller's `targetSelector`. Position-derived ids re-point after structural edits; a stale id resolving to a DIFFERENT element's tween previously got silently replaced. It now bails (no-op) unless the id still points at the expected selector. Adds regression tests (legacy var.{id}-only override restores CSS; object override writes no CSS; stale-id-wrong-selector replace is a no-op). SDK 345/345, build + fallow --gate new-only clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(core): gate acorn GSAP writer behind cutover flag; keep recast default (WS-3F) Product decision pivot: acorn no longer replaces recast as the GSAP writer. Recast remains the default server writer; acorn runs only when STUDIO_SDK_CUTOVER_ENABLED=true (or =1) is set server-side — the same env flag name as the client Vite var, so a single switch flips both sides. Changes: - Restore gsapParser.ts (recast writer) + test/stress/helper files deleted by 3F - Restore @babel/parser + recast deps in packages/core/package.json - Add isAcornGsapWriterEnabled() + loadGsapParser() to files.ts (lines 59-82) - Split executeGsapMutation into async dispatcher + executeGsapMutationRecast (recast, async via loadGsapParser) + executeGsapMutationAcorn (acorn, sync) - Dispatcher defaults to recast; acorn branch taken only when flag is on - Restore gsapWriter.parity.test.ts, gsapWriterParity.acorn.test.ts, and gsapWriterParity.corpus.test.ts to true recast-vs-acorn differential suites (not acorn-vs-itself) - Exempt gsapParser.ts in .fallowrc.jsonc health.ignore + ignoreExports (pre-existing complexity + barrel re-exports consumed outside diff scope) - Add fallow-ignore-file code-duplication to files.ts (intentional parallel switch bodies for two writers) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
266 lines
12 KiB
JSON
266 lines
12 KiB
JSON
{
|
|
"$schema": "https://raw.githubusercontent.com/fallow-rs/fallow/main/config-schema.json",
|
|
"entry": [
|
|
"packages/producer/src/**/*.test.ts",
|
|
"packages/aws-lambda/src/**/*.test.ts",
|
|
"packages/gcp-cloud-run/src/**/*.test.ts",
|
|
"packages/producer/src/regression-harness.ts",
|
|
"packages/producer/src/regression-harness-distributed.test.ts",
|
|
"packages/producer/src/regression-harness-lambda-local.ts",
|
|
"packages/producer/src/transparency-test.ts",
|
|
"packages/producer/src/parity-harness.ts",
|
|
"packages/producer/src/parity-fixtures.ts",
|
|
"packages/producer/src/perf-gate.ts",
|
|
"packages/producer/src/runtime-conformance.ts",
|
|
"packages/producer/src/benchmark.ts",
|
|
"packages/producer/scripts/generate-font-data.ts",
|
|
"packages/cli/scripts/generate-font-data.ts",
|
|
"packages/engine/scripts/test-fitTextFontSize-browser.ts",
|
|
"packages/aws-lambda/scripts/*.ts",
|
|
// Built as standalone IIFE for the browser-side sandbox runtime;
|
|
// referenced by file path (not import) in build-hyperframes-runtime-artifact.ts.
|
|
"packages/core/src/runtime/entry.ts",
|
|
// In-page audit scripts read as raw strings and injected via
|
|
// page.addScriptTag (see layout.ts / validate.ts) — referenced by file
|
|
// path, never imported, so they have no import-graph referrer.
|
|
"packages/cli/src/commands/layout-audit.browser.js",
|
|
"packages/cli/src/commands/contrast-audit.browser.js",
|
|
"packages/cli/src/commands/motion-sample.browser.js",
|
|
// Worker entry points loaded dynamically by their *Pool.ts companions.
|
|
"packages/producer/src/services/pngDecodeBlitWorker.ts",
|
|
"packages/producer/src/services/shaderTransitionWorker.ts",
|
|
// Test fixture worker, spawned by path via the pools' workerEntryPath
|
|
// option from the crash-recovery tests; has no import-graph referrer.
|
|
"packages/producer/src/services/__fixtures__/crashOnMessageWorker.mjs",
|
|
"scripts/*.{ts,mjs,js}",
|
|
"scripts/*/run.mjs",
|
|
// Keyframe UI components — wired dynamically via EaseCurveSection/MotionPanel.
|
|
"packages/studio/src/components/editor/KeyframeDiamond.tsx",
|
|
"packages/studio/src/components/editor/SpringEaseEditor.tsx",
|
|
// NLE notice — rendered conditionally via NLELayout when timeline is first shown.
|
|
"packages/studio/src/components/nle/TimelineEditorNotice.tsx",
|
|
// Zoom hook extracted for downstream razor-blade PRs (#1330, #1331).
|
|
"packages/studio/src/player/components/useTimelineZoom.ts",
|
|
// Cached O(1) GSAP target lookup, replacing O(n²) inline checks.
|
|
// Consumers migrate in a follow-up once useDomGeometryCommits adopts it.
|
|
"packages/studio/src/hooks/gsapTargetCache.ts",
|
|
// Preview helper consumed dynamically from the studio iframe bridge.
|
|
"packages/studio/src/hooks/gsapRuntimePreview.ts",
|
|
],
|
|
"ignorePatterns": [
|
|
"docs/**",
|
|
"packages/producer/tests/**",
|
|
"packages/player/tests/**",
|
|
"packages/engine/tests/**",
|
|
"skills/**/test-corpus/**",
|
|
"skills/**/scripts/**",
|
|
// Agent-invoked motion-graphics tools co-located with their docs (run via
|
|
// `node <path>` per grounding/PROTOCOL.md / categories/maps/module.md
|
|
// prose), not import-graph reachable.
|
|
"skills/motion-graphics/grounding/**",
|
|
"skills/motion-graphics/categories/**",
|
|
// Bundled @font-face data (read at runtime via fs.readFileSync, invisible
|
|
// to the import graph) + its manual rebuild tool.
|
|
"skills/**/fonts/**",
|
|
// Golden snapshot files: data consumed by toMatchFileSnapshot, not importable modules.
|
|
"packages/**/__goldens__/**",
|
|
"registry/**",
|
|
"examples/**",
|
|
"packages/sdk/examples/**",
|
|
".github/workflows/fixtures/**",
|
|
// Auto-generated TS client for the HeyGen cloud API. Regenerated by
|
|
// experiment-framework/scripts/generate_hyperframes_cli_client.py via
|
|
// the sync-hyperframes-codegen.yml workflow; complexity/dead-code
|
|
// findings on this file are not actionable from this repo.
|
|
"packages/cli/src/cloud/_gen/**",
|
|
],
|
|
"ignoreExports": [
|
|
// CLI command files: every command exports a const `examples` per the
|
|
// convention documented in CLAUDE.md. This is a namespace barrel, not a
|
|
// collision.
|
|
{ "file": "packages/cli/src/commands/*.ts", "exports": ["examples"] },
|
|
// Independent ML model managers each declare their own DEFAULT_MODEL /
|
|
// MODELS_DIR / ensureModel for their model namespace.
|
|
{
|
|
"file": "packages/cli/src/{background-removal,tts,whisper}/manager.ts",
|
|
"exports": ["DEFAULT_MODEL", "MODELS_DIR", "ensureModel"],
|
|
},
|
|
// `isPathInside` is documented as exported-for-tests only in fileServer.ts;
|
|
// it has different semantics (symlink resolution) from utils/paths.ts.
|
|
{
|
|
"file": "packages/producer/src/services/fileServer.ts",
|
|
"exports": ["isPathInside"],
|
|
},
|
|
// Studio telemetry: consumed by useRenderQueue.ts / StudioFeedbackBar.tsx
|
|
// (deep relative imports) but fallow's static analyzer doesn't trace
|
|
// them. Same path-resolution quirk — trackStudioSessionStart from the
|
|
// same file resolves fine.
|
|
{
|
|
"file": "packages/studio/src/telemetry/events.ts",
|
|
"exports": ["trackStudioRenderStart", "trackStudioFeedback"],
|
|
},
|
|
// domEditingLayers: these exports are consumed via the browser iframe
|
|
// runtime context (not traceable by static import analysis from the
|
|
// studio entry point) or re-exported through the domEditing barrel but
|
|
// have no downstream consumers yet.
|
|
{
|
|
"file": "packages/studio/src/components/editor/domEditingLayers.ts",
|
|
"exports": [
|
|
"isEditableTextLeaf",
|
|
"collectDomEditTextFields",
|
|
"buildElementLabel",
|
|
"refreshDomEditSelection",
|
|
],
|
|
},
|
|
// domEditing barrel: re-exports consumed throughout the studio but
|
|
// fallow's static analyzer can't trace re-exports through barrel files.
|
|
{
|
|
"file": "packages/studio/src/components/editor/domEditing.ts",
|
|
"exports": ["*"],
|
|
},
|
|
// Exported for render.test.ts (exported-for-tests pattern).
|
|
{
|
|
"file": "packages/cli/src/commands/render.ts",
|
|
"exports": ["resolveBrowserGpuForCli", "renderLocal"],
|
|
},
|
|
// captureCost.ts: constants and helpers consumed by the runCaptureCalibration
|
|
// orchestration function and tests, but the entry-point graph doesn't
|
|
// reach them because the orchestrator's caller resolves them dynamically.
|
|
{
|
|
"file": "packages/producer/src/services/render/captureCost.ts",
|
|
"exports": [
|
|
"CAPTURE_CALIBRATION_TARGET_MS",
|
|
"MAX_MEASURED_CAPTURE_COST_MULTIPLIER",
|
|
"CAPTURE_CALIBRATION_PROTOCOL_TIMEOUT_MS",
|
|
"measureCaptureCostFromSession",
|
|
"logCaptureCalibrationResult",
|
|
"createFailedCaptureCalibrationEstimate",
|
|
],
|
|
},
|
|
// gsapParser.ts is a public-API barrel that re-exports constants, types,
|
|
// and utilities from gsapConstants, gsapSerialize, and springEase. The
|
|
// re-exports are intentional public API consumed by callers outside the
|
|
// changed-file set (e.g. studio, aws-lambda) and therefore appear unused
|
|
// to fallow's static analysis of the PR diff.
|
|
{
|
|
"file": "packages/core/src/parsers/gsapParser.ts",
|
|
"exports": [
|
|
"PROPERTY_GROUPS",
|
|
"classifyPropertyGroup",
|
|
"classifyTweenPropertyGroup",
|
|
"SPRING_PRESETS",
|
|
"generateSpringEaseData",
|
|
"GsapMethod",
|
|
"GsapKeyframesData",
|
|
"GsapKeyframeFormat",
|
|
"PropertyGroupName",
|
|
"SpringPreset",
|
|
],
|
|
},
|
|
// Shared test helpers consumed by gsapParser.test.ts (same file,
|
|
// fallow doesn't trace intra-file test consumption).
|
|
{
|
|
"file": "packages/core/src/parsers/gsapParser.test-helpers.ts",
|
|
"exports": [
|
|
"expectKeyframe",
|
|
"expectKeyframesFormat",
|
|
"convertAndReparse",
|
|
"parseSplitAndAssert",
|
|
],
|
|
},
|
|
// Shared timeline components extracted for downstream PRs in the
|
|
// razor-blade stack (#1330, #1331). Consumers live on those branches.
|
|
{
|
|
"file": "packages/studio/src/player/components/timelineCallbacks.ts",
|
|
"exports": ["*"],
|
|
},
|
|
// gsapTargetCache: cached O(1) GSAP target lookup, consumed by
|
|
// useDomEditCommits and intended to replace the local copy in
|
|
// useDomGeometryCommits once callers migrate.
|
|
{
|
|
"file": "packages/studio/src/hooks/gsapTargetCache.ts",
|
|
"exports": ["isElementGsapTargeted"],
|
|
},
|
|
// Re-exports from useDomEditCommits: barrel-style re-exports
|
|
// consumed by downstream studio code.
|
|
{
|
|
"file": "packages/studio/src/hooks/useDomEditCommits.ts",
|
|
"exports": ["GSAP_CSS_FALLBACK_BLOCKED_MESSAGE", "PersistDomEditOperations"],
|
|
},
|
|
{
|
|
"file": "packages/studio/src/utils/timelineElementSplit.ts",
|
|
"exports": ["buildPatchTarget", "readFileContent"],
|
|
},
|
|
],
|
|
"ignoreDependencies": [
|
|
// Runtime/dynamic deps not visible to static analysis: tsup `external`,
|
|
// dynamic require() resolution, peer/static-file consumption in tests,
|
|
// and bun-hoisted workspace devDeps (e.g. happy-dom in root package.json
|
|
// resolves for every workspace, so workspaces don't redeclare it).
|
|
// Required by @puppeteer/browsers and puppeteer-core at runtime; listed
|
|
// as a direct dep to guarantee installation even when transitive
|
|
// resolution fails (corrupted cache, dedup edge cases).
|
|
"debug",
|
|
"puppeteer",
|
|
"puppeteer-core",
|
|
"esbuild",
|
|
"giget",
|
|
"gsap",
|
|
"happy-dom",
|
|
"ffmpeg-static",
|
|
"ffprobe-static",
|
|
"@hyperframes/core",
|
|
"@hyperframes/studio",
|
|
"@hyperframes/producer",
|
|
"@fontsource/archivo-black",
|
|
"@fontsource/eb-garamond",
|
|
"@fontsource/ibm-plex-mono",
|
|
"@fontsource/inter",
|
|
"@fontsource/jetbrains-mono",
|
|
"@fontsource/league-gothic",
|
|
"@fontsource/montserrat",
|
|
"@fontsource/nunito",
|
|
"@fontsource/oswald",
|
|
"@fontsource/outfit",
|
|
"@fontsource/space-mono",
|
|
"@fontsource/lato",
|
|
"@fontsource/noto-sans-jp",
|
|
"@fontsource/open-sans",
|
|
"@fontsource/playfair-display",
|
|
"@fontsource/poppins",
|
|
"@fontsource/roboto",
|
|
"@fontsource/source-code-pro",
|
|
],
|
|
"duplicates": {
|
|
// Raise from the default 5 to 6 lines so trivially short Hono route-handler
|
|
// preambles (resolveProject + 404 + body-parse) are below the threshold.
|
|
// The three 5-line groups in files.ts / render.ts are structural boilerplate
|
|
// that naturally converges and is unlikely to diverge; extraction would
|
|
// require intrusive middleware changes beyond this PR's scope.
|
|
"minLines": 6,
|
|
},
|
|
"health": {
|
|
// executeGsapMutation (introduced by Phase 3b / acorn-parser stack, already
|
|
// merged to origin/main via #1338) has CRITICAL cyclomatic complexity (58)
|
|
// that pre-dates this PR's scope. Excluding files.ts from health analysis
|
|
// avoids the inherited-fingerprint line-shift problem that suppression
|
|
// comments would cause (any inserted line shifts subsequent function line
|
|
// numbers, breaking fallow's inherited-detection fingerprint).
|
|
//
|
|
// useGsapTweenCache.ts: pre-existing large React-effect hooks (the populate
|
|
// and runtime-scan effects, the per-element animations memo) whose
|
|
// complexity pre-dates the computed-timeline work. Exempted at file level
|
|
// for the same reason as files.ts rather than refactored as scope creep.
|
|
//
|
|
// gsapParser.ts: the recast/babel GSAP writer is a 2500-line legacy parser
|
|
// restored as the default server writer by WS-3.F rework (acorn is now
|
|
// flag-gated behind STUDIO_SDK_CUTOVER_ENABLED). Its complexity pre-dates
|
|
// this PR and was present on all ancestor branches; the file-level exemption
|
|
// avoids the line-shift fingerprint problem for inherited findings.
|
|
"ignore": [
|
|
"packages/core/src/studio-api/routes/files.ts",
|
|
"packages/core/src/parsers/gsapParser.ts",
|
|
],
|
|
},
|
|
}
|