mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-05 00:56:23 +00:00

Files

T

Vance IngallsandClaude Opus 5 e3ec48adce feat(studio): fold a preset shut, and give each one its own title design (#3191 )

* fix(studio): close the typecheck and fallow gaps wa-18b-reschedule opened

useAutomationLanes.ts's write() assumed gesture-scoped coalescing and a
preview-only commit that useDomEditAttributeCommits.ts never grew — backported
that option support from its own later commit so the two sides of the API
agree. The paste path and its tests were missing the box selection's v0/v1
bounds a sibling commit added to AutomationSelection. The FX panel's carve
controls still edited the six mechanism numbers (maxCutDb, bands,
intelligibilityBias) after carveProfile() collapsed authoring to one Strength
knob, so those fields no longer existed on HfCarveSettings; UI now edits
strength, and analyseCarveBands is called with carveProfile(strength).

Also closes fallow's complexity, dead-code and duplication findings on this
PR's diff: extracted automationLaneDragMath.ts (pure group/point-move math)
and useAutomationRangeDrag.ts (the marquee-select gesture) out of
useAutomationLaneGestures.ts, pulled a couple of render-loop ternaries and a
resolver into named functions, dropped an export nothing outside its file
used, and shared a step-simplifier between audioCarve's two envelope
builders.

The edge-stretch vs. box-select priority test in TimelineAutomationLane.test
was still pinning the pre-box-select rule (edge wins over a point sitting on
it) that a sibling commit deliberately reversed — a point inside the box is
now selected content, so grabbing it drags the group instead. Updated the
test to the shipped rule instead of the old one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): cap the via conic's weight so an edge-clamped via point can't NaN

A via point pulled out past the segment (viaX: 5, viaY: -3) clamps to
(0.999, 0.001) — exactly on the steady region's edge, where edge - viaX is 0.
viaConic divided by that zero to get an infinite weight, and shapeVia turned
Infinity into NaN a few steps later (Infinity - Infinity in the quadratic
coefficient). NaN reaching setValueCurveAtTime silences the automated
parameter for the rest of the render.

Capped the weight at 1e6 instead of leaving it unbounded — past that point
the arc already reads as touching the via point, so nothing visible is lost.
Also hardened shapeVia's existing denominator guard (`<= 0`) to `!(> 0)`,
since NaN fails the original comparison and fell through it.

Review by Miga (PR #3208).

* fix(studio-server): fingerprint the proactive waveform cache key too

The route already keys the waveform cache on the asset's size and mtime as
well as its path, so a rebuilt-in-place file gets fresh peaks instead of
stale ones. generateWaveformCache — the proactive path that runs on upload —
still called buildWaveformCacheKey with the path alone, so it wrote to a
different key than the route reads from (making the pre-generated cache
never found) and kept the exact collision bug this fingerprint exists to fix
on its own path.

Review by Miga (PR #3211).

* style(docs): run oxfmt on the /hyperframes-audio skill docs

Table column widths had drifted out of alignment with oxfmt's own rules,
failing format:check and blocking the Preflight gate every downstream
branch inherits. Whitespace only, no content change.

* fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration

\b treats `_` as a word character, so \bbed\b never matched bed_01,
music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap —
an underscore-separated bed classified as "unknown" and could end up offered
as its own carve source. Replaced the short hints with a boundary that
actually excludes letters and digits on both sides.

clipsOverlap computed end = start + duration without guarding sign, so a
negative duration put end before start — an interval that does not describe
anything, and one specific case showed it silently dropping a real overlap
(a shorter, earlier broken end rejected a clip that genuinely contained the
point). Duration clamps to zero instead: a clip cannot un-play time, and a
zero-length clip at its start is the sane reading of "duration nobody wrote
down as positive."

Review by Miga (PR #3212).

* fix(studio): widen PropertyPanel's resetModules render timeout again

The 20s margin (already once widened for the same reason) is timing out in
CI's full-monorepo Test run — the resetModules()+fresh-import render this
test needs is uncached and competes with every other package's test suite
for the same worker pool, and the same test passes in well under 2s
standalone. Went to 45s rather than re-tuning to whatever number happens to
clear the current CI load, since that number moves every time CI gains a
package.

* fix(studio): stop the single-candidate auto-apply carve firing twice

Two auto-apply effects both fire when sourceOptions.length === 1: the
multi-candidate effect only guards length === 0, so a single candidate
passes it too, and the single-candidate effect passes its own guard right
after — both compute the same sources list and both call setCarve, so the
common case (one narrator, one bed) triggered two decodes, two FFT runs, and
two concurrent attribute writes for one decision.

The multi-candidate effect now defers to its sibling for exactly one
candidate, which already has its own detailed handling for that case.

Review by Miga (PR #3213).

* feat(core): carve against every voice over a bed, always (#3212)

* feat(core): carve against every voice over a bed, always dynamically

A bed usually runs under a whole sequence — a narrator, an interview answer, a
second presenter — and carving against one of them left the others fighting it.
`source` becomes `sources`, and `mixCarveSources` sums every voice onto the BED's
clock before anything is measured. That is what keeps one analysis sufficient: the
chain is fixed, so there is no per-voice filter to switch between, and bands drawn
from all the speech there is with envelopes that rise wherever any of it happens
answer the actual question — where and when is speech masking this bed.

Summed rather than averaged: two people talking at once mask more than either
alone. Audio before the bed starts is dropped rather than folded in at zero, since
it plays over nothing and shifting it would put a cut where there is no voice.

`dynamic` is gone. A fixed depth thins the bed through every pause, and once both
have been heard there is no reason to want it, so every carve follows the speech.

Two helpers the panel and the headless script now share instead of each carrying a
copy — two definitions of "what does this name suggest" drift, and then the two
disagree about which track is the voice:

- `classifyAudioName` reads a track's kind from its id and filename together.
  `unknown` is deliberately common: treating an unrecognised name as "not a voice"
  would hide the one track somebody needs to pick.
- `clipsOverlap` keeps out a voice that never plays while the bed does. An unwritten
  duration counts as unbounded, not zero — refusing a clip whose length the
  composition leaves to the media would drop the commonest case there is.

Files written before this still load: a single `source` reads as a one-voice list,
a stored `dynamic` is ignored, and an absent attribute means the defaults whole.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration

\b treats `_` as a word character, so \bbed\b never matched bed_01,
music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap —
an underscore-separated bed classified as "unknown" and could end up offered
as its own carve source. Replaced the short hints with a boundary that
actually excludes letters and digits on both sides.

clipsOverlap computed end = start + duration without guarding sign, so a
negative duration put end before start — an interval that does not describe
anything, and one specific case showed it silently dropping a real overlap
(a shorter, earlier broken end rejected a clip that genuinely contained the
point). Duration clamps to zero instead: a clip cannot un-play time, and a
zero-length clip at its start is the sane reading of "duration nobody wrote
down as positive."

Review by Miga (PR #3212).

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(studio): port the carve UI off the removed source/dynamic fields

#3212 (accidentally squash-merged into this branch instead of main) changed
HfCarveSettings from a single `source` + `dynamic` toggle to a `sources`
list with dynamic mode removed outright — the multi-voice UI consumer that
goes with that shape lands in the very next PR, so this branch was left with
a type that no longer matched its own code.

Minimal port, not the multi-voice redesign that PR does properly: the
"Listen to" picker and analyse() treat sources[0] as the one voice this UI
still understands, and every dynamic-mode branch (the automated envelope
lanes, the toggle, the checkbox) is gone along with the field — a carve is
now always the static value the analysis computes, matching what the type
change made permanent. Test suite trimmed the same way: the automation-lane
and toggle tests covered behavior that no longer exists.

* chore: fix markdown formatting

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-08-13 13:53:29 -07:00

5.8 KiB

Raw Blame History

The three audio attributes

All three go on the <audio> / <video> element itself, JSON-encoded, so a composition carries its whole mix in the HTML with nothing to load beside it. Nothing static validates them: preview plays an unreadable chain dry to stay workable, and the render refuses the whole mix rather than shipping a dry track that sounds plausible and is wrong.

`data-fx-chain` — the effects

{
  "version": 1,
  "nodes": [
    {
      "type": "highpass",
      "id": "n1",
      "label": "Remove Rumble",
      "params": { "frequency": 120, "q": 0.707, "poles": "2" }
    },
    {
      "type": "peaking",
      "id": "n2",
      "fromCarve": true,
      "params": { "frequency": 1600, "gain": -6, "q": 1.4 }
    },
    {
      "type": "limiter",
      "id": "n3",
      "enabled": false,
      "params": { "limit": -1, "attack": 5, "release": 50, "level_out": 0 }
    }
  ]
}

Write these attributes double-quoted, with the JSON's own quotes as ". The browser reads them through getAttribute and does not care, but scripts/carve.mjs finds them with a name="..." regex, so a single-quoted attribute is invisible to it — the carve reports no existing chain and quietly overwrites work it could not see. & becomes &; nothing else needs escaping.

Order is signal order. Each node processes what the one before produced.
type is an effect id from the registry. params are in the units a person thinks in — dB, ms, Hz — and out-of-range values are clamped on read, so a chain that parses is always safe to realise.
id is a stable handle. Automation addresses nodes by id, never by position, so reordering the chain cannot re-point a lane at a different effect. A node with no id loads fine but cannot be automated. Writing a chain by hand, any unique string works; Studio hands out the first free n1, n2, … so matching that convention keeps a hand-written chain and an edited one looking alike.
label is what the rack calls this node, replacing the effect's own name. Write one whenever the node is doing a named job — a chain with two peaking nodes otherwise shows the same row twice and the author cannot tell which is the mud cut and which is the clarity lift. Presets and jobs always set it; a hand-written node should too. See presets.md for the names they use.
enabled: false is bypass — the node stays in the chain, out of the signal path. Absent means enabled.
fromCarve: true marks a node the carve analysis generated. Re-running the carve replaces exactly these and leaves hand-built effects alone. Do not set it by hand: a node tagged this way will be deleted by the next carve.

`data-automation` — the envelopes

{
  "version": 1,
  "lanes": [
    {
      "target": "volume",
      "points": [
        { "t": 0, "v": 1 },
        { "t": 2.5, "v": 0.4 }
      ]
    },
    {
      "target": "fx.n2.gain",
      "points": [
        { "t": 0, "v": 0 },
        { "t": 1, "v": -6, "curve": 0.4 }
      ]
    }
  ]
}

target is volume for the track's own level, or fx.<nodeId>.<param>.
t is seconds from the start of the clip, not of the composition. A bed starting at data-start="8" has t: 0 at composition time 8.
v is in the parameter's own unit: dB for a gain, Hz for a frequency, 0..1 for volume.
A lane holds its first value backwards to the start of its clip and its last value forward to the end. So a bed that begins before the voice needs an explicit "no cut" point at t: 0, or it starts out already ducked.
curve (-1..1) bends the segment leaving a point: positive holds low then rises late. viaX/viaY name an interior point the segment passes through (progress 0..1, value travelled 0..1) and supersede curve when both are present — that is what the timeline writes when a bend is dragged.
512 points per lane, maximum.
A lane whose node is gone is pruned on read rather than erroring.

A lane on a non-automatable parameter is silently inert. Automation is delivered as native AudioParam scheduling, so a knob that no AudioParam backs cannot move: worklet processor options, a WaveShaper curve and a convolution impulse are all set wholesale. fx-registry.md marks each parameter; the four worklet effects (compressor, limiter, gate, bitcrush) have none at all.

`data-fx-carve` — the carve's settings

{ "enabled": true, "sources": ["narration", "interview-guest"], "strength": 0.35 }

sources are the element ids of every voice this bed makes room for. They live on the bed being processed, not on the voices. Summed onto the bed's clock before the analysis, so one set of filters and envelopes covers all of them.
strength 0..1 derives the whole mechanism (see carveProfile).
There is no dynamic: a carve always follows the speech.
enabled is whether the carve applies. It exists because a bed with exactly one candidate voice is carved by default: with "off" represented by an absent attribute, switching it off would read as never-configured and the default would put it back. enabled: false keeps the settings and stops the carve.

This attribute is not read at playback — the chain and lanes it produced are what play. It exists so the settings can be read back and re-derived rather than guessed from the filters, which is what makes changing strength on an existing carve possible.

Older projects may carry the six mechanism numbers (maxCutDb, bands, q, intelligibilityBias, duckDb, headroomDb) instead of strength. They still load: the depth maps back onto a strength and everything else is re-derived. A stored carve with no enabled reads as on, and a single source reads as a one-voice sources list. A stored dynamic is ignored — every carve follows the speech now.

5.8 KiB Raw Blame History

The three audio attributes

data-fx-chain — the effects

data-automation — the envelopes

data-fx-carve — the carve's settings

5.8 KiB

Raw Blame History

`data-fx-chain` — the effects

`data-automation` — the envelopes

`data-fx-carve` — the carve's settings