mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-05 00:56:23 +00:00
Miguel Ángel
8bc1e5d603
* fix(video-workflows): pad the frame's own duration to match the transition tail transitions.mjs extends the index.html WRAPPER's data-duration to cover an outgoing transition's tail, but the frame's own internal composition file kept its shorter, content-only data-duration (authored per frame-worker.md's "duration is fixed upstream" instruction). The render engine clip-gates a sub-composition's visible content at its own declared duration, so content vanished abruptly at content-end instead of fading through the wrapper's extended fade-out tween. A user root-caused and verified this themselves: padding the frame's own duration to match the wrapper fixed it, project-wide, across every non-final frame. transitions.mjs already computes the correct padded duration for the wrapper - it now writes the same value into the matching frame's own file at inject time. Extracted to a shared lib/pad-frame-duration.mjs (mirroring the existing lib/transition-registry.mjs convention) since transitions.mjs's own top-level CLI dispatch runs on import, making it untestable directly. Duplicated identically across pr-to-video, faceless-explainer, and product-launch-video, whose transitions.mjs copies are otherwise byte-identical (confirmed via diff) - one root cause, one fix, applied everywhere it lives. * fix(skills): avoid duration helper file race
77 lines
2.9 KiB
JavaScript
77 lines
2.9 KiB
JavaScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, mkdirSync, writeFileSync, readFileSync, rmSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { padFrameInternalDuration } from "./pad-frame-duration.mjs";
|
|
|
|
// Regression: an outgoing transition pads the index.html WRAPPER's
|
|
// data-duration to cover the transition tail, but the frame's own internal
|
|
// file kept its shorter content-only duration, so the render engine
|
|
// clip-gated the sub-composition's visible content at the shorter value —
|
|
// content vanished abruptly instead of fading through the wrapper's
|
|
// extended fade-out tween. A user diagnosed and verified this fix
|
|
// themselves: pad the frame's own #root/clip data-duration to match.
|
|
test("padFrameInternalDuration pads the matching frame's own data-duration", () => {
|
|
const dir = mkdtempSync(join(tmpdir(), "transitions-pad-"));
|
|
const framesDir = join(dir, "compositions", "frames");
|
|
mkdirSync(framesDir, { recursive: true });
|
|
const frameSrc = "compositions/frames/scene-1.html";
|
|
const framePath = join(dir, frameSrc);
|
|
writeFileSync(
|
|
framePath,
|
|
`<template>
|
|
<div
|
|
id="root"
|
|
data-composition-id="scene-1"
|
|
data-width="1920"
|
|
data-height="1080"
|
|
data-duration="4.2"
|
|
></div>
|
|
</template>`,
|
|
);
|
|
|
|
try {
|
|
padFrameInternalDuration(dir, frameSrc, "scene-1", 4.7);
|
|
const updated = readFileSync(framePath, "utf8");
|
|
assert.match(updated, /data-duration="4\.7"/);
|
|
assert.doesNotMatch(updated, /data-duration="4\.2"/);
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test("padFrameInternalDuration only touches the tag matching the given frame id", () => {
|
|
const dir = mkdtempSync(join(tmpdir(), "transitions-pad-scope-"));
|
|
const framesDir = join(dir, "compositions", "frames");
|
|
mkdirSync(framesDir, { recursive: true });
|
|
const frameSrc = "compositions/frames/scene-2.html";
|
|
const framePath = join(dir, frameSrc);
|
|
const original = `<template>
|
|
<div id="root" data-composition-id="scene-2" data-duration="3.0">
|
|
<div data-composition-id="unrelated-child" data-duration="1.0"></div>
|
|
</div>
|
|
</template>`;
|
|
writeFileSync(framePath, original);
|
|
|
|
try {
|
|
padFrameInternalDuration(dir, frameSrc, "scene-2", 3.5);
|
|
const updated = readFileSync(framePath, "utf8");
|
|
assert.match(updated, /data-composition-id="scene-2" data-duration="3\.5"/);
|
|
assert.match(updated, /data-composition-id="unrelated-child" data-duration="1\.0"/);
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test("padFrameInternalDuration is a no-op when the frame file does not exist", () => {
|
|
const dir = mkdtempSync(join(tmpdir(), "transitions-pad-missing-"));
|
|
try {
|
|
assert.doesNotThrow(() =>
|
|
padFrameInternalDuration(dir, "compositions/frames/missing.html", "missing", 5),
|
|
);
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|