mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-12 15:20:13 +00:00
Vance Ingalls
20be2ea1c2
## Summary - Run `oxfmt .` across the entire codebase to establish formatted baseline - 299 files changed — mechanical formatting only, no logic changes - Double quotes, semicolons, 2-space indent, trailing commas, 100 print width Part 3/4 of [VA-851](https://linear.app/heygen/issue/VA-851/pre-migration-configure-eslint-prettier-and-conventional-commits) ## Test plan - [x] `pnpm format:check` — all 426 files pass - [x] `pnpm -r typecheck` — all packages pass - [x] `pnpm build` — all packages build - [x] All 348 tests pass
2.6 KiB
2.6 KiB
HyperFrame Schema Compliance Review
Executive Summary
- Total files reviewed: 4
- Critical issues: 0
- Overall compliance status: PASS
Critical Issues
None found. All compositions follow the core schema rules for determinism, finite timelines, and registration.
Compliance Checklist
- All compositions have
data-widthanddata-heightattributes - All timelines are finite with duration > 0
- All compositions registered in
window.__timelines - No use of
Math.random(),Date.now(), or non-deterministic code - Primitive clips have required data attributes (
id,data-start,data-track) data-durationspecified for all<img>clips (N/A - no images used)- No manual media playback control (
video.play(),audio.pause(), etc.) - No manual clip mounting/unmounting in scripts
- Relative timing references are valid (N/A - all absolute)
- Clips on same track don't overlap in time
- Reusable compositions in separate HTML files
- Composition files use
<template>tags - External compositions loaded via
data-composition-src - All script-animated content wrapped in compositions
- No infinite or zero-duration timelines
File-by-File Analysis
index.html
Status: COMPLIANT
- Correctly defines the master composition with
data-composition-id="master". - Uses portrait dimensions (1080x1920).
- Loads sub-compositions using
data-composition-src. - Registers
mastertimeline inwindow.__timelines.
compositions/main-orchestration.html
Status: COMPLIANT
- Correctly uses
<template>anddata-composition-id. - Registers
main-orchestrationtimeline. - Deterministic GSAP animations for background and video.
- Audio clips are correctly defined with
id,data-start, anddata-track. - Note: Ensure audio files do not overlap on track 1 if their duration exceeds the gap between start times.
compositions/captions.html
Status: COMPLIANT
- Correctly handles dynamic caption generation within a composition.
- Registers
captionstimeline. - Uses deterministic logic for word animations based on a fixed transcript.
- Correctly uses
data-widthanddata-height.
compositions/graphics.html
Status: COMPLIANT
- Correctly uses
<template>anddata-composition-id. - Registers
graphicstimeline. - Uses deterministic pop-in and exit animations.
- Ambient motion is deterministic (uses fixed durations and repeats).
- Audio clips for SFX are correctly defined on track 10.
- Note: Ensure SFX audio files do not overlap on track 10 if their duration exceeds the gap between start times.