mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-07 10:06:21 +00:00
* refactor(core): retire recast/babel, route all GSAP mutations to acorn (WS-E/3.F) - Delete gsapParser.ts (2595-line recast-based parser/writer) - Delete gsapParser.test.ts, gsapParser.stress.test.ts, gsapParser.test-helpers.ts - Add gsapParserExports.ts: re-export umbrella for gsap-parser subpath - Move SplitAnimationsOptions/SplitAnimationsResult to gsapSerialize.ts - executeGsapMutation: async->sync, static acorn imports replace loadGsapParser() - Fix 3 function name mismatches in files.ts switch cases - generators/hyperframes.ts: imports from gsapSerialize (blocker resolved) - gsapWriterAcorn.ts: SplitAnimationsOptions from gsapSerialize - Parity tests: recast oracle removed; acorn-only regression (14 pass) - Remove recast and @babel/parser from core/package.json Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(sdk): harden mutation handlers + widen variable API (code-review) Self-contained review fixes for the SDK-hotspot stack (#1569–#1573). The dispatch path (_dispatch → applyOp) never runs validateOp, so the new WS-D/WS-3.C guards were advisory-only; re-enforce them in the handlers. - addElement: null-guard the resolved parent (no more `as Element` masking a null → crash on unknown parent id); reject <script> and multi-root fragments via parseInsertableFragment instead of inserting raw markup / silently dropping extra roots. - addWithKeyframes / replaceWithKeyframes: bail on empty keyframes (no degenerate `keyframes: {}` tween) and when the animationId resolves to nothing (no silent degrade-to-add leaving a duplicate tween). - isObjectVariableValue: exclude arrays so an array override value can't be misclassified as a font/image object and written into the variable model. - Composition.setVariableValue: widen the public interface signature to `… | FontValue | ImageValue` to match the impl + EditOp (B2 object-valued variables were unreachable via the typed API). - mutate.gsap.test.ts: import addKeyframeToScript from gsap-writer-acorn — the gsap-parser subpath no longer re-exports write fns after recast retire, so the test threw at runtime (red suite). - Dedup: export EXCLUDED_TAGS from hfIds.ts and drop the verbatim HF_EXCLUDED_TAGS copy in mutate.ts. Adds guard regression tests. SDK 340/340, core hfIds 13/13, build green, fallow --gate new-only clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(sdk): variable-model dedup + undo/scoped-parent correctness; test honesty (code-review) Second batch of review fixes for the SDK-hotspot stack. - Variable model (#7, #13): extract readVariableDefault/writeVariableDefault into a shared engine/variableModel.ts used by both mutate.ts (forward) and apply-patches.ts (replay), so the model shape can't diverge. Add clearVariableDefault and make a `variable` remove patch DELETE the decl's `default` key — the exact inverse of a first-set on a default-less variable. Previously undo of such a set no-op'd and stranded the value. - addElement scoped parent (#8): record the caller's id verbatim (scoped "hf-host/hf-leaf" path or composition id) as the patch parentId instead of the bare data-hf-id, so redo/replay re-resolves the SAME parent via resolveScoped rather than the canonical top-level dup (or document.body). - resolveTimings honesty (#5): correct the header + test that claimed a live "preview == render" parity — neither path consumes the resolver yet (anchor inputs are Pacific/backend-deferred). It's a pure-function property, not a current guarantee. - GSAP writer parity (#12): the recast oracle was deleted in WS-3.F, leaving the WS-3.C keyframe ops comparing acorn output to itself. Pin them as golden inline snapshots and drop the now-dead recast scaffolding (replaceWithKfRecast, removeAnimRecast alias). Remaining pre-WS-3.C parity blocks noted as follow-up. Adds regression tests (undo of default-less variable; scoped-parent redo). SDK 342/342, core timingResolver+parity green, build + fallow --gate new-only clean. Not changed (need design / out of scope): #9 pre-#1569 persisted-override CSS replay (moot for unreleased data; proper fix is render-time CSS derivation), #11 replaceWithKeyframes stale positional id (mitigated by the missing-id no-op guard + type doc; full fix needs non-positional ids). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(sdk): replay CSS-prop derivation for legacy var overrides; stale-id selector guard (code-review) Final review-fix batch — the two items deferred from the prior pass. - #9 legacy variable-override CSS: applyOverrideSet now derives the `--{id}` CSS custom prop from any scalar `var.{id}` override on replay (and removes it for a null override). Sets written before the model/CSS split carried only `var.{id}`; without this, replaying them updated the JSON model but left `var(--{id})` bindings rendering the schema default. Replay-path only — the undo path (applyOne) is untouched, so #1569's separate-patch undo correctness is preserved. Object (font/image) values are never CSS, so they are skipped. - #11 stale positional id: replaceWithKeyframes now requires the located animation to still target the caller's `targetSelector`. Position-derived ids re-point after structural edits; a stale id resolving to a DIFFERENT element's tween previously got silently replaced. It now bails (no-op) unless the id still points at the expected selector. Adds regression tests (legacy var.{id}-only override restores CSS; object override writes no CSS; stale-id-wrong-selector replace is a no-op). SDK 345/345, build + fallow --gate new-only clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(core): gate acorn GSAP writer behind cutover flag; keep recast default (WS-3F) Product decision pivot: acorn no longer replaces recast as the GSAP writer. Recast remains the default server writer; acorn runs only when STUDIO_SDK_CUTOVER_ENABLED=true (or =1) is set server-side — the same env flag name as the client Vite var, so a single switch flips both sides. Changes: - Restore gsapParser.ts (recast writer) + test/stress/helper files deleted by 3F - Restore @babel/parser + recast deps in packages/core/package.json - Add isAcornGsapWriterEnabled() + loadGsapParser() to files.ts (lines 59-82) - Split executeGsapMutation into async dispatcher + executeGsapMutationRecast (recast, async via loadGsapParser) + executeGsapMutationAcorn (acorn, sync) - Dispatcher defaults to recast; acorn branch taken only when flag is on - Restore gsapWriter.parity.test.ts, gsapWriterParity.acorn.test.ts, and gsapWriterParity.corpus.test.ts to true recast-vs-acorn differential suites (not acorn-vs-itself) - Exempt gsapParser.ts in .fallowrc.jsonc health.ignore + ignoreExports (pre-existing complexity + barrel re-exports consumed outside diff scope) - Add fallow-ignore-file code-duplication to files.ts (intentional parallel switch bodies for two writers) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
220 lines
9.7 KiB
TypeScript
220 lines
9.7 KiB
TypeScript
/**
|
|
* WS-C — timingResolver tests.
|
|
*
|
|
* The resolver is pure (no DOM, no Date.now, no Math.random) so it can be
|
|
* unit-tested directly. These tests also serve as the preview==render parity
|
|
* fixture: the resolver produces the exact same output regardless of whether
|
|
* it is called from the preview path (session layer) or the render path
|
|
* (timingCompiler). A golden parity test at the end confirms both paths
|
|
* produce identical enter/exit from the same resolver call.
|
|
*/
|
|
|
|
import { describe, it, expect } from "vitest";
|
|
import {
|
|
resolveTimings,
|
|
type AuthoredTiming,
|
|
type WordTiming,
|
|
type ElementAnchor,
|
|
} from "./timingResolver.js";
|
|
|
|
// ─── Helpers ─────────────────────────────────────────────────────────────────
|
|
|
|
function authored(hfId: string, start: number, duration: number): AuthoredTiming {
|
|
return { hfId, start, duration };
|
|
}
|
|
|
|
function word(index: number, start: number, end: number): WordTiming {
|
|
return { index, start, end };
|
|
}
|
|
|
|
function anchor(
|
|
hfId: string,
|
|
wordIndex: number,
|
|
enterDuration: number,
|
|
exitDuration: number,
|
|
slotEnd: number,
|
|
enterOffset?: number,
|
|
): ElementAnchor {
|
|
return { hfId, wordIndex, enterDuration, exitDuration, slotEnd, enterOffset };
|
|
}
|
|
|
|
// ─── Un-anchored elements keep authored timing ────────────────────────────────
|
|
|
|
describe("resolveTimings — un-anchored elements", () => {
|
|
it("returns authored start/duration unchanged when no anchors supplied", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-a", 1, 2), authored("hf-b", 3, 1.5)],
|
|
wordTimings: [],
|
|
anchors: [],
|
|
});
|
|
expect(result["hf-a"]).toEqual({ enterAt: 1, exitAt: 3, holdDuration: 0 });
|
|
expect(result["hf-b"]).toEqual({ enterAt: 3, exitAt: 4.5, holdDuration: 0 });
|
|
});
|
|
|
|
it("align-on-adjust: anchored and un-anchored elements in same call", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-anchored", 0, 3), authored("hf-free", 4, 2)],
|
|
wordTimings: [word(0, 1.0, 1.5)],
|
|
anchors: [anchor("hf-anchored", 0, 0.5, 0.5, 3.0)],
|
|
});
|
|
|
|
// Anchored: enters at word 0 start (1.0), enterDuration=0.5, exitDuration=0.5
|
|
// slot=3.0 → holdDuration = max(0, 3.0 - (1.0 + 0.5 + 0.5)) = 1.0
|
|
// exitAt = 1.0 + 0.5 + 1.0 + 0.5 = 3.0
|
|
expect(result["hf-anchored"]).toEqual({ enterAt: 1.0, exitAt: 3.0, holdDuration: 1.0 });
|
|
|
|
// Un-anchored: keeps authored timing
|
|
expect(result["hf-free"]).toEqual({ enterAt: 4, exitAt: 6, holdDuration: 0 });
|
|
});
|
|
});
|
|
|
|
// ─── Word-anchored elements ───────────────────────────────────────────────────
|
|
|
|
describe("resolveTimings — word-anchored elements", () => {
|
|
it("anchors element enterAt to word start", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-x", 0, 2)],
|
|
wordTimings: [word(0, 0.5, 1.0), word(1, 1.5, 2.0)],
|
|
anchors: [anchor("hf-x", 1, 0.3, 0.2, 2.5)],
|
|
});
|
|
// enterAt = wordTimings[1].start = 1.5; enterDuration=0.3, exitDuration=0.2
|
|
// holdDuration = max(0, 2.5 - (1.5 + 0.3 + 0.2)) = max(0, 0.5) = 0.5
|
|
// exitAt = 1.5 + 0.3 + 0.5 + 0.2 = 2.5
|
|
expect(result["hf-x"]).toEqual({ enterAt: 1.5, exitAt: 2.5, holdDuration: 0.5 });
|
|
});
|
|
|
|
it("enterOffset shifts enterAt relative to word start", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-y", 0, 1)],
|
|
wordTimings: [word(0, 2.0, 2.5)],
|
|
anchors: [anchor("hf-y", 0, 0.2, 0.1, 4.0, 0.3)],
|
|
});
|
|
// enterAt = 2.0 + 0.3 = 2.3
|
|
// holdDuration = max(0, 4.0 - (2.3 + 0.2 + 0.1)) = 1.4
|
|
// exitAt = 2.3 + 0.2 + 1.4 + 0.1 = 4.0
|
|
expect(result["hf-y"]?.enterAt).toBeCloseTo(2.3);
|
|
expect(result["hf-y"]?.exitAt).toBeCloseTo(4.0);
|
|
expect(result["hf-y"]?.holdDuration).toBeCloseTo(1.4);
|
|
});
|
|
});
|
|
|
|
// ─── Elastic hold math ────────────────────────────────────────────────────────
|
|
|
|
describe("resolveTimings — elastic hold math", () => {
|
|
it("holdDuration = max(0, slotEnd - (enterAt + enterDuration + exitDuration))", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-z", 0, 1)],
|
|
wordTimings: [word(0, 0.0, 0.5)],
|
|
anchors: [anchor("hf-z", 0, 0.5, 0.5, 3.0)],
|
|
});
|
|
// enterAt=0, holdDuration = max(0, 3.0 - (0 + 0.5 + 0.5)) = 2.0
|
|
expect(result["hf-z"]).toEqual({ enterAt: 0, exitAt: 3.0, holdDuration: 2.0 });
|
|
});
|
|
|
|
it("clamps holdDuration >= 0 when slot is too tight", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-tight", 0, 2)],
|
|
wordTimings: [word(0, 5.0, 5.5)],
|
|
// enter=1.0, exit=1.0, slotEnd=5.5 → slot=5.5-(5.0+1.0+1.0)=-1.5 → clamp to 0
|
|
anchors: [anchor("hf-tight", 0, 1.0, 1.0, 5.5)],
|
|
});
|
|
expect(result["hf-tight"]?.holdDuration).toBe(0);
|
|
// exitAt = 5.0 + 1.0 + 0 + 1.0 = 7.0 (element exits after its natural duration)
|
|
expect(result["hf-tight"]?.exitAt).toBe(7.0);
|
|
});
|
|
|
|
it("holdDuration is zero (not negative) when exactly at slot boundary", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-exact", 0, 1)],
|
|
wordTimings: [word(0, 1.0, 1.5)],
|
|
// enterAt=1.0, slotEnd=1.0+0.3+0.2=1.5 → holdDuration=0
|
|
anchors: [anchor("hf-exact", 0, 0.3, 0.2, 1.5)],
|
|
});
|
|
expect(result["hf-exact"]?.holdDuration).toBe(0);
|
|
expect(result["hf-exact"]?.exitAt).toBeCloseTo(1.5);
|
|
});
|
|
});
|
|
|
|
// ─── Missing word index falls back gracefully ────────────────────────────────
|
|
|
|
describe("resolveTimings — missing word index", () => {
|
|
it("falls back to wordStart=0 when word index is not in wordTimings", () => {
|
|
const result = resolveTimings({
|
|
elements: [authored("hf-missing", 5, 2)],
|
|
wordTimings: [word(0, 1.0, 1.5)],
|
|
// wordIndex 99 doesn't exist → wordStart defaults to 0
|
|
anchors: [anchor("hf-missing", 99, 0.5, 0.5, 2.0)],
|
|
});
|
|
// enterAt = 0 + 0 = 0
|
|
// holdDuration = max(0, 2.0 - (0 + 0.5 + 0.5)) = 1.0
|
|
expect(result["hf-missing"]?.enterAt).toBe(0);
|
|
expect(result["hf-missing"]?.holdDuration).toBe(1.0);
|
|
});
|
|
});
|
|
|
|
// ─── Determinism ─────────────────────────────────────────────────────────────
|
|
|
|
describe("resolveTimings — determinism", () => {
|
|
it("produces identical output for identical input (no hidden state)", () => {
|
|
const input = {
|
|
elements: [authored("hf-det", 0, 2), authored("hf-free2", 3, 1)],
|
|
wordTimings: [word(0, 0.5, 1.0)],
|
|
anchors: [anchor("hf-det", 0, 0.3, 0.2, 2.0)],
|
|
};
|
|
const r1 = resolveTimings(input);
|
|
const r2 = resolveTimings(input);
|
|
expect(r1).toEqual(r2);
|
|
});
|
|
});
|
|
|
|
// ─── Preview == render parity golden test ────────────────────────────────────
|
|
//
|
|
// This test mirrors the contract of time_control.py in the backend render path.
|
|
// Both the preview path (SDK session) and the render path (timingCompiler
|
|
// consumer) call resolveTimings() with the same input and MUST produce the
|
|
// same output. Since there is exactly one implementation, calling it twice with
|
|
// the same args is the parity test: they cannot diverge.
|
|
//
|
|
// NOTE: happy-dom cannot do GSAP layout/seek operations so the GSAP-seek path
|
|
// (smart-seek) is exercised by timingCompiler.test.ts (Node.js) separately.
|
|
// The purity of resolveTimings() means this test fully covers resolver logic.
|
|
|
|
// NOTE: this asserts a PROPERTY of the pure resolver (same input → same output),
|
|
// not a guarantee about the two live paths — neither preview nor render calls
|
|
// resolveTimings yet (see timingResolver.ts header). It is a forward fixture for
|
|
// when they do, not proof they currently agree.
|
|
describe("resolveTimings — determinism fixture for future preview/render wiring", () => {
|
|
it("resolver output is identical for identical input (one impl → no drift once wired)", () => {
|
|
// Golden fixture: 3 elements, 2 words, 1 anchored, 2 free.
|
|
const elements: AuthoredTiming[] = [
|
|
authored("hf-title", 0, 2.0), // anchored
|
|
authored("hf-sub", 3.0, 1.5), // free
|
|
authored("hf-cta", 5.0, 1.0), // free
|
|
];
|
|
const wordTimings: WordTiming[] = [word(0, 0.0, 0.5), word(1, 1.0, 1.8)];
|
|
const anchors: ElementAnchor[] = [
|
|
anchor("hf-title", 1, 0.4, 0.3, 3.5), // anchored to word 1
|
|
];
|
|
|
|
// Simulate preview call (same input as would arrive from session layer)
|
|
const previewResult = resolveTimings({ elements, wordTimings, anchors });
|
|
|
|
// Simulate render call (same input as would arrive from timingCompiler)
|
|
const renderResult = resolveTimings({ elements, wordTimings, anchors });
|
|
|
|
// Identical because it is one pure function — this becomes the live
|
|
// "preview == render" guarantee only once both paths actually call it.
|
|
expect(previewResult).toEqual(renderResult);
|
|
|
|
// Spot-check the anchored element's resolved values:
|
|
// enterAt = word[1].start = 1.0 (no offset)
|
|
// holdDuration = max(0, 3.5 - (1.0 + 0.4 + 0.3)) = max(0, 1.8) = 1.8
|
|
// exitAt = 1.0 + 0.4 + 1.8 + 0.3 = 3.5
|
|
expect(previewResult["hf-title"]).toEqual({ enterAt: 1.0, exitAt: 3.5, holdDuration: 1.8 });
|
|
|
|
// Free elements keep authored timing
|
|
expect(previewResult["hf-sub"]).toEqual({ enterAt: 3.0, exitAt: 4.5, holdDuration: 0 });
|
|
expect(previewResult["hf-cta"]).toEqual({ enterAt: 5.0, exitAt: 6.0, holdDuration: 0 });
|
|
});
|
|
});
|