mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-05 00:56:23 +00:00
Miguel Ángel
05c3b5503f
* fix(lint): ignore scripts inside quoted attributes * Address PR review feedback (#2223) - replace repeated attribute scanner with quoted tag ranges - remove the Fallow complexity finding * refactor(lint): parse HTML structure with htmlparser2 * fix(lint): traverse template style sources * test(lint): cover nested template style sources
83 lines
2.7 KiB
TypeScript
83 lines
2.7 KiB
TypeScript
import type { HyperframeLintFinding, HyperframeLinterOptions } from "./types";
|
|
import {
|
|
parseHtmlStructure,
|
|
findRootTag,
|
|
collectCompositionIds,
|
|
readAttr,
|
|
stripHtmlComments,
|
|
} from "./utils";
|
|
import type { OpenTag, ExtractedBlock } from "./utils";
|
|
|
|
export type { OpenTag, ExtractedBlock };
|
|
|
|
export type LintContext = {
|
|
source: string;
|
|
rawSource: string;
|
|
tags: OpenTag[];
|
|
styles: ExtractedBlock[];
|
|
scripts: ExtractedBlock[];
|
|
compositionIds: Set<string>;
|
|
rootTag: OpenTag | null;
|
|
rootCompositionId: string | null;
|
|
options: HyperframeLinterOptions;
|
|
};
|
|
|
|
// Re-export for convenience so rule modules only need one import for the finding type
|
|
export type { HyperframeLintFinding };
|
|
|
|
export function buildLintContext(html: string, options: HyperframeLinterOptions = {}): LintContext {
|
|
const rawSource = html || "";
|
|
// Strip HTML comments before scanning so a commented-out <template> or tag can't
|
|
// hijack the boundary match below. Linear + fixpoint (see stripHtmlComments) to
|
|
// stay ReDoS-free and catch markers that re-form when a comment is removed.
|
|
let source = stripHtmlComments(rawSource);
|
|
const initialStructure = parseHtmlStructure(source);
|
|
const templateTags = initialStructure.tags.filter(
|
|
(tag) => tag.name === "template" && tag.closeIndex != null,
|
|
);
|
|
let sourceWithoutTemplates = source;
|
|
for (const template of [...templateTags].reverse()) {
|
|
const end = template.endIndex ?? template.index;
|
|
sourceWithoutTemplates =
|
|
sourceWithoutTemplates.slice(0, template.index) +
|
|
" ".repeat(end - template.index) +
|
|
sourceWithoutTemplates.slice(end);
|
|
}
|
|
// Some sub-composition files are HTML shells whose real root lives inside a
|
|
// <template>. Keep nested templates intact when the visible document already
|
|
// has a composition root; only unwrap when no root exists outside templates.
|
|
const template = templateTags[0];
|
|
let structure = initialStructure;
|
|
if (template && !findRootTag(sourceWithoutTemplates)) {
|
|
source = source.slice(template.index + template.raw.length, template.closeIndex);
|
|
structure = parseHtmlStructure(source);
|
|
}
|
|
|
|
const tags = structure.tags;
|
|
const styles = [
|
|
...structure.styles,
|
|
...(options.externalStyles ?? []).map((style) => ({
|
|
attrs: `href="${style.href}"`,
|
|
content: style.content,
|
|
raw: style.content,
|
|
index: -1,
|
|
})),
|
|
];
|
|
const scripts = structure.scripts;
|
|
const compositionIds = collectCompositionIds(tags);
|
|
const rootTag = findRootTag(source, tags);
|
|
const rootCompositionId = readAttr(rootTag?.raw || "", "data-composition-id");
|
|
|
|
return {
|
|
source,
|
|
rawSource,
|
|
tags,
|
|
styles,
|
|
scripts,
|
|
compositionIds,
|
|
rootTag,
|
|
rootCompositionId,
|
|
options,
|
|
};
|
|
}
|