Files
hyperframes/packages/inspector/tests/previewHost.test.ts
T
Michael WangandClaude Opus 5.5 b8bb491900 fix(studio-server): harden preview paths, cache folders and local servers (#7510)
* fix(studio-server): keep cache writes inside the project and canonicalize preview paths

- The tool's own folders (.hyperframes records, backups, preview documents,
  .thumbnails, .transcode-cache) are no longer written, pruned or emptied
  through a link that points outside the project. Thumbnails are still
  served when their cache folder is a link; they are just not cached.
- The hf-id stamp record and the history id are replaced atomically instead
  of written through an existing link.
- Sub-composition previews and thumbnails use the composition's canonical
  project-relative path, and the path is attribute-encoded in the document.
- Thumbnail requests from another site are refused before any capture.
- Saved GSAP scripts escape a `</script` sequence so the script element
  keeps its contents.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(core): refuse a UNC or device path on another root before any disk access

isSafePath now rejects a target whose root is a UNC or device root other than
the project's own before it calls realpath or lstat. Projects on a share keep working.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(studio): answer WebMCP clients only from Studio's own page

The polyfill now starts with its tab transport limited to Studio's origin and
its frame transport off, so a page that frames Studio cannot list or call its tools.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(inspector): check Host on the per-session preview server

The preview page server applies the inspector API's loopback Host rule, so a
rebound DNS name cannot read the bundled composition or project files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* revert(studio-server): keep writing media proxies through a linked .transcode-cache

Refusing the folder made every proxied video in such a project answer 502.
A linked cache folder now receives copies again; it is still never swept,
so nothing already in the folder it points at is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(studio-server): drop a comment the comment ratchet refuses

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): skip HEIF and GIF preview prep when .hyperframes/prepared-assets is a link

The preview transform wrote converted images into .hyperframes/prepared-assets
through a link, so a project shipping .hyperframes as a link to another folder
had files written there. Such a project now gets its preview with the images
as written in the composition, unconverted, and nothing is written.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(studio-server): never sweep a linked .transcode-cache, from Studio or hyperframes clean

The link check moves into cleanupProxyCache, which both Studio's cache
maintenance and `hyperframes clean` call, so neither removes files from the
folder a linked .transcode-cache points at.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-10 20:26:12 +00:00

66 lines
2.1 KiB
TypeScript

import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
import { request } from "node:http";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { expect, it, vi } from "vitest";
import { Inspector } from "../src/service";
const pages = vi.hoisted(() => [] as string[]);
vi.mock("puppeteer-core", () => ({
default: {
launch: async () => ({
close: async () => {},
newPage: async () => ({
setViewport: async () => {},
goto: async (url: string) => {
pages.push(url);
await fetch(url);
},
waitForFunction: async () => {},
evaluate: async () => {},
content: async () => "",
close: async () => {},
}),
}),
},
}));
function statusFor(url: string, host: string): Promise<number> {
return new Promise((resolve, reject) => {
request(url, { headers: { host } }, (res) => {
res.resume();
resolve(res.statusCode ?? 0);
})
.on("error", reject)
.end();
});
}
it("serves the preview page to its own browser and refuses a foreign Host", async () => {
const project = mkdtempSync(join(tmpdir(), "inspect-preview-host-"));
writeFileSync(
join(project, "index.html"),
'<!doctype html><html><head></head><body><main data-composition-id="root" data-duration="1" data-width="320" data-height="180"></main></body></html>',
);
writeFileSync(join(project, "notes.txt"), "project file");
const inspector = new Inspector(project, {
executablePath: "browser-stand-in",
instrument: false,
});
try {
await inspector.withPage(async () => {});
const origin = new URL(pages.at(-1)!).origin;
const port = new URL(origin).port;
expect(await statusFor(`${origin}/`, `127.0.0.1:${port}`)).toBe(200);
expect(await statusFor(`${origin}/notes.txt`, `localhost:${port}`)).toBe(200);
for (const path of ["/", "/__hf-runtime.js", "/notes.txt"]) {
expect(await statusFor(`${origin}${path}`, `attacker.example:${port}`)).toBe(403);
}
} finally {
await inspector.dispose();
rmSync(project, { recursive: true, force: true });
}
});