mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-07 18:26:17 +00:00
Miguel Ángel
3bbfea38cf
* fix(engine): use captureBeyondViewport on all CDP screenshot paths Chrome's compositor rounds the viewport boundary inward under multi-tab load, clipping the bottom/right edge of tall portrait compositions (1080x1920). The explicit clip rect already constrains output to exact composition dimensions, making the viewport-boundary pre-clip from captureBeyondViewport:false both redundant and unreliable. Set captureBeyondViewport:true on all three CDP screenshot call sites: pageScreenshotCapture, captureScreenshotWithAlpha, and captureAlphaPng. Add portrait-edge-bleed regression test: 1080x1920 grid with bright magenta bottom rows, rendered with 4 workers. Any compositor clipping at the bottom edge drops PSNR sharply against the golden baseline. Closes #1009 * fix(engine): address review feedback on captureBeyondViewport - Add backref comments on captureScreenshotWithAlpha and captureAlphaPng pointing to pageScreenshotCapture for the rationale, so the next reader doesn't treat the flag as unintentional copy-paste - Note in test meta.json that the static grid fixture covers the capture-side clipping path but not the video-element compositor surface timing that produces the t≈37s self-healing in #1009 * test(producer): use video element in portrait-edge-bleed regression test Replace the static CSS grid with a 1080x1920 portrait video element — matches the original bug report shape where the compositor surface allocation timing causes the bottom-edge clipping. The video has a dark top region and bright magenta bottom 480px, so any viewport clipping at the bottom edge drops PSNR sharply. Baseline regenerated in Docker with 4 workers.
14 lines
581 B
JSON
14 lines
581 B
JSON
{
|
|
"name": "portrait-edge-bleed",
|
|
"description": "Regression test for CDP viewport edge clipping on tall portrait compositions. Magenta rows at the bottom edge of a 1080x1920 canvas; any compositor clipping drops PSNR sharply. Uses 4 workers to exercise the multi-tab compositor path. Note: covers the capture-side clipping but not video-element compositor surface timing from #1009.",
|
|
"tags": ["regression", "capture"],
|
|
"minPsnr": 30,
|
|
"maxFrameFailures": 0,
|
|
"minAudioCorrelation": 0,
|
|
"maxAudioLagWindows": 1,
|
|
"renderConfig": {
|
|
"fps": 30,
|
|
"workers": 4
|
|
}
|
|
}
|