mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-15 13:58:20 +00:00
* fix(studio): guard Zustand no-op setters and fix useConsoleErrorCapture memory leak - Guard setIsPlaying to skip set() when value unchanged (eliminates 60 notifications/sec during reverse playback) - Guard caption store selectGroup to bail before set() when group missing (prevents empty Zustand notifications) - Guard clearSelection to skip when already empty - Fix useConsoleErrorCapture: restore original console.error, remove error event listener, and delete __hfErrorCapture flag on cleanup * fix(studio): delete dead files and unused exports Remove 7 dead files (audioBeatDetection, keyframeSnapping, timelineInspector, DopesheetStrip, StaggerControls, TimelineLayerPanel, TimelineEditorNotice) and their test companions. Delete unused computeFitToChildrenSize export from propertyPanelHelpers. Fix re-export indirection: useDomEditCommits and studioMotionOps.test now import patch builders directly from manualEditsDomPatches instead of the re-export passthrough in manualEditsDom. * fix(studio): eliminate effect-chain state mirroring for lint findings, hover, and GSAP fetch Move lint findingsByElement sync from App.tsx into useLintModal where the value is produced, removing the mirroring useEffect. Consolidate 4 hover-clearing effects in useDomSelection into 2 (one unconditional on context change, one conditional combining caption mode, selection match, and disconnected element checks). Fold the GSAP retry effect into the fetch effect in useGsapTweenCache, scheduling a single retry via setTimeout when the initial fetch returns 0 animations. Eliminates 3 unnecessary render cycles from effect chains. * fix(studio): memoize renderQueue, toolbar, and canvas rect to prevent re-render cascade - Wrap renderQueue object in useMemo so StudioContext consumers don't re-render on every App render - Memoize timelineToolbar JSX so NLELayout memo isn't defeated - Move canvasRect getBoundingClientRect() from render-time IIFE to a useLayoutEffect-backed ref, eliminating layout thrashing - Track and clear setTimeout handles in refreshPreviewDocumentVersion to prevent stale timer accumulation on rapid calls and unmount * refactor(studio): consolidate GSAP shared primitives — defaults, iframe access, keyframe parsing Extract duplicated PROPERTY_DEFAULTS, IframeGsap interface, iframe accessors (getIframeGsap, queryIframeElement), percentage keyframe parsing, and toAbsoluteTime into a single gsapShared.ts module. Removes ~120 lines of copy-pasted logic across 8 hook files, reducing drift risk between the duplicate implementations. * fix(studio): remove dead store fields, dead file, duplicate helper, and unsafe assertions * refactor(studio): deduplicate selector helpers, rounding utils, percentage computation, and iframe access * fix(studio): split StudioContext into Shell + Playback to prevent cascade re-renders * refactor(studio): decompose useGsapScriptCommits into focused mutation hooks * refactor(studio): decompose useFileManager into focused file operation hooks Extract useFileTree (tree loading, refresh, derived assets/compositions) and useEditorSave (debounced save with history tracking) from the 508-LOC useFileManager. The parent hook composes both and retains file I/O, click-to-source, upload/import, and CRUD — preserving the same public interface so no consumers change. * refactor(studio): decompose useDomEditCommits into focused commit hooks Extract geometry (path offset, box size, rotation) and element lifecycle (delete, z-index reorder) into useDomGeometryCommits and useElementLifecycleOps. Parent keeps persistDomEditOperations as core and composes all sub-hooks — public interface unchanged. * refactor(studio): simplify useAppHotkeys with declarative command table * refactor(studio): simplify useAppHotkeys with declarative command table Replace 15 individual useRef callback refs with a single cbRef object. Extract keydown dispatch into pure dispatchModifierKey/dispatchPlainKey functions. Merge duplicate undo/redo logic into shared applyHistory. Extract cross-origin listener boilerplate into safeAddListener/safeRemoveListener. Hook body: 204 LOC (down from 445). Public API unchanged. * fix(studio): remove unused getDomEditTargetKey import * refactor(studio): decompose useDomEditSession into focused editing hooks Extract GSAP-aware geometry intercepts (move/resize/rotation) and animated property commit into useGsapAwareEditing, and selection wiring, GSAP cache management, preview sync, and selection handlers into useDomEditWiring. The parent remains a pure composition shell. * style(studio): fix formatting in 5 files * fix(studio): trim App.tsx to 598 lines (under 600 limit) --------- Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
131 lines
4.4 KiB
TypeScript
131 lines
4.4 KiB
TypeScript
import type { RightPanelTab } from "./studioHelpers";
|
|
import { buildProjectHash, parseProjectHashRoute } from "./projectRouting";
|
|
import { STUDIO_INSPECTOR_PANELS_ENABLED } from "../components/editor/manualEditingAvailability";
|
|
import { roundTo3 } from "./rounding";
|
|
|
|
export interface StudioUrlSelectionState {
|
|
sourceFile?: string;
|
|
id?: string;
|
|
selector?: string;
|
|
selectorIndex?: number;
|
|
}
|
|
|
|
export interface StudioUrlState {
|
|
activeCompPath: string | null;
|
|
currentTime: number | null;
|
|
rightPanelTab: RightPanelTab | null;
|
|
rightCollapsed: boolean | null;
|
|
timelineVisible: boolean | null;
|
|
selection: StudioUrlSelectionState | null;
|
|
}
|
|
|
|
const VALID_TABS: RightPanelTab[] = ["layers", "design", "renders"];
|
|
|
|
export function normalizeStudioUrlPanelTab(
|
|
tab: RightPanelTab | null,
|
|
options: {
|
|
inspectorPanelsEnabled?: boolean;
|
|
} = {},
|
|
): RightPanelTab | null {
|
|
if (!tab) return null;
|
|
if (!VALID_TABS.includes(tab)) return null;
|
|
const inspectorPanelsEnabled = options.inspectorPanelsEnabled ?? STUDIO_INSPECTOR_PANELS_ENABLED;
|
|
|
|
if (!inspectorPanelsEnabled && tab !== "renders") return "renders";
|
|
return tab;
|
|
}
|
|
|
|
export function normalizeStudioCompositionPath(
|
|
activeCompPath: string | null,
|
|
fileTree: string[],
|
|
): string | null {
|
|
if (!activeCompPath || activeCompPath === "index.html") return null;
|
|
return fileTree.includes(activeCompPath) ? activeCompPath : null;
|
|
}
|
|
|
|
function parseBoolean(value: string | null): boolean | null {
|
|
if (value === "1") return true;
|
|
if (value === "0") return false;
|
|
return null;
|
|
}
|
|
|
|
function parseNumber(value: string | null): number | null {
|
|
if (value == null || value === "") return null;
|
|
const parsed = Number(value);
|
|
return Number.isFinite(parsed) ? parsed : null;
|
|
}
|
|
|
|
function parseTab(value: string | null): RightPanelTab | null {
|
|
return VALID_TABS.includes(value as RightPanelTab) ? (value as RightPanelTab) : null;
|
|
}
|
|
|
|
function normalizeSelection(params: URLSearchParams): StudioUrlSelectionState | null {
|
|
const sourceFile = params.get("selFile") || undefined;
|
|
const id = params.get("selId") || undefined;
|
|
const selector = params.get("selSelector") || undefined;
|
|
const selectorIndex = parseNumber(params.get("selIndex"));
|
|
|
|
if (!sourceFile && !id && !selector) return null;
|
|
|
|
return {
|
|
sourceFile,
|
|
id,
|
|
selector,
|
|
selectorIndex: selectorIndex != null ? Math.max(0, Math.floor(selectorIndex)) : undefined,
|
|
};
|
|
}
|
|
|
|
function defaultStudioUrlState(): StudioUrlState {
|
|
return {
|
|
activeCompPath: null,
|
|
currentTime: null,
|
|
rightPanelTab: null,
|
|
rightCollapsed: null,
|
|
timelineVisible: null,
|
|
selection: null,
|
|
};
|
|
}
|
|
|
|
export function parseStudioUrlStateFromHash(hash: string): StudioUrlState {
|
|
const route = parseProjectHashRoute(hash);
|
|
if (!route) return defaultStudioUrlState();
|
|
|
|
const { params } = route;
|
|
return {
|
|
activeCompPath: params.get("comp") || null,
|
|
currentTime: parseNumber(params.get("t")),
|
|
rightPanelTab: normalizeStudioUrlPanelTab(parseTab(params.get("tab"))),
|
|
rightCollapsed: parseBoolean(params.get("rc")),
|
|
timelineVisible: parseBoolean(params.get("tv")),
|
|
selection: normalizeSelection(params),
|
|
};
|
|
}
|
|
|
|
export function readStudioUrlStateFromWindow(): StudioUrlState {
|
|
if (typeof window === "undefined") return defaultStudioUrlState();
|
|
return parseStudioUrlStateFromHash(window.location.hash);
|
|
}
|
|
|
|
export function buildStudioHash(projectId: string, state: StudioUrlState): string {
|
|
const params = new URLSearchParams();
|
|
|
|
params.set("v", "1");
|
|
if (state.activeCompPath) params.set("comp", state.activeCompPath);
|
|
if (state.currentTime != null && Number.isFinite(state.currentTime)) {
|
|
params.set("t", String(Math.max(0, roundTo3(state.currentTime))));
|
|
}
|
|
if (state.rightPanelTab) params.set("tab", state.rightPanelTab);
|
|
if (state.rightCollapsed != null) params.set("rc", state.rightCollapsed ? "1" : "0");
|
|
if (state.timelineVisible != null) params.set("tv", state.timelineVisible ? "1" : "0");
|
|
if (state.selection) {
|
|
if (state.selection.sourceFile) params.set("selFile", state.selection.sourceFile);
|
|
if (state.selection.id) params.set("selId", state.selection.id);
|
|
if (state.selection.selector) params.set("selSelector", state.selection.selector);
|
|
if (typeof state.selection.selectorIndex === "number") {
|
|
params.set("selIndex", String(Math.max(0, Math.floor(state.selection.selectorIndex))));
|
|
}
|
|
}
|
|
|
|
return buildProjectHash(projectId, params);
|
|
}
|