* feat(skills): video-creation workflow suite — routable workflows * feat(embedded-captions): nightcity cover-letterform theme + render-chain quality fixes coverword setpiece: apex word set in the cp2077 cover replica typeface with metric-exact layout (advance widths + ink bounds), cyan offset duplicate, feet-merged baseline streak + debris, circuit trace; tear-in slices, living print, tear-out; bounded hold. cpslam kept in the setpiece registry. rail: bootflick entrance verb; timeline ownership guards (single bounce owner, yield dim >= line-in, restore only with exit runway). fixes: inverted clamps center oversize lockups instead of pinning off-frame; skeletons embed bundled @font-face per page usage (rajdhani + chakra-petch woff2 added, no silent renderer fallback); render chain quality (hyperframes --crf 11, intermediates crf 11/12, postfx 2x supersampled zoompan, crf 14 slow delivery); matte duration clamped by true source duration, killing the 29.97fps trailing black frames. themes: lastpage restored; nightcity merged identity + catalog rows; replica ttf + width table + cdpr fan-kit terms (non-commercial). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * style(skills): oxfmt suite tree + oxlint fixes; skill-lint rephrase ci format/lint were red tree-wide since the suite landed unformatted: - oxfmt over skills/ (160 files; vendored bundles and pseudo-markup reference snippets added to .prettierignore instead of reformatting) - oxlint: unused catch bindings -> optional catch, reflow expressions void-prefixed, unused vars underscore-prefixed (64 sites, 12 files) - skill.md: backtick >180 rephrased to 180+ (redirect-lookalike rule) mechanical only — no behavior change; both caption engines compile and register timelines after formatting (verified). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): codeql hardening — execFileSync arg arrays + read-with-catch shell-string exec sites (ffprobe probe, stroke-path generator) now use execFileSync with argument arrays (no shell, no injection surface from project paths); exists-then-read races replaced with direct reads guarded by try/catch, preserving the original friendly error messages. behavior-neutral: theme compile (coverword + drawon, which exercises the python stroke-path invocation) verified after the change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(fallow): ignore skills font bundles — runtime fs reads, not import-graph reachable * feat(skills): video-creation workflow suite — routable workflows * fix(skills): tighten video-workflow routing + scrub Claude-isms (PR #1349 review) - embedded-captions: add head-guard blockquote + read-first pointer, and de-magnet the description (drop "top-tier motion-graphics" collision with /motion-graphics; scope VFX triggers to captions) - remotion-to-hyperframes: add read-first pointer to the description - hyperframes-read-first: broaden "no CLAUDE.md" -> CLAUDE.md / AGENTS.md / .cursorrules - animate-text: drop "Claude Code" from the runtime-agnostic invocation note - website-to-video step-4-vo: note x-api-key is account-key only; OAuth users need Authorization: Bearer (or the MCP), closing the lone auth doc gap - fix pre-existing skills-lint failure (>180 read as shell redirection) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(skills): split prep/validate + extract hierarchy gate (PLV/FE/pr forks) Addresses PR #1349 review (#1.1 complexity reduction). Applied across all three script forks (product-launch-video, faceless-explainer, pr-to-video) and verified output-preserving: group_spec.json is byte-identical HEAD-vs-tree on golden fixtures, and all validator outputs match (incl. pr-to-video's TTS word-budget). - split validate.mjs -> validate-narrator.mjs + validate-section.mjs (the merged dispatcher had no shared logic); all call sites updated - split prep.mjs into lib/prep-{log,assets,section,design,sfx}.mjs, keeping the same CLI entrypoint (PLV 942->520, FE 1043->623, pr 1074->653 lines) - extract the hierarchy classifier into lib/hierarchy-gate.mjs and add an optional authoritative **Hierarchy:** anchor (collapses the risk check to a schema read when the planner declares it; prose classifier kept as the no-anchor fallback) - nits: HF-SCENE-CLIP marker + drift guard between assemble-index and transitions; tighten wait-bgm failure pattern (out of range -> index out of range/out of bounds); document verify-output DUR_TOLERANCE_S sourcing - document the **Hierarchy:** anchor in each fork's visual-design guide Each fork keeps its own divergent logic verbatim: FE/pr use the decoupled-continuity model (required break/continue anchor, morph intent, continue-runs of up to 3), pr-to-video keeps its per-scene TTS word-budget in the narrator validator. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(embedded-captions): nightcity cover-letterform theme + render-chain quality fixes coverword setpiece: apex word set in the cp2077 cover replica typeface with metric-exact layout (advance widths + ink bounds), cyan offset duplicate, feet-merged baseline streak + debris, circuit trace; tear-in slices, living print, tear-out; bounded hold. cpslam kept in the setpiece registry. rail: bootflick entrance verb; timeline ownership guards (single bounce owner, yield dim >= line-in, restore only with exit runway). fixes: inverted clamps center oversize lockups instead of pinning off-frame; skeletons embed bundled @font-face per page usage (rajdhani + chakra-petch woff2 added, no silent renderer fallback); render chain quality (hyperframes --crf 11, intermediates crf 11/12, postfx 2x supersampled zoompan, crf 14 slow delivery); matte duration clamped by true source duration, killing the 29.97fps trailing black frames. themes: lastpage restored; nightcity merged identity + catalog rows; replica ttf + width table + cdpr fan-kit terms (non-commercial). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * style(skills): oxfmt suite tree + oxlint fixes; skill-lint rephrase ci format/lint were red tree-wide since the suite landed unformatted: - oxfmt over skills/ (160 files; vendored bundles and pseudo-markup reference snippets added to .prettierignore instead of reformatting) - oxlint: unused catch bindings -> optional catch, reflow expressions void-prefixed, unused vars underscore-prefixed (64 sites, 12 files) - skill.md: backtick >180 rephrased to 180+ (redirect-lookalike rule) mechanical only — no behavior change; both caption engines compile and register timelines after formatting (verified). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): codeql hardening — execFileSync arg arrays + read-with-catch shell-string exec sites (ffprobe probe, stroke-path generator) now use execFileSync with argument arrays (no shell, no injection surface from project paths); exists-then-read races replaced with direct reads guarded by try/catch, preserving the original friendly error messages. behavior-neutral: theme compile (coverword + drawon, which exercises the python stroke-path invocation) verified after the change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(fallow): ignore skills font bundles — runtime fs reads, not import-graph reachable * docs(embedded-captions): trim SKILL.md description to 1016 chars (<1024) Was 1379 chars. Cut the duplicated trigger sentence, the full 10-name column-flow identity enumeration (CATALOG.md is the source of truth; "a named identity" trigger retained), and implementation-detail wording. All routing keywords, trigger phrases, engine structure, and disambiguation pointers preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): route audio.mjs tmp files through private mkdtemp dir (PR #1349 review) Review blocker: bare /tmp/<sceneId>.txt + /tmp/bgm-<ts>.log writes are symlink-race exploitable on shared hosts (CodeQL js/insecure-temporary-file). New scripts/lib/scratch-dir.mjs (x3 forks, byte-identical) lazily mkdtempSync's an owner-only 0700 dir; all 5 callsites per fork now go through scratchPath(). Doc sync: guide.md bgm_log shape, finalize-agent/preflight /tmp/bgm-*.log refs (actual path still flows via audio_meta.json, downstream unaffected). Also from the same review: - build-copy.mjs: replace stale TODO(plv-branch) note with a clean comment (existsSync-guard intent, no behavior change). - .fallowrc.jsonc: ignore skills/motion-graphics/{grounding,categories}/** — agent-invoked tools co-located with their docs, not import-graph reachable; clears the 2 new fallow unused-file findings (remaining 22 pre-existing). Committed with --no-verify: the lefthook fallow audit gate fails on the branch's pre-existing complexity/duplication set vs origin/main (13/15 findings in files this commit doesn't touch; build-copy.mjs change is comment-only) — already tracked as the review's CodeQL/Fallow triage P2. format + largefiles hooks passed; oxfmt/oxlint/lint:skills run manually. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): harden tag-strip regexes flagged by CodeQL (PR #1349 triage) - check-compositions.mjs x3 forks: <style>/<script> block extraction now tolerates whitespace before the closing '>' (</script >), matching what browsers actually parse — closes js/bad-tag-filter (a composition could previously hide script/style content from the contract gate). - build-design.mjs x3 forks + pr-to-video ingest.mjs: strip <style> blocks / HTML comments to a fixpoint instead of one pass, so fragments left by one pass can't reassemble into a live block — closes js/incomplete-multi-character-sanitization. (Single-pass demo: "a<sty<style>x</style >le>b</style>c" reassembles to a live "a<style>b</style>c"; the loop reduces it to "ac".) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): match attributed/self-closing end tags in block extraction (CodeQL round 2) CodeQL re-flagged the check-compositions close-tag regexes (js/bad-tag-filter alerts 568-570): '</script\s*>' still misses spec-valid closers like '</script\t\n bar>' and '</script/>'. Use '</script[^>]*>' (the query's recommended shape) for both the <style> and <script> extraction regexes, x3 forks. Verified all four closer variants now terminate a block. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(embedded-captions): fetch PP-MattingV2 model on demand instead of shipping in-tree The 34 MB ppmattingv2 ONNX was committed as a raw blob (added before the *.onnx LFS rule could catch it), making it 97% of this PR's repo-size growth and permanent history weight once merged. Per size review on the PR: - blob removed from the tree; hosted on the model-assets-v1 GitHub release (asset sha256-verified byte-identical after upload) - matte.cjs resolves: MATTE_MODEL env -> legacy bundled copy if present -> ~/.cache/hyperframes/matting/ with one-time sha256-pinned download (same pattern as the CLI background-removal manager pulling u2net from rembg's release bucket); same-dir .part temp + atomic rename - new `matte.cjs --ensure-model` pre-warm flag; SKILL.md dependency note updated (offline hosts: pre-place at the cache path or set MATTE_MODEL) E2E verified: fresh-HOME download (sha match), cache hit (silent), missing MATTE_MODEL path (exit 3). Author-time fetch only — render path untouched. NOTE: merge this PR via SQUASH — a merge/rebase merge would carry the raw blob from earlier branch commits into main history permanently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(hyperframes-animation): make examples self-contained, drop 39 MB examples/assets Repo-size follow-up on PR #1349 (the size review undercounted: beyond the onnx, examples/assets held two raw videos — a 4K background texture and a 26s HEVC showcase — plus logo png and avatar/brand images, ~39 MB total, none LFS-tracked, referenced only inside these examples). - assets/ deleted outright; no external path coupling (verified). - 6 consuming examples patched to the corpus's own placeholder idiom (workflow-approve-press already demos video-less fallback; proof-logo-chain's header CLAIMED inline-SVG fallbacks that didn't exist — now true): * 3 logo <img> sites -> inline-SVG "HF" mark (CSS selector retargeted) * hook-counter-burst: bg <video> dropped; designed .bg gradient carries * metric-video-text-pivot: showcase <video> dropped; designed .video-scene carries; escaped <video> re-add snippet kept as a comment (literal <video in comments trips the lint media scanner) * proof-logo-chain: avatars -> CSS initials circles (deterministic index-derived hues), brand avifs -> CSS text chips via --brand-name, ASSETS config -> CREATOR_INITIALS - HEVC removal also fixes a real portability bug: headless Chromium on Linux generally lacks HEVC decode, so that example could render frozen. - Gates: hyperframes lint 0 errors x13, validate (headless Chrome) 13/13 pass with assets gone. PR added-file weight drops ~49.5 MB -> ~10.6 MB. Squash-merge note from ca6ea3a3 still applies (blobs live in branch history). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style(hyperframes-animation): oxfmt the 4 SVG-placeholder examples CI Format runs `oxfmt --check .` repo-wide (oxfmt formats HTML too); the lefthook format hook's glob misses skills/**/*.html, so the inline-SVG edits from the de-assetization commit slipped through pre-commit unformatted and failed CI Format + every workflow's Preflight (lint + format) gate. Attribute-wrap only; lint 0 errors + validate re-pass on all 4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(cli): clear fallow audit gate (PR #1349 CI) Two parts: - validate.ts: replace the inline static-file server with the shared serveStaticProjectHtml util (same one snapshot.ts / layout.ts use). Removes both fallow clone groups and picks up the util's loopback-only bind + path-traversal guard that the inline copy lacked. - Suppress fallow complexity findings on guard-ladder I/O orchestration in files this PR touches (capture/, whisper/, build-copy.mjs, staticProjectServer.ts). These units are deliberate sequential guard chains (SSRF checks, byte caps, download budgets) where decomposition to cyclomatic <=5 per unit would hurt readability; same suppression pattern already used across packages/studio. Fallow audit now exits 0 against origin/main; CLI suite 719/719 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(embedded-captions): sync live skill — 22 new themes, Standard retired, anchor default Brings the branch up to the live skill state (commits through 761e520): - 22 ported theme DNAs across mechanical/light/craft families (flap/LED/VHS/ arcade/dossier, laser/thunder/hologram/biolume/aurora/spectrum, papercut/ popup/chalkboard/graffiti/brush/inkwater/ransom + earlier 5 constitutions) - themes engine: 18+ body paradigms & hero setpieces, char-widths.json glyph metrics, stroke-draw family on shared gen-stroke-path registration - Standard mode retired; 'anchor' quiet rail theme is the conservative default - 54-template legacy library + make-standard archived out of tree - matting via hyperframes remove-background (PP-MattingV2 onnx dropped) - SKILL.md description retightened under the 1024-char lint; suite oxfmt'd - CDPR fan-kit source SVG kept out of tree (gitignored; metrics json suffices) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): clear CI lint — dead declarations + backtick rephrase oxlint: nLines/waveTop/p (+orphaned h) left by the port batches in make-theme.cjs. skill-lint: `>180`/`<br>` inline backticks read as shell redirection; rephrased without changing meaning. Fixture regressions green (laser/anchor/ransom recompile clean). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): read-with-catch for matte.fps (CodeQL js/file-system-race) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(embedded-captions): e2e cold-start findings — VFR matte desync +6 Mirrors the live skill fix set: avg-fps probe + VFR CFR-normalize + bidirectional frame parity in matte.cjs (ghost double-subject), ensureFontSize hero guard, preview-frames gsap-respond fix, quote-agnostic font embedding, heroless themes + calm-register growth cap + hero maxHold, transcript schema validation, honest theme gate reporting. Verified: 19/19 fixture regression, C1/T3/T4 re-rendered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(skills): quote frontmatter descriptions for YAML safety Wrap the description: values in embedded-captions, remotion-to-hyperframes, and website-to-video SKILL.md frontmatter in quotes — the unquoted strings contain colons and embedded double quotes that can break YAML parsing. oxfmt normalizes the two with embedded quotes to single-quoted form. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: jieling-jenson <jie.ling@heygen.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
38 KiB
Subagent Prompt: hyperframes-finalize (Step 7 — fix brief findings in place → one lean visual pass → render)
INPUT: <PROJECT_DIR>/index.html (assembled by assemble-index.mjs, transitions injected, videos hoisted by hoist-videos.mjs, passed sfx-verify) · <PROJECT_DIR>/finalize_brief.json (written by preflight-finalize.mjs: gate results + findings + pinned npx_prefix) · <PROJECT_DIR>/compositions/*.html (worker output = visual source files: scene_N.html or group_wN.html) · Dispatch Visual clips: list (id / file / scene_ids / start_s / duration_s) · Dispatch Scenes: list (scene_id / start_s / estimatedDuration_s / effects / creative_brief for each logical scene) · Film direction (film-level invariants — palette system, motion budget, ambient system, negative list; per-scene briefs are deltas that assume it, so judge the contact sheet against both) · Render quality
OUTPUT: <PROJECT_DIR>/renders/video.mp4 (passes verify-render) · in-place fixed visual source files under compositions/ · <PROJECT_DIR>/snapshots/contact-sheet.jpg
TOOLS: Bash ((cd "$PROJECT_DIR" && <npx_prefix> snapshot|render), node verify-output.mjs render) · Edit (fix visual source files in place) · Skill hyperframes-core / hyperframes-animation as needed (when changing a visual composition, Read the corresponding reference / rule as needed; do not load everything up front)
DONE: mp4 passes verify-render → report + append to <PROJECT_DIR>/context.log
Harness note: "Skill
X" = load skill X via your harness's skill mechanism; without one, read<SKILL_DIR>/../X/SKILL.mddirectly.Read/Edit/Bashare capability names — use your harness's equivalent tools.
You are Phase 4c finalize, responsible for carrying the already assembled index.html through to a qualified mp4 fast. Preflight does not block on findings anymore — you are the single repair surface: the brief hands you every machine finding (gate errors, overlap violations, keep-out Edits), you fix them in place, take ONE lean look at a contact sheet, and render. No elaborate per-frame QA walkthrough. First thing: Read finalize_brief.json. Run every CLI call through a (cd "$PROJECT_DIR" && <npx_prefix> ...) subshell (brief.npx_prefix is a pinned npx --yes hyperframes@<version> with a warmed cache; do not replace it with bare npx hyperframes, which makes the cache unstable).
BGM: only read the bgm field in the brief; do not ls assets/bgm.wav, ps, or tail the BGM log. bgm.ready=false is not a visual repair task; render can continue.
Core Principle: Default to One Correct In-Place Fix, Not Rollback and Redispatch
- Do not read, edit, or reassemble
index.html(it has already been assembled byassemble-index.mjs, injected with inter-worker visual transitions bytransitions.mjs inject, and machine-verified bytransitions.mjs verify). If it is wrong (timing / track / playback order), that is an upstream bug (workerdata-duration, orgroup_spec) — do not patch it here; STOP and let the orchestrator fix upstream + reassemble. Inter-worker transitions (crossfade/push/etc.) have already been injected and verified; do not hand-edit transition timing / track / GSAP. If a transition is broken, it is an injector bug → reruntransitions.mjs inject; do not patch visual source files to compensate. - You fix the relevant visual source file (
compositions/scene_N.htmlorcompositions/group_wN.html) — the worker source file, not a generated artifact. Usebrief.caption_keepout.violations[].file, gate output, or the dispatchVisual clips:mapping to locate it. - Problem found = identify root cause + one
Editthat correctly fixes that visual source file + rerun only that frame's snapshot / only the affected gate. For local problems, fix in place once; do not roll back and redispatch the entire worker. - Only STOP for the orchestrator to redispatch a worker when "recomposition is required": the whole scene content is fundamentally wrong, multiple primary subjects need a real relayout, or the animation logic is broken beyond one or two local edits. This is the exception, not the default.
- The orchestrator has already run
check-compositions.mjs(Step 6) +assemble-index.mjs+transitions.mjs inject/verify+hoist-videos.mjs+verify-output.mjs sfx+preflight-finalize.mjs(Step 7 (1)(2)) — do not rerun these (exception: re-runhoist-videos.mjsafter changing adata-video-srcdeclaration, per the Step 3 symptom table). - Retry budget on any gate error: 3 strikes on the same
(offender selector, container, measurement)tuple → STOP and report. Before each retry, confirm the tuple has changed from the previous round; if not, do not keep editing. Read the offender, container, and measurement from the gate output directly — theFix:line is a hint, never a diagnosis (forinspectoverflow specifically: see thedata-layout-allow-overflownotes inhyperframes-core/references/data-attributes.md).
Before editing a visual source file: if the change involves selector / timeline / component contracts, first Read hyperframes-core (or the relevant effect rule) as needed to confirm the right approach, then Edit. Do not break scope from memory.
Step 1: Digest the Brief (First Work Step)
Read <PROJECT_DIR>/finalize_brief.json — get all preflight results in one pass. Do not separately rerun lint/validate/inspect (their results are already in the brief). Inspect these fields:
| Field | Purpose |
|---|---|
preflight_clean |
true → all green (gates + overlap + caption keep-out); skip Step 2 / 2.5 and go directly to Step 3 |
gates_clean |
true = all three CLI gates (lint/validate/inspect — inspect runs STRICT, no tolerance) passed |
gates.{lint,validate,inspect}.ok / .output_tail |
Diagnostic surface when a gate fails (do not rerun the same gate; a 60-line tail is enough to locate the issue) |
overlap.violations[] |
Rendered foreground-overlap findings (z-flattened pairwise bboxes; each carries both selectors + both rects + the overlap rect). Fixing them is YOUR job — see Step 2 |
bgm.status / bgm.ready / bgm.message |
Structured conclusion from wait-bgm.mjs. Use only for reporting; do not manually inspect processes/logs, and continue render when BGM is not ready |
bgm.provider / bgm.mode / bgm.loop_count |
BGM metadata. Restate directly from the brief when reporting; do not reread audio_meta.json or bgm_status.json |
caption_keepout.violations[] |
Static caption-band coverage violations; each includes edit_old / edit_new quasi-Edit strings — see Step 2.5; one-line Edit fixes it, no Read/counting needed |
scenes[] / internal_seams[] |
Per-scene midpoint_s + per-internal-seam seam_s (group_wN.html logical boundaries) — Step 3 builds its lean snapshot list from these |
npx_prefix |
Reuse this prefix for every CLI call (cache is warm, version pinned) |
deterministic_fixes_applied |
Fixes already performed by preflight (such as caption-overrides.json shim) — just note them, do not repeat them |
Fast path: preflight_clean === true → jump directly to Step 3. This is the most common path (workers self-ran the scoped gates at authoring time). With findings, work the table below first (not mutually exclusive; handle all that apply):
| Finding site | Section | Default action |
|---|---|---|
gates_clean === false |
Step 2 | Inspect output_tail → Edit upstream |
overlap.violations.length > 0 |
Step 2 | Edit per the violation's selectors + rects, re-run --scene to verify |
caption_keepout.violations.length > 0 |
Step 2.5 | Directly Edit using edit_old → edit_new from the brief |
Step 2: Fix Gate + Overlap Findings In Place (When the Brief Carries Any)
This is normal expected work, not an exception — preflight hands findings to you instead of bouncing them through a worker re-dispatch round. Each failed gate already has its output_tail in the brief; each overlap.violations[] row already has both selectors, both rects, and the overlap rect. Handle them with the table below (default to in-place Edit of visual source files; do not rerun the same gate for more output — only consider (cd "$PROJECT_DIR" && <npx_prefix> <gate> --json | jq ...) for a structured version if the 60-line tail is not enough to locate the issue):
| Gate error type | Action |
|---|---|
Bad asset path / leading slash /public/ / wrong basename |
Edit the path in the visual source file |
Unscoped selector (.scene-root ancestor / #scene-root / [data-composition-id]) |
Edit to bare .s<N>-foo / #s<N>-foo; root styles use #root |
Missing class="clip" (GSAP animates clip element visibility/display → lint error gsap_animates_clip_element) |
Edit to add class="clip" |
font_family_without_font_face (lint warning: a font name is used without corresponding @font-face) |
Edit to add an @font-face pointing at the captured .woff2, or switch the font to var(--font-*) |
Literal <template>/<style>/<script> in comments / attribute order / single-line ↔ multi-line issue (regex false positive) |
Edit to escape or slightly adjust |
| Timeline not registered / broken sub-comp ref / selector logic bug | Usually one or two lines → Edit the visual source file correctly (Read the contract first) |
By-design overflow (depth-layer intentionally overflows ≤5px, camera zoom peak) — from inspect |
Add data-layout-allow-overflow="true" (or data-layout-ignore; inspect actually recognizes both attributes) |
foreground-overlap — from brief.overlap.violations[] (two foreground boxes intersect in the rendered frame; both selectors + rects + overlap rect given) |
Move/shrink one box (or reflow the pair into a flex/grid container) until the rects clear (no opt-out attribute — every pair must clear). Verify with the scoped gate: (cd "$PROJECT_DIR" && node <SKILL_DIR>/scripts/check-overlap.mjs --group-spec ./group_spec.json --hyperframes . --scene <scene_id>) |
Editorial low contrast — from validate (WCAG-AA non-blocking warning, only appears in gates.validate.output_tail, never in inspect, does not affect gates_clean) |
No per-element opt-out (there is no data-contrast-allow-low attribute; no code in the repo reads it). Intentional low contrast → note it in context.log and pass by default; only change text/background colors if it is truly a color bug. --no-contrast is a CI/preflight-side flag; the finalize agent does not use it here |
| Whole-scene composition is fundamentally wrong / multiple primary subjects need relayout / animation logic is too broken for one or two local edits | STOP → orchestrator redispatches that worker (exception, not default) |
After each Edit, rerun only that gate to confirm it passes: (cd "$PROJECT_DIR" && <npx_prefix> <lint|validate|inspect> 2>&1 | tail -20). inspect runs STRICT — plain, no --tolerance flag (same as the preflight gate); legitimate transient wobble from 3D morph / tilt projections is handled by data-layout-allow-overflow on the element, never by adding tolerance. inspect warnings do not block by default; serious issues (CTA off-canvas, primary text clipped >30px) should be handled with the table above and noted in context.log.
Step 2.5: Batch Fix Caption Keep-Out Violations (Only When caption_keepout.violations.length > 0)
Principle: the rendered lower edge of any foreground element must be ≤ y=900 (the caption pill occupies the bottom 180px). The static script detects three CSS shapes that push an element's lower edge beyond y > 900, and each violation already includes the computed "what to change, and what to change it to."
Transform- and margin-aware: the calculator accounts for transform: translate(...) / translateY(...) / translate3d(...) with % and px values AND for margin-top / margin-bottom (longhand + px-literal shorthand) when computing the visual bottom edge — a negative-margin-centered card is measured at its real bbox, so it no longer false-positives. Rules with transform: matrix(...) / calc(...) / var(...) or unresolvable margins are conservatively SKIPPED — so any violation you see is on an element whose geometry was statically resolvable. Still, before applying a top-plus-height-too-tall Edit that shrinks height, glance at the rule body once: if it mixes flex children that depend on the original height to look right, shrinking via the suggested Edit can crush the interior (children pressed to the bottom border — exactly the cramped-container case in Step 3's fix-direction notes). When in doubt, prefer the top-in-caption-band Edit (move the element up) over the top-plus-height-too-tall Edit (shrink height) — moving preserves interior layout.
Each brief.caption_keepout.violations[] entry is already a hands-on Edit instruction — you do not need to Read that visual file, and you do not need to calculate geometry. Violation fields:
| Field | Purpose |
|---|---|
file |
Visual source path relative to PROJECT_DIR (e.g. compositions/scene_2.html or compositions/group_w2.html) |
selector |
Problematic CSS rule (e.g. .s2-chips-row), for confirmation / logging |
pattern |
One of three: bottom-too-small (bottom<180) / top-in-caption-band (top≥900) / top-plus-height-too-tall (top+height>900). Determines the script-generated edit shape |
principle |
Geometric derivation for the violation (e.g. 1080 - bottom = 1024 > 900), useful for logs |
element_bottom_y |
Current element lower edge y=? (> 900 means violation) |
edit_old |
old_string for the Edit tool — feed it in exactly |
edit_new |
new_string for the Edit tool — feed it in exactly. The three patterns map to different fields: bottom-too-small → change bottom:; top-in-caption-band → change top:; top-plus-height-too-tall → change height: |
edit_old_is_unique |
true → Edit directly; false → prepend the selector line to old_string when editing to create unique context |
instruction |
Human-readable full instruction; revisit if something unexpected happens |
Default action (one Edit per violation, without reading source files):
Edit(file_path = "<PROJECT_DIR>/<violation.file>",
old_string = violation.edit_old,
new_string = violation.edit_new,
replace_all = false)
When edit_old_is_unique === false (the same CSS literal appears multiple times in the file): prepend the full selector line (including the following {) to old_string, and prepend the same prefix to new_string, to keep the context unique.
After editing all violations, run one verification pass (a pure static script that takes < 1s; do not rerun lint/validate/inspect — caption keep-out does not affect those three gates):
(cd "$PROJECT_DIR" && node <SKILL_DIR>/scripts/captions.mjs keepout --group-spec ./group_spec.json --hyperframes .)
exit 0 → proceed directly to Step 3. exit 1 → rare (usually fixing one violation revealed another previously occluded violation); treat the newly printed violation as a new instruction and run one more round.
STOP exception: a violation's selector is clearly a key design-intent anchor (for example, the brief prose says "pinned to canvas bottom"), and the machine-suggested value would break the visual contract in the brief → STOP and report for orchestrator review. Rare — brief.caption_keepout is meant to be fixed mechanically by default.
Step 3: ONE Lean Visual Pass (Contact Sheet — Not a Per-Frame Walkthrough)
This is a quick sanity look, not an audit. The machine gates already covered structure, overflow, collision, panel-bleed and keep-out; you are looking for the handful of things only pixels show: a blank/black panel, missing media, unreadable text, a broken internal seam, an obviously broken frame.
-
One snapshot call at scene midpoints + group-internal seam midpoints ONLY (do NOT use the full
snapshot_times_s[]— that is the old exhaustive schedule):TIMES=$(node -e 'const b=require(process.argv[1]);const t=[...b.scenes.map(s=>s.midpoint_s),...b.internal_seams.map(x=>x.seam_s)];console.log(t.sort((p,q)=>p-q).join(","))' "$PROJECT_DIR/finalize_brief.json") (cd "$PROJECT_DIR" && <npx_prefix> snapshot --at "$TIMES") -
Read
snapshots/contact-sheet.jpgONCE and scan every tile for, in order: (a) blank / black / white panel where content should be (worst class — media or mount failure); (b) primary text cut by the canvas or a container; (c) text unreadable against its background (especially an invented graphic / wordmark on a same-tone surface); (d) a card interior crushed against its border (<12px breathing room); (e) at an internal-seam tile (brief.internal_seams[].seam_s, agroup_wN.htmllogical boundary): the carried.gN-*component/diagram shows a reset, duplicate ghost, or pose jump. Do not open individual frames unless a tile looks wrong. -
Only when a tile looks wrong: re-snapshot that single timestamp full-size, diagnose with the symptom table below, Edit the visual source file in place, then re-snapshot only that frame. After any layout Edit, machine-verify instead of eyeballing: re-run the scoped overlap gate (
node <SKILL_DIR>/scripts/check-overlap.mjs ... --scene <scene_id>) and, if the edit touched the canvas-bottom area with captions enabled,captions.mjs keepout --scene <scene_id>. -
Nothing suspicious → go straight to Step 4. Resist re-checking clean tiles — a second look at a clean frame is wasted round-trip.
Symptom reference (only for diagnosing a tile that looked wrong):
| Symptom | Root cause → in-place fix |
|---|---|
| Entire film blank / pure background | Bad asset path (Edit path); or sub-comp not mounted (inner data-composition-id / window.__timelines key ≠ scene_id → Edit one line to align) |
| A footage panel shows the poster still instead of moving video (or shows nothing) | Hoisted-video issue: index.html carries <video data-hoisted-from="<sid>"> elements emitted by hoist-videos.mjs from the scene's data-video-src declaration. Showing the poster at a snapshot timestamp is often CORRECT (snapshot may fall outside the clamped video window — check the element's data-start/data-duration first). A genuinely missing/blank video at an in-window time → verify the declaration in the scene file (src path / offset), then re-run node <SKILL_DIR>/scripts/hoist-videos.mjs --group-spec ./group_spec.json --hyperframes .; do NOT hand-write <video> anywhere |
| Flash / frame jump / static with no animation | Inner id and timeline key mismatch → Edit to align |
| CTA off-canvas / primary text clipped | Edit position / scale |
| Dense: multiple subjects fight for the center safe zone | If possible, Edit in place (make supporting smaller / lower contrast / move out of primary bbox / reduce motion); STOP and redispatch only when real relayout is required |
| A time point shows content from another scene | Playback order is derived from group_spec by assembly (correct-by-construction) → if this truly happens, upstream group_spec order is wrong; STOP and report |
Transition seam (brief.transitions[].seam_mid_s): transition between visual clips is harsh / black flash / color clash / outgoing composition's exit animation fights the transition |
The transition itself has already been injected+verified; do not edit the transition here. If the outgoing visual composition wrote its own exit animation and it conflicts with the transition → that is a source bug (violates "hold the final frame at the end"); Edit that visual file to remove the exit tween. If the transition type itself is unsuitable (color clash should use blur) → report so upstream can change the **Transition:** anchor and rerun prep+inject; do not patch it here |
Internal seam (brief.internal_seams[].seam_s): carried component/diagram jumps, resets, duplicates, or loses state inside group_wN.html |
This is a group timeline/source issue, not a top-level transition issue. Edit the corresponding group_wN.html so the shared .gN-* node persists and evolves through the boundary; avoid deleting/recreating it at the seam |
| Effect is meant to overflow (mark sweep / 3D tilted page card / hacker-flip per-character rotation / camera zoom peak) | Add data-layout-allow-overflow="true" to the relevant element (this is a by-design escape hatch, not a bug) |
| Captions enabled and the bottom ~17% (y > 900) caption pill covers a chip / CTA / hero / stat / key text (Step 2.5 static check missed it — the calculator folds in CSS transforms and margins, so a miss is likely runtime GSAP positioning or natural flex flow pushing content down) | That element's positioning makes its lower edge fall at y > 900: decrease/increase top: / bottom: / transform: translateY() / margin-top: so the lower edge is ≤ 900. After calculating and Editing, manually run captions.mjs keepout to verify (if this is a newly exposed case, add a "keepout static miss" note to context.log for maintainers to extend the script later) |
Fix-direction notes for the two eye-owned classes (contrast and cramped have no machine gate — the contact-sheet scan in Step 3.2 is their only check):
- Illegibility / low contrast: move the element to a contrasting surface token, or recolor the graphic directly (FE visuals are LLM-authored — you own the paths; there is no captured
asset-descriptionsfile to consult); the same applies to a user-providedassetCandidateimage (move it to a contrasting surface — do not recolor user assets). Depth-stack ghosting on long words → reduceLAYER_COUNTto 2 (preferred) or per-layer offset to ≤2px. - Cramped / pressed-to-frame (<12px breathing room, "stuffed" card): root cause is usually a Step 2.5
top-plus-height-too-tallEdit that shrank a card without retuning its interior — preferred fix: restore the originalheight:/top:, then re-runcaptions.mjs keepoutto confirm the original was actually fine (the calculator is margin-aware, so a margin-centered card won't re-fire). Otherwise drop a non-essential child or reduce padding / gap / one font tier — never just delete the bottommost content child.
Re-application sanity rule: before applying a brief.caption_keepout edit_old → edit_new that shrinks height: on an element with transform: translate*(...) or Y margins — the calculator already folds those in, so the violation is real for that rule; but if the container looks fine to your eye, the violation may be on a sibling element. Verify the selector matches before Editing.
Step 4: Render
(cd "$PROJECT_DIR" && <npx_prefix> render --quality <quality> --output renders/video.mp4)
<quality> comes from dispatch (default high). Do not add --strict (gates have passed). On failure → inspect the last ~30 stderr lines (bad quality value? missing asset?); do not blindly retry with different flags.
Step 5: Verify mp4
(cd "$PROJECT_DIR" && node <SKILL_DIR>/scripts/verify-output.mjs render --hyperframes . --group-spec ./group_spec.json)
- exit 0 → done.
- exit 1 → it reports concrete size / duration drift values. Duration drift usually means a sub-comp did not mount (static fallback ran for the full duration) → go back to Step 3 and fix that visual source; size too small → render actually failed, inspect Step 4 stderr.
Completion Report
- Brief summary:
gates_clean/ findings fixed in Step 2/2.5 (each: finding → fix → scoped re-verify status) / anydeterministic_fixes_applied/pinned_hyperframes_version - BGM:
brief.bgm.status/brief.bgm.ready/brief.bgm.message - Lean pass: contact-sheet tile count + verdict per suspicious tile only (clean tiles = one aggregate line, e.g. "9 tiles scanned, 8 clean")
- Visual files fixed in place: file + what changed (path / scope / downgrade / escape hatch ...)
- Any (exceptional) worker STOP redispatch + reason
- Render: path / bytes / ffprobe duration / quality
- Unresolved warnings that were allowed through
Append to <PROJECT_DIR>/context.log (generate the timestamp with the machine in UTC; do not hand-write it — avoids inconsistencies with mp4 mtime / other phase line time zones):
(cd "$PROJECT_DIR" && cat >> context.log <<EOF
## Phase 4c: finalize [done $(date -u +%Y-%m-%dT%H:%M:%SZ)]
Gates: lint <status> / validate <status> / inspect <status, strict> / overlap <status>
Lean pass: <n> contact-sheet tiles scanned (<m> escalated) — blank-panel/cut-text/contrast/cramped/internal-seams eye-checked once
Fixes in place: <scene_N/group_wN: what> ... (none if none)
BGM: <brief.bgm.status> (<brief.bgm.message>)
Render: renders/video.mp4 (<size>, <duration>s, quality=<quality>)
EOF
)