mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-08 02:36:10 +00:00
* fix(media-use): codex gate misfires as 'not logged in' when piped codexUnavailableReason() gated generation on parsing `codex login status` stdout, but that command prints 'Logged in using ChatGPT' to stderr and exits 0 — so the piped stdout media-use captures (execFileSync returns stdout only on success) was empty, and the gate falsely reported 'not logged in'. Every headless / CI / agent run was blocked from codex image gen even when fully authed. Gate on the durable credentials file ($CODEX_HOME/auth.json) instead of the TTY/stderr-only human text. Token validity is still proven by the exec, which fails cleanly on a stale login. The stdout `features list` capability check is unchanged. Verified: reproduced the false 'not logged in' block, then after the fix generated end-to-end via `resolve -t image --provider codex` (valid 1254x1254 PNG, source=generated, provider=codex.image_gen). * fix(media-use): bug-bash fixes — id race, provider/reuse/adopt guards From the bug-bash against main: - MU-23 (HIGH): concurrent resolves raced on nextId (read-max-then-append, non-atomic), so parallel agents got duplicate ids and clobbered each other's files. Add allocateId(): a coarse per-project lock (.media/.lock, 15s stale-steal) around id allocation that scans the manifest AND the type dir for reserved ids, then O_EXCL-creates a placeholder file so the slow download between allocate and append can't collide. 5 parallel resolves now yield 5 distinct ids + files. - X4: --reuse imported across a type mismatch (bgm asset under images/). Apply typesMatch on the --reuse path; reject mismatches (icon<->image still interchangeable). - X5: --provider silently overrode --local-only and made a network call. --local-only is now a hard guard: network providers are skipped even under a forced provider; the miss message explains the conflict. - BUG-2: --provider ignored the exact-cache floor and could hand back an asset from a different provider. A forced --provider now bypasses all reuse rungs (regenerate with THIS provider); the unforced floor is intact. - MU-26/X6: 0-byte assets accepted. --adopt skips 0-byte files (loud); ingest refuses a 0-byte local file (freezeUrl already rejects empty responses). - BUG-4: unknown/unavailable --provider now errors with the available list instead of a generic 'no provider could resolve' (typo != catalog miss). - BUG-5: --reuse "" gave the wrong 'type and intent required' error; it now routes to a clear empty-sha message. - BUG-3: voice duration leaked an unrounded float into index.md; round all durations to 0.1s centrally at record build (matches probe). - Nits: whitespace-only --intent is rejected; nudge grammar (exists/exist). Tests: allocateId reservation + registry local-only-wins added; full media-use suite green. All fixes verified e2e. * fix(cli): reject unknown flags instead of silently ignoring them citty is permissive: an unrecognized flag was dropped, not rejected — so `render . --out x` (the flag is --output/-o) silently ignored --out and rendered to the default renders/<name>.mp4 path. A mistyped flag read as a render/catalog miss. Add assertKnownFlags(): validate every dash-prefixed token against the command's declared args + aliases + the global set (help/version/json) before the command runs, in the shared trackCommandFailures run-wrapper so every leaf command is covered. Handles --flag=value, --no-<bool> negation, camelCase<->kebab arg names, and combined shorts; stops at --; positionals and flag values pass through. Verified: `render . --out x` -> 'Error: Unknown flag: --out'; --output/-o/ --json/--help still accepted. Unit tests added. * docs(skills): install with --full-depth so agents get current main The documented `npx skills add heygen-com/hyperframes` fetched the skills.sh registry blob, which lags GitHub main by hours — so users following the docs got a stale skill (e.g. media-use v1: no --candidates, voice stubbed). The CLI's own `hyperframes skills` command already forces a full clone via --full-depth to bypass this; the docs didn't pass it. Add --full-depth to every documented install command (README, CLAUDE.md, docs/guides/skills.mdx) with a one-line note on the lag. Addresses the user-facing half of the publish/registry lag (#2034). * chore(media-use): collapse resolve.mjs import to satisfy oxfmt --check * fix(cli): extract longFlagName to keep flag validator under complexity gate Also regenerate skills-manifest.json (resolve.mjs formatting change re-hashed the media-use skill). Fixes the Fallow audit + skills-manifest-in-sync CI gates.
141 lines
5.5 KiB
JavaScript
141 lines
5.5 KiB
JavaScript
import { execFileSync } from "node:child_process";
|
|
import { copyFileSync, existsSync, readdirSync, statSync, unlinkSync } from "node:fs";
|
|
import { homedir, tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
|
|
// Image generation via the OpenAI Codex CLI's built-in image tool (gpt-image-2)
|
|
// on the user's ChatGPT subscription: the codex CLI owns auth, media-use holds
|
|
// no key (CLI-only). The image UPSELL behind local mflux; skipped by --local-only.
|
|
//
|
|
// Retrieval mirrors illo-skill rather than trusting the model to save a file:
|
|
// `--enable imagegenext` makes the built-in tool drop the rendered artifact into
|
|
// $CODEX_HOME/generated_images/, and we fetch the freshest file that postdates
|
|
// this run. The save-to-path instruction is only a best-effort verify-first.
|
|
|
|
const TIMEOUT_MS = 600000; // codex exec round-trips the sub; first-run tool spin-up is slow
|
|
const MTIME_SKEW_MS = 2000; // tolerate mtime granularity / clock skew (illo uses 2s)
|
|
|
|
function codexGeneratedDir() {
|
|
// Codex relocates CODEX_HOME on some hosts, so resolve it at run time.
|
|
return join(process.env.CODEX_HOME || join(homedir(), ".codex"), "generated_images");
|
|
}
|
|
|
|
// Newest artifact that postdates `sinceMs` (minus skew), so a stale prior render
|
|
// or a concurrent session's file can't be mistaken for this run's output.
|
|
function freshestGeneratedImage(sinceMs) {
|
|
const dir = codexGeneratedDir();
|
|
if (!existsSync(dir)) return null;
|
|
const floor = sinceMs - MTIME_SKEW_MS;
|
|
let best = null;
|
|
for (const name of readdirSync(dir)) {
|
|
let st;
|
|
try {
|
|
st = statSync(join(dir, name));
|
|
} catch {
|
|
continue;
|
|
}
|
|
if (!st.isFile() || st.mtimeMs < floor) continue;
|
|
if (!best || st.mtimeMs > best.mtimeMs) best = { path: join(dir, name), mtimeMs: st.mtimeMs };
|
|
}
|
|
return best?.path ?? null;
|
|
}
|
|
|
|
// Short `codex` subcommand → combined stdout+stderr, or null if it can't run.
|
|
function codexRun(args) {
|
|
try {
|
|
return execFileSync("codex", args, {
|
|
encoding: "utf8",
|
|
stdio: ["ignore", "pipe", "pipe"],
|
|
timeout: 10000,
|
|
});
|
|
} catch (err) {
|
|
return `${err.stdout?.toString() ?? ""}${err.stderr?.toString() ?? ""}` || null;
|
|
}
|
|
}
|
|
|
|
// Fail-fast host check (mirrors illo): don't burn a minutes-long exec when Codex
|
|
// isn't usable. Returns null when ready, else a human reason. imagegenext ships
|
|
// default-disabled ("under development"), so we check the ROW is present (the
|
|
// capability signal) — the exec enables it per-render with --enable.
|
|
function codexUnavailableReason() {
|
|
try {
|
|
const which = process.platform === "win32" ? "where" : "which";
|
|
execFileSync(which, ["codex"], { stdio: ["ignore", "ignore", "ignore"], timeout: 5000 });
|
|
} catch {
|
|
return "codex CLI not on PATH";
|
|
}
|
|
// Auth marker: presence of the credentials file, NOT `codex login status`.
|
|
// That command prints "Logged in using ChatGPT" only to a human stream
|
|
// (stderr / TTY) and exits 0, so its piped stdout — how media-use spawns it —
|
|
// is empty, and the gate falsely reported "not logged in", blocking codex
|
|
// image gen in every headless / CI / agent run even when fully authed.
|
|
// auth.json is the durable, TTY-independent signal; token validity is proven
|
|
// by the exec itself, which fails cleanly if the login is stale.
|
|
const authPath = join(process.env.CODEX_HOME || join(homedir(), ".codex"), "auth.json");
|
|
if (!existsSync(authPath)) return "codex not logged in (run: codex login)";
|
|
const feats = codexRun(["features", "list"]);
|
|
if (feats == null) return "could not read `codex features list`";
|
|
if (!/\bimage_generation\b/.test(feats)) return "codex image_generation feature unavailable";
|
|
if (!/\bimagegenext\b/.test(feats)) return "codex imagegenext unavailable (upgrade Codex CLI)";
|
|
return null;
|
|
}
|
|
|
|
export async function codexImageGenerate(intent) {
|
|
const unavailable = codexUnavailableReason();
|
|
if (unavailable) {
|
|
console.error(`media-use: codex image upsell unavailable: ${unavailable}`);
|
|
return null;
|
|
}
|
|
const outPath = join(tmpdir(), `media-use-codex-${process.pid}-${Date.now()}.png`);
|
|
const prompt =
|
|
`${intent}\n\n` +
|
|
`Use your built-in image generation tool to render this, then save the image ` +
|
|
`to ${outPath} (overwrite if it exists). Do not ask for confirmation. ` +
|
|
`If you have no built-in image tool, do nothing (no PIL/matplotlib/SVG substitute).`;
|
|
try {
|
|
unlinkSync(outPath); // clear any prior file so verify-first can't accept a stale render
|
|
} catch {
|
|
/* no prior file */
|
|
}
|
|
const started = Date.now();
|
|
try {
|
|
execFileSync(
|
|
"codex",
|
|
[
|
|
"exec",
|
|
"--cd",
|
|
tmpdir(),
|
|
"-s",
|
|
"workspace-write",
|
|
"--skip-git-repo-check",
|
|
"--enable",
|
|
"imagegenext",
|
|
"-",
|
|
],
|
|
{ input: prompt, encoding: "utf8", timeout: TIMEOUT_MS, stdio: ["pipe", "pipe", "pipe"] },
|
|
);
|
|
} catch (err) {
|
|
console.error(
|
|
`media-use: \`codex exec\` image generation failed: ${err.stderr?.toString().trim().slice(-200) || err.message}`,
|
|
);
|
|
return null;
|
|
}
|
|
// Verify-first (save-to-path may have worked), else fetch the imagegenext artifact.
|
|
const produced =
|
|
existsSync(outPath) && statSync(outPath).size > 0 ? outPath : freshestGeneratedImage(started);
|
|
if (!produced) return null;
|
|
if (produced !== outPath) {
|
|
try {
|
|
copyFileSync(produced, outPath);
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
return {
|
|
localPath: outPath,
|
|
ext: ".png",
|
|
source: "generated",
|
|
metadata: { description: intent, provider: "codex.image_gen", provenance: { prompt: intent } },
|
|
};
|
|
}
|