mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-19 19:36:04 +00:00
Audit found the sub-comp root `background:` doesn't paint rule was documented in step-5-build.md (landmine #10, commit4dcc3a62) but NOT in beat-builder-guide.md — which is what sub-agents READ when they build a beat. Workers reading only their guide miss the rule, then the starter template at line 110 actively put `background: #YOUR_BG` on `.bN-root` — exactly the pattern that ships a blank-white frame in the rendered video (the heygen beat-6 CTA case from the prior runs). Two changes: 1. Updated the Step 2 starter template (beat-builder-guide.md ~L105) to NOT carry `background:` on the root. Instead: - `.bN-root` carries layout (width/height/position/overflow) only. - New `.bN-bg` rule uses `position: absolute; inset: 0` to paint full-bleed at the same z-plane as the root. - The body section adds `<div class="bN-bg"></div>` as the first child of the root. Title gets `position: relative; z-index: 1` to sit above the bg layer. - Inline comments name the rule + reference the landmine below. This now matches the `templates/_beat-skeleton.html` file copy (commitf293d9da) exactly — both starter forms are consistent. 2. Added landmine #8 "Sub-comp root `background:` doesn't paint — use a full-bleed child div" to the beat-builder-guide.md numbered landmines section. Includes the BAD/GOOD code-fence pair (same form as step-5-build.md landmine #10), cross-references the starter template above, and notes Studio preview paints root backgrounds (which is why the rule is insidious — the bug manifests only at render time). Subsequent landmine #8 (Alive, not active) renumbered to #9. Both reads — sub-agent reading beat-builder + orchestrator dispatching from step-5 — now see the same rule with the same fix pattern, in both the explicit landmine entry and the starter template they're expected to copy. The starter template itself enforces the rule by construction, so the most common path (copy + modify) honors it automatically. No code change. Doc-only. Mirrors step-5-build.md landmine #10 (the canonical source remains there; this is its sub-agent companion).