Files
hyperframes/packages/studio/src/components/editor/propertyPanelFxSection.tsx
T
Vance IngallsandClaude Sonnet 5 d6c4774ef4 feat(studio): instrument the audio FX rack, including work an agent did (#3229)
* fix(studio): close the typecheck and fallow gaps wa-18b-reschedule opened

useAutomationLanes.ts's write() assumed gesture-scoped coalescing and a
preview-only commit that useDomEditAttributeCommits.ts never grew — backported
that option support from its own later commit so the two sides of the API
agree. The paste path and its tests were missing the box selection's v0/v1
bounds a sibling commit added to AutomationSelection. The FX panel's carve
controls still edited the six mechanism numbers (maxCutDb, bands,
intelligibilityBias) after carveProfile() collapsed authoring to one Strength
knob, so those fields no longer existed on HfCarveSettings; UI now edits
strength, and analyseCarveBands is called with carveProfile(strength).

Also closes fallow's complexity, dead-code and duplication findings on this
PR's diff: extracted automationLaneDragMath.ts (pure group/point-move math)
and useAutomationRangeDrag.ts (the marquee-select gesture) out of
useAutomationLaneGestures.ts, pulled a couple of render-loop ternaries and a
resolver into named functions, dropped an export nothing outside its file
used, and shared a step-simplifier between audioCarve's two envelope
builders.

The edge-stretch vs. box-select priority test in TimelineAutomationLane.test
was still pinning the pre-box-select rule (edge wins over a point sitting on
it) that a sibling commit deliberately reversed — a point inside the box is
now selected content, so grabbing it drags the group instead. Updated the
test to the shipped rule instead of the old one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): cap the via conic's weight so an edge-clamped via point can't NaN

A via point pulled out past the segment (viaX: 5, viaY: -3) clamps to
(0.999, 0.001) — exactly on the steady region's edge, where edge - viaX is 0.
viaConic divided by that zero to get an infinite weight, and shapeVia turned
Infinity into NaN a few steps later (Infinity - Infinity in the quadratic
coefficient). NaN reaching setValueCurveAtTime silences the automated
parameter for the rest of the render.

Capped the weight at 1e6 instead of leaving it unbounded — past that point
the arc already reads as touching the via point, so nothing visible is lost.
Also hardened shapeVia's existing denominator guard (`<= 0`) to `!(> 0)`,
since NaN fails the original comparison and fell through it.

Review by Miga (PR #3208).

* fix(studio-server): fingerprint the proactive waveform cache key too

The route already keys the waveform cache on the asset's size and mtime as
well as its path, so a rebuilt-in-place file gets fresh peaks instead of
stale ones. generateWaveformCache — the proactive path that runs on upload —
still called buildWaveformCacheKey with the path alone, so it wrote to a
different key than the route reads from (making the pre-generated cache
never found) and kept the exact collision bug this fingerprint exists to fix
on its own path.

Review by Miga (PR #3211).

* style(docs): run oxfmt on the /hyperframes-audio skill docs

Table column widths had drifted out of alignment with oxfmt's own rules,
failing format:check and blocking the Preflight gate every downstream
branch inherits. Whitespace only, no content change.

* fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration

\b treats `_` as a word character, so \bbed\b never matched bed_01,
music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap —
an underscore-separated bed classified as "unknown" and could end up offered
as its own carve source. Replaced the short hints with a boundary that
actually excludes letters and digits on both sides.

clipsOverlap computed end = start + duration without guarding sign, so a
negative duration put end before start — an interval that does not describe
anything, and one specific case showed it silently dropping a real overlap
(a shorter, earlier broken end rejected a clip that genuinely contained the
point). Duration clamps to zero instead: a clip cannot un-play time, and a
zero-length clip at its start is the sane reading of "duration nobody wrote
down as positive."

Review by Miga (PR #3212).

* fix(studio): widen PropertyPanel's resetModules render timeout again

The 20s margin (already once widened for the same reason) is timing out in
CI's full-monorepo Test run — the resetModules()+fresh-import render this
test needs is uncached and competes with every other package's test suite
for the same worker pool, and the same test passes in well under 2s
standalone. Went to 45s rather than re-tuning to whatever number happens to
clear the current CI load, since that number moves every time CI gains a
package.

* fix(studio): stop the single-candidate auto-apply carve firing twice

Two auto-apply effects both fire when sourceOptions.length === 1: the
multi-candidate effect only guards length === 0, so a single candidate
passes it too, and the single-candidate effect passes its own guard right
after — both compute the same sources list and both call setCarve, so the
common case (one narrator, one bed) triggered two decodes, two FFT runs, and
two concurrent attribute writes for one decision.

The multi-candidate effect now defers to its sibling for exactly one
candidate, which already has its own detailed handling for that case.

Review by Miga (PR #3213).

* feat(core): carve against every voice over a bed, always (#3212)

* feat(core): carve against every voice over a bed, always dynamically

A bed usually runs under a whole sequence — a narrator, an interview answer, a
second presenter — and carving against one of them left the others fighting it.
`source` becomes `sources`, and `mixCarveSources` sums every voice onto the BED's
clock before anything is measured. That is what keeps one analysis sufficient: the
chain is fixed, so there is no per-voice filter to switch between, and bands drawn
from all the speech there is with envelopes that rise wherever any of it happens
answer the actual question — where and when is speech masking this bed.

Summed rather than averaged: two people talking at once mask more than either
alone. Audio before the bed starts is dropped rather than folded in at zero, since
it plays over nothing and shifting it would put a cut where there is no voice.

`dynamic` is gone. A fixed depth thins the bed through every pause, and once both
have been heard there is no reason to want it, so every carve follows the speech.

Two helpers the panel and the headless script now share instead of each carrying a
copy — two definitions of "what does this name suggest" drift, and then the two
disagree about which track is the voice:

- `classifyAudioName` reads a track's kind from its id and filename together.
  `unknown` is deliberately common: treating an unrecognised name as "not a voice"
  would hide the one track somebody needs to pick.
- `clipsOverlap` keeps out a voice that never plays while the bed does. An unwritten
  duration counts as unbounded, not zero — refusing a clip whose length the
  composition leaves to the media would drop the commonest case there is.

Files written before this still load: a single `source` reads as a one-voice list,
a stored `dynamic` is ignored, and an absent attribute means the defaults whole.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration

\b treats `_` as a word character, so \bbed\b never matched bed_01,
music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap —
an underscore-separated bed classified as "unknown" and could end up offered
as its own carve source. Replaced the short hints with a boundary that
actually excludes letters and digits on both sides.

clipsOverlap computed end = start + duration without guarding sign, so a
negative duration put end before start — an interval that does not describe
anything, and one specific case showed it silently dropping a real overlap
(a shorter, earlier broken end rejected a clip that genuinely contained the
point). Duration clamps to zero instead: a clip cannot un-play time, and a
zero-length clip at its start is the sane reading of "duration nobody wrote
down as positive."

Review by Miga (PR #3212).

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(studio): port the carve UI off the removed source/dynamic fields

#3212 (accidentally squash-merged into this branch instead of main) changed
HfCarveSettings from a single `source` + `dynamic` toggle to a `sources`
list with dynamic mode removed outright — the multi-voice UI consumer that
goes with that shape lands in the very next PR, so this branch was left with
a type that no longer matched its own code.

Minimal port, not the multi-voice redesign that PR does properly: the
"Listen to" picker and analyse() treat sources[0] as the one voice this UI
still understands, and every dynamic-mode branch (the automated envelope
lanes, the toggle, the checkbox) is gone along with the field — a carve is
now always the static value the analysis computes, matching what the type
change made permanent. Test suite trimmed the same way: the automation-lane
and toggle tests covered behavior that no longer exists.

* refactor(studio): break up the FX rack's largest functions and files

Fallow flagged 9 complexity findings and 2 file-size violations after the
telemetry stack landed. Extracts FxPresetRun, FxAddMenu, FxRackChain,
FxNodeOpenBody, FxNodeParams, and useFxAudition/useFxCarve/useFxLevelling/
useFxChainObserved out of propertyPanelFxSection.tsx and
propertyPanelAudioFxGroup.tsx, splits propertyPanelFxNodeRow.tsx's open-face
rendering into its own component, and dedupes a clone in studioTelemetry.ts.
Pure structural move — no behavior change; full test suite still green.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-13 15:05:51 -07:00

551 lines
20 KiB
TypeScript

/**
* The FX section for an audio element: the chain, plus the voiceover carve.
*
* The carve is its own module — see `propertyPanelFxCarveModule.tsx` for why it
* is not an entry in the chain.
*/
import { useCallback, useMemo, useState, type KeyboardEvent } from "react";
import {
defaultAudioFxParams,
mintAudioFxNodeId,
type HfAudioFxChain,
type HfAudioFxNode,
type HfAudioFxParamValues,
} from "@hyperframes/core/audio-fx";
import { applyAudioFxPreset, getAudioFxPreset } from "@hyperframes/core/audio-fx-presets";
import {
addAudioEq,
audioEqIds,
removeAudioEq,
setAudioEqBandGain,
} from "@hyperframes/core/audio-fx-eq";
import { applyAudioFxProfile, getAudioFxProfile } from "@hyperframes/core/audio-fx-profiles";
import { audioFxJobNode, type HfAudioFxJob } from "@hyperframes/core/audio-fx-jobs";
import { FxPresetMenu } from "./propertyPanelFxPresetMenu.js";
import { FxRackChain } from "./propertyPanelFxRackChain.js";
import { FxAddMenu } from "./propertyPanelFxAddMenu.js";
import { useFxAudition } from "./useFxAudition.js";
import {
nodeOrigin,
trackNodeAdded,
trackNodeMoved,
trackNodeRemoved,
trackPresetApplied,
trackPresetAuditioned,
trackPresetAutomated,
trackPresetRemoved,
} from "./audioFxTelemetry.js";
import type { FxSectionProps } from "./propertyPanelFxSectionTypes.js";
export type { FxSectionProps } from "./propertyPanelFxSectionTypes.js";
/**
* One effect appended, at the values its module opens on.
*
* For most effects that is the registry's defaults. For the five with a
* derived knob it is NOT: the registry defaults are not a point on the
* profile's curve, so the module opened reading a strength it was not set to —
* a compressor arrived showing Evenness 0.67 with its make-up gain at 0 dB,
* which is the "quieter as you turn it up" bug the profiles exist to prevent,
* on the very first frame. Seeding through the profile puts the knob and the
* mechanism in agreement from the start.
*/
function withEffect(base: HfAudioFxChain, type: string): HfAudioFxChain {
return {
...base,
nodes: [
...base.nodes,
{
type,
id: mintAudioFxNodeId(base),
enabled: true,
params: getAudioFxProfile(type)
? applyAudioFxProfile(type, 0.5, defaultAudioFxParams(type))
: defaultAudioFxParams(type),
},
],
};
}
/** The same, for a job — an ordinary node that arrives already named and aimed. */
function withJob(base: HfAudioFxChain, job: HfAudioFxJob): HfAudioFxChain {
return { ...base, nodes: [...base.nodes, audioFxJobNode(job, base)] };
}
// The preset-run card, the add shelf and the audition machinery are already
// their own files; what is left is the section deciding which of them to show.
// fallow-ignore-next-line complexity
export function FxSection({
chain,
automatedTargets,
liveAutomationValues,
onAutomateParam,
onRemoveParamAutomation,
onRemoveNodeAutomation,
onRemoveNodesAutomation,
onChainChange,
onChainPreview,
carve,
carvedAgainstBy,
onCarveChange,
onCarvePreview,
sourceOptions,
trackKind,
analysing,
disabled,
onLevel,
onRemoveLevel,
levelled,
onAuditionLevel,
auditioningLevel,
onAutomatePreset,
onRemovePresetAutomation,
automatedPresets,
onAuditionTransport,
}: FxSectionProps) {
const presetAutomated = automatedPresets ?? new Set<string>();
// Falls back to the persisting write when no preview handler is supplied, which
// keeps the control working rather than going dead.
const previewCarve = onCarvePreview ?? onCarveChange;
// Nothing to carve against means nothing to show — see the block below.
// Not offered on the voice another track is already carving against — that
// track is the far end of someone else's relationship, and a carve of its own
// could only name a source it must not.
const showCarve = !carvedAgainstBy && (sourceOptions.length > 0 || carve !== null);
const [adding, setAdding] = useState(false);
const [picking, setPicking] = useState(false);
const [openNode, setOpenNode] = useState<number | null>(0);
const mutate = useCallback(
(nodes: HfAudioFxNode[]) => onChainChange({ ...chain, nodes }),
[chain, onChainChange],
);
// Dragging a knob previews without persisting; releasing it commits once.
const previewNode = useCallback(
(index: number, params: HfAudioFxParamValues) =>
onChainPreview?.({
...chain,
nodes: chain.nodes.map((n, i) => (i === index ? { ...n, params } : n)),
}),
[chain, onChainPreview],
);
const { audition, clearAudition } = useFxAudition(chain, onChainPreview, onAuditionTransport);
const applyPreset = useCallback(
(id: string) => {
const preset = getAudioFxPreset(id);
if (!preset) return;
// Appends. Stacking a character preset onto an already-cleaned voice is a
// real thing to want, and replacing silently would throw work away — so
// the destructive option is a separate gesture, not the default one.
const next = applyAudioFxPreset(chain, preset);
// Re-applying replaces this preset's own nodes in place rather than
// appending a second copy, and the two are different decisions — worth
// telling apart in the numbers.
const reapply = chain.nodes.some((n) => n.fromPreset === preset.id);
trackPresetApplied(
preset.id,
preset.family,
preset.nodes.length,
reapply ? "reapply" : "append",
{ trackKind },
);
// The audition WAS this, so there is nothing to put back — and putting the
// old chain back over the write that just landed is a race the author
// hears as the preset arriving and then leaving again.
clearAudition();
mutate(next.nodes);
// Land on the first node the preset wrote, so the author can hear what
// arrived and immediately see what it is made of.
setOpenNode(next.nodes.findIndex((n) => n.fromPreset === preset.id));
setPicking(false);
},
[chain, mutate, clearAudition, trackKind],
);
const addJob = useCallback(
(job: HfAudioFxJob) => {
clearAudition();
trackNodeAdded(job.type, "job", job.id, { trackKind });
mutate(withJob(chain, job).nodes);
setOpenNode(chain.nodes.length);
setAdding(false);
},
[chain, mutate, clearAudition, trackKind],
);
const addEffect = useCallback(
(type: string) => {
clearAudition();
trackNodeAdded(type, "effect", null, { trackKind });
mutate(withEffect(chain, type).nodes);
setOpenNode(chain.nodes.length);
setAdding(false);
},
[chain, mutate, clearAudition, trackKind],
);
const updateNode = useCallback(
(index: number, patch: Partial<HfAudioFxNode>) =>
mutate(chain.nodes.map((n, i) => (i === index ? { ...n, ...patch } : n))),
[chain.nodes, mutate],
);
/**
* How much of a preset is applied, 0..1.
*
* The switch and the lane are the same value, not two ways of silencing a
* preset: `presetAmount` drives the wet/dry blend the graph wraps the run in,
* so Off is amount 0 and a lane ramping 0 → 1 is the same control moving
* continuously. Writing `enabled` instead would take the nodes out of the
* graph, which a lane cannot do part-way and cannot do without a rebuild.
*
* On every node of the run because that is where the chain can hold it — see
* `HfAudioFxNode.presetAmount`.
*/
const setRunAmount = useCallback(
(items: { node: HfAudioFxNode; i: number }[], amount: number, persist = true) => {
const slots = new Set(items.map((item) => item.i));
const next = {
...chain,
nodes: chain.nodes.map((n, i) => (slots.has(i) ? { ...n, presetAmount: amount } : n)),
};
if (persist) mutate(next.nodes);
else onChainPreview?.(next);
},
[chain, mutate, onChainPreview],
);
/**
* Take a preset back out whole, lanes and all.
*
* Same contract as removing one node — an orphaned lane keeps driving a
* parameter that is no longer in the graph, and with ids minted lowest-free
* the next effect added inherits it.
*/
const removeRun = useCallback(
(items: { node: HfAudioFxNode; i: number }[], presetId?: string) => {
// One call, not a loop: every write is computed from the same snapshot and
// replaces the whole attribute, so a loop kept only its last write and left
// the other nodes' lanes behind as orphans. The preset id goes with it —
// the `fx.preset.<id>` amount lane belongs to the preset, not to any node,
// so nothing else would ever collect it, and re-applying the preset later
// resurrected the old ramp.
const ids = items.map(({ node }) => node.id).filter((id): id is string => Boolean(id));
if (ids.length > 0 || presetId) onRemoveNodesAutomation?.(ids, presetId);
if (presetId) trackPresetRemoved(presetId, { trackKind });
const slots = new Set(items.map((item) => item.i));
mutate(chain.nodes.filter((_, i) => !slots.has(i)));
setOpenNode(null);
},
[chain.nodes, mutate, onRemoveNodesAutomation, trackKind],
);
const removeNode = useCallback(
(index: number) => {
// The node's lanes go with it. `resolveAutomation` only hides an orphan at
// read time; left in the attribute, and with ids minted lowest-free, the
// next effect added takes the same id and inherits the dead envelope —
// arriving with its control disabled and "Automated" without the author
// ever automating it, and baked into the render.
const removed = chain.nodes[index];
const removedId = removed?.id;
if (removedId) onRemoveNodeAutomation?.(removedId);
if (removed) trackNodeRemoved(removed.type, nodeOrigin(removed), { trackKind });
mutate(chain.nodes.filter((_, i) => i !== index));
setOpenNode(null);
},
[chain.nodes, mutate, onRemoveNodeAutomation, trackKind],
);
// Open by default: the module is the carve's whole control surface now, and a
// collapsed card would hide the knob the author came here for.
const [carveOpen, setCarveOpen] = useState(true);
const carveNodes = useMemo(() => chain.nodes.filter((n) => n.fromCarve), [chain.nodes]);
/** Everything the author added, with the chain index every edit addresses. */
const handBuilt = useMemo(
() =>
chain.nodes
.map((node, i) => ({ node, i }))
// Carve and EQ bands belong to their own modules; showing them here too
// would put the same filter on screen twice with two ways to edit it.
.filter(({ node }) => !node.fromCarve && !node.fromEq),
[chain.nodes],
);
/**
* The hand-built list cut into runs, so a preset reads as one thing.
*
* Applying a preset drops five rows into the rack with nothing saying they
* arrived together — which is the same failure the carve module was built to
* fix, one level down. Consecutive only: a preset whose nodes have been pulled
* apart by a reorder is no longer a unit, and drawing a bracket around the gap
* would claim an adjacency the signal path does not have.
*/
const runs = useMemo(() => {
const out: { preset?: string; items: { node: HfAudioFxNode; i: number }[] }[] = [];
for (const item of handBuilt) {
const preset = item.node.fromPreset;
const last = out.at(-1);
if (last && last.preset === preset) last.items.push(item);
else out.push({ ...(preset ? { preset } : {}), items: [item] });
}
return out;
}, [handBuilt]);
/**
* Preset runs the author has folded shut.
*
* A preset is one thing they added, and once it is set the seven modules
* inside are detail — a rack with two presets in it was thirteen cards deep
* before anything hand-built appeared. Collapsed by id rather than by index so
* it survives a reorder, and open by default: a preset that arrives already
* hidden is one nobody learns is a chain they can edit.
*/
const [collapsedRuns, setCollapsedRuns] = useState<ReadonlySet<string>>(new Set());
const eqIds = useMemo(() => audioEqIds(chain), [chain]);
/**
* The number each row wears, counted over what the rack actually shows.
*
* Not the chain index: the carve's filters and an EQ's bands are inside their
* own modules, so counting raw nodes would leave the visible rack jumping from
* 02 to 07 and the numbers would look like a bug rather than a position.
*/
const positions = useMemo(() => {
const map = new Map<number, number>();
let at = (showCarve ? 1 : 0) + eqIds.length;
for (const { i } of handBuilt) map.set(i, ++at);
return map;
}, [handBuilt, eqIds.length, showCarve]);
const [openEq, setOpenEq] = useState<string | null>(null);
const addEq = useCallback(() => {
clearAudition();
const { chain: next, eqId } = addAudioEq(chain);
trackNodeAdded("eq", "eq", null, { trackKind });
mutate(next.nodes);
setOpenEq(eqId);
setAdding(false);
}, [chain, mutate, clearAudition, trackKind]);
// Dragging a fader is heard immediately and written once on release, the same
// split every other control in the rack uses.
const previewEqBand = useCallback(
(eqId: string, band: string, gain: number) =>
onChainPreview?.(setAudioEqBandGain(chain, eqId, band, gain)),
[chain, onChainPreview],
);
const commitEqBand = useCallback(
(eqId: string, band: string, gain: number) =>
mutate(setAudioEqBandGain(chain, eqId, band, gain).nodes),
[chain, mutate],
);
const removeEq = useCallback(
(eqId: string) => {
// Batched for the same reason as `removeRun` — this loop had the identical
// last-write-wins bug and was only unreachable because an EQ band row
// offers no automation toggle today.
const ids = chain.nodes
.filter((node) => node.fromEq === eqId)
.map((node) => node.id)
.filter((id): id is string => Boolean(id));
if (ids.length > 0) onRemoveNodesAutomation?.(ids);
mutate(removeAudioEq(chain, eqId).nodes);
},
[chain, mutate, onRemoveNodesAutomation],
);
const moveNode = useCallback(
(index: number, delta: number) => {
const target = index + delta;
if (target < 0 || target >= chain.nodes.length) return;
const next = [...chain.nodes];
const [moved] = next.splice(index, 1);
next.splice(target, 0, moved!);
if (moved) trackNodeMoved(moved.type, delta < 0 ? "up" : "down", { trackKind });
mutate(next);
setOpenNode(target);
},
[chain.nodes, mutate, trackKind],
);
/**
* Escape closes whichever menu is open.
*
* The first thing anyone reaches for, and on a surface that covers the rack it
* is the one that needs no discovering. Bound on the section rather than the
* window: a keystroke aimed at the timeline is not aimed at this.
*/
const closeMenus = useCallback(
(event: KeyboardEvent) => {
if (event.key !== "Escape" || (!adding && !picking)) return;
// Stops the panel's own Escape handling from also firing — closing a menu
// and deselecting the clip on one keystroke loses the author their place.
event.stopPropagation();
audition(null);
onAuditionLevel?.(false);
setAdding(false);
setPicking(false);
},
[adding, picking, audition, onAuditionLevel],
);
/** Seed a lane for a run's preset amount, or omit the control when one already exists. */
const presetAutomateHandler = (
presetId: string | undefined,
amount: number,
): (() => void) | undefined => {
if (!presetId || !onAutomatePreset || presetAutomated.has(presetId)) return undefined;
return () => {
trackPresetAutomated(presetId, true, { trackKind });
onAutomatePreset(presetId, amount);
};
};
/** Delete a run's preset-amount lane, or omit the control when there is none. */
const presetRemoveAutomationHandler = (
presetId: string | undefined,
): (() => void) | undefined => {
if (!presetId || !onRemovePresetAutomation || !presetAutomated.has(presetId)) return undefined;
return () => onRemovePresetAutomation(presetId);
};
return (
<div
className="hf-fx-section space-y-2"
// Focus lives on the buttons and menu items inside, so the keystroke
// bubbles to here without the section needing focus of its own.
onKeyDown={closeMenus}
>
<FxRackChain
chain={chain}
showCarve={showCarve}
carveNodes={carveNodes}
carve={carve}
sourceOptions={sourceOptions}
automatedTargets={automatedTargets}
liveAutomationValues={liveAutomationValues}
carveOpen={carveOpen}
disabled={disabled}
analysing={analysing}
onToggleCarveOpen={() => setCarveOpen((was) => !was)}
onCarveChange={onCarveChange}
onCarvePreview={previewCarve}
eqIds={eqIds}
openEq={openEq}
onToggleEq={(eqId) => setOpenEq((was) => (was === eqId ? null : eqId))}
onPreviewEqBand={previewEqBand}
onCommitEqBand={commitEqBand}
onRemoveEq={removeEq}
handBuiltCount={handBuilt.length}
runs={runs}
positions={positions}
openNode={openNode}
onToggleOpenNode={(i) => setOpenNode(openNode === i ? null : i)}
onUpdateNode={updateNode}
onMoveNode={moveNode}
onRemoveNode={removeNode}
onPreviewNode={previewNode}
trackKind={trackKind}
collapsedRuns={collapsedRuns}
onToggleCollapse={(runKey) =>
setCollapsedRuns((was) => {
const next = new Set(was);
if (was.has(runKey)) next.delete(runKey);
else next.add(runKey);
return next;
})
}
onSetRunAmount={setRunAmount}
onRemoveRun={removeRun}
onAutomateParam={onAutomateParam}
onRemoveParamAutomation={onRemoveParamAutomation}
presetAutomated={presetAutomated}
presetAutomateHandler={presetAutomateHandler}
presetRemoveAutomationHandler={presetRemoveAutomationHandler}
/>
{adding ? (
<FxAddMenu
disabled={disabled}
analysing={analysing}
levelled={levelled}
auditioningLevel={auditioningLevel}
onLevel={onLevel}
onRemoveLevel={onRemoveLevel}
onEq={addEq}
onJob={addJob}
onEffect={addEffect}
onClose={() => setAdding(false)}
audition={audition}
onAuditionLevel={onAuditionLevel}
withJob={withJob}
withEffect={withEffect}
/>
) : null}
{picking ? (
<FxPresetMenu
trackKind={trackKind}
onPick={applyPreset}
onAuditionTracked={(id) => trackPresetAuditioned(id, { trackKind })}
onAudition={
onChainPreview
? (id) => {
const preset = id ? getAudioFxPreset(id) : null;
audition(preset ? (base) => applyAudioFxPreset(base, preset) : null);
}
: undefined
}
/>
) : null}
{/* The buttons stay while their menu is open, and close it — an author who
opened one and changed their mind had no way back: picking something
was the only thing that set these false, so the only exits were adding
an effect they did not want or deselecting the clip. */}
<div className="flex gap-1">
<button
type="button"
className="hf-fx-preset w-full rounded-[4px] border border-dashed border-panel-border-input py-1 text-[11px] text-panel-text-2 hover:text-panel-text-0 disabled:opacity-40"
aria-expanded={picking}
disabled={disabled}
onClick={() => {
// Leaving the shelf by closing it is still leaving it, and an
// audition left playing is audible over a chain the document does
// not have.
if (picking) audition(null);
setPicking(!picking);
setAdding(false);
}}
>
{picking ? "Close" : "Presets"}
</button>
<button
type="button"
className="hf-fx-add w-full rounded-[4px] border border-dashed border-panel-border-input py-1 text-[11px] text-panel-text-2 hover:text-panel-text-0 disabled:opacity-40"
aria-expanded={adding}
disabled={disabled}
onClick={() => {
if (adding) {
audition(null);
onAuditionLevel?.(false);
}
setAdding(!adding);
setPicking(false);
}}
>
{adding ? "Close" : "Add effect"}
</button>
</div>
</div>
);
}