Files
hyperframes/packages
JamesandClaude Opus 4.7 d7ff692f9f refactor(telemetry): address remaining PR #1035 review feedback
Three follow-ups from @miguel-heygen's review:

1. HERMES_QUIET — switch to existence check.
   `env["HERMES_QUIET"] === "1"` was brittle vs. future Hermes changes
   (e.g. if cli.py ever sets it to "true"). The var name itself is
   specific enough that existence is the right signal.

2. CI_PROVIDERS — convert to a discriminated union.
   `mode: "truthy" | "presence"` is stricter than the previous pair of
   optional boolean flags (which allowed entries with neither set).

3. Sandbox detection tests — add coverage.
   - Docker positive: /.dockerenv present → docker.
   - Negative case: plain Linux laptop with no markers → null.

Together with the gVisor 4.4.0 fix in the previous commit, that addresses
all three actionable callouts (the discriminated-union nit was non-blocking
but worth doing while in the file).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-22 19:10:30 -04:00
..
2026-05-22 13:37:28 -04:00
2026-05-22 13:37:28 -04:00
2026-05-22 13:37:28 -04:00
2026-05-22 13:37:28 -04:00
2026-05-22 13:37:28 -04:00