Files
hyperframes/packages/engine/src/utils/processTracker.test.ts
T
James Russo 57d3bf4960 refactor(engine): manage child process lifecycles (#2160)
* refactor(engine): manage child process lifecycles

* fix(engine): preserve child reaping after runtime errors

* fix(engine): untrack child processes on exit
2026-07-17 01:17:53 -04:00

106 lines
3.3 KiB
TypeScript

import { describe, it, expect, beforeEach, vi } from "vitest";
import { spawn } from "node:child_process";
import { trackChildProcess, killTrackedProcesses } from "./processTracker.js";
// Reset tracked set between tests by killing everything
beforeEach(() => {
killTrackedProcesses();
});
describe("trackChildProcess", () => {
it("tracks a spawned process and removes it after exit", async () => {
const proc = spawn("echo", ["hello"], { stdio: "ignore" });
trackChildProcess(proc);
await new Promise<void>((resolve) => proc.on("close", resolve));
// After exit, killTrackedProcesses should be a no-op (nothing to kill)
killTrackedProcesses();
});
it("removes an exited process before its stdio closes", async () => {
const proc = spawn("sleep", ["60"], { stdio: "ignore" });
const closePromise = new Promise<void>((resolve) => proc.on("close", resolve));
const kill = vi.spyOn(proc, "kill");
trackChildProcess(proc);
try {
proc.emit("exit", 0, null);
killTrackedProcesses();
expect(kill).not.toHaveBeenCalled();
} finally {
kill.mockRestore();
proc.kill("SIGKILL");
await closePromise;
}
});
it("removes the process on spawn error", async () => {
const proc = spawn("/nonexistent-binary-that-does-not-exist", { stdio: "ignore" });
proc.on("error", () => undefined);
trackChildProcess(proc);
await new Promise<void>((resolve) => proc.on("close", () => resolve()));
killTrackedProcesses();
});
it("keeps a process tracked after a post-spawn error", () => {
const proc = spawn("sleep", ["60"], { stdio: "ignore" });
const kill = vi.spyOn(proc, "kill");
proc.on("error", () => undefined);
trackChildProcess(proc);
proc.emit("error", new Error("kill EPERM"));
killTrackedProcesses();
expect(kill).toHaveBeenCalledWith("SIGTERM");
});
});
describe("killTrackedProcesses", () => {
it("kills a running process", async () => {
const proc = spawn("sleep", ["60"], { stdio: "ignore" });
trackChildProcess(proc);
const exitPromise = new Promise<number | null>((resolve) => proc.on("close", resolve));
killTrackedProcesses();
const code = await exitPromise;
// SIGTERM exit: code is null (killed by signal)
expect(code).toBeNull();
});
it("handles already-exited processes gracefully", async () => {
const proc = spawn("true", { stdio: "ignore" });
trackChildProcess(proc);
await new Promise<void>((resolve) => proc.on("close", resolve));
// Should not throw even though process already exited
killTrackedProcesses();
});
it("escalates to SIGKILL for processes that ignore SIGTERM", async () => {
// Spawn a process that traps SIGTERM (bash ignoring it)
const proc = spawn("bash", ["-c", "trap '' TERM; sleep 60"], { stdio: "ignore" });
trackChildProcess(proc);
const exitPromise = new Promise<void>((resolve) => proc.on("close", resolve));
killTrackedProcesses();
// The 500ms SIGKILL escalation should kill it
await exitPromise;
expect(proc.killed).toBe(true);
}, 5000);
it("is idempotent — second call is a no-op", () => {
const proc = spawn("sleep", ["60"], { stdio: "ignore" });
trackChildProcess(proc);
killTrackedProcesses();
killTrackedProcesses();
});
});