Files
hyperframes/packages/producer/tests/style-9-prod/src/code_review.md
T
Vance Ingalls 20be2ea1c2 style: apply oxfmt baseline formatting across all source files (#25)
## Summary
- Run `oxfmt .` across the entire codebase to establish formatted baseline
- 299 files changed — mechanical formatting only, no logic changes
- Double quotes, semicolons, 2-space indent, trailing commas, 100 print width

Part 3/4 of [VA-851](https://linear.app/heygen/issue/VA-851/pre-migration-configure-eslint-prettier-and-conventional-commits)

## Test plan
- [x] `pnpm format:check` — all 426 files pass
- [x] `pnpm -r typecheck` — all packages pass
- [x] `pnpm build` — all packages build
- [x] All 348 tests pass
2026-03-23 17:15:14 -07:00

2.4 KiB

HyperFrame Schema Compliance Review

Executive Summary

  • Total files reviewed: 4
  • Critical issues: 0
  • Overall compliance status: PASS

Critical Issues

None found. The compositions follow the deterministic requirements and structural rules of the HyperFrame schema.

Compliance Checklist

  • All compositions have data-width and data-height attributes
  • All timelines are finite with duration > 0
  • All compositions registered in window.__timelines
  • No use of Math.random(), Date.now(), or non-deterministic code
  • Primitive clips have required data attributes (id, data-start, data-track)
  • data-duration specified for all <img> clips (N/A - no images used)
  • No manual media playback control (video.play(), audio.pause(), etc.)
  • No manual clip mounting/unmounting in scripts
  • Relative timing references are valid (N/A - absolute timing used)
  • Clips on same track don't overlap in time
  • Reusable compositions in separate HTML files
  • Composition files use <template> tags
  • External compositions loaded via data-composition-src
  • All script-animated content wrapped in compositions
  • No infinite or zero-duration timelines

index.html

Status: COMPLIANT

Observations:

  • Correctly defines the root composition main-video.
  • Uses data-composition-src for external compositions.
  • Registers its timeline in window.__timelines.
  • Audio clips have id, data-start, and data-track.

compositions/intro.html

Status: COMPLIANT

Observations:

  • Wrapped in a <template> tag.
  • Root element has data-composition-id, data-width, data-height, and data-duration.
  • Script is deterministic and registers the timeline.

compositions/captions.html

Status: COMPLIANT

Observations:

  • Wrapped in a <template> tag.
  • Root element has data-composition-id, data-width, data-height, and data-duration.
  • Script uses a fixed transcript for deterministic caption generation.
  • Correctly registers the timeline.

compositions/stats.html

Status: COMPLIANT

Observations:

  • Wrapped in a <template> tag.
  • Root element has data-composition-id, data-width, data-height, and data-duration.
  • Script is deterministic. Ambient motion is implemented using a finite loop based on totalDuration, avoiding infinite repeats which is good practice for the renderer.
  • Correctly registers the timeline.