Files
hyperframes/packages/studio/src/components/editor/domEditOverlayCrop.test.ts
T
Miguel Angel Simon Sierra 39f33bd3a3 fix(studio): draw the crop UI in the element's rotated frame
Selecting a rotated (cropped) element appeared to straighten it: the crop
dim and dashed window were drawn on the axis-aligned bounding box, so the
bright window was a straight rectangle and the element's rotated corners
were masked to near-black — while the DOM transform was untouched.

clip-path applies in the element's LOCAL frame, before its transform, so
the crop visualization now renders inside a container rotated with the
element: readElementCropFrame decomposes the computed 2D matrix into
angle + per-axis scale (element scale finally factored into the px
mapping too) and 3D/unparseable transforms keep the axis-aligned
presentation. Pointer deltas rotate into the element frame before the
inset resolvers, so edge/pan drags track the rotated handles correctly.
2026-07-11 15:34:41 -04:00

244 lines
7.4 KiB
TypeScript

import { describe, expect, it } from "vitest";
import {
cropRectFromInsets,
hugRectForElement,
readElementCropFrame,
readElementCropInsets,
resolveCropInsetFromEdgeDrag,
resolveCropInsetFromMoveDrag,
rotateDeltaIntoFrame,
} from "./domEditOverlayCrop";
describe("resolveCropInsetFromEdgeDrag", () => {
const startInsets = { top: 10, right: 20, bottom: 30, left: 40 };
it("converts overlay-space edge movement into element-space inset changes", () => {
expect(
resolveCropInsetFromEdgeDrag({
edge: "left",
startInsets,
deltaX: 20,
deltaY: 0,
scaleX: 2,
scaleY: 1,
width: 200,
height: 120,
}),
).toEqual({ top: 10, right: 20, bottom: 30, left: 50 });
expect(
resolveCropInsetFromEdgeDrag({
edge: "right",
startInsets,
deltaX: 20,
deltaY: 0,
scaleX: 2,
scaleY: 1,
width: 200,
height: 120,
}),
).toEqual({ top: 10, right: 10, bottom: 30, left: 40 });
});
it("clamps edited insets so opposing sides never overlap", () => {
expect(
resolveCropInsetFromEdgeDrag({
edge: "left",
startInsets,
deltaX: 400,
deltaY: 0,
scaleX: 1,
scaleY: 1,
width: 100,
height: 120,
}),
).toEqual({ top: 10, right: 20, bottom: 30, left: 80 });
expect(
resolveCropInsetFromEdgeDrag({
edge: "top",
startInsets,
deltaX: 0,
deltaY: -40,
scaleX: 1,
scaleY: 2,
width: 200,
height: 120,
}),
).toEqual({ top: 0, right: 20, bottom: 30, left: 40 });
});
});
describe("resolveCropInsetFromMoveDrag", () => {
const startInsets = { top: 10, right: 20, bottom: 30, left: 40 };
it("shifts opposing insets together so the crop size stays constant", () => {
expect(
resolveCropInsetFromMoveDrag({ startInsets, deltaX: 20, deltaY: -10, scaleX: 2, scaleY: 1 }),
).toEqual({ top: 0, right: 10, bottom: 40, left: 50 });
});
it("clamps the window inside the element bounds", () => {
expect(
resolveCropInsetFromMoveDrag({ startInsets, deltaX: 999, deltaY: 999, scaleX: 1, scaleY: 1 }),
).toEqual({ top: 40, right: 0, bottom: 0, left: 60 });
});
});
describe("cropRectFromInsets", () => {
it("shrinks the overlay rect by scaled insets", () => {
expect(
cropRectFromInsets(
{ left: 100, top: 50, width: 200, height: 100 },
{ top: 10, right: 40, bottom: 20, left: 30 },
2,
1,
),
).toEqual({ left: 160, top: 60, width: 60, height: 70 });
});
it("clamps to zero size when insets exceed the rect", () => {
const r = cropRectFromInsets(
{ left: 0, top: 0, width: 100, height: 100 },
{ top: 300, right: 300, bottom: 300, left: 300 },
1,
1,
);
expect(r.width).toBe(0);
expect(r.height).toBe(0);
});
});
describe("readElementCropInsets tri-state", () => {
// Regression: a clip-path the crop tool can't represent (circle/polygon/
// non-px inset) used to parse to ZEROS — indistinguishable from "no crop" —
// so selecting lifted the clip and deselecting removed/replaced it: the
// authored circle clip was silently destroyed by a mere select+deselect.
const fakeEl = (inlineClip: string) =>
({
style: { getPropertyValue: (p: string) => (p === "clip-path" ? inlineClip : "") },
ownerDocument: { defaultView: { getComputedStyle: () => ({ clipPath: "none" }) } },
}) as unknown as HTMLElement;
it("zeros for no clip", () => {
expect(readElementCropInsets(fakeEl(""))).toEqual({
top: 0,
right: 0,
bottom: 0,
left: 0,
radius: 0,
});
});
it("parses a px inset", () => {
expect(readElementCropInsets(fakeEl("inset(16px round 12px)"))).toEqual({
top: 16,
right: 16,
bottom: 16,
left: 16,
radius: 12,
});
});
it("null for a circle clip (uneditable, must not be lifted)", () => {
expect(readElementCropInsets(fakeEl("circle(50% at 50% 50%)"))).toBeNull();
});
it("null for a non-px inset (uneditable, must not be lifted)", () => {
expect(readElementCropInsets(fakeEl("inset(10%)"))).toBeNull();
});
it("hugRectForElement passes the rect through for uneditable clips", () => {
const rect = { left: 1, top: 2, width: 30, height: 40, editScaleX: 1, editScaleY: 1 };
expect(hugRectForElement(rect, fakeEl("circle(50%)"))).toEqual(rect);
});
});
// Regression: crop UI drawn on the axis-aligned bounding box visually
// "straightens" a rotated element — the dim masks the rotated corners. The
// frame gives the element's own box + rotation so the UI rotates with it.
describe("readElementCropFrame", () => {
const overlayRect = { left: 100, top: 50, width: 220, height: 130, editScaleX: 1, editScaleY: 1 };
const fakeEl = (transform: string, offsetWidth = 200, offsetHeight = 100) =>
({
offsetWidth,
offsetHeight,
ownerDocument: { defaultView: { getComputedStyle: () => ({ transform }) } },
}) as unknown as HTMLElement;
it("identity transform → the axis-aligned overlay rect", () => {
expect(readElementCropFrame(fakeEl("none"), overlayRect)).toEqual({
angleDeg: 0,
left: 100,
top: 50,
width: 220,
height: 130,
scaleX: 1,
scaleY: 1,
});
});
it("rotated element → its own box, centered on the AABB, with the angle", () => {
// rotate(30deg): matrix(cos, sin, -sin, cos, tx, ty)
const cos = Math.cos(Math.PI / 6);
const sin = Math.sin(Math.PI / 6);
const frame = readElementCropFrame(
fakeEl(`matrix(${cos}, ${sin}, ${-sin}, ${cos}, 10, 20)`),
overlayRect,
);
expect(frame.angleDeg).toBeCloseTo(30, 3);
expect(frame.width).toBeCloseTo(200, 3);
expect(frame.height).toBeCloseTo(100, 3);
// centered on the AABB center (210, 115)
expect(frame.left + frame.width / 2).toBeCloseTo(210, 3);
expect(frame.top + frame.height / 2).toBeCloseTo(115, 3);
expect(frame.scaleX).toBeCloseTo(1, 3);
});
it("scaled element → scale factored into px-per-element-px", () => {
const frame = readElementCropFrame(fakeEl("matrix(1.5, 0, 0, 2, 0, 0)"), overlayRect);
expect(frame.angleDeg).toBe(0);
expect(frame.scaleX).toBeCloseTo(1.5, 3);
expect(frame.scaleY).toBeCloseTo(2, 3);
expect(frame.width).toBeCloseTo(300, 3);
expect(frame.height).toBeCloseTo(200, 3);
});
it("3D transform falls back to the axis-aligned frame", () => {
const frame = readElementCropFrame(
fakeEl("matrix3d(1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1)"),
overlayRect,
);
expect(frame).toEqual({
angleDeg: 0,
left: 100,
top: 50,
width: 220,
height: 130,
scaleX: 1,
scaleY: 1,
});
});
});
describe("rotateDeltaIntoFrame", () => {
it("passes deltas through at 0deg", () => {
expect(rotateDeltaIntoFrame(10, 5, 0)).toEqual({ deltaX: 10, deltaY: 5 });
});
it("rotates a screen delta into a 90deg-rotated frame", () => {
// Element rotated +90°: dragging DOWN on screen moves along the element's +x.
const { deltaX, deltaY } = rotateDeltaIntoFrame(0, 10, 90);
expect(deltaX).toBeCloseTo(10, 6);
expect(deltaY).toBeCloseTo(0, 6);
});
it("round-trips a 30deg rotation", () => {
const local = rotateDeltaIntoFrame(7, -3, 30);
const back = rotateDeltaIntoFrame(local.deltaX, local.deltaY, -30);
expect(back.deltaX).toBeCloseTo(7, 6);
expect(back.deltaY).toBeCloseTo(-3, 6);
});
});