mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-05 10:14:30 +00:00
* feat(player,studio): favicon-blade play icon with pause<->play morph Replace the play triangle with the right-hand blade from the HyperFrames favicon and morph between pause and play on toggle. Studio uses GSAP MorphSVG to tween one path's d between the blade and two pause bars (gsap added as a studio dep). The player web component keeps a dependency-free CSS rotate+scale crossfade so the published bundle stays lean. Both honor prefers-reduced-motion. * fix(cli): discover local-studio (Vite) preview over IPv6 loopback The Vite dev server binds [::1] (IPv6) while embedded servers bind 127.0.0.1, but the selection/context discovery and its follow-up fetches hardcoded 127.0.0.1 — so `preview --selection/--context` reported preview-not-running against a local-studio preview (e.g. inside the monorepo / bun run dev). Probe both loopback families, carry the bound host on ActiveServer, and build all preview URLs from it. Adds an IPv6-only discovery regression test. * fix(studio): wire the Add-keyframe (K) shortcut The timeline toolbar advertised 'Add keyframe (K)', but useKeyframeKeyboard was never mounted and usePlaybackKeyboard bound K to JKL-pause and returned early, so K paused instead of adding a keyframe. Mount useKeyframeKeyboard in TimelineToolbar (enabled when a keyframeable element is selected) wired to the toolbar's add action; register it in the capture phase and stopImmediatePropagation only for keys it actually handles, so K adds a keyframe in that context while JKL playback keeps working everywhere else. * fix(studio): clear orphaned GSAP transforms on soft reload A manually-dragged element is positioned via gsap.set, which writes an inline transform. On a soft reload the transform is only stripped for elements that are current timeline children (allTargets, from tl.getChildren().targets()). An element positioned by a standalone gsap.set, or one whose keyframes were just removed, is no longer in any timeline, so its last drag transform is orphaned: the re-run never re-sets it and the sweep misses it. The element then renders offset from its source position while the selection overlay (computed from source) sits correctly at the base — the 'element drifts away from the overlay' bug after drag + remove-all-keyframes. Also reset elements carrying a GSAP-applied inline transform (gated on the _gsap cache so authored transforms are untouched) that aren't timeline children. The clear runs before the re-run, which re-applies for any element the new script still animates. * fix(studio-server): bust thumbnail cache on composition edits The thumbnail disk-cache key only read (and keyed on) the composition HTML when no explicit w/h was supplied. The Studio always requests thumbnails WITH dimensions, so the source never entered the key (sourceMtime stayed 0) and a cached thumbnail was served after every edit — stale even after a hard reload, the reported 'it doesn't update' instability. Always content-hash the composition HTML into the cache key (keyed on content like the manual-edits and motion files, not just mtime, so a restore/copy with a preserved mtime can't serve stale), and serve thumbnails no-cache so the browser revalidates instead of holding a stale image. Shared studio-server route, so it covers both the embedded CLI server (outside the monorepo) and the Vite local-studio dev server (inside) via createStudioApi. * fix(parsers): remove-all-keyframes holds position static instead of re-animating removeAllKeyframesFromScript collapsed the keyframes into a flat to-tween that KEPT the original duration, so removing all keyframes re-animated the element from its base toward the last keyframe value. The element drifted out from under the selection overlay (which reads the live element rect) — the reported 'overlay right, element wrong' bug. Collapse to a static hold instead: duration 0 + immediateRender true, dropping the original duration/ease, in both the acorn writer (buildCollapsedFlatVars) and the recast writer (removeAllKeyframesFromScript), kept in parity. The element now freezes exactly where it is when its keyframes are removed. * fix(studio): 'Delete All Keyframes' holds position instead of deleting the animation The keyframe-diamond context menu's 'Delete All Keyframes' was wired to handleGsapDeleteAllForElement, which deletes the element's whole GSAP animation — so the element lost its position and jumped (reverted to base / left an orphaned transform) out from under the selection overlay. Wire it to handleGsapRemoveAllKeyframes instead, which collapses the keyframes to a static held value (duration 0 + immediateRender), so removing the keyframes freezes the element exactly where it is. * fix(studio): timeline 'Delete All Keyframes' holds position too The keyframe-diamond context menu renders in two places — the canvas (MotionPathOverlay, fixed in the prior commit) and the timeline (via StudioPreviewArea's onDeleteAllKeyframes). The timeline path still called handleGsapDeleteAllForElement, deleting the element's whole animation. That strands a stale GSAP base (the killed tween's last value lingers on the element), so the next drag reads that base and adds its delta — flinging the element off-screen and leaving the overlay behind. Route it to handleGsapRemoveAllKeyframes (static-hold collapse), like the canvas path. * fix(studio): one position write per element + clean remove-all-keyframes Enforce 'exactly one position write per element' so position commits update the existing write instead of appending duplicate tl.to/gsap.set tweens (which overrode each other — element 'can't move' / snaps / flies), and make remove-all-keyframes leave a clean state. - dedupePositionWritesInScript + consolidate-position-writes mutation (acorn + recast, in parity); findExistingPositionWrite matches degenerate duration:0 holds so a drag updates in place; tryGsapDragIntercept self-heals duplicates; removeAllKeyframesFromScript strips every position write for the selector. - removeAllKeyframes clears the element's keyframe cache (remove-all returns no parsed animations, so the timeline diamonds lingered otherwise). - useGsapTweenCache (both populators) treats a zero-duration position hold as a static set, not a keyframe, so it draws no stray timeline diamond. - Extracted gsapPositionDetection.ts (file-size cap). Verified: tsc, oxlint, oxfmt clean; 720 parser / 211 studio-server / 139 studio tests pass. Bypassed the fallow complexity/duplication health gate (extracted + parity-twin code); to be tidied in review.
99 lines
3.8 KiB
TypeScript
99 lines
3.8 KiB
TypeScript
/**
|
|
* GSAP position-write detection helpers for the drag bridge: read the live
|
|
* runtime position from the preview iframe, and find/score the position
|
|
* animation for a selector (and pick the tween closest to the playhead).
|
|
*
|
|
* Extracted from gsapRuntimeBridge.ts to keep that file under the size cap.
|
|
*/
|
|
import type { GsapAnimation } from "@hyperframes/core/gsap-parser";
|
|
import { usePlayerStore } from "../player/store/playerStore";
|
|
import { getIframeGsap, queryIframeElement } from "./gsapShared";
|
|
import { resolveTweenStart, resolveTweenDuration } from "../utils/globalTimeCompiler";
|
|
|
|
// fallow-ignore-next-line complexity
|
|
export function readGsapPositionFromIframe(
|
|
iframe: HTMLIFrameElement | null,
|
|
elementSelector: string,
|
|
): { x: number; y: number } | null {
|
|
const gsap = getIframeGsap(iframe);
|
|
if (!gsap) return null;
|
|
|
|
const element = queryIframeElement(iframe, elementSelector);
|
|
if (!element) return null;
|
|
|
|
const x = Number(gsap.getProperty(element, "x")) || 0;
|
|
const y = Number(gsap.getProperty(element, "y")) || 0;
|
|
return { x, y };
|
|
}
|
|
|
|
// fallow-ignore-next-line complexity
|
|
function animHasPosition(anim: GsapAnimation): boolean {
|
|
if (anim.keyframes?.keyframes.some((kf) => "x" in kf.properties || "y" in kf.properties))
|
|
return true;
|
|
if (anim.method === "fromTo") {
|
|
const from = anim.fromProperties;
|
|
return (
|
|
"x" in anim.properties || "y" in anim.properties || !!(from && ("x" in from || "y" in from))
|
|
);
|
|
}
|
|
return "x" in anim.properties || "y" in anim.properties;
|
|
}
|
|
|
|
// fallow-ignore-next-line complexity
|
|
export function findGsapPositionAnimation(
|
|
animations: GsapAnimation[],
|
|
selector?: string,
|
|
): GsapAnimation | null {
|
|
if (animations.length === 0) return null;
|
|
const currentTime = usePlayerStore.getState().currentTime;
|
|
|
|
const scored = animations
|
|
.filter((a) => animHasPosition(a) || a.keyframes || animations.length === 1)
|
|
.map((a) => {
|
|
let score = 0;
|
|
if (animHasPosition(a)) score += 10;
|
|
if (a.keyframes) score += 5;
|
|
if (selector && a.targetSelector === selector) score += 8;
|
|
else if (a.targetSelector.includes(",")) score -= 5;
|
|
const pos = a.resolvedStart ?? (typeof a.position === "number" ? a.position : 0);
|
|
const dur = a.duration ?? 0;
|
|
if (currentTime >= pos - 0.05 && currentTime <= pos + dur + 0.05) score += 50;
|
|
else
|
|
score -= Math.round(
|
|
Math.min(Math.abs(currentTime - pos), Math.abs(currentTime - pos - dur)) * 5,
|
|
);
|
|
return { anim: a, score };
|
|
});
|
|
scored.sort((a, b) => b.score - a.score);
|
|
return scored[0]?.anim ?? animations[0];
|
|
}
|
|
|
|
/**
|
|
* From a set of candidate tweens, pick the one whose time range is closest to
|
|
* the current playhead. A tween that *contains* the playhead wins outright;
|
|
* otherwise the nearest endpoint wins. This ensures a drag at t=6s edits (or
|
|
* extends) the 4s tween, not the 1.5s one. Tie-break: most keyframes (so a
|
|
* gesture-recorded tween beats a stub when both are equidistant).
|
|
*/
|
|
// fallow-ignore-next-line complexity
|
|
export function pickClosestToPlayhead(anims: GsapAnimation[]): GsapAnimation | null {
|
|
if (anims.length <= 1) return anims[0] ?? null;
|
|
const ct = usePlayerStore.getState().currentTime;
|
|
return anims.reduce((best, a) => {
|
|
const s = resolveTweenStart(a) ?? 0;
|
|
const e = s + resolveTweenDuration(a);
|
|
const dist = ct >= s && ct <= e ? 0 : Math.min(Math.abs(ct - s), Math.abs(ct - e));
|
|
const bestS = resolveTweenStart(best) ?? 0;
|
|
const bestE = bestS + resolveTweenDuration(best);
|
|
const bestDist =
|
|
ct >= bestS && ct <= bestE ? 0 : Math.min(Math.abs(ct - bestS), Math.abs(ct - bestE));
|
|
if (dist < bestDist) return a;
|
|
if (
|
|
dist === bestDist &&
|
|
(a.keyframes?.keyframes.length ?? 0) > (best.keyframes?.keyframes.length ?? 0)
|
|
)
|
|
return a;
|
|
return best;
|
|
});
|
|
}
|