Files
hyperframes/packages/studio/src/hooks/gsapRuntimeReaders.ts
T
Miguel Angel Simon Sierra 5d1cafff82 fix(studio): address review findings on graded-element editing
Review follow-ups (both reviewers, all findings):

- resize captures scope to the resize group: convert-to-keyframes
  resolvedFromValues and the whole-offset backfill pass the group filter,
  so an opacity-touching intro tween can't ride into a converted scale
  tween (the rotation fix's contract, now uniform across intercepts)
- commitStaticSet resolves every group's target set BEFORE committing and
  coalesces groups landing on the same legacy mixed set into one commit —
  the second commit can no longer chase a stale group-derived id
- installAuthoredOpacityCapture also stamps an element the moment it GAINS
  data-color-grading at runtime (attributeFilter), not just at insertion
- both writer twins now share the same emitted-set dedupe shape
- applySoftReload's positional tail becomes a SoftReloadOptions object
- readAllAnimatedProperties builds the group-filtered key set immutably
  instead of deleting from the set mid-iteration
- applyAuthoredInlineOpacity documents the priority-lossy round-trip
- the marquee hit-test reads activeCompositionPathRef like its neighbors

New tests: resize intercept (scale route + group filter + non-uniform
longhands), after-write-HTML / stamp / empty-stamp opacity restore, the
no-op-commit-with-missed-instant-patch soft-reload contract, and the
runtime-gained-grading stamp.
2026-07-11 15:18:49 -04:00

229 lines
7.4 KiB
TypeScript

/**
* Low-level GSAP runtime property readers shared by gsapRuntimeBridge and gsapDragCommit.
*/
import type { GsapAnimation } from "@hyperframes/core/gsap-parser";
import { classifyPropertyGroup, type PropertyGroupName } from "@hyperframes/core/gsap-parser";
import {
COLOR_GRADING_SOURCE_HIDDEN_ATTR,
HF_COLOR_GRADING_CANVAS_ID_PREFIX,
} from "@hyperframes/core/color-grading";
import { getIframeGsap, queryIframeElement, type IframeGsap } from "./gsapShared";
import { roundTo3 } from "../utils/rounding";
/**
* The element's live value for `prop` as GSAP drives it. Opacity on a
* color-grading-hidden source needs a detour: the runtime hides the source
* with inline `opacity: 0 !important`, so computed opacity is the hide, not
* the animated value. The grading canvas mirrors the source's effective
* opacity every frame, so it is the truth for that one property — reading the
* raw 0 here is what bakes `opacity: 0` into committed keyframes.
*/
function readLiveGsapValue(gsap: IframeGsap, el: Element, prop: string): number {
if (prop === "opacity" && el.getAttribute(COLOR_GRADING_SOURCE_HIDDEN_ATTR) != null && el.id) {
const canvas = el.ownerDocument.getElementById(HF_COLOR_GRADING_CANVAS_ID_PREFIX + el.id);
const win = el.ownerDocument.defaultView;
if (canvas && win) {
const val = Number(win.getComputedStyle(canvas).opacity);
if (Number.isFinite(val)) return val;
}
}
return Number(gsap.getProperty(el, prop));
}
export function readGsapProperty(
iframe: HTMLIFrameElement | null,
selector: string | null,
prop: string,
): number | null {
if (!selector) return null;
const gsap = getIframeGsap(iframe);
if (!gsap) return null;
const el = queryIframeElement(iframe, selector);
if (!el) return null;
try {
const val = readLiveGsapValue(gsap, el, prop);
if (!Number.isFinite(val)) return null;
return POSITION_PROPS.has(prop) ? Math.round(val) : roundTo3(val);
} catch {
return null;
}
}
export const POSITION_PROPS = new Set(["x", "y", "xPercent", "yPercent"]);
const GSAP_CONFIG_KEYS = new Set([
"duration",
"ease",
"delay",
"stagger",
"id",
"onComplete",
"onUpdate",
"onStart",
"onRepeat",
"repeat",
"yoyo",
"repeatDelay",
"paused",
"immediateRender",
"lazy",
"overwrite",
"keyframes",
"parent",
]);
export function readAllAnimatedProperties(
iframe: HTMLIFrameElement | null,
selector: string,
anim: GsapAnimation,
group?: PropertyGroupName,
): Record<string, number> {
const result: Record<string, number> = {};
if (!iframe) return result;
const gsap = getIframeGsap(iframe);
if (!gsap) return result;
const el = queryIframeElement(iframe, selector);
if (!el) return result;
let doc: Document | null = null;
try {
doc = iframe?.contentDocument ?? null;
} catch {
/* cross-origin guard — doc stays null */
}
const propKeys = new Set<string>();
if (anim.keyframes) {
for (const kf of anim.keyframes.keyframes) {
for (const p of Object.keys(kf.properties)) {
if (typeof kf.properties[p] === "number") propKeys.add(p);
}
}
} else {
for (const p of Object.keys(anim.properties)) propKeys.add(p);
}
// When a group filter is specified, only properties belonging to that group
// may enter the result — including the baseline passes below. The whole
// point of property-group tweens is that a rotation commit never carries
// opacity/rotationX/etc. captured from unrelated tweens on the element.
const inGroup = (p: string) => !group || classifyPropertyGroup(p) === group;
const groupedPropKeys = new Set([...propKeys].filter(inGroup));
for (const prop of groupedPropKeys) {
const val = readLiveGsapValue(gsap, el, prop);
if (Number.isFinite(val)) {
result[prop] = POSITION_PROPS.has(prop) ? Math.round(val) : roundTo3(val);
}
}
const otherTweenProps = new Set<string>();
try {
const win = iframe.contentWindow as unknown as { __timelines?: Record<string, unknown> };
const timelines = win.__timelines;
if (timelines) {
for (const tl of Object.values(timelines)) {
const tlObj = tl as {
getChildren?: (
deep: boolean,
) => Array<{ targets?: () => Element[]; vars?: Record<string, unknown> }>;
};
if (!tlObj?.getChildren) continue;
for (const child of tlObj.getChildren(true)) {
if (typeof child.targets !== "function") continue;
const targets = child.targets();
if (!targets.includes(el)) continue;
const vars = child.vars;
if (!vars) continue;
for (const k of Object.keys(vars)) {
if (!GSAP_CONFIG_KEYS.has(k) && inGroup(k)) otherTweenProps.add(k);
}
}
}
}
} catch {}
for (const p of groupedPropKeys) otherTweenProps.delete(p);
// Tier 1: Transform + visual properties with universal CSS defaults.
// Safe to compare against hardcoded values — these are always 0 or 1
// regardless of the element's stylesheet.
const UNIVERSAL_BASELINE: Record<string, number> = {
opacity: 1,
scale: 1,
scaleX: 1,
scaleY: 1,
scaleZ: 1,
rotation: 0,
rotationX: 0,
rotationY: 0,
skewX: 0,
skewY: 0,
z: 0,
xPercent: 0,
yPercent: 0,
transformPerspective: 0,
blur: 0,
brightness: 1,
contrast: 1,
saturate: 1,
hueRotate: 0,
grayscale: 0,
sepia: 0,
invert: 0,
};
// Collect all properties that ANY tween on this element explicitly targets.
// Only capture baseline values for these — GSAP reports non-default values
// (scaleZ=0, brightness=0) for untouched properties, polluting keyframes.
const allTweenedProps = new Set([...groupedPropKeys, ...otherTweenProps]);
for (const [prop, defaultVal] of Object.entries(UNIVERSAL_BASELINE)) {
if (prop in result) continue;
if (!allTweenedProps.has(prop)) continue;
const val = readLiveGsapValue(gsap, el, prop);
if (Number.isFinite(val) && Math.round(val * 1000) !== Math.round(defaultVal * 1000)) {
result[prop] = roundTo3(val);
}
}
// Tier 2: Element-dependent properties — their "default" depends on the
// stylesheet, so we compare GSAP's runtime value against the element's
// computed CSS value. Only capture if GSAP has actively changed it.
const COMPUTED_BASELINE = [
"borderRadius",
"borderTopLeftRadius",
"borderTopRightRadius",
"borderBottomLeftRadius",
"borderBottomRightRadius",
"letterSpacing",
"wordSpacing",
"lineHeight",
"fontSize",
"outlineOffset",
"outlineWidth",
"strokeDashoffset",
"strokeWidth",
"backgroundPositionX",
"backgroundPositionY",
];
let computedStyle: CSSStyleDeclaration | null = null;
try {
computedStyle = doc?.defaultView?.getComputedStyle(el) ?? null;
} catch {}
for (const prop of COMPUTED_BASELINE) {
if (prop in result) continue;
if (!inGroup(prop)) continue;
if (otherTweenProps.has(prop)) continue;
const gsapVal = Number(gsap.getProperty(el, prop));
if (!Number.isFinite(gsapVal)) continue;
let cssVal = NaN;
if (computedStyle) {
const raw = computedStyle.getPropertyValue(
prop.replace(/[A-Z]/g, (m) => `-${m.toLowerCase()}`),
);
cssVal = parseFloat(raw);
}
if (Number.isFinite(cssVal) && Math.round(gsapVal * 1000) === Math.round(cssVal * 1000))
continue;
result[prop] = roundTo3(gsapVal);
}
return result;
}