mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-19 19:36:04 +00:00
assemble-index.mjs was emitting scene host divs with id="el-<sid>" in all modes. HyperShader resolves scenes via document.getElementById(sid) (packages/shader-transitions/src/hyper-shader.ts:289, 825) where sid is the value from data-composition-id, and additionally requires the same element to carry class="scene" (line 828 raises "scene ids not found in DOM" otherwise). With the el- prefix, init() consistently threw and no shader transitions ran. The pattern only appeared after we added the el- prefix in a prior fix for host-id uniqueness (across two compositions). Fix: branch on useHyperShader. Shader mode uses the bare sid (lets getElementById find it). Non-shader mode keeps el-<sid> (no getElementById lookup happens there; the el- prefix preserves uniqueness when an inner composition's root carries the same data-composition-id). Verified against hyper-shader.ts source — both lookups (line 289 in the seam compositor + line 825 in init's id-resolution check) are bare-id. The class="scene" attribute was already conditional on useHyperShader so no additional change needed. No behavior change for non-shader compositions; restores shader transitions for shader-mode compositions.