mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-05 17:30:50 +00:00

Files

T

xiayeandClaude Opus 4.7 5a0966dfeb fix(runtime,player): replay bridge state on iframe ready to repair race

The audio-locked attribute was correctly setting `muted = true` and posting
`set-muted` to the iframe runtime, but on warm-cache reloads of claude.ai
and inside the Claude desktop Electron client, the iframe finishes loading
*after* the parent has already sent control messages — the iframe runtime's
postMessage listener isn't installed yet, so the messages are silently
dropped. Audio plays unmuted with no UI to recover.

Confirmed via:
- "First open" on claude.ai: cold cache, iframe slow → listener up before
  `set-muted` lands → audio muted ✅
- "Hard refresh" on claude.ai: warm cache, iframe fast → listener up after
  message arrives → message lost → audio plays ❌
- Claude desktop: Electron renderer consistently fast → race always loses
  → audio plays ❌

Fix: add a `{source: "hf-preview", type: "ready"}` event the runtime emits
once `installRuntimeControlBridge` has registered the listener. The player
listens for it and replays current bridge state (`set-muted`, `set-volume`,
`set-playback-rate`). Pre-ready messages are now safe to send — they'll be
replayed once the runtime can receive them.

The replay is idempotent — re-asserting defaults is a no-op — so it's also
safe across iframe reloads (new runtime instance emits ready again).

Tests: 6 new (1 bridge: ready posted on install; 5 player: replays muted /
volume / playback-rate / audio-locked-forced-mute / handles second ready /
ignores ready from wrong source). Suites green: core 1387, player 137.

Refs:
- Investigation: heygen-com/hyperframes#1300 (UA-fallback attempt — unrelated
  to actual root cause)
- claude.ai-web.log analysis revealed cross-origin iframe + race condition,
  not attribute stripping as originally hypothesized

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-06-09 12:22:27 -07:00

2.1 KiB

Raw Blame History

Hyperframe Runtime Engine

This folder owns the runtime that powers preview and producer parity.

Current Direction

Runtime source of truth is converging on hyperframe.ts.
Build produces:
- dist/hyperframe.runtime.iife.js (browser bootstrap)
- dist/hyperframe.runtime.mjs (tooling/tests)
- dist/hyperframe.manifest.json (version + sha256 + artifact map)
FE owns iframe runtime injection.
BE persists raw generated HTML without injecting runtime scripts.
Producer validates pinned runtime checksum from manifest before render.

Runtime Contract (Stable Surface)

Globals:

window.__player
window.__playerReady
window.__renderReady
window.__timelines
window.__clipManifest

postMessage:

parent -> runtime control:
- source: "hf-parent"
- type: "control"
- actions: play, pause, seek, set-muted, set-playback-rate, enable-pick-mode, disable-pick-mode
runtime -> parent events:
- source: "hf-preview"
- type: "state" and type: "timeline"
- type: "ready" — emitted once when installRuntimeControlBridge registers the control-message listener. The parent uses it to replay current playback state (set-muted, set-volume, set-playback-rate) so any control message sent before the listener was installed isn't lost. Emitted again on every iframe reload because the new runtime instance starts with no state.

Determinism baseline:

renderSeek is the producer-canonical seek path.
30fps quantization and readiness gates are correctness requirements.

Build

bun run --filter @hyperframes/core build:hyperframes-runtime

Security Expectations

Runtime bootstrap URL must be version-pinned and host-allowlisted.
Iframe bridge payloads must be schema-validated.
Unsafe URL schemes (javascript: and unapproved data:) are rejected.
Fail closed if runtime bootstrap/handshake is not healthy.

Product Editing Model

Primary mode: prompt + element picking.
Secondary mode: manual precision controls.
Avoid timeline-first manual workflows as default product path.

2.1 KiB Raw Blame History