mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-18 16:08:56 +00:00
* fix(cli): no auto-update across 0.x minors; install skills at the CLI's release tag - autoUpdate: before 1.0 a minor bump counts as a major one, so 0.8.x -> 0.9.x is a notice, not a silent background install. From 1.0 on, the major alone. - skills: `skills update` / bare `skills` / `init` install from heygen-com/hyperframes#v<VERSION>, and `skills check` plus the background freshness nudge read the manifest at the same tag. A build the repo has no tag for (dev build) falls back to main, as before. - skills: run the upstream installer as `npx skills@1.7.4` instead of an unpinned `npx skills`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): keep the comment share of the touched files from rising Comment ratchet: trim the comments added in the previous commit. No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): pass the CLI version into the skills check instead of importing it scripts/clawhub-unlist-retired.mjs loads skillsManifest.ts from source under plain node, which cannot resolve a relative `../version.js` import. Callers now pass `cliVersion` (and skillsSourceRef takes it as an argument), so the module keeps importing only node builtins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): read skills at the CLI's tag without a probe; pin skills@1.5.13 - A release build reads the manifest at its own tag directly (publish pushes the tag before npm publish). Only a 404 for that manifest falls back to main; a timeout, missing git or proxy error now surfaces instead of quietly comparing against main, so the background nudge can't cache a false "outdated" count. - checkSkills returns the ref it read, and skills update installs from that same ref, so check and install can't disagree within one run. - Pin skills@1.5.13 (it parses `#<ref>` too) so the pin matches the version agentDirs.generated.ts and the lock-path notes were checked against. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(cli): split the tag and main manifest fetches Fallow flagged fetchRemoteManifest's CRAP score (31.6 > 30). The tag fetch (404 is the only fallback to main) and the SHA-pinned main fetch are now their own functions. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): never auto-upgrade a Homebrew install `brew upgrade hyperframes` installs whatever formula the tap holds, so a background run scheduled for an allowed patch could still cross a 0.x minor. Homebrew installs now only get the update notice naming `brew upgrade`. A new test drives the scheduler through the real installer detection and installer script: no spawn on Homebrew, a versioned npm install for a patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
145 lines
6.3 KiB
TypeScript
145 lines
6.3 KiB
TypeScript
// Passive "your skills are stale" nudge. Mirrors updateCheck.ts: a background
|
|
// check populates a 24h cache; printSkillsUpdateNotice() reads the cache
|
|
// synchronously and prints one line on exit.
|
|
//
|
|
// Why a passive nudge (not just `skills check`): agents don't reliably run a
|
|
// check on their own, but they DO run render/lint/validate — so we piggyback
|
|
// the reminder on the commands they already run.
|
|
|
|
import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
|
|
import { dirname, join, resolve } from "node:path";
|
|
import { CONFIG_PATH, readConfig, readConfigFresh, writeConfig } from "../telemetry/config.js";
|
|
import { isUnattended } from "./attendedTerminal.js";
|
|
import { hostAnswers } from "./hostAnswers.js";
|
|
import { checkSkills } from "./skillsManifest.js";
|
|
import { updateCheckDisabled } from "./updateCheck.js";
|
|
import { VERSION } from "../version.js";
|
|
|
|
const CHECK_INTERVAL_MS = 24 * 60 * 60 * 1000; // 24 hours
|
|
|
|
interface SkillsUpdateMeta {
|
|
updateAvailable: boolean;
|
|
outdated: number;
|
|
missing: number;
|
|
}
|
|
|
|
/** Synchronous read from cache — never fetches. */
|
|
function getSkillsUpdateMeta(): SkillsUpdateMeta {
|
|
const config = readConfig();
|
|
return {
|
|
updateAvailable: config.skillsUpdateAvailable ?? false,
|
|
outdated: config.skillsOutdatedCount ?? 0,
|
|
missing: config.skillsMissingCount ?? 0,
|
|
};
|
|
}
|
|
|
|
function cacheFresh(lastSkillsCheck: string | undefined, now: number): boolean {
|
|
if (!lastSkillsCheck) return false;
|
|
return now - new Date(lastSkillsCheck).getTime() < CHECK_INTERVAL_MS;
|
|
}
|
|
|
|
/** Run the real check and persist the result to the cache. Skipped when DNS does not answer. */
|
|
export async function refreshSkillsCache(): Promise<void> {
|
|
if (!(await hostAnswers("github.com"))) return;
|
|
// `canonical: true` so this nudge's counts agree with `updateSkills`'s
|
|
// source of truth — otherwise a stale in-repo skills-manifest.json (e.g.
|
|
// inside a hyperframes checkout) can produce a false-positive count here.
|
|
const result = await checkSkills({ canonical: true, cliVersion: VERSION });
|
|
// Only record a meaningful check when skills were actually found.
|
|
if (result.location) {
|
|
// Fresh read: this runs in a background child, beside the command's own config writes.
|
|
const config = readConfigFresh();
|
|
config.lastSkillsCheck = new Date().toISOString();
|
|
config.skillsUpdateAvailable = result.updateAvailable;
|
|
config.skillsOutdatedCount = result.summary.outdated;
|
|
// Core-missing only: skills that install on demand (workflows not yet
|
|
// triggered on this machine) are not "missing" worth nagging about.
|
|
config.skillsMissingCount = result.summary.coreMissing;
|
|
writeConfig(config);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Drop the cached verdict (counts + timestamp) so the next command's
|
|
* background check re-runs instead of nagging from a pre-reconcile snapshot.
|
|
*
|
|
* Called after a `skills` install/update/check has reconciled or re-measured
|
|
* the install. Those commands are excluded from the nudge pipeline entirely
|
|
* (see cli.ts), so nothing else refreshes the cache when they run — without
|
|
* this, the last background verdict (taken BEFORE the install) keeps printing
|
|
* "N skills out of date or missing" on every other command for up to 24h
|
|
* after a successful install/update.
|
|
*
|
|
* Counts are cleared along with the timestamp — not left behind — so an
|
|
* offline machine (where the next refresh fails and falls back to the cached
|
|
* meta) goes quiet rather than resurrecting the stale pre-install counts.
|
|
*
|
|
* Best-effort: a config write failure must never fail the skills command
|
|
* that just succeeded.
|
|
*/
|
|
export function invalidateSkillsCache(): void {
|
|
try {
|
|
// Fresh read narrows the lost-update window against a concurrently
|
|
// running CLI process that wrote other config fields in the meantime.
|
|
const config = readConfigFresh();
|
|
delete config.lastSkillsCheck;
|
|
delete config.skillsUpdateAvailable;
|
|
delete config.skillsOutdatedCount;
|
|
delete config.skillsMissingCount;
|
|
writeConfig(config);
|
|
} catch {
|
|
// best-effort — never break the command that just reconciled skills
|
|
}
|
|
}
|
|
|
|
/** Not tied to a TTY: agents run the CLI without one and are the ones that need to hear it. */
|
|
function skillsNoticeOff(): boolean {
|
|
return process.env["HYPERFRAMES_SKIP_SKILLS"] === "1" || updateCheckDisabled();
|
|
}
|
|
|
|
/** Whether a background skills check is due: this run shows notices and the 24 h cache is stale. */
|
|
export function skillsCheckDue(): boolean {
|
|
if (skillsNoticeOff()) return false;
|
|
return !cacheFresh(readConfig().lastSkillsCheck, Date.now());
|
|
}
|
|
|
|
/** True at most once a day per project; records the showing. Unreadable state counts as never shown. */
|
|
function claimDailyNotice(project: string, now = Date.now()): boolean {
|
|
const noticeFile = join(dirname(CONFIG_PATH), "skills-notice.json");
|
|
let shown: Record<string, number> = {};
|
|
try {
|
|
shown = JSON.parse(readFileSync(noticeFile, "utf-8")) as Record<string, number>;
|
|
} catch {
|
|
// first notice, or a damaged file that the write below replaces
|
|
}
|
|
if (now - (shown[project] ?? 0) < CHECK_INTERVAL_MS) return false;
|
|
const kept = Object.entries(shown).filter(([, at]) => now - at < CHECK_INTERVAL_MS);
|
|
try {
|
|
mkdirSync(dirname(noticeFile), { recursive: true, mode: 0o700 });
|
|
writeFileSync(noticeFile, JSON.stringify(Object.fromEntries([...kept, [project, now]])));
|
|
} catch {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
/** The stale-skills nudge text, or null when nothing is outdated or missing. */
|
|
function skillsNoticeText(meta: SkillsUpdateMeta): string | null {
|
|
const total = meta.outdated + meta.missing;
|
|
if (total < 1) return null;
|
|
const noun = total === 1 ? "skill" : "skills";
|
|
return `\n ${total} HyperFrames ${noun} out of date or missing.\n Run: npx hyperframes skills update\n\n`;
|
|
}
|
|
|
|
/**
|
|
* Print a one-line nudge to stderr if installed skills are stale, at most once a day per project.
|
|
* Off in CI, dev, HYPERFRAMES_NO_UPDATE_CHECK and HYPERFRAMES_SKIP_SKILLS. Unattended, only
|
|
* missing skills count: an agent without them cannot do the work, an outdated one still can.
|
|
*/
|
|
export function printSkillsUpdateNotice(cwd: string = process.cwd()): void {
|
|
if (skillsNoticeOff()) return;
|
|
const meta = getSkillsUpdateMeta();
|
|
const text = skillsNoticeText(isUnattended() ? { ...meta, outdated: 0 } : meta);
|
|
if (text && claimDailyNotice(resolve(cwd))) process.stderr.write(text);
|
|
}
|