mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-01 19:42:03 +00:00
James Russo
8228932e17
The set-version guard parsed `git status --porcelain` and extracted the path with a fixed `line.slice(3)`. The porcelain "XY <path>" prefix width can shift, and when it did the slice dropped a leading character — misreading `.claude-plugin/plugin.json` as `claude-plugin/plugin.json`, which failed the allowed-paths match and falsely blocked a legitimate release with "Unexpected uncommitted changes". There was no escape hatch. Collect changed paths from `git diff --name-only -z HEAD` (tracked) plus `git ls-files --others --exclude-standard -z` (untracked) instead. Both emit bare NUL-separated repo-relative paths with no status column to misparse, so the allowed-paths comparison is exact. Extract the pure helpers (splitNulList, findUnexpectedChanges) and cover them with tests. Also document the release flow in CLAUDE.md (the repo had no release docs).
97 lines
2.6 KiB
TypeScript
97 lines
2.6 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import { describe, it } from "node:test";
|
|
import {
|
|
changelogArtifacts,
|
|
findUnexpectedChanges,
|
|
isPrerelease,
|
|
parseReleaseOptions,
|
|
releaseAllowedPaths,
|
|
releaseRequiresChangelog,
|
|
splitNulList,
|
|
} from "./set-version.ts";
|
|
|
|
describe("set-version release options", () => {
|
|
it("parses stable release flags", () => {
|
|
assert.deepEqual(parseReleaseOptions(["1.2.3", "--no-tag", "--skip-changelog-check"]), {
|
|
version: "1.2.3",
|
|
skipTag: true,
|
|
skipChangelogCheck: true,
|
|
});
|
|
});
|
|
|
|
it("requires reviewed changelog artifacts for stable tagged releases", () => {
|
|
assert.equal(
|
|
releaseRequiresChangelog({
|
|
version: "1.2.3",
|
|
skipTag: false,
|
|
skipChangelogCheck: false,
|
|
}),
|
|
true,
|
|
);
|
|
});
|
|
|
|
it("does not require changelog artifacts for prereleases, no-tag bumps, or emergency skips", () => {
|
|
assert.equal(isPrerelease("1.2.3-alpha.1"), true);
|
|
assert.equal(
|
|
releaseRequiresChangelog({
|
|
version: "1.2.3-alpha.1",
|
|
skipTag: false,
|
|
skipChangelogCheck: false,
|
|
}),
|
|
false,
|
|
);
|
|
assert.equal(
|
|
releaseRequiresChangelog({
|
|
version: "1.2.3",
|
|
skipTag: true,
|
|
skipChangelogCheck: false,
|
|
}),
|
|
false,
|
|
);
|
|
assert.equal(
|
|
releaseRequiresChangelog({
|
|
version: "1.2.3",
|
|
skipTag: false,
|
|
skipChangelogCheck: true,
|
|
}),
|
|
false,
|
|
);
|
|
});
|
|
|
|
it("tracks both GitHub release and docs changelog artifacts", () => {
|
|
assert.deepEqual(changelogArtifacts("1.2.3"), [
|
|
"releases/v1.2.3.md",
|
|
"docs/changelog.mdx#HyperFrames v1.2.3",
|
|
]);
|
|
});
|
|
});
|
|
|
|
describe("changed-path guard", () => {
|
|
it("splits NUL-separated git output and drops the empty trailing entry", () => {
|
|
assert.deepEqual(splitNulList("packages/core/package.json\0releases/v1.2.3.md\0"), [
|
|
"packages/core/package.json",
|
|
"releases/v1.2.3.md",
|
|
]);
|
|
assert.deepEqual(splitNulList(""), []);
|
|
});
|
|
|
|
it("accepts a release whose changes are all allowed paths", () => {
|
|
const allowed = releaseAllowedPaths("1.2.3");
|
|
assert.deepEqual(
|
|
findUnexpectedChanges(
|
|
["packages/core/package.json", ".claude-plugin/plugin.json", "releases/v1.2.3.md"],
|
|
allowed,
|
|
),
|
|
[],
|
|
);
|
|
});
|
|
|
|
it("flags changes outside the allowed release paths", () => {
|
|
const allowed = releaseAllowedPaths("1.2.3");
|
|
assert.deepEqual(
|
|
findUnexpectedChanges(["packages/core/package.json", "packages/core/src/index.ts"], allowed),
|
|
["packages/core/src/index.ts"],
|
|
);
|
|
});
|
|
});
|