mirror of
https://github.com/andrewyng/openworker.git
synced 2026-09-12 07:10:09 +00:00
Address action-demanding transitions to the assignee; neutral verdict label
Send-back/unblock/cancel by someone else now land in the worker's queue (only cancel did — send-backs woke nobody); done stays unaddressed. The Request changes button drops the send-to-X phrasing — it's a board write, delivery is the queue's job.
This commit is contained in:
@@ -111,7 +111,7 @@ test("item detail: timeline with attachment, worker link, request changes", asyn
|
||||
// Request changes… discloses a comment box; sending returns the item to work
|
||||
await detail.getByRole("button", { name: "Request changes…" }).click();
|
||||
await detail.getByPlaceholder("What needs to change?").fill("totals drift on Tom");
|
||||
await detail.getByRole("button", { name: "Send to security" }).click();
|
||||
await detail.getByRole("button", { name: "Request changes", exact: true }).click();
|
||||
await expect(detail).toContainText("In progress");
|
||||
// switching rows switches the pane
|
||||
await page.getByTestId("board-item-3").click();
|
||||
|
||||
@@ -358,6 +358,8 @@ function DetailActions({
|
||||
onChange={(e) => setChangesText(e.target.value)}
|
||||
/>
|
||||
<div className="board-changes-row">
|
||||
{/* A board write, not a message: review → in_progress with the
|
||||
comment attached; delivery to the assignee is the queue's job. */}
|
||||
<button
|
||||
className="board-btn primary"
|
||||
disabled={!changesText.trim()}
|
||||
@@ -365,7 +367,7 @@ function DetailActions({
|
||||
onTransition(detail.id, "in_progress", changesText.trim())
|
||||
}
|
||||
>
|
||||
Send to {detail.assignee || "worker"}
|
||||
Request changes
|
||||
</button>
|
||||
<button className="board-btn ghost" onClick={() => setChangesOpen(false)}>
|
||||
Cancel
|
||||
|
||||
Reference in New Issue
Block a user