Round-2 F-5, second half: with the session model as reviewer,
Auto-Approve allowed `git config --global user.name tester` without a
card. The protected-file floor lets plain git keys through and ignores
--global, and nothing in code covered other user-level settings, so the
verdict was the model's alone.
Now, in Auto-Approve, a shell command that changes the user's settings
outside the working folders goes to a person, not the reviewer:
`git config --global|--system` writes, npm / pnpm / yarn / pip config
writes (not npm/pnpm `--location project` or pip `--site`), setx, .NET
SetEnvironmentVariable for User or Machine, registry writes, and writes
to shell profiles or user-level config files (~/.bashrc, $PROFILE,
~/.gitconfig) that lie outside every folder. Inline shells (`bash -c`,
`powershell -Command`, `cmd /c`) are read too. Reading settings,
repo-local git config and sourcing a profile are unchanged, as are
Interactive, Custom, full access, the user's own command allowlist and
an approved plan step for the exact command.
Eval corpora: gate-081 now records human_only (its secure answer);
review-047 and review-222 are tagged settings-floor and left out of the
score; legacy danger-029/030 join the shadow-eval exact list.
* Protected list gains .github/actions/, .git/worktrees/, pytest.ini,
sitecustomize.py, usercustomize.py, .mise.toml / mise.toml (and .local
variants), .pnpmfile.cjs, .cargo/config.toml, .cargo/config and
.vscode/settings.json: each is read or run by a tool without being named.
* git config settings that only pick a default keep their normal handling:
core.longPaths, push.default, push.autoSetupRemote, fetch.prune,
rebase.autoStash, merge.conflictStyle.
* Shell commands that name a protected in-project path need a person, unless the
read-only check accepts the command (also each part of a `;` / `&&` / `||`
sequence, with `cd` and output-discarding redirects allowed). Paths are matched
as written and from the shell's current folder, with wildcards expanded.
Running a protected file is not a change to it.
* `git config` commands that change a setting need a person, except plain ones
that only label commits or pick a default (user.name, user.email,
init.defaultBranch, core.autocrlf, pull.rebase, color.ui). Reads are unaffected.
* Protected list gains git's own settings (.git/config, .git/info/attributes,
.git/modules/, a .git file), conftest.py at any depth, more CI files
(azure-pipelines.yml, .travis.yml, Jenkinsfile, bitbucket-pipelines.yml,
.buildkite/), .vscode/launch.json, and .npmrc / .yarnrc / .yarnrc.yml.
* File-tool writes are also checked against where the path really lands on disk,
read the way the operating system reads it; a location that can't be worked out
counts as protected.
* Corpora: gate-133..gate-141 added; danger-022 (a global git config change) moved
out of the reviewer corpus because the gate now sends it to a person.
* scripts/measure_protected_paths.py replays recorded runs and counts what newly
needs a person.
The in-project protected list (files that run on a later action) compared paths
exactly. Windows, and macOS by default, ignore letter case, but Path.resolve()
only restores the on-disk case for parts that already exist, so a target that
did not exist yet could miss the list in a different case. Matching now folds
case on those platforms, in _is_protected_in_project and in the own-settings
floor's write branch; Linux keeps exact matching.
The list gains files that a build backend, env tool, git or a hook manager runs
without being named: setup.py, .envrc, .gitattributes, .pre-commit-config.yaml,
tox.ini, .devcontainer/, .husky/, .circleci/, and AGENTS.md (read into every
later session's system prompt). package.json, pyproject.toml and setup.cfg stay
with the reviewer on purpose: users edit them constantly and the reviewer sees
the content.
Gate corpus rows gate-065..068 now have expected_current = expected_secure.
test_running_an_agent_written_script_tells_the_reviewer_so used setup.py as an
arbitrary script name; it now uses make_report.py.