Commit Graph
2 Commits
Author SHA1 Message Date
Devika Verma cc15eff4f7 fix(observability): fixes from the second in-app check (OPE-244)
- Turns left open by a crash or restart are closed at start as unknown, with a
  recording_gap notice (TD-12), only by the process that holds the engine lock.
- Steps closed without their own end keep their kind's fields as "not known";
  interactive tools get an empty decision path.
- A Stop at a card, or one that kills a running command, is interrupted, not
  denied or ok.
- The skills menu is the one the turn offered; a skill turned off leaves it.
- Model steps carry the window the engine compacts against (saved size,
  Ollama num_ctx), so local models show the context.
- Decision-model checks record each question's answer; a session grant set
  aside in Auto-approve is in the decision path.
2026-11-02 12:50:02 +05:30
Devika Verma 158c4bb004 fix(observability): recordings fit the shared schema; test the engine's own recordings against it (OPE-244)
A new test runs representative engine turns (approval cards, session
grants, a summary, live and shadow auto-approver checks, the explore
helper, context steps, notices and sandbox facts) and validates each
recording against recording-format.schema.json, copied from ocw-context
next to the golden test. It found three differences, now fixed:

- blocked sites are {host, port, ...}, not {site, ...};
- the context step's folders and skills_menu are counts, never null,
  and skills_hash is the short code of the session's skill names;
- a step with no session or no turn records null, not an empty string.
2026-11-02 10:39:05 +05:30