mirror of
https://github.com/andrewyng/openworker.git
synced 2026-11-04 13:27:11 +00:00
Devika Verma
77a035db8d
An unattended session mirrors its questions to a bound channel, and buttons_for() rendered one button per option and nothing else. So the dead end this issue closed in the app was still wide open in Slack: a reader whose answer wasn't on the list could only click a wrong option or leave the agent suspended. Skip now trails the options, carrying the sentinel answer_result() already maps to a null answer — that text-only-surface branch was written for exactly this caller and had a test before it had a sender. It grants nobody new authority. Anyone who can click an option in that channel can already decide the question; this only adds declining to what they could already do, which is the gentler of the two. Grouped questions stay button-less on purpose. Any button at all flips the mirror from the plain-text path to the interactive one, which would cost them the "(Open the app to respond.)" hint — and the app is where their per-question skip lives anyway.
101 lines
3.6 KiB
Python
101 lines
3.6 KiB
Python
"""Interactive prompts over messaging: button encoding, block rendering, and the click→resolve path."""
|
|
|
|
import asyncio
|
|
import json
|
|
|
|
from coworker.inbox import InboxStore
|
|
from coworker.interactions import Button, buttons_for, decode, encode
|
|
from coworker.tools.ask import SKIP_SENTINEL
|
|
from coworker.connectors.base import InteractionEvent
|
|
from coworker.connectors.senders import _slack_blocks
|
|
from coworker.providers import ModelCapabilities, ProviderClient
|
|
from coworker.server.manager import SessionManager
|
|
|
|
|
|
class ScriptedProvider(ProviderClient):
|
|
def __init__(self, turns):
|
|
self._turns = list(turns)
|
|
|
|
def complete(self, *, model, messages, tools=None, **settings):
|
|
return self._turns.pop(0)
|
|
|
|
def capabilities(self, model):
|
|
return ModelCapabilities()
|
|
|
|
|
|
def test_encode_decode_roundtrip():
|
|
v = encode("abc123", "allow")
|
|
assert decode(v) == ("abc123", "allow")
|
|
assert decode("not json") is None
|
|
assert decode(json.dumps({"nope": 1})) is None
|
|
|
|
|
|
def test_buttons_for_kinds(tmp_path):
|
|
st = InboxStore(tmp_path / "inbox.json")
|
|
appr = st.add_approval("s1", "Run `write_file`?")
|
|
btns = buttons_for(appr)
|
|
assert [b.label for b in btns] == ["Approve", "Deny"]
|
|
assert decode(btns[0].value) == (appr.id, "allow")
|
|
assert decode(btns[1].value) == (appr.id, "deny")
|
|
|
|
q = st.add_question("s1", "Which region?", options=["us-east-1", "us-west-2"])
|
|
qb = buttons_for(q)
|
|
# Skip trails the options (OPE-153) — the channel gets the card's way out too.
|
|
assert [b.label for b in qb] == ["us-east-1", "us-west-2", "Skip"]
|
|
assert decode(qb[0].value) == (q.id, "us-east-1") # resolution IS the option text
|
|
assert decode(qb[-1].value) == (q.id, SKIP_SENTINEL)
|
|
|
|
# free-text question (no options) and notifications get no buttons → "open the app"
|
|
assert buttons_for(st.add_question("s1", "Say something")) == []
|
|
assert buttons_for(st.add_notification("s1", "FYI")) == []
|
|
|
|
|
|
def test_slack_blocks_shape():
|
|
blocks = _slack_blocks("Run `x`?", [Button("Approve", "v1"), Button("Deny", "v2")])
|
|
assert blocks[0]["type"] == "section"
|
|
els = blocks[1]["elements"]
|
|
assert [e["text"]["text"] for e in els] == ["Approve", "Deny"]
|
|
assert [e["value"] for e in els] == ["v1", "v2"]
|
|
assert [e["action_id"] for e in els] == ["ocw_0", "ocw_1"]
|
|
# no buttons → just the section, no actions block
|
|
assert len(_slack_blocks("hi", [])) == 1
|
|
|
|
|
|
def test_interaction_click_resolves_item(tmp_path):
|
|
mgr = SessionManager(workspace=tmp_path, provider=ScriptedProvider([]))
|
|
mgr.secrets.put(
|
|
"slack:default",
|
|
{
|
|
"bot_token": "xoxb-test",
|
|
"app_token": "xapp-test",
|
|
"allowed_users": ["U_BOB"],
|
|
"approval_owner_ids": ["U_BOB"],
|
|
},
|
|
)
|
|
item = mgr.inbox.add_approval("sX", "Run `write_file`?")
|
|
|
|
resolved: list = []
|
|
|
|
async def fake_wait(item_id):
|
|
# stand in for the suspended agent: record what the item resolved to
|
|
resolved.append(await mgr.inbox.wait(item_id))
|
|
|
|
async def scenario():
|
|
waiter = asyncio.create_task(fake_wait(item.id))
|
|
await asyncio.sleep(0) # let the waiter register
|
|
await mgr._on_interaction(
|
|
InteractionEvent(
|
|
platform="slack",
|
|
chat_id="C1",
|
|
message_id="111.2",
|
|
value=encode(item.id, "allow"),
|
|
user_id="U_BOB",
|
|
user_name="bob",
|
|
)
|
|
)
|
|
await asyncio.wait_for(waiter, timeout=2)
|
|
|
|
asyncio.run(scenario())
|
|
assert resolved == ["allow"]
|
|
assert mgr.inbox.get(item.id).state == "resolved"
|