mirror of
https://github.com/andrewyng/openworker.git
synced 2026-09-12 07:10:09 +00:00
Rohit C Prasad
a9458524e8
The Test button was the form's only save path — extras like the thinking budget silently never persisted. Blur saves with a Saved flash; empty clears.
73 lines
3.6 KiB
TypeScript
73 lines
3.6 KiB
TypeScript
// Settings ▸ Models key flows on the shared provider gallery (§39 components, UX-021 page):
|
|
// bad key fails in place, a passing Test auto-saves and slides home to the gallery where the
|
|
// card wears its ✓. Providers are seeded in three states (OpenAI configured+used, Anthropic
|
|
// configured-unused, Z AI unconfigured w/ a prefilled endpoint behind the disclosure). The
|
|
// mock's /verify fails on a key containing "bad"; POST /v1/providers flips `configured`.
|
|
import { expect } from "@playwright/test";
|
|
import { test } from "./fixtures";
|
|
|
|
async function openModels(page) {
|
|
await page.goto("/");
|
|
await page.getByTestId("account-row").click();
|
|
await page.getByRole("button", { name: "Settings", exact: true }).click();
|
|
await page.getByRole("button", { name: "Models", exact: true }).click();
|
|
await expect(page.getByTestId("set-provider-openai")).toBeVisible();
|
|
}
|
|
|
|
test("Test with a bad key fails in place; a good key saves and returns to the gallery", async ({
|
|
page,
|
|
}) => {
|
|
await openModels(page);
|
|
await page.getByTestId("set-provider-zai").click();
|
|
|
|
await page.getByTestId("set-field-api_key").fill("sk-bad-key");
|
|
await page.getByTestId("set-test").click();
|
|
await expect(page.getByText("Invalid API key.")).toBeVisible();
|
|
|
|
// A good key: Test verifies AND saves (§39) — the in-field pill confirms, then the form
|
|
// slides home and the card wears its ✓.
|
|
await page.getByTestId("set-field-api_key").fill("sk-glm-realkey");
|
|
await page.getByTestId("set-test").click();
|
|
await expect(page.getByTestId("set-saved-pill")).toContainText("Tested & saved");
|
|
await expect(page.getByTestId("set-provider-zai")).toContainText("✓ Connected", {
|
|
timeout: 5_000,
|
|
});
|
|
|
|
// State-restore regression (owner catch 2026-07-19): revisiting the just-saved provider
|
|
// must show the masked placeholder + saved pill — never the typed key restored as a draft
|
|
// (the auto-return used to stash the saved key and replay it on the next open).
|
|
await page.getByTestId("set-provider-zai").click();
|
|
await expect(page.getByTestId("set-field-api_key")).toHaveValue("");
|
|
await expect(page.getByTestId("set-field-api_key")).toHaveAttribute("placeholder", "••••••••");
|
|
await expect(page.getByTestId("set-saved-pill")).toContainText("Tested & saved");
|
|
});
|
|
|
|
test("a configured provider's form opens with the saved state, no plaintext key", async ({
|
|
page,
|
|
}) => {
|
|
await openModels(page);
|
|
await page.getByTestId("set-provider-openai").click();
|
|
// Stored credentials show as the in-field saved pill + masked placeholder — never the key.
|
|
await expect(page.getByTestId("set-saved-pill")).toContainText("Tested & saved");
|
|
await expect(page.getByTestId("set-field-api_key")).toHaveValue("");
|
|
await expect(page.getByTestId("set-field-api_key")).toHaveAttribute("placeholder", "••••••••");
|
|
});
|
|
|
|
test("non-secret extras blur-save on a configured provider (thinking budget)", async ({
|
|
page,
|
|
}) => {
|
|
// Owner-hit 2026-07-23: typed a thinking budget, left Settings, value silently never
|
|
// saved — the Test button was the form's only save path. Blur now saves extras.
|
|
await openModels(page);
|
|
await page.getByTestId("set-provider-anthropic").click();
|
|
const budget = page.getByTestId("set-field-thinking_budget");
|
|
await budget.fill("8192");
|
|
await budget.blur();
|
|
await expect(page.getByTestId("set-field-saved-thinking_budget")).toBeVisible();
|
|
|
|
// Leave and come back: the value survived (served from the provider's stored values).
|
|
await page.getByTestId("set-back").click();
|
|
await page.getByTestId("set-provider-anthropic").click();
|
|
await expect(page.getByTestId("set-field-thinking_budget")).toHaveValue("8192");
|
|
});
|