mirror of
https://github.com/andrewyng/openworker.git
synced 2026-09-03 13:00:37 +00:00
NIKHIL PENTAPALLI
b922311a79
resolve_from_reply decided allow/deny with 'in' checks on the whole message, so "disallow" resolved as allow (checked first, and it contains "allow") and replies containing words like "note" or "not" resolved as deny instead of being recorded as free-text answers. Since this gates parked unattended actions, a false allow is the worst-case direction. Keyword intent now requires word boundaries (with the common -d forms added); emoji checks stay as substring matches. Anything that matches neither list falls through to the existing free-text path, which records the reply verbatim instead of acting on it.
125 lines
4.7 KiB
Python
125 lines
4.7 KiB
Python
"""Phase 3 gate — multi-inbox routing: named bindings, route resolution, delivery + reply."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from coworker.inbox import InboxStore
|
|
from coworker.inbox_routing import (
|
|
DEFAULT_INBOX,
|
|
InboxRouting,
|
|
deliver,
|
|
resolve_from_reply,
|
|
)
|
|
|
|
|
|
def test_route_precedence(tmp_path):
|
|
r = InboxRouting(tmp_path / "routing.json")
|
|
r.set_binding("ops", channel="slack", target="#ops-coworker")
|
|
r.set_persona_default("ops", "ops")
|
|
# Persona default applies...
|
|
assert r.route_for("s1", "ops") == "ops"
|
|
# ...unless a per-session override wins.
|
|
r.set_session_override("s1", DEFAULT_INBOX)
|
|
assert r.route_for("s1", "ops") == DEFAULT_INBOX
|
|
# Unbound persona/session → default.
|
|
assert r.route_for("s2", "cowork") == DEFAULT_INBOX
|
|
|
|
|
|
def test_bindings_persist(tmp_path):
|
|
InboxRouting(tmp_path / "routing.json").set_binding(
|
|
"ops", channel="telegram", target="123"
|
|
)
|
|
r2 = InboxRouting(tmp_path / "routing.json")
|
|
b = r2.binding_for("ops")
|
|
assert b.channel == "telegram" and b.target == "123"
|
|
|
|
|
|
def test_deliver_to_channel_embeds_item_id(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
routing = InboxRouting(tmp_path / "routing.json")
|
|
routing.set_binding("ops", channel="slack", target="#ops")
|
|
item = store.add_approval("s1", "Restart service?", body="prod web-1", inbox="ops")
|
|
|
|
sent = {}
|
|
|
|
def sender(channel, target, text):
|
|
sent.update(channel=channel, target=target, text=text)
|
|
|
|
assert deliver(item, routing.binding_for("ops"), sender) is True
|
|
assert sent["channel"] == "slack" and sent["target"] == "#ops"
|
|
assert f"[ow:{item.id}]" in sent["text"] # rebrand: emits [ow:…] since 2026-07-22
|
|
|
|
|
|
def test_in_app_only_binding_delivers_nothing(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
routing = InboxRouting(tmp_path / "routing.json")
|
|
item = store.add_approval("s1", "x", inbox=DEFAULT_INBOX)
|
|
calls = []
|
|
assert (
|
|
deliver(item, routing.binding_for(DEFAULT_INBOX), lambda *a: calls.append(a))
|
|
is False
|
|
)
|
|
assert calls == []
|
|
|
|
|
|
def test_inbound_reply_resolves_correct_item(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
item = store.add_approval("s1", "Deploy?", inbox="ops")
|
|
# Current token spelling…
|
|
ok = resolve_from_reply(f"approve [ow:{item.id}]", store.resolve)
|
|
assert ok is True
|
|
assert store.get(item.id).resolution == "allow"
|
|
|
|
|
|
def test_inbound_freetext_answer_to_question(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
q = store.add_question("s1", "Which region?")
|
|
res = resolve_from_reply(f"us-east-1 [ow:{q.id}]", store.resolve)
|
|
assert res is True and store.get(q.id).resolution == "us-east-1"
|
|
|
|
|
|
def test_reply_without_token_is_ignored(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
assert resolve_from_reply("random chatter", store.resolve) is None
|
|
|
|
|
|
def test_inbound_legacy_ocw_token_still_resolves(tmp_path):
|
|
"""Replies to messages sent BEFORE the @OpenWorker rename carry [ocw:…] — must keep working."""
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
item = store.add_approval("s1", "Deploy?", inbox="ops")
|
|
assert resolve_from_reply(f"deny [ocw:{item.id}]", store.resolve) is True
|
|
assert store.get(item.id).resolution == "deny"
|
|
|
|
|
|
def test_disallow_is_not_parsed_as_allow(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
item = store.add_approval("s1", "Deploy?", inbox="ops")
|
|
assert resolve_from_reply(f"disallow [ow:{item.id}]", store.resolve) is True
|
|
assert store.get(item.id).resolution != "allow"
|
|
|
|
|
|
def test_words_containing_no_are_not_parsed_as_deny(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
q = store.add_question("s1", "Which region?")
|
|
assert resolve_from_reply(f"north-east node [ow:{q.id}]", store.resolve) is True
|
|
assert store.get(q.id).resolution == "north-east node"
|
|
|
|
|
|
def test_denied_and_approved_word_forms(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
a = store.add_approval("s1", "Deploy?", inbox="ops")
|
|
b = store.add_approval("s1", "Restart?", inbox="ops")
|
|
resolve_from_reply(f"denied [ow:{a.id}]", store.resolve)
|
|
resolve_from_reply(f"approved [ow:{b.id}]", store.resolve)
|
|
assert store.get(a.id).resolution == "deny"
|
|
assert store.get(b.id).resolution == "allow"
|
|
|
|
|
|
def test_emoji_reactions_still_resolve(tmp_path):
|
|
store = InboxStore(tmp_path / "inbox.json")
|
|
a = store.add_approval("s1", "Deploy?", inbox="ops")
|
|
b = store.add_approval("s1", "Restart?", inbox="ops")
|
|
resolve_from_reply(f"👍 [ow:{a.id}]", store.resolve)
|
|
resolve_from_reply(f"❌ [ow:{b.id}]", store.resolve)
|
|
assert store.get(a.id).resolution == "allow"
|
|
assert store.get(b.id).resolution == "deny"
|