mirror of
https://github.com/andrewyng/openworker.git
synced 2026-09-03 13:00:37 +00:00
Rohit C Prasad
25dc283d9b
The artifacts scan used rglob and filtered after descending, so a home directory workspace walked into ~/Library and triggered the macOS App Data consent prompt on every turn. Walk with pruning instead, and skip Library / AppData in search too. The composer chip now shows the session total by default, with the context window bar behind a Settings toggle.
51 lines
2.0 KiB
Python
51 lines
2.0 KiB
Python
"""list_artifacts must never descend into OS application-data directories.
|
|
|
|
On macOS 14+, merely traversing ~/Library/Application Support (other apps' containers)
|
|
trips the App Data TCC protection and the user gets an alarming "OpenWorker would like to
|
|
access data from other apps" prompt. The artifacts panel refreshes after every turn, so a
|
|
home-directory workspace produced that prompt unprompted. Pruning must happen DURING the
|
|
walk (rglob descends first and filters after, which is what caused the bug).
|
|
"""
|
|
|
|
import os
|
|
|
|
from coworker.server.manager import SessionManager
|
|
from coworker.tools.search import OS_DATA_DIRS
|
|
|
|
|
|
def _ws(tmp_path):
|
|
ws = tmp_path / "home"
|
|
(ws / "Library" / "Application Support" / "SomeOtherApp").mkdir(parents=True)
|
|
(ws / "Library" / "Application Support" / "SomeOtherApp" / "secrets.json").write_text("{}")
|
|
(ws / "Library" / "notes.md").write_text("# private")
|
|
(ws / "node_modules" / "pkg").mkdir(parents=True)
|
|
(ws / "node_modules" / "pkg" / "readme.md").write_text("# dep")
|
|
(ws / "report.md").write_text("# real artifact")
|
|
return ws
|
|
|
|
|
|
def test_os_data_dirs_are_not_traversed(tmp_path, monkeypatch):
|
|
ws = _ws(tmp_path)
|
|
walked: list[str] = []
|
|
real_walk = os.walk
|
|
|
|
def spy(top, *a, **k):
|
|
for dirpath, dirs, files in real_walk(top, *a, **k):
|
|
walked.append(dirpath)
|
|
yield dirpath, dirs, files
|
|
|
|
monkeypatch.setattr("coworker.server.manager.os.walk", spy)
|
|
m = SessionManager(data_dir=tmp_path / "data", workspace=str(ws))
|
|
names = [a["name"] for a in m.list_artifacts("s1")]
|
|
|
|
assert "report.md" in names
|
|
# The private file is skipped AND its directory was never entered (the TCC trigger).
|
|
assert "notes.md" not in names
|
|
assert "secrets.json" not in names
|
|
assert not any("Library" in p for p in walked), f"descended into Library: {walked}"
|
|
assert not any("node_modules" in p for p in walked)
|
|
|
|
|
|
def test_os_data_dirs_cover_mac_and_windows():
|
|
assert {"Library", "AppData", "Application Data"} <= OS_DATA_DIRS
|