ext/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-10-29 22:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #62751 from diptanilsaha/fix-report-link-onclick-data

Browse Source 
fix(accounts): pass report row data to link handlers without ampersands
This commit is contained in:
mergify[bot]
2026-10-29 09:23:21 +00:00
committed by GitHub
parent cc58245340 b4e9b810e8
commit 6500dab228
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
erpnext/accounts/report/consolidated_financial_statement/consolidated_financial_statement.js
+3 -1
View File
@@ -143,7 +143,9 @@ frappe.query_reports["Consolidated Financial Statement"] = {
value = data.account_name || value;
column.link_onclick =
"erpnext.financial_statements.open_general_ledger(" + JSON.stringify(data) + ")";
"erpnext.financial_statements.open_general_ledger(" +
erpnext.financial_statements.to_onclick_arg(data) +
")";
column.is_tree = true;
}
erpnext/accounts/report/profitability_analysis/profitability_analysis.js
+1 -1
View File
@@ -90,7 +90,7 @@ frappe.query_reports["Profitability Analysis"] = {
column.link_onclick =
"frappe.query_reports['Profitability Analysis'].open_profit_and_loss_statement(" +
JSON.stringify(data) +
erpnext.financial_statements.to_onclick_arg(data) +
")";
column.is_tree = true;
}
erpnext/public/js/financial_statements.js
+10 -2
View File
@@ -147,7 +147,9 @@ erpnext.financial_statements = {
};
column.link_onclick =
"erpnext.financial_statements.open_general_ledger(" + JSON.stringify(glData) + ")";
"erpnext.financial_statements.open_general_ledger(" +
erpnext.financial_statements.to_onclick_arg(glData) +
")";
value = default_formatter(value, row, column, data);
}
@@ -261,7 +263,9 @@ erpnext.financial_statements = {
if (data.account || data.accounts) {
column.link_onclick =
"erpnext.financial_statements.open_general_ledger(" + JSON.stringify(data) + ")";
"erpnext.financial_statements.open_general_ledger(" +
erpnext.financial_statements.to_onclick_arg(data) +
")";
}
column.is_tree = true;
}
@@ -284,6 +288,10 @@ erpnext.financial_statements = {
return value;
},
// `link_onclick` is placed in an HTML attribute, so keep `&` out of it
to_onclick_arg: function (data) {
return JSON.stringify(data).replace(/&/g, "\\u0026");
},
open_general_ledger: function (data) {
if (!data.account && !data.accounts) return;
let filters = frappe.query_report.filters;