mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-16 14:27:26 +00:00
feat(core): name every preset node for the job it is doing
A peaking filter is "Peaking EQ" wherever it appears, so Clean Voice showed the
same two words at node 02 (cutting mud at 250 Hz) and node 04 (lifting clarity
at 3 kHz) with nothing to tell them apart. Reading down the rack, an author
could not follow what had been done for them.
`HfAudioFxNode.label` carries the job name, presets set it per node, and the
rack shows it in place of the effect's own name. Clean Voice now reads: Remove
Rumble, Reduce Mud, Even Out Loudness, Add Clarity, Peak Ceiling.
FIXES A BUG IN a533d1677: `parseAudioFxChain` and `serializeAudioFxChain` were
dropping `fromPreset` entirely — only `fromCarve` survived the attribute. So a
preset could not find its own nodes after a reload: re-applying would stack a
second copy instead of replacing, and the rack would lose the grouping. The
round-trip test compared only node TYPES, so it passed the whole time. It now
compares type, id, fromPreset and label, and fails if any is dropped.
Three tests, all falsified. Re-introducing the fromPreset drop fails the
round-trip; dropping label from the serializer fails it too; and giving two
nodes in one preset the same name fails the no-repeats check, which is the
invariant this whole change exists to hold. Identical CONSECUTIVE nodes are
exempt from that check — a stacked 24 dB/oct pair is one stage built from two
biquads, not two jobs.
Core 1688 -> 1690, studio 3664 -> 3665.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
68263fac73
commit
0d04e4cb19
@@ -813,6 +813,17 @@ export interface HfAudioFxNode {
|
||||
* and each has to be able to find its own.
|
||||
*/
|
||||
fromPreset?: string;
|
||||
/**
|
||||
* What the rack calls this node, when the effect's own name is not specific
|
||||
* enough to be useful.
|
||||
*
|
||||
* A peaking filter is "Shape One Range" wherever it appears, so a chain that
|
||||
* cuts mud at 250 Hz and lifts clarity at 3 kHz shows the same words twice
|
||||
* and an author cannot tell the two apart. A preset names each node for the
|
||||
* JOB it is doing instead — "Reduce Mud", "Add Clarity" — and the rack reads
|
||||
* as a list of things that were done rather than a list of filter types.
|
||||
*/
|
||||
label?: string;
|
||||
/** Absent means enabled — chain files written before the field existed still load. */
|
||||
enabled?: boolean;
|
||||
params?: HfAudioFxParamValues;
|
||||
@@ -862,6 +873,8 @@ export function parseAudioFxChain(json: string): HfAudioFxChain {
|
||||
enabled?: unknown;
|
||||
params?: unknown;
|
||||
fromCarve?: unknown;
|
||||
fromPreset?: unknown;
|
||||
label?: unknown;
|
||||
};
|
||||
if (typeof node.type !== "string" || !BY_ID.has(node.type)) {
|
||||
throw new AudioFxChainError(`Node ${i} has unknown effect type: ${String(node.type)}`);
|
||||
@@ -870,6 +883,13 @@ export function parseAudioFxChain(json: string): HfAudioFxChain {
|
||||
type: node.type,
|
||||
...(typeof node.id === "string" && node.id ? { id: node.id } : {}),
|
||||
...(node.fromCarve === true ? { fromCarve: true as const } : {}),
|
||||
// Both survive the round trip or a preset stops being able to find its
|
||||
// own nodes after a reload: re-applying would stack a second copy and
|
||||
// the rack would lose the grouping it braces them with.
|
||||
...(typeof node.fromPreset === "string" && node.fromPreset
|
||||
? { fromPreset: node.fromPreset }
|
||||
: {}),
|
||||
...(typeof node.label === "string" && node.label ? { label: node.label } : {}),
|
||||
enabled: node.enabled !== false,
|
||||
params: normalizeAudioFxParams(
|
||||
node.type,
|
||||
@@ -893,6 +913,8 @@ export function serializeAudioFxChain(chain: HfAudioFxChain): string {
|
||||
type: node.type,
|
||||
...(node.id ? { id: node.id } : {}),
|
||||
...(node.fromCarve === true ? { fromCarve: true } : {}),
|
||||
...(node.fromPreset ? { fromPreset: node.fromPreset } : {}),
|
||||
...(node.label ? { label: node.label } : {}),
|
||||
...(node.enabled === false ? { enabled: false } : {}),
|
||||
params: normalizeAudioFxParams(node.type, node.params),
|
||||
})),
|
||||
|
||||
@@ -94,14 +94,58 @@ describe("the catalogue is internally valid", () => {
|
||||
}
|
||||
});
|
||||
|
||||
it("survives being written to an attribute and read back", () => {
|
||||
it("survives being written to an attribute and read back, TAGS AND ALL", () => {
|
||||
// Comparing only types is what let `fromPreset` be silently dropped by the
|
||||
// parser: every preset round-tripped its effects while losing the tag that
|
||||
// lets it find its own nodes again. Compare what the rack actually needs.
|
||||
for (const p of HF_AUDIO_FX_PRESETS) {
|
||||
const chain = applyAudioFxPreset(empty(), p);
|
||||
const back = parseAudioFxChain(serializeAudioFxChain(chain));
|
||||
expect(
|
||||
back.nodes.map((n) => n.type),
|
||||
back.nodes.map((x) => ({
|
||||
type: x.type,
|
||||
id: x.id,
|
||||
fromPreset: x.fromPreset,
|
||||
label: x.label,
|
||||
})),
|
||||
`${p.id} did not round-trip`,
|
||||
).toEqual(chain.nodes.map((n) => n.type));
|
||||
).toEqual(
|
||||
chain.nodes.map((x) => ({
|
||||
type: x.type,
|
||||
id: x.id,
|
||||
fromPreset: x.fromPreset,
|
||||
label: x.label,
|
||||
})),
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
it("names every node for the job it is doing", () => {
|
||||
for (const p of HF_AUDIO_FX_PRESETS) {
|
||||
for (const node of p.nodes) {
|
||||
expect(node.label, `${p.id}: a ${node.type} node has no job name`).toBeTruthy();
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("never shows the same name twice in one chain", () => {
|
||||
// The failure this exists to prevent: a rack reading "Shape One Range"
|
||||
// twice, once cutting mud and once adding clarity, with nothing to tell
|
||||
// them apart. Identical CONSECUTIVE nodes are exempt — a stacked pair is
|
||||
// one stage built from two biquads, not two jobs.
|
||||
for (const p of HF_AUDIO_FX_PRESETS) {
|
||||
const seen = new Map<string, number>();
|
||||
p.nodes.forEach((node, i) => {
|
||||
const key = node.label ?? node.type;
|
||||
const prev = seen.get(key);
|
||||
const stackedPair =
|
||||
prev === i - 1 && JSON.stringify(p.nodes[prev]?.params) === JSON.stringify(node.params);
|
||||
expect(
|
||||
prev === undefined || stackedPair,
|
||||
`${p.id} shows "${key}" twice — an author cannot tell the two apart`,
|
||||
).toBe(true);
|
||||
seen.set(key, i);
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
@@ -156,6 +200,7 @@ describe("applying a preset", () => {
|
||||
// complete node rather than a partial one the graph has to guess at.
|
||||
expect(node.params).toEqual({ ...normalizeAudioFxParams("highpass", {}), frequency: 100 });
|
||||
expect(node.fromPreset).toBe("rumble-cut");
|
||||
expect(node.label).toBe("Cut Rumble");
|
||||
expect(node.enabled).toBe(true);
|
||||
});
|
||||
|
||||
|
||||
@@ -44,6 +44,15 @@ export type HfAudioFxPresetFamily = "voice" | "repair" | "character" | "space";
|
||||
export interface HfAudioFxPresetNode {
|
||||
/** Effect id from HF_AUDIO_FX. */
|
||||
type: string;
|
||||
/**
|
||||
* What the rack calls this node — the JOB it is doing, not its filter type.
|
||||
*
|
||||
* A peaking filter is "Shape One Range" wherever it appears, so a chain that
|
||||
* cuts mud and then lifts clarity shows the same words twice and an author
|
||||
* cannot follow it. Naming each node for its job is what lets a preset read
|
||||
* as a list of things that were done.
|
||||
*/
|
||||
label?: string;
|
||||
/** Only what this preset means to set; the rest come from the effect's defaults. */
|
||||
params?: HfAudioFxParamValues;
|
||||
}
|
||||
@@ -70,9 +79,13 @@ const preset = (
|
||||
* because a BiquadFilterNode is two-pole and that is the honest maximum for one
|
||||
* node. The telephone band wants the steeper slope, so it pays for two.
|
||||
*/
|
||||
const steep = (type: "highpass" | "lowpass", frequency: number): HfAudioFxPresetNode[] => [
|
||||
{ type, params: { frequency, q: 0.707, poles: "2" } },
|
||||
{ type, params: { frequency, q: 0.707, poles: "2" } },
|
||||
const steep = (
|
||||
type: "highpass" | "lowpass",
|
||||
frequency: number,
|
||||
label: string,
|
||||
): HfAudioFxPresetNode[] => [
|
||||
{ type, label, params: { frequency, q: 0.707, poles: "2" } },
|
||||
{ type, label, params: { frequency, q: 0.707, poles: "2" } },
|
||||
];
|
||||
|
||||
export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
@@ -83,14 +96,15 @@ export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
"Clean Voice",
|
||||
"Cuts rumble and mud, evens out the level, adds a little clarity.",
|
||||
[
|
||||
{ type: "highpass", params: { frequency: 80, q: 0.707, poles: "2" } },
|
||||
{ type: "peaking", params: { frequency: 250, gain: -3, q: 1.2 } },
|
||||
{ type: "highpass", label: "Remove Rumble", params: { frequency: 80, q: 0.707, poles: "2" } },
|
||||
{ type: "peaking", label: "Reduce Mud", params: { frequency: 250, gain: -3, q: 1.2 } },
|
||||
{
|
||||
type: "compressor",
|
||||
label: "Even Out Loudness",
|
||||
params: { threshold: -20, ratio: 3, attack: 12, release: 180, makeup: 3 },
|
||||
},
|
||||
{ type: "peaking", params: { frequency: 3000, gain: 2.5, q: 1 } },
|
||||
{ type: "limiter", params: { limit: -1, attack: 5, release: 50 } },
|
||||
{ type: "peaking", label: "Add Clarity", params: { frequency: 3000, gain: 2.5, q: 1 } },
|
||||
{ type: "limiter", label: "Peak Ceiling", params: { limit: -1, attack: 5, release: 50 } },
|
||||
],
|
||||
),
|
||||
preset(
|
||||
@@ -99,16 +113,17 @@ export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
"Broadcast",
|
||||
"Denser and more forward — a radio-presenter sound.",
|
||||
[
|
||||
{ type: "highpass", params: { frequency: 90, q: 0.707, poles: "2" } },
|
||||
{ type: "peaking", params: { frequency: 400, gain: -3, q: 1.4 } },
|
||||
{ type: "highpass", label: "Remove Rumble", params: { frequency: 90, q: 0.707, poles: "2" } },
|
||||
{ type: "peaking", label: "Reduce Boxiness", params: { frequency: 400, gain: -3, q: 1.4 } },
|
||||
{
|
||||
type: "compressor",
|
||||
label: "Even Out Loudness",
|
||||
params: { threshold: -24, ratio: 4, attack: 8, release: 150, makeup: 5 },
|
||||
},
|
||||
{ type: "peaking", params: { frequency: 2500, gain: 3, q: 0.9 } },
|
||||
{ type: "highshelf", params: { frequency: 8000, gain: 2 } },
|
||||
{ type: "saturate", params: { type: "tanh", threshold: -12, output: 0 } },
|
||||
{ type: "limiter", params: { limit: -1, attack: 5, release: 60 } },
|
||||
{ type: "peaking", label: "Add Clarity", params: { frequency: 2500, gain: 3, q: 0.9 } },
|
||||
{ type: "highshelf", label: "Add Air", params: { frequency: 8000, gain: 2 } },
|
||||
{ type: "saturate", label: "Warmth", params: { type: "tanh", threshold: -12, output: 0 } },
|
||||
{ type: "limiter", label: "Peak Ceiling", params: { limit: -1, attack: 5, release: 60 } },
|
||||
],
|
||||
),
|
||||
preset(
|
||||
@@ -117,14 +132,15 @@ export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
"Close & Warm",
|
||||
"Intimate and lightly handled, for a voice close to the mic.",
|
||||
[
|
||||
{ type: "highpass", params: { frequency: 70, q: 0.707, poles: "2" } },
|
||||
{ type: "lowshelf", params: { frequency: 180, gain: 2 } },
|
||||
{ type: "highpass", label: "Remove Rumble", params: { frequency: 70, q: 0.707, poles: "2" } },
|
||||
{ type: "lowshelf", label: "Add Weight", params: { frequency: 180, gain: 2 } },
|
||||
{
|
||||
type: "compressor",
|
||||
label: "Even Out Loudness",
|
||||
params: { threshold: -18, ratio: 2.5, attack: 20, release: 250, makeup: 2 },
|
||||
},
|
||||
{ type: "peaking", params: { frequency: 3000, gain: 1.5, q: 0.8 } },
|
||||
{ type: "limiter", params: { limit: -1.5 } },
|
||||
{ type: "peaking", label: "Add Clarity", params: { frequency: 3000, gain: 1.5, q: 0.8 } },
|
||||
{ type: "limiter", label: "Peak Ceiling", params: { limit: -1.5 } },
|
||||
],
|
||||
),
|
||||
|
||||
@@ -137,28 +153,34 @@ export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
"repair",
|
||||
"Cut Rumble",
|
||||
"Removes traffic, handling and air-conditioning from under a voice.",
|
||||
[{ type: "highpass", params: { frequency: 100, q: 0.707, poles: "2" } }],
|
||||
[{ type: "highpass", label: "Cut Rumble", params: { frequency: 100, q: 0.707, poles: "2" } }],
|
||||
),
|
||||
preset(
|
||||
"room-gate",
|
||||
"repair",
|
||||
"Quiet Between Phrases",
|
||||
"Silences the gaps between words. Room tone under speech stays — this closes the pauses, it does not remove noise.",
|
||||
[{ type: "gate", params: { threshold: -45, range: -18, ratio: 10, attack: 2, release: 180 } }],
|
||||
[
|
||||
{
|
||||
type: "gate",
|
||||
label: "Silence the Gaps",
|
||||
params: { threshold: -45, range: -18, ratio: 10, attack: 2, release: 180 },
|
||||
},
|
||||
],
|
||||
),
|
||||
preset(
|
||||
"boom-tame",
|
||||
"repair",
|
||||
"Tame Boominess",
|
||||
"Takes out the chestiness of a voice too close to the mic.",
|
||||
[{ type: "peaking", params: { frequency: 200, gain: -4, q: 1.4 } }],
|
||||
[{ type: "peaking", label: "Tame Boominess", params: { frequency: 200, gain: -4, q: 1.4 } }],
|
||||
),
|
||||
preset(
|
||||
"harsh-tame",
|
||||
"repair",
|
||||
"Soften Harshness",
|
||||
"Rounds off a brittle upper-mid. Broad and always-on; sibilance proper wants the measuring version.",
|
||||
[{ type: "peaking", params: { frequency: 3200, gain: -3, q: 1.6 } }],
|
||||
[{ type: "peaking", label: "Soften Harshness", params: { frequency: 3200, gain: -3, q: 1.6 } }],
|
||||
),
|
||||
|
||||
// ------------------------------------------------------------ character --
|
||||
@@ -168,18 +190,26 @@ export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
"Telephone",
|
||||
"Down the line — the narrow band of a phone call.",
|
||||
[
|
||||
...steep("highpass", 300),
|
||||
...steep("lowpass", 3400),
|
||||
{ type: "peaking", params: { frequency: 1200, gain: 6, q: 1.2 } },
|
||||
{ type: "peaking", params: { frequency: 550, gain: -4, q: 1 } },
|
||||
{ type: "saturate", params: { type: "tanh", threshold: -18, output: -2 } },
|
||||
...steep("highpass", 300, "Strip the Bass"),
|
||||
...steep("lowpass", 3400, "Strip the Treble"),
|
||||
{ type: "peaking", label: "Phone Honk", params: { frequency: 1200, gain: 6, q: 1.2 } },
|
||||
{ type: "peaking", label: "De-mud", params: { frequency: 550, gain: -4, q: 1 } },
|
||||
{
|
||||
type: "saturate",
|
||||
label: "Circuit Grit",
|
||||
params: { type: "tanh", threshold: -18, output: -2 },
|
||||
},
|
||||
],
|
||||
),
|
||||
preset("radio-am", "character", "AM Radio", "Narrow, gritty and a little crushed.", [
|
||||
{ type: "highpass", params: { frequency: 400, q: 0.707, poles: "2" } },
|
||||
{ type: "lowpass", params: { frequency: 3000, q: 0.707, poles: "2" } },
|
||||
{ type: "saturate", params: { type: "tanh", threshold: -15, output: -2 } },
|
||||
{ type: "bitcrush", params: { bits: 10, samples: 1, mix: 0.25 } },
|
||||
{ type: "highpass", label: "Strip the Bass", params: { frequency: 400, q: 0.707, poles: "2" } },
|
||||
{
|
||||
type: "lowpass",
|
||||
label: "Strip the Treble",
|
||||
params: { frequency: 3000, q: 0.707, poles: "2" },
|
||||
},
|
||||
{ type: "saturate", label: "Radio Grit", params: { type: "tanh", threshold: -15, output: -2 } },
|
||||
{ type: "bitcrush", label: "Crunch", params: { bits: 10, samples: 1, mix: 0.25 } },
|
||||
]),
|
||||
preset(
|
||||
"megaphone",
|
||||
@@ -187,11 +217,23 @@ export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
"Megaphone",
|
||||
"Shouted through a horn, with the slap that comes with it.",
|
||||
[
|
||||
{ type: "highpass", params: { frequency: 500, q: 0.707, poles: "2" } },
|
||||
{ type: "lowpass", params: { frequency: 4000, q: 0.707, poles: "2" } },
|
||||
{ type: "peaking", params: { frequency: 1800, gain: 8, q: 1.5 } },
|
||||
{ type: "saturate", params: { type: "hard", threshold: -12, output: -3 } },
|
||||
{ type: "delay", params: { time: 40, feedback: 0.15, mix: 0.15 } },
|
||||
{
|
||||
type: "highpass",
|
||||
label: "Strip the Bass",
|
||||
params: { frequency: 500, q: 0.707, poles: "2" },
|
||||
},
|
||||
{
|
||||
type: "lowpass",
|
||||
label: "Strip the Treble",
|
||||
params: { frequency: 4000, q: 0.707, poles: "2" },
|
||||
},
|
||||
{ type: "peaking", label: "Horn Honk", params: { frequency: 1800, gain: 8, q: 1.5 } },
|
||||
{
|
||||
type: "saturate",
|
||||
label: "Overdrive",
|
||||
params: { type: "hard", threshold: -12, output: -3 },
|
||||
},
|
||||
{ type: "delay", label: "Horn Slap", params: { time: 40, feedback: 0.15, mix: 0.15 } },
|
||||
],
|
||||
),
|
||||
preset(
|
||||
@@ -200,48 +242,86 @@ export const HF_AUDIO_FX_PRESETS: readonly HfAudioFxPreset[] = [
|
||||
"Tape",
|
||||
"Worn, warm and slightly unsteady, like a played-out cassette.",
|
||||
[
|
||||
{ type: "lowpass", params: { frequency: 6500, q: 0.707, poles: "2" } },
|
||||
{ type: "lowshelf", params: { frequency: 120, gain: 2 } },
|
||||
{ type: "saturate", params: { type: "tanh", threshold: -14, output: 0 } },
|
||||
{ type: "bitcrush", params: { bits: 12, samples: 2, mix: 0.35 } },
|
||||
{ type: "lowpass", label: "Tape Rolloff", params: { frequency: 6500, q: 0.707, poles: "2" } },
|
||||
{ type: "lowshelf", label: "Add Weight", params: { frequency: 120, gain: 2 } },
|
||||
{
|
||||
type: "saturate",
|
||||
label: "Tape Warmth",
|
||||
params: { type: "tanh", threshold: -14, output: 0 },
|
||||
},
|
||||
{ type: "bitcrush", label: "Tape Noise", params: { bits: 12, samples: 2, mix: 0.35 } },
|
||||
// A slow, shallow chorus is what wow and flutter actually are.
|
||||
{ type: "chorus", params: { delay: 6, depth: 0.6, speed: 0.4, mix: 0.15 } },
|
||||
{
|
||||
type: "chorus",
|
||||
label: "Wow & Flutter",
|
||||
params: { delay: 6, depth: 0.6, speed: 0.4, mix: 0.15 },
|
||||
},
|
||||
],
|
||||
),
|
||||
preset("pa-system", "character", "Tannoy", "Announced across a concourse.", [
|
||||
{ type: "highpass", params: { frequency: 350, q: 0.707, poles: "2" } },
|
||||
{ type: "lowpass", params: { frequency: 3500, q: 0.707, poles: "2" } },
|
||||
{ type: "peaking", params: { frequency: 1500, gain: 5, q: 1.2 } },
|
||||
{ type: "saturate", params: { type: "tanh", threshold: -16, output: -1 } },
|
||||
{ type: "reverb", params: { size: 0.5, damping: 0.7, wet: 0.25, dry: 0.8 } },
|
||||
{ type: "highpass", label: "Strip the Bass", params: { frequency: 350, q: 0.707, poles: "2" } },
|
||||
{
|
||||
type: "lowpass",
|
||||
label: "Strip the Treble",
|
||||
params: { frequency: 3500, q: 0.707, poles: "2" },
|
||||
},
|
||||
{ type: "peaking", label: "Tannoy Honk", params: { frequency: 1500, gain: 5, q: 1.2 } },
|
||||
{
|
||||
type: "saturate",
|
||||
label: "Driver Grit",
|
||||
params: { type: "tanh", threshold: -16, output: -1 },
|
||||
},
|
||||
{
|
||||
type: "reverb",
|
||||
label: "Concourse",
|
||||
params: { size: 0.5, damping: 0.7, wet: 0.25, dry: 0.8 },
|
||||
},
|
||||
]),
|
||||
preset("intercom", "character", "Intercom", "Buzzed through a door panel, squelch and all.", [
|
||||
{ type: "gate", params: { threshold: -40, range: -30, ratio: 10, attack: 1, release: 120 } },
|
||||
{ type: "highpass", params: { frequency: 500, q: 0.707, poles: "2" } },
|
||||
{ type: "lowpass", params: { frequency: 3000, q: 0.707, poles: "2" } },
|
||||
{ type: "peaking", params: { frequency: 2000, gain: 6, q: 2 } },
|
||||
{ type: "bitcrush", params: { bits: 11, samples: 1, mix: 0.3 } },
|
||||
{
|
||||
type: "gate",
|
||||
label: "Squelch",
|
||||
params: { threshold: -40, range: -30, ratio: 10, attack: 1, release: 120 },
|
||||
},
|
||||
{ type: "highpass", label: "Strip the Bass", params: { frequency: 500, q: 0.707, poles: "2" } },
|
||||
{
|
||||
type: "lowpass",
|
||||
label: "Strip the Treble",
|
||||
params: { frequency: 3000, q: 0.707, poles: "2" },
|
||||
},
|
||||
{ type: "peaking", label: "Panel Honk", params: { frequency: 2000, gain: 6, q: 2 } },
|
||||
{ type: "bitcrush", label: "Crunch", params: { bits: 11, samples: 1, mix: 0.3 } },
|
||||
]),
|
||||
|
||||
// ---------------------------------------------------------------- space --
|
||||
preset("room-tight", "space", "Tight Room", "A small hard room — presence without wash.", [
|
||||
{ type: "reverb", params: { size: 0.25, damping: 0.6, wet: 0.18, dry: 0.9 } },
|
||||
{
|
||||
type: "reverb",
|
||||
label: "Tight Room",
|
||||
params: { size: 0.25, damping: 0.6, wet: 0.18, dry: 0.9 },
|
||||
},
|
||||
]),
|
||||
preset(
|
||||
"room-natural",
|
||||
"space",
|
||||
"Natural Room",
|
||||
"Sounds recorded somewhere rather than nowhere.",
|
||||
[{ type: "reverb", params: { size: 0.5, damping: 0.5, wet: 0.25, dry: 0.85 } }],
|
||||
[
|
||||
{
|
||||
type: "reverb",
|
||||
label: "Natural Room",
|
||||
params: { size: 0.5, damping: 0.5, wet: 0.25, dry: 0.85 },
|
||||
},
|
||||
],
|
||||
),
|
||||
preset("hall", "space", "Hall", "Long and open, for something that should sit far back.", [
|
||||
{ type: "reverb", params: { size: 0.9, damping: 0.3, wet: 0.4, dry: 0.75 } },
|
||||
{ type: "reverb", label: "Hall", params: { size: 0.9, damping: 0.3, wet: 0.4, dry: 0.75 } },
|
||||
]),
|
||||
preset("slap-echo", "space", "Slap Echo", "One quick repeat — rockabilly vocal, not a wash.", [
|
||||
{ type: "delay", params: { time: 110, feedback: 0.12, mix: 0.22 } },
|
||||
{ type: "delay", label: "Slap Echo", params: { time: 110, feedback: 0.12, mix: 0.22 } },
|
||||
]),
|
||||
preset("dub-throw", "space", "Dub Throw", "Repeats that trail off well behind the beat.", [
|
||||
{ type: "delay", params: { time: 375, feedback: 0.55, mix: 0.3 } },
|
||||
{ type: "delay", label: "Dub Throw", params: { time: 375, feedback: 0.55, mix: 0.3 } },
|
||||
]),
|
||||
];
|
||||
|
||||
@@ -289,6 +369,7 @@ export function audioFxPresetNodes(
|
||||
type: node.type,
|
||||
id: mintAudioFxNodeId(running),
|
||||
fromPreset: preset.id,
|
||||
...(node.label ? { label: node.label } : {}),
|
||||
enabled: true,
|
||||
params: normalizeAudioFxParams(node.type, node.params),
|
||||
};
|
||||
|
||||
@@ -250,6 +250,38 @@ describe("FxSection chain", () => {
|
||||
expect(next.nodes.map((n) => n.type)).toEqual(["reverb", "highpass"]);
|
||||
});
|
||||
|
||||
it("shows a preset node by the job it is doing, not its filter type", () => {
|
||||
const { host } = mount({
|
||||
chain: {
|
||||
version: 1,
|
||||
nodes: [
|
||||
{
|
||||
type: "peaking",
|
||||
id: "a",
|
||||
label: "Reduce Mud",
|
||||
enabled: true,
|
||||
params: defaultAudioFxParams("peaking"),
|
||||
},
|
||||
{
|
||||
type: "peaking",
|
||||
id: "b",
|
||||
label: "Add Clarity",
|
||||
enabled: true,
|
||||
params: defaultAudioFxParams("peaking"),
|
||||
},
|
||||
],
|
||||
} as HfAudioFxChain,
|
||||
});
|
||||
const names = Array.from(host.querySelectorAll(".hf-fx-node-name")).map((e) =>
|
||||
e.textContent?.trim(),
|
||||
);
|
||||
// Without the label both rows read "Peaking EQ" and an author cannot tell
|
||||
// which one is cutting and which is lifting.
|
||||
expect(names).toContain("Reduce Mud");
|
||||
expect(names).toContain("Add Clarity");
|
||||
expect(names).not.toContain("Peaking EQ");
|
||||
});
|
||||
|
||||
it("cannot move the ends past themselves", () => {
|
||||
const { host } = mount({ chain: chainOf("peaking", "reverb") });
|
||||
const ups = host.querySelectorAll('.hf-fx-move[title="Move up"]');
|
||||
|
||||
@@ -591,7 +591,9 @@ function FxNodeRow({
|
||||
data-fx-node={node.type}
|
||||
>
|
||||
<FxNodeHeader
|
||||
label={def.label}
|
||||
// The node's own job name when a preset gave it one: a chain that cuts
|
||||
// mud and then lifts clarity must not show "Peaking EQ" twice.
|
||||
label={node.label ?? def.label}
|
||||
open={open}
|
||||
bypassed={bypassed}
|
||||
first={index === 0}
|
||||
|
||||
Reference in New Issue
Block a user