refactor(skills): move product-launch / pr-to-video / faceless-explainer onto the script-driven architecture (#1635)

* refactor(product-launch-video): restructure onto script-driven architecture

Move product-launch-video onto the shared script-driven authoring flow:
build-frame remixes a hyperframes-creative preset onto brand tokens, audio
routes through the shared hyperframes-media engine, per-preset caption skins,
and every frame is authored as a directed shot. Removes the old bespoke
scripts (captions/validate/prep/hoist/…) in favour of the shared lib.

assemble-index.mjs keeps upstream #1629's blank/partial scene-file guard
(reject an empty or markup-less scene file at assembly, before emitting
data-composition-src, and re-dispatch) carried onto the restructured reader.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(pr-to-video): restructure onto script-driven architecture

Move pr-to-video onto the shared script-driven authoring flow: ingest.mjs
folds the gh PR artifacts into the synthetic capture package the shared
backend (build-frame / captions / assemble-index) reads, add the mechanism
beat, route audio through hyperframes-media, and remix a hyperframes-creative
preset onto brand tokens via the shared lib.

- Fix skill name: pr-to-video-refactor -> pr-to-video (match directory).
- Drop a stale faceless-explainer-refactor reference in an ingest.mjs comment.
- assemble-index.mjs keeps upstream #1629's blank/partial scene-file guard.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(faceless-explainer): restructure onto script-driven architecture

Move faceless-explainer onto the shared script-driven authoring flow:
every visual is invented (typography / abstract graphics / diagram / data-viz)
and authored through the shared backend (build-frame remixes a
hyperframes-creative preset onto tokens, audio via hyperframes-media,
assemble-index builds the standalone index.html) using the shared lib.

- Fix skill name: faceless-explainer-refactor -> faceless-explainer (match directory).
- assemble-index.mjs keeps upstream #1629's blank/partial scene-file guard.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(skills): refresh test-skills-fresh.sh workflow roster

Update the install-and-verify harness to the current surface: 10 workflows
(adds website-to-video, embedded-captions, graphic-overlays, slideshow;
drops the removed footage-recut) and refreshed example prompts.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* style(product-launch-video): oxfmt storyboard.mjs

Run oxfmt over lib/storyboard.mjs — formatting only, no logic change.
Fixes the Format / Preflight CI check.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(studio): import commitGsapPositionFromDrag from its actual module

The function was split out into gsapDragPositionCommit.ts in #1605, but the
test kept importing it from ./gsapDragCommit, which no longer exports it —
yielding 'is not a function' at runtime. Import from the correct module.

Inherited main breakage (same fix as #1631); fixes the Test CI check on this
branch independently of merge order.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(hyperframes): refine router skill metadata tags

Update the entry router's metadata tags (video / animation / router focus);
oxfmt collapses the now-shorter metadata to a single line.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(skills): tighten caption comment-strip + document audio --only merge

Review follow-ups (#1635):

- captions.mjs (x3): the HTML-comment strip used a single global replace, which
  CodeQL flags as incomplete multi-character sanitization (a nested/partial pair
  can re-form a marker the single pass misses). Strip in a fixpoint loop instead.
  Input is preset-library content, not user-controlled, so this is lint-
  cleanliness, not XSS defense.
- audio.mjs (x3): document that fetch-sfx (--only sfx) MERGES into the neutral
  audio_engine_meta.json sidecar — the engine reads prev and recomputes only the
  sfx section, so voices/bgm from the generate pass are preserved (review Q).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(skills): remove existsSync->write TOCTOU in workflow scripts

Clears the 9 js/file-system-race CodeQL alerts (captions/audio/transitions x3).
Each was an existsSync precheck followed by a later write of the same path:

- captions.mjs: caption-overrides shim -> atomic writeFileSync({ flag: 'wx' }).
- audio.mjs (sync-durations) + transitions.mjs (inject): drop the existsSync
  precheck and read directly, surfacing the same friendly error from a try/catch
  on readFileSync — no check->write gap.

Behavior is unchanged (same error messages); these are local single-process
deterministic scripts so the race was never a real risk, but this clears the gate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(skills): paint root composition ground color in assemble-index

Per-frame roots carry data-start/data-duration and get clip-gated against the
global timeline at render, so only the first frame's window overlaps global 0 —
a frame's own full-bleed background can't serve as the video ground, and every
frame after the first renders on the bare body color (black). Paint the ground
on the always-present root composition using the project's frame.md canvas color
(the same role the caption skin maps to --cap-canvas); fall back to the body
letterbox color when frame.md is absent or has no resolvable ground.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(hyperframes): drop router-tag edit (moved to the foundation PR)

The entry SKILL.md is rewritten wholesale by the frame-presets/media foundation
PR (#1632); editing it here too guaranteed a merge conflict. Restore this file
to main and let the router-tag tweak live with the rewrite in #1632, so the two
PRs no longer both touch it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

skills/pr-to-video/scripts/fetch-people-avatars.mjs

@@ -1,9 +1,9 @@
 #!/usr/bin/env node
-// Phase 1 — contributor avatar fetch (NETWORK; orchestrator-invoked).
+// Step 1 — contributor avatar fetch (NETWORK; orchestrator-invoked).
 //
 // The counterpart to ingest.mjs: ingest is a pure offline transform, THIS is the
 // one network step on the people front. It reads the people list ingest produced
-// and downloads each contributor's GitHub avatar into public/avatars/<login>.png,
+// and downloads each contributor's GitHub avatar into assets/<login>.png,
 // then rewrites people.json with `avatarFetched` flags so downstream (story-design)
 // knows which avatars actually exist.
 //
@@ -15,14 +15,14 @@
 // Reads:
 //   --people <path>      capture/extracted/people.json (from ingest.mjs)
 // Writes:
-//   public/avatars/<login>.png    one per contributor whose avatar resolved
+//   assets/<login>.png    one per contributor whose avatar resolved
 //   (rewrites people.json in place with avatarFetched: true/false)
 //
 // Flags: --project-dir .  --timeout 8000 (ms per request)
 //   Avatars are written to <project-dir>/<person.avatarFile>, where avatarFile is
-//   the project-root-relative "public/avatars/<login>.png" — the SAME anchor prep.mjs
-//   resolves assetCandidates against (join(projectRoot, cand.path)). Anchor on the
-//   project root, NOT on public/, or the path doubles to public/public/.
+//   the project-root-relative "assets/<login>.png" — the SAME assets/ dir the frame
+//   workers reference and assemble-index stages (lib/assets.mjs). Anchor on the
+//   project root so the path stays under the project's assets/.
 //
 // Usage (orchestrator already cd'd into PROJECT_DIR, so --project-dir defaults to "."):
 //   node fetch-people-avatars.mjs --people ./capture/extracted/people.json
@@ -61,9 +61,9 @@ if (!people.length) softExit("no contributors in people.json — skipping");
 async function fetchOne(person) {
   const { login, avatarUrl } = person;
   if (!login || !avatarUrl) return "skip";
-  // avatarFile is project-root-relative ("public/avatars/<login>.png"); anchor on
-  // the project root so it does not double to public/public/.
-  const dest = join(projectDir, person.avatarFile || `public/avatars/${login}.png`);
+  // avatarFile is project-root-relative ("assets/<login>.png"); anchor on the
+  // project root so it stays under the project's assets/ dir.
+  const dest = join(projectDir, person.avatarFile || `assets/${login}.png`);
   mkdirSync(dirname(dest), { recursive: true });
   // Idempotent: a non-empty file from a prior run is reused (re-runs are free).
   if (existsSync(dest) && statSync(dest).size > 0) {
@@ -113,7 +113,7 @@ try {
 }
 
 console.log(
-  `✓ fetch-avatars: ${ok + cached}/${people.length} avatar(s) in public/avatars/` +
+  `✓ fetch-avatars: ${ok + cached}/${people.length} avatar(s) in assets/` +
     ` (${ok} new, ${cached} cached, ${fail} failed)`,
 );
 process.exit(0);