mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-13 07:40:06 +00:00
refactor(skills): move product-launch / pr-to-video / faceless-explainer onto the script-driven architecture (#1635)
* refactor(product-launch-video): restructure onto script-driven architecture Move product-launch-video onto the shared script-driven authoring flow: build-frame remixes a hyperframes-creative preset onto brand tokens, audio routes through the shared hyperframes-media engine, per-preset caption skins, and every frame is authored as a directed shot. Removes the old bespoke scripts (captions/validate/prep/hoist/…) in favour of the shared lib. assemble-index.mjs keeps upstream #1629's blank/partial scene-file guard (reject an empty or markup-less scene file at assembly, before emitting data-composition-src, and re-dispatch) carried onto the restructured reader. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(pr-to-video): restructure onto script-driven architecture Move pr-to-video onto the shared script-driven authoring flow: ingest.mjs folds the gh PR artifacts into the synthetic capture package the shared backend (build-frame / captions / assemble-index) reads, add the mechanism beat, route audio through hyperframes-media, and remix a hyperframes-creative preset onto brand tokens via the shared lib. - Fix skill name: pr-to-video-refactor -> pr-to-video (match directory). - Drop a stale faceless-explainer-refactor reference in an ingest.mjs comment. - assemble-index.mjs keeps upstream #1629's blank/partial scene-file guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(faceless-explainer): restructure onto script-driven architecture Move faceless-explainer onto the shared script-driven authoring flow: every visual is invented (typography / abstract graphics / diagram / data-viz) and authored through the shared backend (build-frame remixes a hyperframes-creative preset onto tokens, audio via hyperframes-media, assemble-index builds the standalone index.html) using the shared lib. - Fix skill name: faceless-explainer-refactor -> faceless-explainer (match directory). - assemble-index.mjs keeps upstream #1629's blank/partial scene-file guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(skills): refresh test-skills-fresh.sh workflow roster Update the install-and-verify harness to the current surface: 10 workflows (adds website-to-video, embedded-captions, graphic-overlays, slideshow; drops the removed footage-recut) and refreshed example prompts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * style(product-launch-video): oxfmt storyboard.mjs Run oxfmt over lib/storyboard.mjs — formatting only, no logic change. Fixes the Format / Preflight CI check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(studio): import commitGsapPositionFromDrag from its actual module The function was split out into gsapDragPositionCommit.ts in #1605, but the test kept importing it from ./gsapDragCommit, which no longer exports it — yielding 'is not a function' at runtime. Import from the correct module. Inherited main breakage (same fix as #1631); fixes the Test CI check on this branch independently of merge order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(hyperframes): refine router skill metadata tags Update the entry router's metadata tags (video / animation / router focus); oxfmt collapses the now-shorter metadata to a single line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): tighten caption comment-strip + document audio --only merge Review follow-ups (#1635): - captions.mjs (x3): the HTML-comment strip used a single global replace, which CodeQL flags as incomplete multi-character sanitization (a nested/partial pair can re-form a marker the single pass misses). Strip in a fixpoint loop instead. Input is preset-library content, not user-controlled, so this is lint- cleanliness, not XSS defense. - audio.mjs (x3): document that fetch-sfx (--only sfx) MERGES into the neutral audio_engine_meta.json sidecar — the engine reads prev and recomputes only the sfx section, so voices/bgm from the generate pass are preserved (review Q). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): remove existsSync->write TOCTOU in workflow scripts Clears the 9 js/file-system-race CodeQL alerts (captions/audio/transitions x3). Each was an existsSync precheck followed by a later write of the same path: - captions.mjs: caption-overrides shim -> atomic writeFileSync({ flag: 'wx' }). - audio.mjs (sync-durations) + transitions.mjs (inject): drop the existsSync precheck and read directly, surfacing the same friendly error from a try/catch on readFileSync — no check->write gap. Behavior is unchanged (same error messages); these are local single-process deterministic scripts so the race was never a real risk, but this clears the gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(skills): paint root composition ground color in assemble-index Per-frame roots carry data-start/data-duration and get clip-gated against the global timeline at render, so only the first frame's window overlaps global 0 — a frame's own full-bleed background can't serve as the video ground, and every frame after the first renders on the bare body color (black). Paint the ground on the always-present root composition using the project's frame.md canvas color (the same role the caption skin maps to --cap-canvas); fall back to the body letterbox color when frame.md is absent or has no resolvable ground. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(hyperframes): drop router-tag edit (moved to the foundation PR) The entry SKILL.md is rewritten wholesale by the frame-presets/media foundation PR (#1632); editing it here too guaranteed a merge conflict. Restore this file to main and let the router-tag tweak live with the rewrite in #1632, so the two PRs no longer both touch it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
d0f0ec29e7
commit
1967901b57
@@ -1,11 +1,13 @@
|
||||
#!/usr/bin/env node
|
||||
// Phase 1 — PR ingest (deterministic; no subagent; NO network).
|
||||
// Step 1 — PR ingest (deterministic; no subagent; NO network).
|
||||
//
|
||||
// Pure transform. The orchestrator (SKILL.md Step 1) runs `gh` itself so auth /
|
||||
// not-found / private-repo errors surface with gh's own stderr; THIS script never
|
||||
// touches the network. It only folds the two gh artifacts into the synthetic
|
||||
// capture package the shared backend (build-design / prep) expects — exactly the
|
||||
// shape faceless-explainer's scaffold writes, so the whole downstream runs unchanged.
|
||||
// capture package the shared Gen-B backend (build-frame / captions / assemble-index)
|
||||
// expects — the same shape faceless-explainer's Step 1 writes by hand, so the
|
||||
// whole downstream runs unchanged. `capture/extracted/` is kept (no website was
|
||||
// captured — the PR is ingested into the same folder the engine reads by default).
|
||||
//
|
||||
// Reads:
|
||||
// --pr-json <path> gh pr view --json number,title,body,author,url,baseRefName,
|
||||
@@ -21,7 +23,7 @@
|
||||
// commenters / assignees — the PR `author` is only the opener, so
|
||||
// commit authors from commits[].authors[] are tracked separately),
|
||||
// bot-filtered + deduped, each with a GitHub avatar URL + intended
|
||||
// public/avatars/<login>.png path. The avatars themselves are
|
||||
// assets/<login>.png path. The avatars themselves are
|
||||
// downloaded by the orchestrator (fetch-people-avatars.mjs) — THIS
|
||||
// script stays offline. people.json + the avatars are the ONE place
|
||||
// the faceless default is relaxed: an optional credits/shipped-by close.
|
||||
@@ -243,7 +245,7 @@ const people = [...peopleMap.values()]
|
||||
// Unauthenticated avatar endpoint — redirects to the user's avatar; the
|
||||
// orchestrator's fetch-people-avatars.mjs downloads it here.
|
||||
avatarUrl: `https://github.com/${encodeURIComponent(p.login)}.png?size=200`,
|
||||
avatarFile: `public/avatars/${p.login}.png`,
|
||||
avatarFile: `assets/${p.login}.png`,
|
||||
avatarFetched: false, // set true by fetch-people-avatars.mjs once downloaded
|
||||
}))
|
||||
.sort((a, b) => primaryRoleRank(a.roles) - primaryRoleRank(b.roles));
|
||||
@@ -407,7 +409,7 @@ if (url) lines.push(`URL: ${url}`);
|
||||
lines.push("");
|
||||
|
||||
// People & reviews — human context for an optional credits / shipped-by close.
|
||||
// Avatars land in public/avatars/<login>.png (downloaded by the orchestrator).
|
||||
// Avatars land in assets/<login>.png (downloaded by the orchestrator).
|
||||
if (people.length) {
|
||||
lines.push("## People & reviews");
|
||||
const authorPerson = people.find((p) => p.roles.includes("author"));
|
||||
@@ -439,9 +441,7 @@ if (people.length) {
|
||||
lines.push(`Commenters: ${commentersOnly.map((p) => `@${p.login}`).join(", ")}`);
|
||||
if (reviewDecision) lines.push(`Review decision: ${reviewDecision}`);
|
||||
if (mergedByLogin) lines.push(`Merged by: @${mergedByLogin}`);
|
||||
lines.push(
|
||||
`Avatars: public/avatars/<login>.png (${people.length} contributor(s) — see people.json)`,
|
||||
);
|
||||
lines.push(`Avatars: assets/<login>.png (${people.length} contributor(s) — see people.json)`);
|
||||
if (botsFiltered.size) lines.push(`(bots filtered out: ${[...botsFiltered].join(", ")})`);
|
||||
lines.push("");
|
||||
}
|
||||
@@ -505,11 +505,6 @@ const tokens = {
|
||||
description: oneLiner,
|
||||
colors: [],
|
||||
fonts: [],
|
||||
headings: [],
|
||||
sections: [],
|
||||
ctas: [],
|
||||
svgs: [],
|
||||
cssVariables: {},
|
||||
};
|
||||
|
||||
// ---------- assemble people.json ----------
|
||||
|
||||
Reference in New Issue
Block a user