fix(compiler): don't scan media tags inside comments/scripts; DOM-check auto-start (#1938) (#1940)

The timing compiler scanned raw HTML with tag regexes that weren't
comment-aware, so a comment or script merely mentioning `<video>`/`<audio>`
was rewritten as a real element — injecting id/data-start/data-hf-auto-start
into the comment text. That phantom attribute then tripped the probe stage's
substring check (`html.includes("data-hf-auto-start")`), launching an
unnecessary browser probe on every render with an unexplained empty reasons list.

- Mask comments, <script>, and <style> regions before the tag scan, then
  restore them verbatim (compileTimingAttrs, extractResolvedMedia).
- Replace the probe's substring match with a DOM query
  (video[data-hf-auto-start]) and add "auto-start video(s)" to the reasons list.
This commit is contained in:
Miguel Ángel
2026-07-06 18:19:35 -04:00
committed by GitHub
parent afa7f292fb
commit 1a3330a972
4 changed files with 64 additions and 3 deletions
@@ -128,6 +128,35 @@ describe("compileTimingAttrs", () => {
expect(unresolved).toHaveLength(0);
});
it("ignores media tags mentioned inside comments (issue #1938)", () => {
const html =
"<!-- this comment mentions a <video> and an <audio> tag -->\n<p>no media here</p>";
const { html: compiled, unresolved } = compileTimingAttrs(html);
// Comment text is preserved verbatim — no id/data-start/data-hf-auto-start injected.
expect(compiled).toBe(html);
expect(compiled).not.toContain("data-hf-auto-start");
expect(unresolved).toHaveLength(0);
});
it("ignores media tags inside <script> string literals", () => {
const html = '<script>const x = "<video src=\\"a.mp4\\">";</script>';
const { html: compiled, unresolved } = compileTimingAttrs(html);
expect(compiled).toBe(html);
expect(unresolved).toHaveLength(0);
});
it("still compiles real media tags alongside a comment that mentions them", () => {
const html =
'<!-- a <video> in prose -->\n<video src="a.mp4" data-start="0" data-duration="2">';
const { html: compiled } = compileTimingAttrs(html);
expect(compiled).toContain("<!-- a <video> in prose -->");
expect(compiled).toContain('id="hf-video-0"');
expect(compiled).toContain('data-end="2"');
});
});
describe("injectDurations", () => {