mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-01 19:42:03 +00:00
feat(studio): select a time range on an automation lane (#3050)
* feat(core): audio FX registry One declarative description of every effect that can be applied to an audio track: fourteen across filters, dynamics, non-linear and time, each exposing its full parameter surface rather than a curated subset. Parameters carry the range, step, unit and scale a control needs, so a panel can generate its UI from this rather than hard-coding a form per effect, and a value that survives `normalizeAudioFxParams` is always safe to realise. Everything is declared in the units a person thinks in — dB, ms, Hz. Parsing rejects an unknown effect id rather than skipping the node. A chain that quietly loses an effect renders something other than what was authored, which is worse than refusing to load it. Data only: no audio is produced here. The graph that realises each effect is referenced by the `web` id and lands in the next change, which keeps this module free of browser globals so the engine and the linter can import it. * fix(core): stop declaring knobs that move nothing Three parameters were declared with ranges, defaults and hints, and read by no builder — dials an author could turn with no audible result. - `chorus.decay` and `bitcrush.aa`: removed. FFmpeg's chorus feeds a decay back into its delay line and a bitcrusher's anti-alias needs a real filter; adding either is new DSP, not a fix, so the honest move is to stop advertising them. - `lowshelf.q` / `highshelf.q`: removed. The Web Audio spec leaves Q unused for shelving filters, so the control moved nothing — and because the shared Q helper marks it automatable, an author could draw an envelope on it and hear nothing at all. `phaser.decay` and `gate.knee` stay: the first drives the sweep depth, and the second is now read by the gate's processor. A test asserts each of these directly, since the existing exposure invariant only checks that a flagged parameter reaches an AudioParam — a parameter the node then ignores passes it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(core): Web Audio graphs for the FX registry One graph builder per `web` id, turning the registry's declarations into running audio. Every node exposes `update`, so turning a dial re-parameterises the live graph rather than rebuilding it: an AudioParam change lands on the next 128-sample quantum, about 2.7 ms at 48 kHz. `buildFxChain` reports whether an update could be applied in place — adding or bypassing an effect, or switching a filter between one and two poles (which changes the node type from BiquadFilterNode to IIRFilterNode), changes the graph's shape and returns false so the caller rebuilds. Four effects have no native node and run as AudioWorklet processors: compressor, limiter, gate and bitcrush. The module is registered from a data: URL rather than a blob:, because a blob inherits the page origin and is opaque on a file:// page, where it fails with an unhelpful AbortError. Reverb has no single node either. `synthesizeReverbImpulse` generates a tail from the room parameters, seeded so the same room sounds the same on every machine, and the ConvolverNode uses it. Tests cover the wiring — which nodes get built, how they connect, parameter application and clamping, in-place update versus rebuild, disposal — against a fake AudioContext, since happy-dom has no Web Audio. * fix(core): reverb level, phaser wiring, per-channel dynamics, one-pole rebuild Four defects in the graph builders, all found by review rather than by ear. **Reverb was unusable at its own defaults.** A ConvolverNode applies the impulse's gain whole — the graph sets `normalize = false` so a room is deterministic rather than browser-defined — but the impulse was raw decaying noise. Measured L2 at the registry default (size 0.7 / damping 0.5): 46.4, or +33.3 dB, putting the wet path ~24 dB over dry at the default `wet: 0.35`. It is now normalised to unit energy, so the wet knob means what it says. Preview and render both convolve this buffer, so they stayed identical throughout — equally deafening before, equally correct now. **Phaser in_gain/out_gain trim the signal entering and leaving the effect**, not a wet/dry pair. Wired to the wet and dry legs, "Input" muted the dry path and the two defaults summed to 1.14, so inserting a phaser raised the track level. They are now input and output trims with the legs summed at unity. Its declared waveform is also honoured: `lfo.type` was never assigned, so the default "Triangular" was silently a sine. **The dynamics worklets held one envelope across a channel-major loop.** The followers advance per sample, so on stereo a 20 ms attack behaved as 10 ms, and the right channel's gain came from an envelope that had already traversed the left — the two ducked differently from the same input and the image pumped. State is now per channel, as is the gate's smoothed gain and bitcrush's sample-hold counter, which previously advanced only on the last channel and left every earlier one frozen for a whole quantum. The gate also honours the knee it declares instead of chattering on material sitting at the threshold. **A one-pole filter's cutoff was swallowed in preview.** Its coefficients are fixed at construction, so `update` cannot push a new frequency — but the shape signature carried only type and pole count, so a cutoff change looked like a values-only edit and went into a no-op updater. Preview kept filtering at the old frequency while the render used the new one: a preview/render divergence in exactly the two effects that do not use a BiquadFilterNode. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(engine): render audio FX in an OfflineAudioContext Reads `data-fx-chain` off an audio element and runs the chain over the trimmed WAV before volume automation is baked in — effects should see the raw signal, and the envelope belongs on their output. The processing happens in an OfflineAudioContext inside the headless browser the engine already drives, running the same graph builders the studio previews with. That is the point of the approach: one implementation per effect, so the render agreeing with the preview is a property of the architecture rather than a tolerance to police. Reimplementing each effect as an FFmpeg filter would mean two implementations to keep in step, and for the dynamics processors and modulated delays there is no filter that behaves the same way. `build:audio-fx-runtime` bundles the graph builders into an injectable IIFE, following the same pattern as the existing runtime artifacts, so the browser runs exactly the code the studio does. The page loads from a file:// URL rather than about:blank because AudioWorklet is only exposed in a secure context — the compressor, limiter, gate and bitcrush processors would otherwise fail to register with an opaque error. file:// qualifies and needs no listening socket. The chain is serialised into the attribute the way colour grading carries its config, so there is no side-car file to resolve or lose. An FX failure is fatal for the whole mix rather than a per-track soft failure. Every other audio failure mode degrades gracefully — the track drops, siblings continue — but substituting the dry signal for a processed one ships a render that sounds plausible and is not what the author set up. Since the per-element work races under Promise.all, an internal AbortController chained off the caller's signal aborts in-flight siblings before workDir is removed. * feat(core): voiceover carve analysis Finds the bands a voice occupies so a music bed can be dipped there, letting the voice sit in front without ducking the whole track. Carve is a relationship between two tracks rather than an effect on one, so it stays out of the FX chain. What it emits is an ordinary chain of peaking filters, so a carve composes with whatever else is on the track and needs no separate rendering path. Selection is weighted toward intelligibility rather than raw voice energy. Ranking purely by power lands on the fundamental almost every time, because that is where a voice is loudest — but the masking that actually hurts a voiceover happens higher up, and dipping 160 Hz mostly just thins the bed. The bias is a control, not a constant: at 0 it follows raw energy, at 1 it weights toward 1-3 kHz. Ranking happens in dB, which matters more than it looks. Speech spreads 20-30 dB across these bands — it falls off roughly 6 dB per octave above the fundamental — so a weighting has to be on that scale to move anything at all. A multiplicative weight of `1 - bias + bias * shaped` is bounded below by `1 - bias`, capping its influence at 10*log10(1/(1 - bias)): 5.2 dB at the 0.7 default, 3 dB at 0.5. That is no influence against a real voice — every bias short of ~0.95 would rank exactly like bias 0 and carve the fundamental, the outcome the bias exists to prevent, while looking decisive against a fixture whose bands sit 2 dB apart. So the bias is a dB penalty, zero at 2 kHz and worth up to 30 dB at full strength, and relative cut depths come from a dB difference rather than a ratio of weighted linear powers. The bias reweights ranking without overriding the spectrum — a band the voice has no energy in is not worth carving, and scores -Infinity rather than competing — so a strongly low-pitched voice can still select low at full bias. What the tests hold is that biasing never selects lower than the unbiased ranking, that the DEFAULT bias reaches the presence region on a voice with a realistic tilt, and that bias 0 still follows raw power exactly. Includes a radix-2 FFT rather than a dependency; one Welch-style averaged spectrum over third-octave bands does not justify pulling in a DSP library. * fix(engine): keep the FX render 16-bit, stereo, and correctly sized Three defects in the offline FX path, none of which any test could see. **Float output silently disabled sample-accurate volume automation.** The writer emitted 32-bit IEEE float; the very next mixer step bakes the volume envelope into the samples and accepts only 16-bit PCM, returning null otherwise. So enabling any effect downgraded that track to the ffmpeg expression path — capped at 32 straight segments, quantising a curved envelope, and on a dense one falling back to base volume. It now writes 16-bit PCM, clamped rather than wrapped so a limiter at 0 dB or a resonant filter cannot turn overshoot into a click. A test asserts the baker accepts the writer's own output and actually fades it. **Everything was folded to mono.** `prepareAudioTrack` goes out of its way to emit stereo — its pan filter exists to dodge ffmpeg's 3 dB mono-to-stereo rematrix — and this folded it, then wrote one channel. So adding a single peaking EQ collapsed a bed's width and cost ~3 dB in the render, while preview stayed stereo. Channels now travel as one plane each, through an OfflineAudioContext of the same width, and come back interleaved. **Small results decoded the wrong length.** `new Float32Array(buf.buffer)` discards byteOffset and byteLength, and Node pools small allocations: a 400-byte payload sits at offset 8 inside an 8 KiB pool, so a clip under ~1024 samples decoded as 2048 samples of unrelated memory — and the empty-result guard could not see it. The reader has the mirror-image fix: a float data chunk on an odd boundary (ffmpeg's pcm_f32le writes fmt(18) + fact, landing `data` at 58) now copies instead of throwing RangeError on an unaligned view. The tail limitation is now stated rather than mis-stated: the context is exactly as long as the input, so a reverb or delay still ringing is cut there. The old comment claimed the opposite. How far a tail may run past a clip's end changes the clip's length in the mix, so it is a product decision, not one to make here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(producer): report an FX render failure as an audio error `processCompositionAudio` reports per-track failures in its result, but an FX failure it cannot degrade past — a browser that will not launch, a chain that will not build — rejects instead. `runAudioStage` had no try, so that rejection escaped to the orchestrator as an unclassified pipeline exception, losing the stage/owner/retryable classification this stage exists to attach, and skipping its abort check on the way out. It now lands in `audioError` alongside every other cause, while an abort still keeps its own shape rather than being reported as an audio problem. Not done here: committing the generated `audio-fx-runtime-inline.ts` so a fresh clone typechecks packages/engine without building first. The bundle is built from the stub, and the stub changes three times across this stack — so the artifact differs per branch and would conflict on every restack. Its model, position-edits-render-inline.ts, is committed only because it is stable. Building before testing is this monorepo's existing contract (studio's tests need core's dist too), so the gap is not specific to audio FX and is better closed by a build ordering gate than by committing a per-branch artifact. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(engine): skip the browser FX render cases when there is no browser CI's `Test` job was red on this PR with four failures, all the same cause: Failed to launch the browser process: spawn /home/runner/.cache/hyperframes/chrome/chrome-headless-shell The job installs ffmpeg and no browser, deliberately — every other suite that needs an external binary already guards on it (`describe.skipIf(!HAS_FFMPEG)`). These cases were the only ones assuming a Chrome, so they failed on an absent dependency rather than on anything about the code. Guards on `resolveHeadlessShellPath()` — the same resolver `acquireBrowser` launches through, so the check cannot drift from the thing it guards the way a hard-coded cache path would. A configured path that does not exist throws; that is caught and read as "cannot run here". Checked both directions rather than just the green one: with a browser all 11 cases run and pass, and with `HYPERFRAMES_BROWSER_PATH` pointed at a missing binary exactly 3 skip and the other 8 still run. A guard that silently skipped everything would have looked identical in CI. They keep their value where it exists — every developer machine, and any job that has run `hyperframes browser ensure`. Not touched: the CodeQL failure on this PR is a run from 2026-08-07, five days and several force-pushes stale. None of the 17 open repo alerts are in files this PR changes; it re-runs on this push. * chore(engine): suppress the temp-file alert with the reason it is safe CodeQL flags `writeWav`'s `writeFileSync` as js/insecure-temporary-file (high) — the one new alert on #3021, and the reason its CodeQL check is red. It is a false positive, and the comment says why rather than just silencing it: `path` is always inside a directory made by `mkdtempSync`, never a name assembled directly under `tmpdir()`. Both callers are covered — the browser host page writes into `mkdtempSync(join(tmpdir(), "hf-fx-host-"))`, and the render output goes to the producer work dir, itself `mkdtempSync(join(tempRoot, "producer-project-"))`. mkdtemp picks the random suffix and creates the directory 0700 in one syscall, so the predictable filename inside it cannot be pre-created or symlinked by another user, which is the attack the rule is about. The analyzer sees the dataflow reach `tmpdir()` and not the mkdtemp in between. Suppressed inline rather than dismissed in the UI, so the justification lives next to the code and the rule stays live for anything added later in this file. Matches the repo's existing convention — `planV2.ts:222` carries an `lgtm[js/insecure-temporary-file]` for a different reason on the same rule. Correcting myself: I first reported this alert as not real, having intersected the PR's files against the default-branch alert list, which does not contain PR-ref alerts. Querying ?ref=refs/pull/3021/merge returns it straight away. * feat(core): register the audio-fx-rack canary at 0% Lands the rollout switch dark, per the registry's own procedure: "Start at percentage: 0 and merge that — a canary at 0 is dead code you can land safely and ramp without a code review." Declared at the bottom of the stack so every branch above can read it. The gate itself goes in at wa-4-fx-panel, where the rack first appears. Scope is deliberate and stated in the description: it gates the AUTHORING surface only. A composition that already carries `data-fx-chain` still plays and renders it. A canary should stage who can REACH a feature, not make an attribute somebody already wrote silently inert — an agent that writes a chain through the skill would otherwise produce a file whose audio processing vanishes with no error. * feat(studio): audio FX panel generated from the registry Controls for the whole chain: add, remove, reorder, bypass, and every knob each effect declares. Nothing in the panel knows what a compressor is. The registry supplies each parameter's range, step, unit and scale and the panel renders what it finds, so adding an effect or a knob upstream needs no change here, and the panel cannot offer a value the renderer would reject — a typed-in figure is clamped into the declared range on the way through. Frequency and time controls span three or four decades, so those declare a log scale and the slider maps exponentially; a linear slider would spend most of its travel somewhere useless. Reorder is a first-class control because chain order changes the sound: a reverb before a compressor is not the same as after. Carve gets its own block rather than an entry in the add menu, with a picker for the voice track to listen to. It processes this track based on another one, which is how a sidechain control works — it lives on the track that changes, and names the source. * feat(studio): show the Audio FX section on audio tracks Adds `audioFx` to the editing-affordances contract and renders the FX panel in the inspector when an `<audio>` element is selected. The section is audio-only. A `<video>` carries its sound on a separate `<audio>` element, so an FX chain on the video would have nothing to process. Chain and carve settings are written straight back onto the element as serialised attributes, the way colour grading carries its config, so persistence is an ordinary attribute write and needs no new server route. A chain that cannot be parsed renders as empty rather than breaking the panel, and the attribute is left untouched until the user changes something. The collapsed group summarises what is on the track ("2 effects + carve") so the state is visible without expanding it. Wired into PropertyPanelFlat rather than PropertyPanel: STUDIO_FLAT_INSPECTOR_ENABLED defaults to true, so the flat inspector is what actually renders. * refactor(studio): lift audioFxSummary out of PropertyPanelFlat `PropertyPanelFlat.tsx` is 612 lines here against the repo's 600-line cap, so the required File size check is red — the sole reason this PR is blocked. The review says as much: "mechanical fix (~5 min), not a design problem. Code itself is LGTM." Moves `audioFxSummary` to `audioFxSummary.ts`, the same file a later branch creates for it. Deliberately the smallest cut that clears the cap rather than the whole `AudioFxGroup` extraction: every later commit in the stack edits AudioFxGroup, so moving it here would collide with each of them, while almost nothing touches this function. 595 lines. * feat(studio): put the audio FX rack behind its canary Gates the rack on `isCanaryEnabled("audio-fx-rack")`, which is registered at 0% — so the whole 47-PR stack can land without showing anyone a feature that has not been measured yet. The gate sits on the AUTHORING surface and nowhere else. The runtime and the render still honour a `data-fx-chain` already on an element, so a composition written through the skill or by `carve.mjs` keeps its processing rather than going silently dry for anyone outside the cohort. A canary should stage who can REACH a feature, not make an attribute somebody already wrote stop working with no error. Gated at the panel rather than in `resolveEditingSections`: the affordance resolver is a pure function in core describing what an element CAN support, and rollout state is not a property of an `<audio>` tag. Pinned the 0% with a test, and checked it fails at 25 — a ramp should have to break something that says "this ships dark" out loud. One gap, stated rather than papered over: the gate itself has no unit test. I wrote one and deleted it, because `PropertyPanel.test.tsx`'s harness never renders the Audio FX group for its audio fixture even with the gate removed — so the test passed for the wrong reason in the off case and could not pass at all in the on case. A test that cannot fail for the right reason is worse than none. Verifying the gate needs the panel harness to mount that section first, which is its own change. * feat(core,studio): hear the FX chain in preview, and run the carve analysis Splices an element's FX chain into the playback graph so preview stops being silent about effects, and wires the carve button that was previously inert. The chain goes between the decoded source and its gain stage: effects see the raw signal and volume automation rides on their output, matching the order the offline render uses. Since preview and render call the same graph builders, what is heard while scrubbing is what gets written. The splice lives in the transport rather than on the `<audio>` element. The transport plays each track from a decoded AudioBuffer and mutes the element to avoid doubling, so capturing the element with createMediaElementSource would have processed a stream nothing is listening to — it looked like it worked because the call succeeded, and the audio was unchanged. A chain that cannot be built plays dry rather than silencing the track, which is the right failure in preview: the author keeps working and hears the source. The render still refuses, because shipping the dry signal there would be wrong. Carve now analyses for real: it decodes the chosen voice track, ranks its bands and writes the resulting peaking filters onto this track. Generated nodes are tagged `fromCarve`, so re-running replaces the previous carve instead of stacking another set on top of hand-added effects. Known limitation: the graph is built when a source is scheduled, so a knob turned mid-playback takes effect on the next play or seek rather than immediately. Live re-parameterisation needs the transport to hold the handle and forward updates. * fix(studio,core): stop parameter drags from restarting playback Dragging a knob wrote the chain through the persisting attribute path on every input event. That path refreshes the preview, which reloads the composition and reschedules audio — so a single drag reloaded dozens of times and playback stuttered the whole way. Drags now go through `onSetAttributeLive`, the same path colour grading uses for scrubs: it coalesces undo entries and sets `skipRefresh`, so no reload happens. The persisting write fires once, when the gesture ends — pointer-up or blur for a slider, Enter or blur for a typed value. A select commits immediately since there is no drag to wait for. While dragging, the control is driven from local state. Waiting for the value to round-trip through the element attribute made the knob lag behind the pointer. For the change to be audible without a reload, the graph now follows the attribute: the chain installed by the transport observes the element and re-parameterises itself in place, so a value change lands on the next 128-sample quantum. A shape change (effect added, bypassed, pole count) cannot be patched into a running graph, so it still waits for the next schedule rather than cutting the audio mid-play. The regression test drags a slider through several values and asserts the persisting handler is untouched until release. * fix(core): register FX worklets before building nodes that need them An AudioWorkletNode cannot be constructed before its processor is registered — it throws, and the surrounding chain is lost with it. `attachElementFxChain` built the chain first and only then called `ensureAudioFxWorklets`, so every worklet-backed effect (compressor, limiter, gate, bitcrush) threw on construction and the track fell back to dry. Instrumenting the preview showed `hf-compressor: InvalidStateError` with addModule never called at all. When the module has not landed yet the track now plays dry and the graph is swapped in once registration resolves, so the effect arrives a moment late instead of never. Registration is also tracked per context rather than in one module-level promise. A processor registered on one AudioContext does not exist on another, so the shared promise made every context after the first believe it was ready when it was not — the studio's transport owns its own context, which is exactly that case. With the worklets actually running, the compressor's per-sample log10 and pow became real audio-thread work. Samples below the knee have a gain of exactly unity and need neither, so the envelope is now compared in the linear domain and the transcendentals only run for samples that are actually being compressed. * refactor(studio): split the FX node row out of FxSection Clears the health findings the FX stack left behind: the chain-node render callback was a 70-line closure over half of FxSection's state, and the two reorder arrows were the same button written twice. Also drops two exports with no consumers, and registers the audio FX runtime stub as an entry point — it is bundled by file path, so nothing imports it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(studio): lift the audio FX group out of PropertyPanelFlat `PropertyPanelFlat.tsx` was 672 lines against the repo's 600-line cap, so the required File size check was red — the sole reason #3014 and #3022 are blocked. Both reviews say the same thing: "mechanical fix, not a design problem. Code itself is LGTM." Moves `AudioFxGroup` and `audioFxSummary` into `propertyPanelAudioFxGroup.tsx`, which is where a later branch puts them anyway — done here so the file is under the cap from the point it first crosses it, rather than ten branches later. 533 lines now. The four audio imports it no longer needs go with it. Not fixed here: three `FxSection carve` tests fail on this branch with "Cannot read properties of undefined (reading 'toFixed')". Confirmed pre-existing by stashing this change and re-running — that is the separate `Test` failure the review also flags. * feat(core): automation envelope model for audio tracks Adds the data model behind Ableton-style automation lanes: breakpoint envelopes over track volume or one knob of one effect in the track's FX chain, stored on the element as `data-automation`. Times are clip-local, so an envelope travels with the clip when it moves — the clip-envelope model rather than arrangement automation. `sampleAutomationLane` is the single interpolator. The lane drawing, the preview scheduler and the render bake all call it, so the picture and the sound cannot disagree about the curve. Log-scaled parameters interpolate in log space, matching what their own knob already promises. FX nodes gain a stable `id`, minted by count rather than randomly so the document is the same on every machine. Lanes address nodes by id, so reordering a chain never re-points a lane at a different effect, and a lane whose effect was deleted is dropped rather than left to reattach. Also warns when a track carries both a volume lane and a GSAP volume tween, since only the lane is heard and the tween silently does nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(core): expose the AudioParams behind automatable FX knobs Marks the knobs an automation lane can drive and has each graph builder hand back the AudioParam behind them, so a scheduler can write to a running effect without knowing what the effect is. A knob is not always one AudioParam. A wet/dry mix is two gains moving in opposition, and a knob in milliseconds drives a delay time in seconds, so each target carries the mapping out of the knob's own declared unit. What stays unautomatable is stated where it is decided: a WaveShaper curve, a convolution impulse and a one-pole filter's coefficients are all rebuilt wholesale rather than scheduled, and the four worklet effects take values by postMessage rather than through AudioParams. The registry flag is written by hand, so a test builds every effect and checks the exposure both ways — nothing flagged is missing, nothing exposed is unflagged. A flag that lied would offer a lane that silently did nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(core): play automation envelopes in preview Schedules each lane onto the AudioParams behind its knob using native ramps and value curves. Nothing evaluates the envelope per frame: it is handed to the audio thread once, so it stays sample-accurate however busy the main thread is, and the offline render will schedule it the same way. Timing comes from the transport, so an envelope survives seeking into the middle of a clip, a clip that has not started yet, and a playback rate that compresses clip seconds into context seconds. A straight line is only scheduled as a ramp when nothing bends it — no curvature, a linear parameter scale, and no unit mapping. Log-scaled parameters and mapped ones are sampled instead, since a delay knob in milliseconds and a wet/dry pair moving in opposition are not linear in the parameter they drive. Lanes with nowhere to write are skipped rather than reported: a one-pole filter exposes no frequency param, and the worklet effects expose none at all. Editing an envelope mid-playback re-aims it at the live playhead rather than restarting the track. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(engine): bake automation envelopes into the render The offline render schedules FX lanes with the same scheduler preview uses, inside the OfflineAudioContext that already runs the same graph builders. The input WAV is the clip's own audio from its first sample, so clip-local time is offline time and the envelope needs no offset. Volume lanes take the existing PCM bake rather than a second mechanism: the lane is converted to keyframes, so a straight fade stays two of them and only a bent segment is sampled — the baker interpolates linearly and would otherwise quietly straighten the curve. A volume lane supersedes keyframes probed from the timeline, which `lint` already warns about. A browser test sweeps a lowpass from below a 2 kHz tone to well above it and measures both ends. Parsing the envelope is not the same as scheduling it, and only running the real thing tells the two apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(core): make the volume lane audible in preview The envelope was scheduled onto the transport's gain AudioParam, but the runtime rewrites that gain every tick from `data-volume` and the GSAP-seeked value — so it was erased within a frame. Volume automation was correct in the render and inaudible while previewing. The lane now feeds the per-tick path where the probed volume keyframes already sit, checked ahead of them so the two cannot fight, and the transport no longer schedules volume at all: one mechanism instead of two racing. The cost is honest — in preview the level steps per tick rather than per sample, exactly as the existing keyframe path does. The render still bakes it into the PCM sample-accurately, and FX parameters are still scheduled on their own AudioParams, since nothing rewrites those. Parsed lanes are cached by attribute text: the runtime asks once per tick per track, and parsing there would run the JSON parser 60 times a second for a value that only changes on an edit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(core): apply chain edits to the running graph A structural edit — an effect added, removed, bypassed, or a filter's pole count switched — was dropped. `buildFxChain`'s update reports false when the change is not merely new values, and the attribute observer ignored that, so the edit only took hold when the persisting write reloaded the composition. That reload restarted every playing track, which is what was heard as the audio chopping. The graph is now swapped in place: the old effects are detached, the new ones built and connected between the same source and gain, and any lanes re-scheduled onto the new nodes. The source node is never touched, so playback does not restart. A track with no chain is watched too, rather than wired through and forgotten, so adding its first effect is heard the same way. That means the function always returns a disposer instead of null for the empty case. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(studio): the geometry and plumbing behind automation lanes Everything an automation lane needs before there is a lane to look at, kept apart from the component so the maths can be read and tested without a pointer. `automationLaneGeometry` is pure: which parameters a clip can automate (its fader, then each automatable knob of each effect that carries a node id), how a value maps to a position in the lane, and how a lane is edited. Two decisions live here and are worth review: - A log-read knob maps on its own log scale, so the middle of a 100 Hz–20 kHz lane is the geometric mean. Dragging and drawing then agree with what the knob's own scale already promises. - `withLane` replaces a lane in place rather than appending. A lane with no explicitly chosen parameter shows whichever comes first, so moving the edited one to the end would switch the lane out from under the pointer on the first edit. `automationLaneData` parses the two attributes, cached by their text so the identity only changes when the text does — the lane holds an optimistic draft while a point is dragged and compares against that identity, and a fresh object on every playhead tick would throw the drag away. It binds automation to the chain the way preview and the render bind it, so a lane whose effect was deleted is dropped rather than drawn against the wrong axis. `useAutomationLanes` routes edits through the DOM edit session, targeting the selected element because that is what the attribute commit path writes to. Row height reserves each lane at its own height rather than counting it as another keyframe lane, and `TimelinePropertyLanes` gains a footer slot so the lanes share the keyframe disclosure — and its `aria-controls`. `TimelineElement` moves to its own module: playerStore had reached the 600-line studio ceiling exactly and could not carry another field. It is re-exported from there, so no importer changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) * fix(studio): make automationLaneData reviewable, and evict one entry not all The cache key held a literal NUL byte instead of its escape, so git classified the whole module as binary: it landed as `Bin 0 -> 2677 bytes` with zero diffable lines, invisible to review, to grep, and to any textual merge. The escape is behaviour-identical. With the file readable, two things in it needed fixing. Eviction cleared the entire map. Clearing changes the identity of every lane's automation at once, and a lane compares its drag draft against that identity — so one unrelated element arriving at the limit would release an in-progress drag and snap the point back. It now drops the oldest entry, and a hit is re-inserted so it counts as recently used. Nothing tested this module, which is what let the binary blob through. Now covered: identity stability, re-parsing when the chain changes but the automation text does not, a hot entry surviving 40 evictions, and an unreadable attribute reading as nothing. The geometry module's exports are ignored for dead-code while its consumer sits one PR upstack, following the convention already used for the fast-capture stack. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(studio): carry the audio FX attributes onto every timeline row Both element builders read `data-fx-chain` and `data-automation` off the host element, and an expanded sub-composition child is built without one — so an audio track inside a sub-composition reserved no automation height and drew no lanes, while the property panel, which reads the live DOM selection rather than the row, still showed its chain and its toggles. `hostElementState` exists to re-inherit exactly this class of host-only field; it now covers these two alongside `hidden`, `timelineLocked` and `timelineRole`. `parseTimelineFromDOM` had the same gap and now reads both directly. Also exempts the offline FX render's browser entry from the health gate: it runs only inside the headless page the engine drives, so its CRAP score is coverage-driven rather than complexity-driven, and its behaviour is covered by the engine's real-browser render tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(studio): the automation lane itself Draws each automated parameter as its own lane under the audio clip, on the same disclosure caret the keyframe lanes use — that caret is the DAW automation triangle. One lane per parameter rather than a selector to swap between them, so two envelopes can be read and edited without hiding either. Double-click the line to add a point, drag to shape it, right-click a point to remove it. Three things here took more than one attempt, and the comments say why: - **A dragged point did not move.** The live write deliberately skips the preview refresh — that is what keeps dragging from restarting playback — so the stored value does not move under the pointer. The lane keeps a local draft. - **Releasing snapped it back.** The draft was dropped when the drag ended, which is before the persisted write comes around; it now lives until the automation it was drawn over actually changes. - **A press was eaten.** Not stopping propagation let the timeline start its own gesture and swallow the second half of a double-click. The lane owns the press once it is live — and when it is not, it selects its clip instead, since lanes sit below the clip bar where the timeline's own selection handler never sees them. The envelope is inset by the grab radius so a point at the clip's first or last frame is drawn whole rather than half outside the lane, and clip time still lines up with screen position because the inset and the offset cancel. 🤖 Generated with [Claude Code](https://claude.com/claude-code) * fix(studio): let a track disclose its automation without a tween The lane was mounted inside the property-lanes wrapper, which renders only for a track's GSAP keyframe clip — so an audio clip with no tween resolved to nothing: no disclosure caret, no reserved height, no lanes. Verified on a composition with one `<audio>`, an envelope, and no tweens anywhere: 0 carets, 0 lanes. The attribute still wrote and the render still baked it, so the feature failed silently for exactly the tracks it exists for. Same composition now: 1 caret, and expanding it draws the Volume lane. Automation counts as something to disclose. `resolveTrackKeyframeClip` takes a counter alongside the keyframe lane counts and qualifies a clip on either; the header asks the same counter about the clip it already holds. A function rather than another map threaded through the props: every caller then reads one cached parse, so the height a row reserves and the lanes drawn in it cannot drift apart. That drift is also fixed for the lane's own offset, which passed the raw tween count where every other consumer uses distinct property groups. Two tweens on one property drew one keyframe lane but pushed the automation lane down by two, spilling into the next track; one tween on two properties did the inverse and drew it over a diamond lane, stealing its pointer events. It now reads the same `laneCounts` map the reserved height and the drawn lanes use. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(studio): automate a parameter without reloading the preview The write path and the volume half of the panel surface. **A commit that persists without reloading.** For attributes the runtime applies to the live graph itself — an FX chain, its automation — a reload would only interrupt playback to reach the state the preview already has. `skipRefresh` and `refreshAfter` were already independent options; this exposes the combination that skips the reload but still re-reads the selection. Both halves are needed, and they were fighting each other. Without the reload, audio no longer chops on an edit. Without the resync, the panel keeps reading the selection snapshot it was built with, so a second edit computes from a pre-edit value and appears to do nothing — deleting one effect made every later delete a no-op. `handleDomAttributeLiveCommit` is untouched and still used for knob dragging, where a per-move re-render is exactly what you do not want. **Volume.** An automated track's slider is disabled, since a level set there would be overwritten by the envelope on the next tick, and the toggle beside it adds or deletes the lane. Adding seeds it with a single point at the level the slider already shows, so automating a track never changes how loud it is. **One shared reader** for both panel sections, which is what surfaced that resolving against an absent chain would have deleted every FX lane the moment someone automated a volume: the volume section does not parse the chain, so "no chain" now means "do not resolve" rather than "drop what cannot be resolved". The toggle itself lives with the FX controls it is shared with, and says `Automated` / `Automate` through the studio's own Tooltip rather than a native browser hover. 🤖 Generated with [Claude Code](https://claude.com/claude-code) * fix(studio): stop the last two automation writes reloading the preview The quiet commit added here was only used by the FX group. Two writers still went through the refreshing one, so they reloaded the preview and restarted every playing track — the exact chop the live write during a drag exists to avoid: - releasing a dragged breakpoint, so the audio hitched at the end of every point you moved; - clicking the volume toggle, while the same click on an effect parameter was already silent. Both are quiet now: still persisted, still resyncing the selection so a following edit computes from the value just written. Also fixes the seeded volume. `Number(dataAttributes.volume ?? "1")` is 0 for an attribute that is present but empty, so automating such a track started its lane at silence while the engine read the same empty value as unity. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(studio): automate and un-automate each effect parameter The per-parameter surface in the FX panel. An automated parameter's control is disabled — a value typed there would be overwritten by the envelope on the next tick, so the lane is the value now — and the toggle beside it adds or deletes that parameter's lane. Adding seeds the lane with a single point at the value the control already holds, so switching to an envelope never changes the sound, only where the value comes from. Parameters no envelope can drive have no toggle at all: the worklet-backed dynamics expose no AudioParams, a WaveShaper's curve and a convolution impulse are rebuilt wholesale rather than scheduled. Neither does a chain node with no id, since a lane addresses nodes by id — so adding an effect now mints one. Carve moves onto the same non-reloading write, and decodes its source in an `OfflineAudioContext`: opening a second output device mid-playback makes the running track glitch while the hardware is reconfigured. Turning carve off now also drops the filters it generated, which otherwise kept dipping the bed with nothing in the panel to explain it. `AudioFxGroup` moves into its own module — PropertyPanelFlat was at its size budget — which also gave the panel's write behaviour somewhere to be tested: what it writes, seeded at the current value, preserving the lanes it is not touching, and clearing the attribute when the last one goes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) * feat(studio): only offer voiceover carve when there is a voice to carve against Carve is a relationship between two tracks — it analyses another track's voice and dips this bed where that voice sits. In a composition with a single audio track there is nothing to listen to, so the block offered an empty source picker and an Analyse button that could never do anything. It is now shown only when the composition holds another audio track, and still shown when carve is already configured: hiding a live setting because its voice track was removed would leave the bed being dipped from out of sight. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(studio): cover carve visibility through the real element The panel derives carve's source list from the selected element's document, so a selection with no element has no sources — which the new visibility rule correctly reads as 'nothing to carve against'. The suite mounted exactly that, so it was asserting on a hidden block. Selections now carry a real <audio> with a sibling track, and the two cases the rule exists for are pinned directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(studio): keep FX panel writes from clobbering each other Three writes in the audio panel each read the source file, mutate one attribute and write it back. Fired without ordering they read the same content and the last one lands, dropping the others. - Deleting an effect left its automation lanes in the attribute. Ids are minted lowest-free, so the next effect added took the same id and inherited the dead envelope: disabled and "Automated" without the author ever automating it, and baked into the render. - Switching carve off wrote the chain (dropping the filters it generated) and the carve settings at once, so either the filters stayed with no carve to explain them or the settings survived with no filters. - The three carve dials committed per input event, patching the source and resyncing the selection dozens of times per drag. They now preview live and persist on release, like the FX knobs already do. Volume automation reads through the quiet commit too, so removing a lane resyncs the panel instead of leaving the slider disabled. * feat(engine): let an FX tail decay instead of cutting it at the clip The offline render ended at the last input sample, so a reverb or a delay was still ringing when the context stopped. Measured on a 1.5 s tone through a default reverb, the render cut at 1.524 s while the tail was still at -29.7 dB — an audible chop, and the one place the render did not match preview. The length does not have to be guessed. Every tail here follows from its own settings: a convolution is exactly as long as its impulse, and `synthesizeReverbImpulse` derives that from room size; a delay's repeats fall by `feedback` every `time`, so the count down to -60 dB is a log. Everything else settles with its input — an all-pass chain has group delay, not a tail, and a 9-second compressor release has no signal to release once the clip stops. `chainTailSeconds` sums them (the chain is serial, so a delay in front of a reverb hands each repeat to the room), reads a lane's maximum rather than the static knob where one is automated, and caps at 5 s — 5 s between repeats at 0.95 feedback is eleven minutes of decay, and the panel can dial exactly that. The mixer's per-track atrim now allows the clip plus its tail; the atrim after apad still holds every track to the composition's length, so a tail can run over what follows but never extends the video. Same fixture after: a smooth decay to -72 dB, last non-zero sample at 3.306 s against the 3.4 s the settings predict. * feat(studio): curve, snap and type a value in an automation lane Four gestures from Ableton's envelope editor, which is the muscle memory an automation lane inherits. Alt-drag the line between two breakpoints to bend it, Alt-double-click to straighten. `curve` was already honoured everywhere it is read — drawn in the lane, sampled in preview, baked into the render through setValueCurveAtTime — with no gesture anywhere that could set it, so every envelope anyone could draw was linear in practice. The curve is solved, not accumulated (x^e = f, so e = ln f / ln x), which keeps the segment under the pointer instead of drifting away over a long drag; the test asserts that by sampling with the renderer's own sampler. Shift locks a drag to one axis and fines the vertical travel to a quarter. Which axis won is decided in pixels — seconds and dB are not comparable numbers, and comparing them would make the lock depend on the zoom. A dragged point snaps to the beat grid and to its neighbouring points, with Alt to ignore it. The radius is tight on purpose: a lane is often a few seconds wide, where a generous radius makes a point unplaceable between two beats. Double-click a point to type its value. -6.0 dB is not a pixel you can find, and there was no way to enter one. The gesture layer moves to useAutomationLaneGestures and the path builder to envelopePath: the component was at the studio's 600-line ceiling, and both are worth testing without a render. trackShowsBeatStrip comes out of TimelineLanes for the same reason. * feat(studio): pure range ops for automation lane selections Add pointsIn() and replaceRange() functions for managing automation envelope edits within a time range. The key invariant: envelope values outside the selection never move. Implemented by anchoring the boundaries at t0 and t1 by sampling the original lane, so cutting middle sections cannot reshape the rest. Inner points from shape generators can suppress redundant anchors at merge distance. * fix(studio): budget replaceRange's inner points before capping, not after * feat(studio): automation selection slice * feat(studio): drag-select a time range on an automation lane Dragging on an automation lane's empty background now arms a range selection, snapped to the beat grid and clamped to the lane duration; a sub-3px drag counts as a click and clears instead. Point drags and Alt-drag segment bends still take priority, since the range arm only runs where the existing point/segment hit-test already returned null. useAutomationLanes binds the selection slice per element/lane so the rect renders from the store, matching the read pattern the writes already use. * feat(studio): delete an automation selection from the keyboard Escape clears the active automation-lane time selection; Delete/Backspace empties it via replaceRange(..., inner: []), which pins anchor points at both edges and leaves the envelope outside the selection untouched. Mounted in TimelineLanes.tsx next to the useAutomationLanes() call that already lives there. Also adds a stale-selection guard in TimelineAutomationLaneSlot that clears the selection if its lane's target stops existing on the bound element's automation (e.g. the automated effect was deleted). * test(studio): cover the automation selection stale-target guard * fix(studio): let an automation range keep Delete from the clip useAppHotkeys listens on window/capture, so it runs before useAutomationSelectionKeyboard's document/capture handler. With a range selected, Delete fell straight through to the clip-delete branch and destroyed the whole audio clip the lane belongs to; Backspace hit the reset-keyframes branch on the way and wiped the clip's keyframes. Guard both by returning early when automationSelection is set, mirroring the selectedKeyframes precedent six lines above. No preventDefault: the downstream handler still needs the key. dispatchPlainKey is exported so the arbitration between keyframes, an automation range and the clip can be pinned without standing up the hook. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(engine): render audio FX in an OfflineAudioContext Reads `data-fx-chain` off an audio element and runs the chain over the trimmed WAV before volume automation is baked in — effects should see the raw signal, and the envelope belongs on their output. The processing happens in an OfflineAudioContext inside the headless browser the engine already drives, running the same graph builders the studio previews with. That is the point of the approach: one implementation per effect, so the render agreeing with the preview is a property of the architecture rather than a tolerance to police. Reimplementing each effect as an FFmpeg filter would mean two implementations to keep in step, and for the dynamics processors and modulated delays there is no filter that behaves the same way. `build:audio-fx-runtime` bundles the graph builders into an injectable IIFE, following the same pattern as the existing runtime artifacts, so the browser runs exactly the code the studio does. The page loads from a file:// URL rather than about:blank because AudioWorklet is only exposed in a secure context — the compressor, limiter, gate and bitcrush processors would otherwise fail to register with an opaque error. file:// qualifies and needs no listening socket. The chain is serialised into the attribute the way colour grading carries its config, so there is no side-car file to resolve or lose. An FX failure is fatal for the whole mix rather than a per-track soft failure. Every other audio failure mode degrades gracefully — the track drops, siblings continue — but substituting the dry signal for a processed one ships a render that sounds plausible and is not what the author set up. Since the per-element work races under Promise.all, an internal AbortController chained off the caller's signal aborts in-flight siblings before workDir is removed. * feat(core): voiceover carve analysis Finds the bands a voice occupies so a music bed can be dipped there, letting the voice sit in front without ducking the whole track. Carve is a relationship between two tracks rather than an effect on one, so it stays out of the FX chain. What it emits is an ordinary chain of peaking filters, so a carve composes with whatever else is on the track and needs no separate rendering path. Selection is weighted toward intelligibility rather than raw voice energy. Ranking purely by power lands on the fundamental almost every time, because that is where a voice is loudest — but the masking that actually hurts a voiceover happens higher up, and dipping 160 Hz mostly just thins the bed. The bias is a control, not a constant: at 0 it follows raw energy, at 1 it weights toward 1-3 kHz. Ranking happens in dB, which matters more than it looks. Speech spreads 20-30 dB across these bands — it falls off roughly 6 dB per octave above the fundamental — so a weighting has to be on that scale to move anything at all. A multiplicative weight of `1 - bias + bias * shaped` is bounded below by `1 - bias`, capping its influence at 10*log10(1/(1 - bias)): 5.2 dB at the 0.7 default, 3 dB at 0.5. That is no influence against a real voice — every bias short of ~0.95 would rank exactly like bias 0 and carve the fundamental, the outcome the bias exists to prevent, while looking decisive against a fixture whose bands sit 2 dB apart. So the bias is a dB penalty, zero at 2 kHz and worth up to 30 dB at full strength, and relative cut depths come from a dB difference rather than a ratio of weighted linear powers. The bias reweights ranking without overriding the spectrum — a band the voice has no energy in is not worth carving, and scores -Infinity rather than competing — so a strongly low-pitched voice can still select low at full bias. What the tests hold is that biasing never selects lower than the unbiased ranking, that the DEFAULT bias reaches the presence region on a voice with a realistic tilt, and that bias 0 still follows raw power exactly. Includes a radix-2 FFT rather than a dependency; one Welch-style averaged spectrum over third-octave bands does not justify pulling in a DSP library. * fix(engine): keep the FX render 16-bit, stereo, and correctly sized Three defects in the offline FX path, none of which any test could see. **Float output silently disabled sample-accurate volume automation.** The writer emitted 32-bit IEEE float; the very next mixer step bakes the volume envelope into the samples and accepts only 16-bit PCM, returning null otherwise. So enabling any effect downgraded that track to the ffmpeg expression path — capped at 32 straight segments, quantising a curved envelope, and on a dense one falling back to base volume. It now writes 16-bit PCM, clamped rather than wrapped so a limiter at 0 dB or a resonant filter cannot turn overshoot into a click. A test asserts the baker accepts the writer's own output and actually fades it. **Everything was folded to mono.** `prepareAudioTrack` goes out of its way to emit stereo — its pan filter exists to dodge ffmpeg's 3 dB mono-to-stereo rematrix — and this folded it, then wrote one channel. So adding a single peaking EQ collapsed a bed's width and cost ~3 dB in the render, while preview stayed stereo. Channels now travel as one plane each, through an OfflineAudioContext of the same width, and come back interleaved. **Small results decoded the wrong length.** `new Float32Array(buf.buffer)` discards byteOffset and byteLength, and Node pools small allocations: a 400-byte payload sits at offset 8 inside an 8 KiB pool, so a clip under ~1024 samples decoded as 2048 samples of unrelated memory — and the empty-result guard could not see it. The reader has the mirror-image fix: a float data chunk on an odd boundary (ffmpeg's pcm_f32le writes fmt(18) + fact, landing `data` at 58) now copies instead of throwing RangeError on an unaligned view. The tail limitation is now stated rather than mis-stated: the context is exactly as long as the input, so a reverb or delay still ringing is cut there. The old comment claimed the opposite. How far a tail may run past a clip's end changes the clip's length in the mix, so it is a product decision, not one to make here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(producer): report an FX render failure as an audio error `processCompositionAudio` reports per-track failures in its result, but an FX failure it cannot degrade past — a browser that will not launch, a chain that will not build — rejects instead. `runAudioStage` had no try, so that rejection escaped to the orchestrator as an unclassified pipeline exception, losing the stage/owner/retryable classification this stage exists to attach, and skipping its abort check on the way out. It now lands in `audioError` alongside every other cause, while an abort still keeps its own shape rather than being reported as an audio problem. Not done here: committing the generated `audio-fx-runtime-inline.ts` so a fresh clone typechecks packages/engine without building first. The bundle is built from the stub, and the stub changes three times across this stack — so the artifact differs per branch and would conflict on every restack. Its model, position-edits-render-inline.ts, is committed only because it is stable. Building before testing is this monorepo's existing contract (studio's tests need core's dist too), so the gap is not specific to audio FX and is better closed by a build ordering gate than by committing a per-branch artifact. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(engine): skip the browser FX render cases when there is no browser CI's `Test` job was red on this PR with four failures, all the same cause: Failed to launch the browser process: spawn /home/runner/.cache/hyperframes/chrome/chrome-headless-shell The job installs ffmpeg and no browser, deliberately — every other suite that needs an external binary already guards on it (`describe.skipIf(!HAS_FFMPEG)`). These cases were the only ones assuming a Chrome, so they failed on an absent dependency rather than on anything about the code. Guards on `resolveHeadlessShellPath()` — the same resolver `acquireBrowser` launches through, so the check cannot drift from the thing it guards the way a hard-coded cache path would. A configured path that does not exist throws; that is caught and read as "cannot run here". Checked both directions rather than just the green one: with a browser all 11 cases run and pass, and with `HYPERFRAMES_BROWSER_PATH` pointed at a missing binary exactly 3 skip and the other 8 still run. A guard that silently skipped everything would have looked identical in CI. They keep their value where it exists — every developer machine, and any job that has run `hyperframes browser ensure`. Not touched: the CodeQL failure on this PR is a run from 2026-08-07, five days and several force-pushes stale. None of the 17 open repo alerts are in files this PR changes; it re-runs on this push. * chore(engine): suppress the temp-file alert with the reason it is safe CodeQL flags `writeWav`'s `writeFileSync` as js/insecure-temporary-file (high) — the one new alert on #3021, and the reason its CodeQL check is red. It is a false positive, and the comment says why rather than just silencing it: `path` is always inside a directory made by `mkdtempSync`, never a name assembled directly under `tmpdir()`. Both callers are covered — the browser host page writes into `mkdtempSync(join(tmpdir(), "hf-fx-host-"))`, and the render output goes to the producer work dir, itself `mkdtempSync(join(tempRoot, "producer-project-"))`. mkdtemp picks the random suffix and creates the directory 0700 in one syscall, so the predictable filename inside it cannot be pre-created or symlinked by another user, which is the attack the rule is about. The analyzer sees the dataflow reach `tmpdir()` and not the mkdtemp in between. Suppressed inline rather than dismissed in the UI, so the justification lives next to the code and the rule stays live for anything added later in this file. Matches the repo's existing convention — `planV2.ts:222` carries an `lgtm[js/insecure-temporary-file]` for a different reason on the same rule. Correcting myself: I first reported this alert as not real, having intersected the PR's files against the default-branch alert list, which does not contain PR-ref alerts. Querying ?ref=refs/pull/3021/merge returns it straight away. * test(engine): probe ffmpeg and Chrome instead of assuming them Two failures on #3021's Test job, both about the environment rather than the code under test. **Bare `ffmpeg` is not on PATH in CI.** The 16-bit fixture shelled out to `execFileSync("ffmpeg", ...)` and died with ENOENT. The job does provide ffmpeg, through `prepare-ffmpeg-bin`, which is what `getFfmpegBinary()` resolves — every other ffmpeg-dependent suite in this package already goes through it. Now this one does too, and the case is `skipIf(!HAS_FFMPEG)` so a contributor without ffmpeg skips rather than fails. **The browser guard trusted the wrong thing.** It asked `resolveHeadlessShellPath()` and treated a returned path as "a browser is here". CI's cache holds a chrome-headless-shell that resolves and then fails to spawn — a partial download is indistinguishable from a working one by `existsSync`, which is all that resolver checks. So the three browser cases ran anyway and failed on the launch. It now runs `--version` and requires exit 0, which is the same probe the ffmpeg suites use: ask the binary, do not infer from the filesystem. Checked both directions rather than just the green one. With a working browser all 11 cases run and pass; with `HYPERFRAMES_BROWSER_PATH` pointed at a binary that exits non-zero — CI's exact situation — exactly 3 skip and the other 8 still run. A guard that quietly skipped everything would have looked identical on the CI summary. * feat(core): register the audio-fx-rack canary at 0% Lands the rollout switch dark, per the registry's own procedure: "Start at percentage: 0 and merge that — a canary at 0 is dead code you can land safely and ramp without a code review." Declared at the bottom of the stack so every branch above can read it. The gate itself goes in at wa-4-fx-panel, where the rack first appears. Scope is deliberate and stated in the description: it gates the AUTHORING surface only. A composition that already carries `data-fx-chain` still plays and renders it. A canary should stage who can REACH a feature, not make an attribute somebody already wrote silently inert — an agent that writes a chain through the skill would otherwise produce a file whose audio processing vanishes with no error. * feat(studio): audio FX panel generated from the registry Controls for the whole chain: add, remove, reorder, bypass, and every knob each effect declares. Nothing in the panel knows what a compressor is. The registry supplies each parameter's range, step, unit and scale and the panel renders what it finds, so adding an effect or a knob upstream needs no change here, and the panel cannot offer a value the renderer would reject — a typed-in figure is clamped into the declared range on the way through. Frequency and time controls span three or four decades, so those declare a log scale and the slider maps exponentially; a linear slider would spend most of its travel somewhere useless. Reorder is a first-class control because chain order changes the sound: a reverb before a compressor is not the same as after. Carve gets its own block rather than an entry in the add menu, with a picker for the voice track to listen to. It processes this track based on another one, which is how a sidechain control works — it lives on the track that changes, and names the source. * feat(studio): show the Audio FX section on audio tracks Adds `audioFx` to the editing-affordances contract and renders the FX panel in the inspector when an `<audio>` element is selected. The section is audio-only. A `<video>` carries its sound on a separate `<audio>` element, so an FX chain on the video would have nothing to process. Chain and carve settings are written straight back onto the element as serialised attributes, the way colour grading carries its config, so persistence is an ordinary attribute write and needs no new server route. A chain that cannot be parsed renders as empty rather than breaking the panel, and the attribute is left untouched until the user changes something. The collapsed group summarises what is on the track ("2 effects + carve") so the state is visible without expanding it. Wired into PropertyPanelFlat rather than PropertyPanel: STUDIO_FLAT_INSPECTOR_ENABLED defaults to true, so the flat inspector is what actually renders. * refactor(studio): lift audioFxSummary out of PropertyPanelFlat `PropertyPanelFlat.tsx` is 612 lines here against the repo's 600-line cap, so the required File size check is red — the sole reason this PR is blocked. The review says as much: "mechanical fix (~5 min), not a design problem. Code itself is LGTM." Moves `audioFxSummary` to `audioFxSummary.ts`, the same file a later branch creates for it. Deliberately the smallest cut that clears the cap rather than the whole `AudioFxGroup` extraction: every later commit in the stack edits AudioFxGroup, so moving it here would collide with each of them, while almost nothing touches this function. 595 lines. * feat(core,studio): hear the FX chain in preview, and run the carve analysis Splices an element's FX chain into the playback graph so preview stops being silent about effects, and wires the carve button that was previously inert. The chain goes between the decoded source and its gain stage: effects see the raw signal and volume automation rides on their output, matching the order the offline render uses. Since preview and render call the same graph builders, what is heard while scrubbing is what gets written. The splice lives in the transport rather than on the `<audio>` element. The transport plays each track from a decoded AudioBuffer and mutes the element to avoid doubling, so capturing the element with createMediaElementSource would have processed a stream nothing is listening to — it looked like it worked because the call succeeded, and the audio was unchanged. A chain that cannot be built plays dry rather than silencing the track, which is the right failure in preview: the author keeps working and hears the source. The render still refuses, because shipping the dry signal there would be wrong. Carve now analyses for real: it decodes the chosen voice track, ranks its bands and writes the resulting peaking filters onto this track. Generated nodes are tagged `fromCarve`, so re-running replaces the previous carve instead of stacking another set on top of hand-added effects. Known limitation: the graph is built when a source is scheduled, so a knob turned mid-playback takes effect on the next play or seek rather than immediately. Live re-parameterisation needs the transport to hold the handle and forward updates. * fix(studio,core): stop parameter drags from restarting playback Dragging a knob wrote the chain through the persisting attribute path on every input event. That path refreshes the preview, which reloads the composition and reschedules audio — so a single drag reloaded dozens of times and playback stuttered the whole way. Drags now go through `onSetAttributeLive`, the same path colour grading uses for scrubs: it coalesces undo entries and sets `skipRefresh`, so no reload happens. The persisting write fires once, when the gesture ends — pointer-up or blur for a slider, Enter or blur for a typed value. A select commits immediately since there is no drag to wait for. While dragging, the control is driven from local state. Waiting for the value to round-trip through the element attribute made the knob lag behind the pointer. For the change to be audible without a reload, the graph now follows the attribute: the chain installed by the transport observes the element and re-parameterises itself in place, so a value change lands on the next 128-sample quantum. A shape change (effect added, bypassed, pole count) cannot be patched into a running graph, so it still waits for the next schedule rather than cutting the audio mid-play. The regression test drags a slider through several values and asserts the persisting handler is untouched until release. * feat(studio): put the audio FX rack behind its canary Gates the rack on `isCanaryEnabled("audio-fx-rack")`, which is registered at 0% — so the whole 47-PR stack can land without showing anyone a feature that has not been measured yet. The gate sits on the AUTHORING surface and nowhere else. The runtime and the render still honour a `data-fx-chain` already on an element, so a composition written through the skill or by `carve.mjs` keeps its processing rather than going silently dry for anyone outside the cohort. A canary should stage who can REACH a feature, not make an attribute somebody already wrote stop working with no error. Gated at the panel rather than in `resolveEditingSections`: the affordance resolver is a pure function in core describing what an element CAN support, and rollout state is not a property of an `<audio>` tag. Pinned the 0% with a test, and checked it fails at 25 — a ramp should have to break something that says "this ships dark" out loud. One gap, stated rather than papered over: the gate itself has no unit test. I wrote one and deleted it, because `PropertyPanel.test.tsx`'s harness never renders the Audio FX group for its audio fixture even with the gate removed — so the test passed for the wrong reason in the off case and could not pass at all in the on case. A test that cannot fail for the right reason is worse than none. Verifying the gate needs the panel harness to mount that section first, which is its own change. * fix(core): register FX worklets before building nodes that need them An AudioWorkletNode cannot be constructed before its processor is registered — it throws, and the surrounding chain is lost with it. `attachElementFxChain` built the chain first and only then called `ensureAudioFxWorklets`, so every worklet-backed effect (compressor, limiter, gate, bitcrush) threw on construction and the track fell back to dry. Instrumenting the preview showed `hf-compressor: InvalidStateError` with addModule never called at all. When the module has not landed yet the track now plays dry and the graph is swapped in once registration resolves, so the effect arrives a moment late instead of never. Registration is also tracked per context rather than in one module-level promise. A processor registered on one AudioContext does not exist on another, so the shared promise made every context after the first believe it was ready when it was not — the studio's transport owns its own context, which is exactly that case. With the worklets actually running, the compressor's per-sample log10 and pow became real audio-thread work. Samples below the knee have a gain of exactly unity and need neither, so the envelope is now compared in the linear domain and the transcendentals only run for samples that are actually being compressed. * refactor(studio): split the FX node row out of FxSection Clears the health findings the FX stack left behind: the chain-node render callback was a 70-line closure over half of FxSection's state, and the two reorder arrows were the same button written twice. Also drops two exports with no consumers, and registers the audio FX runtime stub as an entry point — it is bundled by file path, so nothing imports it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(core): automation envelope model for audio tracks Adds the data model behind Ableton-style automation lanes: breakpoint envelopes over track volume or one knob of one effect in the track's FX chain, stored on the element as `data-automation`. Times are clip-local, so an envelope travels with the clip when it moves — the clip-envelope model rather than arrangement automation. `sampleAutomationLane` is the single interpolator. The lane drawing, the preview scheduler and the render bake all call it, so the picture and the sound cannot disagree about the curve. Log-scaled parameters interpolate in log space, matching what their own knob already promises. FX nodes gain a stable `id`, minted by count rather than randomly so the document is the same on every machine. Lanes address nodes by id, so reordering a chain never re-points a lane at a different effect, and a lane whose effect was deleted is dropped rather than left to reattach. Also warns when a track carries both a volume lane and a GSAP volume tween, since only the lane is heard and the tween silently does nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * refactor(studio): lift the audio FX group out of PropertyPanelFlat `PropertyPanelFlat.tsx` was 672 lines against the repo's 600-line cap, so the required File size check was red — the sole reason #3014 and #3022 are blocked. Both reviews say the same thing: "mechanical fix, not a design problem. Code itself is LGTM." Moves `AudioFxGroup` and `audioFxSummary` into `propertyPanelAudioFxGroup.tsx`, which is where a later branch puts them anyway — done here so the file is under the cap from the point it first crosses it, rather than ten branches later. 533 lines now. The four audio imports it no longer needs go with it. Not fixed here: three `FxSection carve` tests fail on this branch with "Cannot read properties of undefined (reading 'toFixed')". Confirmed pre-existing by stashing this change and re-running — that is the separate `Test` failure the review also flags. * feat(core): expose the AudioParams behind automatable FX knobs Marks the knobs an automation lane can drive and has each graph builder hand back the AudioParam behind them, so a scheduler can write to a running effect without knowing what the effect is. A knob is not always one AudioParam. A wet/dry mix is two gains moving in opposition, and a knob in milliseconds drives a delay time in seconds, so each target carries the mapping out of the knob's own declared unit. What stays unautomatable is stated where it is decided: a WaveShaper curve, a convolution impulse and a one-pole filter's coefficients are all rebuilt wholesale rather than scheduled, and the four worklet effects take values by postMessage rather than through AudioParams. The registry flag is written by hand, so a test builds every effect and checks the exposure both ways — nothing flagged is missing, nothing exposed is unflagged. A flag that lied would offer a lane that silently did nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(core): play automation envelopes in preview Schedules each lane onto the AudioParams behind its knob using native ramps and value curves. Nothing evaluates the envelope per frame: it is handed to the audio thread once, so it stays sample-accurate however busy the main thread is, and the offline render will schedule it the same way. Timing comes from the transport, so an envelope survives seeking into the middle of a clip, a clip that has not started yet, and a playback rate that compresses clip seconds into context seconds. A straight line is only scheduled as a ramp when nothing bends it — no curvature, a linear parameter scale, and no unit mapping. Log-scaled parameters and mapped ones are sampled instead, since a delay knob in milliseconds and a wet/dry pair moving in opposition are not linear in the parameter they drive. Lanes with nowhere to write are skipped rather than reported: a one-pole filter exposes no frequency param, and the worklet effects expose none at all. Editing an envelope mid-playback re-aims it at the live playhead rather than restarting the track. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(core): make the volume lane audible in preview The envelope was scheduled onto the transport's gain AudioParam, but the runtime rewrites that gain every tick from `data-volume` and the GSAP-seeked value — so it was erased within a frame. Volume automation was correct in the render and inaudible while previewing. The lane now feeds the per-tick path where the probed volume keyframes already sit, checked ahead of them so the two cannot fight, and the transport no longer schedules volume at all: one mechanism instead of two racing. The cost is honest — in preview the level steps per tick rather than per sample, exactly as the existing keyframe path does. The render still bakes it into the PCM sample-accurately, and FX parameters are still scheduled on their own AudioParams, since nothing rewrites those. Parsed lanes are cached by attribute text: the runtime asks once per tick per track, and parsing there would run the JSON parser 60 times a second for a value that only changes on an edit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(engine): bake automation envelopes into the render The offline render schedules FX lanes with the same scheduler preview uses, inside the OfflineAudioContext that already runs the same graph builders. The input WAV is the clip's own audio from its first sample, so clip-local time is offline time and the envelope needs no offset. Volume lanes take the existing PCM bake rather than a second mechanism: the lane is converted to keyframes, so a straight fade stays two of them and only a bent segment is sampled — the baker interpolates linearly and would otherwise quietly straighten the curve. A volume lane supersedes keyframes probed from the timeline, which `lint` already warns about. A browser test sweeps a lowpass from below a 2 kHz tone to well above it and measures both ends. Parsing the envelope is not the same as scheduling it, and only running the real thing tells the two apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(core): apply chain edits to the running graph A structural edit — an effect added, removed, bypassed, or a filter's pole count switched — was dropped. `buildFxChain`'s update reports false when the change is not merely new values, and the attribute observer ignored that, so the edit only took hold when the persisting write reloaded the composition. That reload restarted every playing track, which is what was heard as the audio chopping. The graph is now swapped in place: the old effects are detached, the new ones built and connected between the same source and gain, and any lanes re-scheduled onto the new nodes. The source node is never touched, so playback does not restart. A track with no chain is watched too, rather than wired through and forgotten, so adding its first effect is heard the same way. That means the function always returns a disposer instead of null for the empty case. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(studio): drop the FX panel's dead __testables export Fallow audit flagged it — no test imports the module. * fix(core,studio): clear the remaining Fallow audit findings on the FX panel - Split FxSection's per-node row into FxNodeRow + FxNodeControls so the CRAP score (31.6, threshold 30) splits across two smaller units instead of moving wholesale with one extraction. - Dedupe the repeated "open the add menu, read its items" block in propertyPanelFxSection.test.tsx into openAddMenuItems(). - Merge build-audio-fx-runtime.ts and build-position-edits-render.ts into one build-inline-artifact.ts, config-selected by CLI arg — the two scripts were a byte-for-byte clone save for names. - Exempt canary.test.ts's rawFnv (a deliberate independent reimplementation used to cross-check canaryBucket, per its own docstring) and the property-panel test files' shared renderInto/mount scaffolding (pre-existing across 9 files, 2 outside this stack) in .fallowrc.jsonc, consistent with this file's existing exemptions for the same class of intentional/pre-existing duplication. * fix(ci): allowlist the build-script consolidation in the no-main-deletions guard build-audio-fx-runtime.ts and build-position-edits-render.ts were merged into build-inline-artifact.ts to kill a fallow duplication finding; the deletion guard flagged that as an accidental loss since main still has both originals. * fix(core): dedupe the wet/dry mix math between delayFeedback and chorusLfo Both effect builders set wet.gain to the mix and dry.gain to its complement in identical two-line blocks; fallow kept re-flagging it as a 10-line clone on every unrelated change. Extracted setWetDryMix. * fix(core): remove the build-audio-fx-runtime.ts stray resurrected by a main merge An earlier merge with main brought this deleted file back (git's merge/delete handling on an unchanged-on-one-side file); package.json already points at build-inline-artifact.ts, so it sat unreachable and duplicating that file's config, both of which fallow flagged. * fix(studio): pull TimelineLanes under the 600-line cap TimelineLanes.tsx hit 620 lines. Extracted the three per-clip pointer gestures (resize-start, pointer-down move-arm, click/razor-split) into createClipGestureHandlers — one factory call per rendered clip instead of ~120 lines of inline handler bodies in the render loop. 529 lines now. * fix(studio): split the extracted pointerdown handler under the CRAP threshold Moving the ~120-line gesture logic into timelineClipGestureHandlers.ts concentrated it into two functions fallow flagged (onPointerDown at CRAP 63.6, onResizeStart at 31.6). Split the decision logic (which gesture a pointerdown implies) into a pure resolvePointerDownAction, then split its own intent-blocking check into isIntentBlocked. onResizeStart's guard moved into canStartResize. Every function now scores under 30. * fix(studio): drop the unused DomEditSelection import in PropertyPanelFlat CI caught it on PR #3026 (wa-12-panel-params); a later refactor in the stack removed the last use of the type here without removing the import. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
e465a07a32
commit
3670e9a921
@@ -0,0 +1,113 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { dispatchPlainKey } from "./useAppHotkeys";
|
||||
import { usePlayerStore } from "../player/store/playerStore";
|
||||
import type { TimelineElement } from "../player/store/timelineElement";
|
||||
|
||||
/** Minimal valid fixture — TimelineElement only requires these five fields. */
|
||||
const bgmElement: TimelineElement = {
|
||||
id: "bgm",
|
||||
key: "bgm",
|
||||
tag: "audio",
|
||||
start: 0,
|
||||
duration: 6,
|
||||
track: 0,
|
||||
};
|
||||
|
||||
/** Every callback dispatchPlainKey can reach, so a test can assert which one
|
||||
* a key resolved to. Unannotated on purpose: the parameter type is not
|
||||
* exported, and structural inference checks it at the call site. */
|
||||
function callbacks() {
|
||||
return {
|
||||
handleTimelineElementDelete: vi.fn(async () => {}),
|
||||
handleTimelineElementSplit: vi.fn(async () => {}),
|
||||
handleDomEditElementDelete: vi.fn(async () => {}),
|
||||
handleUndo: vi.fn(async () => {}),
|
||||
handleRedo: vi.fn(async () => {}),
|
||||
handleCopy: vi.fn(() => false),
|
||||
handlePaste: vi.fn(async () => {}),
|
||||
handleCut: vi.fn(async () => false),
|
||||
onResetKeyframes: vi.fn(() => true),
|
||||
onDeleteSelectedKeyframes: vi.fn(),
|
||||
showToast: vi.fn(),
|
||||
leftSidebarRef: { current: null },
|
||||
domEditSelectionRef: { current: null },
|
||||
};
|
||||
}
|
||||
|
||||
const press = (key: string) =>
|
||||
new KeyboardEvent("keydown", { key, bubbles: true, cancelable: true });
|
||||
|
||||
afterEach(() => {
|
||||
usePlayerStore.getState().clearAutomationSelection();
|
||||
usePlayerStore.setState({
|
||||
elements: [],
|
||||
selectedElementId: null,
|
||||
selectedElementIds: new Set<string>(),
|
||||
selectedKeyframes: new Set<string>(),
|
||||
});
|
||||
});
|
||||
|
||||
describe("dispatchPlainKey — Delete arbitration", () => {
|
||||
const selectBgm = () =>
|
||||
usePlayerStore.setState({ elements: [bgmElement], selectedElementId: "bgm" });
|
||||
|
||||
const selectRange = () =>
|
||||
usePlayerStore
|
||||
.getState()
|
||||
.setAutomationSelection({ elementKey: "bgm", target: "volume", t0: 2, t1: 4 });
|
||||
|
||||
it("deletes the selected clip when no automation range is active", () => {
|
||||
selectBgm();
|
||||
const cb = callbacks();
|
||||
const e = press("Delete");
|
||||
dispatchPlainKey(e, "delete", cb);
|
||||
// The pre-existing contract, pinned so the new guard cannot widen.
|
||||
expect(cb.handleTimelineElementDelete).toHaveBeenCalledTimes(1);
|
||||
expect(e.defaultPrevented).toBe(true);
|
||||
});
|
||||
|
||||
it("leaves the clip alone when an automation range is active", () => {
|
||||
// The bug: this listener is on window/capture so it runs BEFORE
|
||||
// useAutomationSelectionKeyboard's document/capture handler. Without the
|
||||
// guard, clearing a 2s automation range deleted the whole audio clip.
|
||||
selectBgm();
|
||||
selectRange();
|
||||
const cb = callbacks();
|
||||
const e = press("Delete");
|
||||
dispatchPlainKey(e, "delete", cb);
|
||||
expect(cb.handleTimelineElementDelete).not.toHaveBeenCalled();
|
||||
// Must NOT be consumed: the automation handler downstream still needs it.
|
||||
expect(e.defaultPrevented).toBe(false);
|
||||
});
|
||||
|
||||
it("leaves keyframe reset alone when an automation range is active", () => {
|
||||
// Backspace's reset-keyframes branch sits below the guard, so it has to be
|
||||
// covered too — otherwise Backspace wiped every keyframe on the clip.
|
||||
selectBgm();
|
||||
usePlayerStore.setState({
|
||||
keyframeCache: new Map([["bgm", { targets: [], version: 0 }]]),
|
||||
});
|
||||
selectRange();
|
||||
const cb = callbacks();
|
||||
const e = press("Backspace");
|
||||
dispatchPlainKey(e, "backspace", cb);
|
||||
expect(cb.onResetKeyframes).not.toHaveBeenCalled();
|
||||
expect(cb.handleTimelineElementDelete).not.toHaveBeenCalled();
|
||||
expect(e.defaultPrevented).toBe(false);
|
||||
});
|
||||
|
||||
it("still lets a keyframe selection win over an automation range", () => {
|
||||
// Ordering: the keyframe guard precedes the automation one, so a keyframe
|
||||
// selection keeps Delete even with a range showing.
|
||||
selectBgm();
|
||||
selectRange();
|
||||
usePlayerStore.setState({ selectedKeyframes: new Set(["bgm:opacity:0"]) });
|
||||
const cb = callbacks();
|
||||
const e = press("Delete");
|
||||
dispatchPlainKey(e, "delete", cb);
|
||||
expect(cb.onDeleteSelectedKeyframes).toHaveBeenCalledTimes(1);
|
||||
expect(cb.handleTimelineElementDelete).not.toHaveBeenCalled();
|
||||
expect(e.defaultPrevented).toBe(true);
|
||||
});
|
||||
});
|
||||
@@ -222,7 +222,10 @@ function dispatchModifierKey(event: KeyboardEvent, key: string, cb: HotkeyCallba
|
||||
}
|
||||
|
||||
// fallow-ignore-next-line complexity
|
||||
function dispatchPlainKey(event: KeyboardEvent, key: string, cb: HotkeyCallbacks): void {
|
||||
/** Exported for tests: the unmodified-key half of the dispatcher, so the
|
||||
* Delete arbitration between keyframes, an automation range and the clip can
|
||||
* be asserted without standing up the whole hook. */
|
||||
export function dispatchPlainKey(event: KeyboardEvent, key: string, cb: HotkeyCallbacks): void {
|
||||
if (key === "f" && !event.shiftKey && !event.altKey) {
|
||||
event.preventDefault();
|
||||
if (document.fullscreenElement) void document.exitFullscreen();
|
||||
@@ -288,6 +291,13 @@ function dispatchPlainKey(event: KeyboardEvent, key: string, cb: HotkeyCallbacks
|
||||
event.preventDefault();
|
||||
return;
|
||||
}
|
||||
// An active automation range owns Delete: useAutomationSelectionKeyboard
|
||||
// empties the range in place, pinning the anchors. Fall through WITHOUT
|
||||
// preventDefault so that document-level handler still sees the key — this
|
||||
// listener is on window/capture, so it runs first and everything below
|
||||
// would otherwise win. Without this the press reaches the clip delete
|
||||
// below and destroys the whole clip the lane belongs to.
|
||||
if (usePlayerStore.getState().automationSelection) return;
|
||||
if (event.key === "Backspace") {
|
||||
const { selectedElementId, keyframeCache } = usePlayerStore.getState();
|
||||
if (selectedElementId && keyframeCache.has(selectedElementId) && cb.onResetKeyframes()) {
|
||||
|
||||
@@ -0,0 +1,104 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { act } from "react";
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import { usePlayerStore } from "../player/store/playerStore";
|
||||
import { useAutomationSelectionKeyboard } from "./useAutomationSelectionKeyboard";
|
||||
import type {
|
||||
AutomationLaneBinding,
|
||||
UseAutomationLanesResult,
|
||||
} from "../player/components/useAutomationLanes";
|
||||
import type { TimelineElement } from "../player/store/timelineElement";
|
||||
|
||||
/** Minimal valid fixture — TimelineElement only requires these five fields. */
|
||||
const bgmElement: TimelineElement = {
|
||||
id: "bgm",
|
||||
key: "bgm",
|
||||
tag: "audio",
|
||||
start: 0,
|
||||
duration: 6,
|
||||
track: 0,
|
||||
};
|
||||
|
||||
(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
||||
|
||||
function Host({ lanes }: { lanes: UseAutomationLanesResult }) {
|
||||
useAutomationSelectionKeyboard({ lanes });
|
||||
return null;
|
||||
}
|
||||
|
||||
const key = (k: string) => {
|
||||
const e = new KeyboardEvent("keydown", { key: k, bubbles: true, cancelable: true });
|
||||
act(() => void document.dispatchEvent(e));
|
||||
};
|
||||
|
||||
describe("useAutomationSelectionKeyboard", () => {
|
||||
const setup = (binding: Partial<AutomationLaneBinding>) => {
|
||||
const onCommit = vi.fn();
|
||||
const lanes: UseAutomationLanesResult = {
|
||||
bind: () => ({
|
||||
automation: {
|
||||
version: 1,
|
||||
lanes: [
|
||||
{
|
||||
target: "volume",
|
||||
points: [
|
||||
{ t: 0, v: 1 },
|
||||
{ t: 2, v: 0.5 },
|
||||
{ t: 4, v: 0 },
|
||||
],
|
||||
},
|
||||
],
|
||||
},
|
||||
lanes: [],
|
||||
chain: null,
|
||||
onPreview: vi.fn(),
|
||||
onCommit,
|
||||
onSelect: vi.fn(),
|
||||
readOnly: false,
|
||||
selection: null,
|
||||
onRangeSelect: vi.fn(),
|
||||
onRangeClear: vi.fn(),
|
||||
...binding,
|
||||
}),
|
||||
};
|
||||
const host = document.createElement("div");
|
||||
document.body.append(host);
|
||||
act(() => createRoot(host).render(<Host lanes={lanes} />));
|
||||
return { onCommit };
|
||||
};
|
||||
|
||||
it("Delete empties the selected range and pins anchors", () => {
|
||||
usePlayerStore.setState({ elements: [bgmElement], selectedElementId: "bgm" });
|
||||
usePlayerStore
|
||||
.getState()
|
||||
.setAutomationSelection({ elementKey: "bgm", target: "volume", t0: 1, t1: 3 });
|
||||
const { onCommit } = setup({});
|
||||
key("Delete");
|
||||
const written = onCommit.mock.calls.at(-1)?.[0];
|
||||
const points = written?.lanes?.[0]?.points ?? [];
|
||||
expect(points.map((p: { t: number }) => p.t)).toEqual([0, 1, 3, 4]);
|
||||
});
|
||||
|
||||
it("Escape clears the selection", () => {
|
||||
usePlayerStore
|
||||
.getState()
|
||||
.setAutomationSelection({ elementKey: "bgm", target: "volume", t0: 1, t1: 3 });
|
||||
setup({});
|
||||
key("Escape");
|
||||
expect(usePlayerStore.getState().automationSelection).toBeNull();
|
||||
});
|
||||
|
||||
it("is inert while a text input has focus", () => {
|
||||
usePlayerStore
|
||||
.getState()
|
||||
.setAutomationSelection({ elementKey: "bgm", target: "volume", t0: 1, t1: 3 });
|
||||
const { onCommit } = setup({});
|
||||
const input = document.createElement("input");
|
||||
document.body.append(input);
|
||||
input.focus();
|
||||
key("Delete");
|
||||
expect(onCommit).not.toHaveBeenCalled();
|
||||
input.remove();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,79 @@
|
||||
/**
|
||||
* Keyboard surface for the active automation selection: Escape clears,
|
||||
* Delete/Backspace empties the range (anchors pinned, envelope outside
|
||||
* untouched). Sibling of useKeyframeKeyboard and copies its contract:
|
||||
* capture phase so playback shortcuts cannot swallow keys we act on, inert
|
||||
* while any text input has focus, and a key is only consumed when it does
|
||||
* something.
|
||||
*/
|
||||
import { useEffect } from "react";
|
||||
import { usePlayerStore, type TimelineElement } from "../player/store/playerStore";
|
||||
import { laneFor, withLane } from "../player/components/automationLaneGeometry";
|
||||
import { replaceRange } from "../player/components/automationLaneSelection";
|
||||
import { resolveAutomationRange, type HfAutomation } from "@hyperframes/core/audio-automation";
|
||||
import type { AutomationSelection } from "../player/store/automationSelectionSlice";
|
||||
import type { UseAutomationLanesResult } from "../player/components/useAutomationLanes";
|
||||
|
||||
function isTextInput(el: Element | null): boolean {
|
||||
if (!el) return false;
|
||||
const tag = el.tagName;
|
||||
if (tag === "INPUT" || tag === "TEXTAREA" || tag === "SELECT") return true;
|
||||
return el instanceof HTMLElement && el.isContentEditable;
|
||||
}
|
||||
|
||||
/**
|
||||
* The write that empties the active selection, or null when there is nothing
|
||||
* to do: the clip is gone, its lane is read-only, the target no longer
|
||||
* resolves to a range, or the lane already has no points in it. Split out of
|
||||
* the keydown handler so each stays under the complexity a single branch of
|
||||
* keyboard dispatch should carry.
|
||||
*/
|
||||
function resolveDeleteWrite(
|
||||
state: { elements: TimelineElement[]; selectedElementId: string | null },
|
||||
lanes: UseAutomationLanesResult,
|
||||
sel: AutomationSelection,
|
||||
): { onCommit(next: HfAutomation): void; next: HfAutomation } | null {
|
||||
const element = state.elements.find((el) => (el.key ?? el.id) === sel.elementKey);
|
||||
if (!element) return null;
|
||||
const binding = lanes.bind(element, sel.elementKey === state.selectedElementId);
|
||||
if (binding.readOnly) return null;
|
||||
const lane = laneFor(binding.automation, sel.target);
|
||||
const range = resolveAutomationRange(sel.target, binding.chain ?? undefined);
|
||||
if (!range || lane.points.length === 0) return null;
|
||||
const points = replaceRange({ lane, range, t0: sel.t0, t1: sel.t1, inner: [] });
|
||||
return {
|
||||
onCommit: binding.onCommit,
|
||||
next: withLane(binding.automation, { target: sel.target, points }),
|
||||
};
|
||||
}
|
||||
|
||||
export function useAutomationSelectionKeyboard({
|
||||
lanes,
|
||||
}: {
|
||||
lanes: UseAutomationLanesResult;
|
||||
}): void {
|
||||
useEffect(() => {
|
||||
const handler = (e: KeyboardEvent): void => {
|
||||
if (isTextInput(document.activeElement)) return;
|
||||
const state = usePlayerStore.getState();
|
||||
const sel = state.automationSelection;
|
||||
if (!sel) return;
|
||||
|
||||
if (e.key === "Escape") {
|
||||
state.clearAutomationSelection();
|
||||
return;
|
||||
}
|
||||
const isDeleteKey = e.key === "Delete" || e.key === "Backspace";
|
||||
if (!isDeleteKey || e.metaKey || e.ctrlKey) return;
|
||||
|
||||
const write = resolveDeleteWrite(state, lanes, sel);
|
||||
if (!write) return;
|
||||
|
||||
e.preventDefault();
|
||||
e.stopImmediatePropagation();
|
||||
write.onCommit(write.next);
|
||||
};
|
||||
document.addEventListener("keydown", handler, true);
|
||||
return () => document.removeEventListener("keydown", handler, true);
|
||||
}, [lanes]);
|
||||
}
|
||||
@@ -459,33 +459,33 @@ describe("TimelineAutomationLane", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("TimelineAutomationLane modifiers", () => {
|
||||
/** The lane's own box, so pointer coordinates map to clip time and value. */
|
||||
const BOX = { left: 100, top: 0, width: 400 + PAD * 2, height: AUTOMATION_LANE_H };
|
||||
/** The lane's own box, so pointer coordinates map to clip time and value. */
|
||||
const BOX = { left: 100, top: 0, width: 400 + PAD * 2, height: AUTOMATION_LANE_H };
|
||||
|
||||
/** x for a clip time, y for a 0..1 unit height, in client coordinates. The
|
||||
* 6px inset and the height have to match the lane's own, or a point sits
|
||||
* outside the grab radius and a press silently does nothing. */
|
||||
const at = (t: number, unit: number) => ({
|
||||
clientX: BOX.left + PAD + (t / 4) * 400,
|
||||
clientY: BOX.top + 6 + (1 - unit) * (AUTOMATION_LANE_H - 12),
|
||||
});
|
||||
/** x for a clip time, y for a 0..1 unit height, in client coordinates. The
|
||||
* 6px inset and the height have to match the lane's own, or a point sits
|
||||
* outside the grab radius and a press silently does nothing. */
|
||||
const at = (t: number, unit: number) => ({
|
||||
clientX: BOX.left + PAD + (t / 4) * 400,
|
||||
clientY: BOX.top + 6 + (1 - unit) * (AUTOMATION_LANE_H - 12),
|
||||
});
|
||||
|
||||
const mount = (automation: HfAutomation, over: Record<string, unknown> = {}) => {
|
||||
const base = laneProps({ automation, ...over });
|
||||
// Narrowed once here: laneProps types these as the prop signature, and every
|
||||
// assertion below reads the calls the lane made.
|
||||
const props = {
|
||||
...base,
|
||||
onPreview: base.onPreview as ReturnType<typeof vi.fn>,
|
||||
onCommit: base.onCommit as ReturnType<typeof vi.fn>,
|
||||
};
|
||||
const { container } = render(<TimelineAutomationLane {...props} />);
|
||||
const svg = container.querySelector("svg")!;
|
||||
stubBox(svg, BOX);
|
||||
return { container, svg, props };
|
||||
const mount = (automation: HfAutomation, over: Record<string, unknown> = {}) => {
|
||||
const base = laneProps({ automation, ...over });
|
||||
// Narrowed once here: laneProps types these as the prop signature, and every
|
||||
// assertion below reads the calls the lane made.
|
||||
const props = {
|
||||
...base,
|
||||
onPreview: base.onPreview as ReturnType<typeof vi.fn>,
|
||||
onCommit: base.onCommit as ReturnType<typeof vi.fn>,
|
||||
};
|
||||
const { container } = render(<TimelineAutomationLane {...props} />);
|
||||
const svg = container.querySelector("svg")!;
|
||||
stubBox(svg, BOX);
|
||||
return { container, svg, props };
|
||||
};
|
||||
|
||||
describe("TimelineAutomationLane modifiers", () => {
|
||||
it("bends a segment when it is Alt-dragged, and leaves the points where they were", () => {
|
||||
// `curve` was honoured everywhere it is read — drawn, sampled in preview,
|
||||
// baked into the render — with no gesture that could set it.
|
||||
@@ -608,3 +608,44 @@ describe("TimelineAutomationLane modifiers", () => {
|
||||
expect(committed?.lanes[0]?.points[0]?.v).toBe(VOLUME_RANGE.max);
|
||||
});
|
||||
});
|
||||
|
||||
describe("TimelineAutomationLane range selection", () => {
|
||||
it("drag on the background selects a range, snapped to the grid", () => {
|
||||
const onRangeSelect = vi.fn();
|
||||
const { svg } = mount(ramp, { snapTimes: [1], onRangeSelect });
|
||||
fire(svg, "pointerdown", at(0.98, 0.5)); // background: no point within grab radius
|
||||
fire(svg, "pointermove", at(3, 0.5));
|
||||
fire(svg, "pointerup", at(3, 0.5));
|
||||
const last = onRangeSelect.mock.calls.at(-1);
|
||||
expect(last?.[0]).toBe(1); // snapped to the beat
|
||||
expect(last?.[1]).toBeCloseTo(3, 1);
|
||||
});
|
||||
|
||||
it("a sub-threshold click clears instead of selecting", () => {
|
||||
const onRangeSelect = vi.fn();
|
||||
const onRangeClear = vi.fn();
|
||||
const { svg } = mount(ramp, { onRangeSelect, onRangeClear });
|
||||
fire(svg, "pointerdown", at(1, 0.5));
|
||||
fire(svg, "pointerup", at(1.001, 0.5));
|
||||
expect(onRangeSelect).not.toHaveBeenCalled();
|
||||
expect(onRangeClear).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("draws the selection rect between its endpoints", () => {
|
||||
const { container } = mount(ramp, { rangeSelection: { t0: 1, t1: 3 } });
|
||||
const rect = container.querySelector("[data-automation-selection]");
|
||||
expect(rect).not.toBeNull();
|
||||
expect(Number(rect?.getAttribute("x"))).toBeCloseTo(PAD + 100, 0); // xOf(1) at 400px/4s
|
||||
expect(Number(rect?.getAttribute("width"))).toBeCloseTo(200, 0);
|
||||
});
|
||||
|
||||
it("point drags still win over range selection", () => {
|
||||
const onRangeSelect = vi.fn();
|
||||
const { svg, props } = mount(ramp, { onRangeSelect });
|
||||
fire(svg, "pointerdown", at(0, 1)); // exactly on a point
|
||||
fire(svg, "pointermove", at(1, 0.8));
|
||||
fire(svg, "pointerup", at(1, 0.8));
|
||||
expect(onRangeSelect).not.toHaveBeenCalled();
|
||||
expect(props.onCommit).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -72,6 +72,10 @@ export interface TimelineAutomationLaneProps {
|
||||
readOnly?: boolean;
|
||||
/** Called when a read-only lane is pressed: selects the clip so it goes live. */
|
||||
onSelect?(): void;
|
||||
/** Active selection on THIS lane, or null. */
|
||||
rangeSelection?: { t0: number; t1: number } | null | undefined;
|
||||
onRangeSelect?: ((t0: number, t1: number) => void) | undefined;
|
||||
onRangeClear?: (() => void) | undefined;
|
||||
}
|
||||
|
||||
export function TimelineAutomationLane({
|
||||
@@ -89,6 +93,9 @@ export function TimelineAutomationLane({
|
||||
snapTimes,
|
||||
readOnly,
|
||||
onSelect,
|
||||
rangeSelection,
|
||||
onRangeSelect,
|
||||
onRangeClear,
|
||||
}: TimelineAutomationLaneProps) {
|
||||
const stored = laneFor(automation, target);
|
||||
|
||||
@@ -183,6 +190,9 @@ export function TimelineAutomationLane({
|
||||
snapTimes,
|
||||
readOnly,
|
||||
onSelect,
|
||||
onRangeSelect,
|
||||
onRangeClear,
|
||||
duration,
|
||||
});
|
||||
const { dragIndex, curveIndex, hint, editing } = gestures;
|
||||
|
||||
@@ -255,6 +265,31 @@ export function TimelineAutomationLane({
|
||||
stroke="rgba(255,255,255,0.08)"
|
||||
strokeDasharray="3 4"
|
||||
/>
|
||||
{rangeSelection ? (
|
||||
<>
|
||||
<rect
|
||||
data-automation-selection=""
|
||||
x={xOf(rangeSelection.t0)}
|
||||
y={0}
|
||||
width={Math.max(0, xOf(rangeSelection.t1) - xOf(rangeSelection.t0))}
|
||||
height={h}
|
||||
fill={accentColor}
|
||||
opacity={0.15}
|
||||
pointerEvents="none"
|
||||
/>
|
||||
{[rangeSelection.t0, rangeSelection.t1].map((t) => (
|
||||
<line
|
||||
key={t}
|
||||
x1={xOf(t)}
|
||||
x2={xOf(t)}
|
||||
y1={0}
|
||||
y2={h}
|
||||
stroke={accentColor}
|
||||
opacity={0.5}
|
||||
/>
|
||||
))}
|
||||
</>
|
||||
) : null}
|
||||
<path
|
||||
d={path}
|
||||
fill="none"
|
||||
@@ -355,6 +390,16 @@ export function TimelineAutomationLaneSlot({
|
||||
[beatTimes, element.start, element.duration],
|
||||
);
|
||||
const bound = lanes.bind(element, isSelected);
|
||||
// Stale-selection guard: the selected lane's target can vanish out from under
|
||||
// it (e.g. its effect got deleted from the chain, dropping the lane), leaving
|
||||
// a rectangle selecting nothing. Clear it rather than let it point at a
|
||||
// target that no longer draws.
|
||||
useEffect(() => {
|
||||
const target = bound.selection?.target;
|
||||
if (target !== undefined && !bound.lanes.some((lane) => lane.target === target)) {
|
||||
bound.onRangeClear();
|
||||
}
|
||||
}, [bound]);
|
||||
if (bound.lanes.length === 0) return null;
|
||||
const inClip = currentTime >= element.start && currentTime <= element.start + element.duration;
|
||||
const top = getTimelineLaneTop(laneCount);
|
||||
@@ -382,6 +427,13 @@ export function TimelineAutomationLaneSlot({
|
||||
onSelect={bound.onSelect}
|
||||
snapTimes={snapTimes}
|
||||
readOnly={bound.readOnly}
|
||||
rangeSelection={
|
||||
bound.selection?.target === lane.target
|
||||
? { t0: bound.selection.t0, t1: bound.selection.t1 }
|
||||
: null
|
||||
}
|
||||
onRangeSelect={(t0, t1) => bound.onRangeSelect(lane.target, t0, t1)}
|
||||
onRangeClear={bound.onRangeClear}
|
||||
/>
|
||||
);
|
||||
})}
|
||||
|
||||
@@ -0,0 +1,69 @@
|
||||
// @vitest-environment happy-dom
|
||||
import { act } from "react";
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
import { createRoot } from "react-dom/client";
|
||||
import { TimelineAutomationLaneSlot } from "./TimelineAutomationLane";
|
||||
import type { AutomationLaneBinding, UseAutomationLanesResult } from "./useAutomationLanes";
|
||||
import type { TimelineElement } from "../store/timelineElement";
|
||||
|
||||
(globalThis as unknown as { IS_REACT_ACT_ENVIRONMENT: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
|
||||
|
||||
const element: TimelineElement = {
|
||||
id: "bgm",
|
||||
key: "bgm",
|
||||
tag: "audio",
|
||||
start: 0,
|
||||
duration: 6,
|
||||
track: 0,
|
||||
};
|
||||
|
||||
function mountSlot(binding: Partial<AutomationLaneBinding>) {
|
||||
const onRangeClear = vi.fn();
|
||||
const lanes: UseAutomationLanesResult = {
|
||||
bind: () => ({
|
||||
automation: { version: 1, lanes: [] },
|
||||
lanes: [{ target: "volume", points: [{ t: 0, v: 1 }] }],
|
||||
chain: null,
|
||||
onPreview: vi.fn(),
|
||||
onCommit: vi.fn(),
|
||||
onSelect: vi.fn(),
|
||||
readOnly: false,
|
||||
selection: null,
|
||||
onRangeSelect: vi.fn(),
|
||||
onRangeClear,
|
||||
...binding,
|
||||
}),
|
||||
};
|
||||
const host = document.createElement("div");
|
||||
document.body.append(host);
|
||||
act(() => {
|
||||
createRoot(host).render(
|
||||
<TimelineAutomationLaneSlot
|
||||
element={element}
|
||||
isSelected={false}
|
||||
lanes={lanes}
|
||||
pps={100}
|
||||
laneCount={0}
|
||||
accentColor="#0af"
|
||||
currentTime={0}
|
||||
/>,
|
||||
);
|
||||
});
|
||||
return { onRangeClear };
|
||||
}
|
||||
|
||||
describe("TimelineAutomationLaneSlot stale-selection guard", () => {
|
||||
it("clears the selection when its lane's target no longer exists", () => {
|
||||
const { onRangeClear } = mountSlot({
|
||||
selection: { elementKey: "bgm", target: "fx.gone.wet", t0: 1, t1: 2 },
|
||||
});
|
||||
expect(onRangeClear).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("leaves an in-scope selection alone", () => {
|
||||
const { onRangeClear } = mountSlot({
|
||||
selection: { elementKey: "bgm", target: "volume", t0: 1, t1: 2 },
|
||||
});
|
||||
expect(onRangeClear).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
@@ -5,22 +5,21 @@ import { TimelineCompactDiamonds } from "./TimelineCompactDiamonds";
|
||||
import { TimelinePropertyLanes } from "./TimelinePropertyLanes";
|
||||
import { TimelineAutomationLaneSlot } from "./TimelineAutomationLane";
|
||||
import { useAutomationLanes } from "./useAutomationLanes";
|
||||
import { useAutomationSelectionKeyboard } from "../../hooks/useAutomationSelectionKeyboard";
|
||||
import { TimelineTrackHeader } from "./TimelineTrackHeader";
|
||||
import { resolveTrackKeyframeClip, trackShowsBeatStrip } from "./useTimelineTrackLayout";
|
||||
import { trackDisplayNumber, trackDisplaySuffix } from "./timelineTrackDisplay";
|
||||
import { clipTimingStart } from "../../hooks/gsapShared";
|
||||
import { getTimelineEditCapabilities } from "./timelineEditing";
|
||||
import { CLIP_Y, TRACK_H } from "./timelineLayout";
|
||||
import { usePlayerStore, type TimelineElement } from "../store/playerStore";
|
||||
import { usePlayerStore } from "../store/playerStore";
|
||||
import {
|
||||
isMultiDragActive,
|
||||
isMultiDragPassenger,
|
||||
multiDragDeltaSeconds,
|
||||
type MultiDragPreviewInput,
|
||||
multiDragPassengerOffsetPx,
|
||||
} from "./timelineMultiDragPreview";
|
||||
import type { TimelineLaneBaseProps } from "./timelineLaneProps";
|
||||
import type { TimelineEditCallbacks } from "./timelineCallbacks";
|
||||
import type { TimelineLanesProps } from "./timelineLaneProps";
|
||||
import { trackStudioKeyframeLaneExpand } from "../../telemetry/events";
|
||||
import { isAudioTimelineElement, isMusicTrack } from "../../utils/timelineInspector";
|
||||
import { createClipGestureHandlers } from "./timelineClipGestureHandlers";
|
||||
@@ -33,18 +32,6 @@ import type { TimelineLogicalRow } from "./timelineKeyboardNavigation";
|
||||
import { timelineClipFocusId } from "./timelineNavigationIdentity";
|
||||
import { useTimelineKeyboardActor } from "./useTimelineKeyboardActor";
|
||||
|
||||
interface TimelineLanesProps extends TimelineLaneBaseProps {
|
||||
/** Live-derived by TimelineCanvas from {@link TimelineLaneBaseProps.draggedClip}. */
|
||||
draggedElement: TimelineElement | null;
|
||||
multiDragPreview: MultiDragPreviewInput | null;
|
||||
onToggleTrackHidden: TimelineEditCallbacks["onToggleTrackHidden"];
|
||||
onTogglePropertyGroupKeyframe: TimelineEditCallbacks["onTogglePropertyGroupKeyframe"];
|
||||
onResizeElement: TimelineEditCallbacks["onResizeElement"];
|
||||
onMoveElement: TimelineEditCallbacks["onMoveElement"];
|
||||
onRazorSplit: TimelineEditCallbacks["onRazorSplit"];
|
||||
onRazorSplitAll: TimelineEditCallbacks["onRazorSplitAll"];
|
||||
}
|
||||
|
||||
export function TimelineLanes({
|
||||
pps,
|
||||
contentOrigin,
|
||||
@@ -112,6 +99,7 @@ export function TimelineLanes({
|
||||
const lanesIdPrefix = `timeline-lanes${useId().replaceAll(":", "")}`;
|
||||
const expandedClipIds = usePlayerStore((s) => s.expandedClipIds);
|
||||
const automationLanes = useAutomationLanes();
|
||||
useAutomationSelectionKeyboard({ lanes: automationLanes });
|
||||
const toggleClipExpanded = usePlayerStore((s) => s.toggleClipExpanded);
|
||||
const logicalRowsByTrack = useMemo(() => {
|
||||
const byTrack = new Map<number, TimelineLogicalRow[]>();
|
||||
|
||||
@@ -0,0 +1,96 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { pointsIn, replaceRange } from "./automationLaneSelection";
|
||||
import { sampleAutomationLane, VOLUME_RANGE } from "@hyperframes/core/audio-automation";
|
||||
import type { HfAutomationLane } from "@hyperframes/core/audio-automation";
|
||||
|
||||
const ramp: HfAutomationLane = {
|
||||
target: "volume",
|
||||
points: [
|
||||
{ t: 0, v: 1 },
|
||||
{ t: 2, v: 0.6 },
|
||||
{ t: 3, v: 0.4 },
|
||||
{ t: 6, v: 0 },
|
||||
],
|
||||
};
|
||||
|
||||
describe("pointsIn", () => {
|
||||
it("returns only the points inside the range, endpoints inclusive", () => {
|
||||
expect(pointsIn(ramp, 2, 3).map((p) => p.t)).toEqual([2, 3]);
|
||||
expect(pointsIn(ramp, 2.1, 2.9)).toEqual([]);
|
||||
});
|
||||
});
|
||||
|
||||
describe("replaceRange", () => {
|
||||
it("never moves the envelope outside the selection", () => {
|
||||
// THE invariant. Deleting the middle of a ramp must not reshape the rest.
|
||||
const next: HfAutomationLane = {
|
||||
target: "volume",
|
||||
points: replaceRange({ lane: ramp, range: VOLUME_RANGE, t0: 1.5, t1: 3.5, inner: [] }),
|
||||
};
|
||||
for (const t of [0, 0.5, 1.0, 1.5, 3.5, 4, 5, 6]) {
|
||||
expect(sampleAutomationLane(next, t, "linear")).toBeCloseTo(
|
||||
sampleAutomationLane(ramp, t, "linear"),
|
||||
5,
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
it("pins anchors at both edges when the interior empties", () => {
|
||||
const pts = replaceRange({ lane: ramp, range: VOLUME_RANGE, t0: 1.5, t1: 3.5, inner: [] });
|
||||
const times = pts.map((p) => p.t);
|
||||
expect(times).toContain(1.5);
|
||||
expect(times).toContain(3.5);
|
||||
expect(times).not.toContain(2);
|
||||
expect(times).not.toContain(3);
|
||||
});
|
||||
|
||||
it("lets inner points at the edges stand in for the anchors", () => {
|
||||
// A ramp generator emits its own boundary points; pinning a second anchor
|
||||
// at the same time would fight it.
|
||||
const pts = replaceRange({
|
||||
lane: ramp,
|
||||
range: VOLUME_RANGE,
|
||||
t0: 2,
|
||||
t1: 3,
|
||||
inner: [
|
||||
{ t: 2, v: 0 },
|
||||
{ t: 3, v: 1 },
|
||||
],
|
||||
});
|
||||
expect(pts.filter((p) => p.t === 2)).toHaveLength(1);
|
||||
expect(pts.find((p) => p.t === 2)?.v).toBe(0);
|
||||
});
|
||||
|
||||
it("sorts and respects the point cap", () => {
|
||||
const dense = Array.from({ length: 600 }, (_, i) => ({ t: 1.5 + i * 0.001, v: 0.5 }));
|
||||
const pts = replaceRange({ lane: ramp, range: VOLUME_RANGE, t0: 1.5, t1: 3.5, inner: dense });
|
||||
expect(pts.length).toBeLessThanOrEqual(512);
|
||||
expect([...pts].sort((a, b) => a.t - b.t)).toEqual(pts);
|
||||
});
|
||||
|
||||
it("keeps a constant flat when the lane has no points", () => {
|
||||
const empty: HfAutomationLane = { target: "volume", points: [] };
|
||||
const pts = replaceRange({ lane: empty, range: VOLUME_RANGE, t0: 1, t1: 2, inner: [] });
|
||||
// Nothing to preserve, nothing to pin: an empty lane stays empty.
|
||||
expect(pts).toEqual([]);
|
||||
});
|
||||
|
||||
it("keeps the far anchor and every outside point when inner would overflow the cap", () => {
|
||||
const dense = Array.from({ length: 600 }, (_, i) => ({ t: 1.5 + i * 0.001, v: 0.5 }));
|
||||
const pts = replaceRange({ lane: ramp, range: VOLUME_RANGE, t0: 1.5, t1: 3.5, inner: dense });
|
||||
const times = pts.map((p) => p.t);
|
||||
expect(times).toContain(1.5); // near anchor
|
||||
expect(times).toContain(3.5); // far anchor — this is what the bug dropped
|
||||
expect(times).toContain(0); // outside point before the range
|
||||
expect(times).toContain(6); // outside point after the range
|
||||
expect(pts.length).toBeLessThanOrEqual(512);
|
||||
});
|
||||
|
||||
it("thins the interior evenly rather than dropping its tail", () => {
|
||||
const dense = Array.from({ length: 2001 }, (_, i) => ({ t: 1.5 + i * 0.001, v: 0.5 }));
|
||||
const pts = replaceRange({ lane: ramp, range: VOLUME_RANGE, t0: 1.5, t1: 3.5, inner: dense });
|
||||
const innerTimes = pts.map((p) => p.t).filter((t) => t > 1.5 && t < 3.5);
|
||||
// Evenly spread across the range, not clustered at the start.
|
||||
expect(Math.max(...innerTimes)).toBeGreaterThan(3.0);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,74 @@
|
||||
/**
|
||||
* Range operations over one automation lane.
|
||||
*
|
||||
* `replaceRange` is the only mutator every range feature (delete, shapes,
|
||||
* paste, stretch) composes, and it carries the invariant that makes them safe:
|
||||
* the envelope OUTSIDE the selection never moves. It samples the lane at both
|
||||
* edges first and pins anchor points there, so cutting the middle out of a
|
||||
* ramp cannot reshape the rest of the clip.
|
||||
*
|
||||
* Exact for linear segments. A curved segment straddling an edge keeps its
|
||||
* edge VALUE but reshapes slightly between its own start and the anchor — the
|
||||
* curve exponent now runs over a shorter span. Accepted: the alternative is
|
||||
* splitting curves analytically for a difference the ear cannot place.
|
||||
*/
|
||||
|
||||
import {
|
||||
MAX_AUTOMATION_POINTS,
|
||||
sampleAutomationLane,
|
||||
type AutomationRange,
|
||||
type HfAutomationLane,
|
||||
type HfAutomationPoint,
|
||||
} from "@hyperframes/core/audio-automation";
|
||||
import { POINT_MERGE_SEC } from "./automationLaneGeometry";
|
||||
|
||||
/** Points inside [t0, t1], endpoints inclusive. */
|
||||
export function pointsIn(lane: HfAutomationLane, t0: number, t1: number): HfAutomationPoint[] {
|
||||
return lane.points.filter((p) => p.t >= t0 && p.t <= t1);
|
||||
}
|
||||
|
||||
/** An anchor, unless `inner` already provides the edge within the merge radius. */
|
||||
function anchor(
|
||||
lane: HfAutomationLane,
|
||||
range: AutomationRange,
|
||||
t: number,
|
||||
inner: readonly HfAutomationPoint[],
|
||||
): HfAutomationPoint[] {
|
||||
if (inner.some((p) => Math.abs(p.t - t) <= POINT_MERGE_SEC)) return [];
|
||||
return [{ t, v: sampleAutomationLane(lane, t, range.scale) }];
|
||||
}
|
||||
|
||||
/** Evenly subsample items to a budget, preserving first and last. */
|
||||
function decimateEvenly<T>(items: readonly T[], budget: number): T[] {
|
||||
if (budget <= 0) return [];
|
||||
if (items.length <= budget) return [...items];
|
||||
if (budget === 1) return [items[0]!];
|
||||
const out: T[] = [];
|
||||
const step = (items.length - 1) / (budget - 1);
|
||||
for (let i = 0; i < budget; i += 1) {
|
||||
const item = items[Math.round(i * step)];
|
||||
if (item) out.push(item);
|
||||
}
|
||||
return out;
|
||||
}
|
||||
|
||||
export function replaceRange(input: {
|
||||
lane: HfAutomationLane;
|
||||
range: AutomationRange;
|
||||
t0: number;
|
||||
t1: number;
|
||||
inner: HfAutomationPoint[];
|
||||
}): HfAutomationPoint[] {
|
||||
const { lane, range, t0, t1, inner } = input;
|
||||
// An empty lane draws a flat default; there is nothing to preserve, and
|
||||
// pinning anchors would turn "no automation" into a constant lane.
|
||||
if (lane.points.length === 0 && inner.length === 0) return [];
|
||||
const outside = lane.points.filter((p) => p.t < t0 || p.t > t1);
|
||||
const edges =
|
||||
lane.points.length === 0
|
||||
? []
|
||||
: [...anchor(lane, range, t0, inner), ...anchor(lane, range, t1, inner)];
|
||||
const budget = Math.max(0, MAX_AUTOMATION_POINTS - outside.length - edges.length);
|
||||
const cappedInner = inner.length <= budget ? inner : decimateEvenly(inner, budget);
|
||||
return [...outside, ...edges, ...cappedInner].sort((a, b) => a.t - b.t);
|
||||
}
|
||||
@@ -9,6 +9,8 @@ import type { DraggedClipState, ResizingClipState, BlockedClipState } from "./us
|
||||
import type { TimelineClipIndex, TimelineTimeRange } from "../lib/timelineClipIndex";
|
||||
import type { TimelineRowGeometry } from "./timelineLayout";
|
||||
import type { TimelineVirtualRow } from "./useTimelineVirtualRows";
|
||||
import type { MultiDragPreviewInput } from "./timelineMultiDragPreview";
|
||||
import type { TimelineEditCallbacks } from "./timelineCallbacks";
|
||||
import type { TimelineLogicalRow } from "./timelineKeyboardNavigation";
|
||||
import type { TimelineClipRenderContext } from "./TimelineTypes";
|
||||
|
||||
@@ -98,3 +100,20 @@ export interface TimelineLaneBaseProps {
|
||||
onContextMenuLane?: (e: React.MouseEvent, track: number, time: number) => void;
|
||||
beatAnalysis?: MusicBeatAnalysis | null;
|
||||
}
|
||||
|
||||
/**
|
||||
* {@link TimelineLaneBaseProps} plus the handful of props only the lane
|
||||
* renderer ({@link import("./TimelineLanes")}) itself needs — the drag-preview
|
||||
* state and the edit callbacks TimelineCanvas does not otherwise touch.
|
||||
*/
|
||||
export interface TimelineLanesProps extends TimelineLaneBaseProps {
|
||||
/** Live-derived by TimelineCanvas from {@link TimelineLaneBaseProps.draggedClip}. */
|
||||
draggedElement: TimelineElement | null;
|
||||
multiDragPreview: MultiDragPreviewInput | null;
|
||||
onToggleTrackHidden: TimelineEditCallbacks["onToggleTrackHidden"];
|
||||
onTogglePropertyGroupKeyframe: TimelineEditCallbacks["onTogglePropertyGroupKeyframe"];
|
||||
onResizeElement: TimelineEditCallbacks["onResizeElement"];
|
||||
onMoveElement: TimelineEditCallbacks["onMoveElement"];
|
||||
onRazorSplit: TimelineEditCallbacks["onRazorSplit"];
|
||||
onRazorSplitAll: TimelineEditCallbacks["onRazorSplitAll"];
|
||||
}
|
||||
|
||||
@@ -56,6 +56,10 @@ export interface UseAutomationLaneGesturesInput {
|
||||
snapTimes?: readonly number[] | undefined;
|
||||
readOnly?: boolean | undefined;
|
||||
onSelect?: (() => void) | undefined;
|
||||
/** Live range-select callbacks; absent = background drags do nothing (read-only lanes). */
|
||||
onRangeSelect?: ((t0: number, t1: number) => void) | undefined;
|
||||
onRangeClear?: (() => void) | undefined;
|
||||
duration: number; // clamp bound for range endpoints
|
||||
}
|
||||
|
||||
export interface UseAutomationLaneGesturesResult {
|
||||
@@ -90,6 +94,9 @@ export function useAutomationLaneGestures({
|
||||
snapTimes,
|
||||
readOnly,
|
||||
onSelect,
|
||||
onRangeSelect,
|
||||
onRangeClear,
|
||||
duration,
|
||||
}: UseAutomationLaneGesturesInput): UseAutomationLaneGesturesResult {
|
||||
const [dragIndex, setDragIndex] = useState<number | null>(null);
|
||||
const [curveIndex, setCurveIndex] = useState<number | null>(null);
|
||||
@@ -98,6 +105,11 @@ export function useAutomationLaneGestures({
|
||||
const dragOrigin = useRef<{ t: number; v: number } | null>(null);
|
||||
/** Point whose value is being typed, and the text so far. */
|
||||
const [editing, setEditing] = useState<{ index: number; text: string } | null>(null);
|
||||
/** A background drag in progress: its start and live end, in clip seconds. */
|
||||
const [rangeDrag, setRangeDrag] = useState<{ from: number; to: number } | null>(null);
|
||||
/** Whether the live drag has crossed the pixel threshold that turns a press
|
||||
* into an actual range, rather than a click that should just clear one. */
|
||||
const rangeCrossed = useRef(false);
|
||||
|
||||
/** Index of a point under the pointer, or null. */
|
||||
const hitIndex = useCallback(
|
||||
@@ -155,7 +167,22 @@ export function useAutomationLaneGestures({
|
||||
return;
|
||||
}
|
||||
const gesture = gestureAt(e);
|
||||
if (!gesture) return;
|
||||
if (!gesture) {
|
||||
// Neither a point nor an Alt-held segment: the press landed on the
|
||||
// lane's empty background. That is a range selection's gesture, not
|
||||
// nothing — but only when a caller wants to hear about one; a
|
||||
// read-only lane already returned above, so this is a live one with no
|
||||
// range feature wired up.
|
||||
if (!onRangeSelect) return;
|
||||
e.preventDefault();
|
||||
capturePointer(e);
|
||||
const raw = pointAt(e.clientX, e.clientY).t;
|
||||
const clamped = Math.min(duration, Math.max(0, raw));
|
||||
const t = e.altKey ? clamped : snapLaneTime(clamped, snapTimes ?? [], SNAP_SEC);
|
||||
rangeCrossed.current = false;
|
||||
setRangeDrag({ from: t, to: t });
|
||||
return;
|
||||
}
|
||||
e.preventDefault();
|
||||
capturePointer(e);
|
||||
if (gesture.curve) {
|
||||
@@ -165,7 +192,7 @@ export function useAutomationLaneGestures({
|
||||
dragOrigin.current = originOf(lane.points[gesture.index]);
|
||||
setDragIndex(gesture.index);
|
||||
},
|
||||
[gestureAt, lane, readOnly, onSelect],
|
||||
[gestureAt, lane, readOnly, onSelect, onRangeSelect, pointAt, duration, snapTimes],
|
||||
);
|
||||
|
||||
/** Bend the segment under the pointer, which is what Alt-dragging the line does. */
|
||||
@@ -214,16 +241,46 @@ export function useAutomationLaneGestures({
|
||||
|
||||
const onPointerMove = useCallback(
|
||||
(e: ReactPointerEvent<SVGSVGElement>): void => {
|
||||
if (rangeDrag !== null) {
|
||||
e.stopPropagation();
|
||||
const raw = pointAt(e.clientX, e.clientY).t;
|
||||
const clamped = Math.min(duration, Math.max(0, raw));
|
||||
const t = e.altKey ? clamped : snapLaneTime(clamped, snapTimes ?? [], SNAP_SEC);
|
||||
setRangeDrag({ from: rangeDrag.from, to: t });
|
||||
if (Math.abs(xOf(t) - xOf(rangeDrag.from)) > 3) {
|
||||
rangeCrossed.current = true;
|
||||
onRangeSelect?.(Math.min(rangeDrag.from, t), Math.max(rangeDrag.from, t));
|
||||
}
|
||||
return;
|
||||
}
|
||||
if (curveIndex === null && dragIndex === null) return;
|
||||
e.stopPropagation();
|
||||
if (curveIndex !== null) bendSegment(e.clientX, e.clientY);
|
||||
else movePoint(e);
|
||||
},
|
||||
[bendSegment, curveIndex, dragIndex, movePoint],
|
||||
[
|
||||
rangeDrag,
|
||||
pointAt,
|
||||
duration,
|
||||
snapTimes,
|
||||
xOf,
|
||||
onRangeSelect,
|
||||
bendSegment,
|
||||
curveIndex,
|
||||
dragIndex,
|
||||
movePoint,
|
||||
],
|
||||
);
|
||||
|
||||
const endDrag = useCallback(
|
||||
(e: ReactPointerEvent<SVGSVGElement>): void => {
|
||||
if (rangeDrag !== null) {
|
||||
e.stopPropagation();
|
||||
if (!rangeCrossed.current) onRangeClear?.();
|
||||
rangeCrossed.current = false;
|
||||
setRangeDrag(null);
|
||||
return;
|
||||
}
|
||||
if (dragIndex === null && curveIndex === null) return;
|
||||
e.stopPropagation();
|
||||
setDragIndex(null);
|
||||
@@ -232,7 +289,7 @@ export function useAutomationLaneGestures({
|
||||
setHint(null);
|
||||
commitPoints(lane.points, true);
|
||||
},
|
||||
[curveIndex, dragIndex, lane, commitPoints],
|
||||
[rangeDrag, onRangeClear, curveIndex, dragIndex, lane, commitPoints],
|
||||
);
|
||||
|
||||
const onDoubleClick = useCallback(
|
||||
|
||||
@@ -19,7 +19,9 @@ import {
|
||||
} from "@hyperframes/core/audio-automation";
|
||||
import type { HfAudioFxChain } from "@hyperframes/core/audio-fx";
|
||||
import { useDomEditActionsContextOptional } from "../../contexts/DomEditContext";
|
||||
import type { TimelineElement } from "../store/playerStore";
|
||||
import { getTimelineElementIdentity } from "../lib/timelineElementHelpers";
|
||||
import { usePlayerStore, type TimelineElement } from "../store/playerStore";
|
||||
import type { AutomationSelection } from "../store/automationSelectionSlice";
|
||||
import { elementAutomation, elementFxChain } from "./automationLaneData";
|
||||
|
||||
export interface AutomationLaneBinding {
|
||||
@@ -39,6 +41,13 @@ export interface AutomationLaneBinding {
|
||||
*/
|
||||
onSelect(): void;
|
||||
readOnly: boolean;
|
||||
/** This element's active time selection, or null if none / it belongs to a
|
||||
* different element. */
|
||||
selection: AutomationSelection | null;
|
||||
/** Live write while dragging a range on the given lane; does not persist —
|
||||
* the selection is ephemeral store state, not part of the composition. */
|
||||
onRangeSelect(target: string, t0: number, t1: number): void;
|
||||
onRangeClear(): void;
|
||||
}
|
||||
|
||||
export interface UseAutomationLanesResult {
|
||||
@@ -49,11 +58,15 @@ export function useAutomationLanes(): UseAutomationLanesResult {
|
||||
// Optional: the player also runs outside Studio, where there is no edit
|
||||
// session. There the lanes render read-only, which is the right fallback.
|
||||
const domEdit = useDomEditActionsContextOptional();
|
||||
const automationSelection = usePlayerStore((s) => s.automationSelection);
|
||||
const setAutomationSelection = usePlayerStore((s) => s.setAutomationSelection);
|
||||
const clearAutomationSelection = usePlayerStore((s) => s.clearAutomationSelection);
|
||||
|
||||
const bind = useCallback(
|
||||
(element: TimelineElement, isSelected: boolean): AutomationLaneBinding => {
|
||||
const chain = elementFxChain(element);
|
||||
const automation = elementAutomation(element);
|
||||
const elementKey = getTimelineElementIdentity(element);
|
||||
|
||||
const write = (next: HfAutomation, persist: boolean): void => {
|
||||
if (!domEdit || !isSelected) return;
|
||||
@@ -80,9 +93,15 @@ export function useAutomationLanes(): UseAutomationLanesResult {
|
||||
// Selecting is its own gesture; the lane goes live after it.
|
||||
onSelect: () => void domEdit?.handleTimelineElementSelect(element),
|
||||
readOnly: !domEdit || !isSelected,
|
||||
selection: automationSelection?.elementKey === elementKey ? automationSelection : null,
|
||||
onRangeSelect: (target, t0, t1) => {
|
||||
if (!domEdit || !isSelected) return;
|
||||
setAutomationSelection({ elementKey, target, t0, t1 });
|
||||
},
|
||||
onRangeClear: () => clearAutomationSelection(),
|
||||
};
|
||||
},
|
||||
[domEdit],
|
||||
[domEdit, automationSelection, setAutomationSelection, clearAutomationSelection],
|
||||
);
|
||||
|
||||
return useMemo(() => ({ bind }), [bind]);
|
||||
|
||||
@@ -0,0 +1,14 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { usePlayerStore } from "./playerStore";
|
||||
|
||||
describe("automationSelectionSlice", () => {
|
||||
it("stores one ordered selection and clears it", () => {
|
||||
const store = usePlayerStore.getState();
|
||||
store.setAutomationSelection({ elementKey: "bgm", target: "volume", t0: 2, t1: 1 });
|
||||
const sel = usePlayerStore.getState().automationSelection;
|
||||
// Ordered on write, so every consumer can assume t0 < t1.
|
||||
expect(sel).toEqual({ elementKey: "bgm", target: "volume", t0: 1, t1: 2 });
|
||||
usePlayerStore.getState().clearAutomationSelection();
|
||||
expect(usePlayerStore.getState().automationSelection).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,38 @@
|
||||
/**
|
||||
* The active time selection on one automation lane.
|
||||
*
|
||||
* A store slice, not lane-local state, for the same reason keyframe selection
|
||||
* is one: Delete/copy/paste handlers and the shape menu live outside the lane
|
||||
* component and need to read it. Ephemeral by construction — nothing
|
||||
* serializes store state, and the selection must never survive into a render.
|
||||
*/
|
||||
import type { StoreApi } from "zustand";
|
||||
|
||||
export interface AutomationSelection {
|
||||
/** TimelineElement key (key ?? id) of the clip that owns the lane. */
|
||||
elementKey: string;
|
||||
/** Lane target: "volume" or "fx.<nodeId>.<param>". */
|
||||
target: string;
|
||||
/** Clip-local seconds; always t0 < t1 (ordered on write). */
|
||||
t0: number;
|
||||
t1: number;
|
||||
}
|
||||
|
||||
export interface AutomationSelectionSlice {
|
||||
automationSelection: AutomationSelection | null;
|
||||
setAutomationSelection: (sel: AutomationSelection) => void;
|
||||
clearAutomationSelection: () => void;
|
||||
}
|
||||
|
||||
export function createAutomationSelectionSlice(
|
||||
set: StoreApi<AutomationSelectionSlice>["setState"],
|
||||
): AutomationSelectionSlice {
|
||||
return {
|
||||
automationSelection: null,
|
||||
setAutomationSelection: (sel) =>
|
||||
set({
|
||||
automationSelection: sel.t0 <= sel.t1 ? sel : { ...sel, t0: sel.t1, t1: sel.t0 },
|
||||
}),
|
||||
clearAutomationSelection: () => set({ automationSelection: null }),
|
||||
};
|
||||
}
|
||||
@@ -10,6 +10,10 @@ import {
|
||||
} from "../../utils/studioUiPreferences";
|
||||
import { clampTimelineZoomPercent, computePinnedZoomPercent } from "../components/timelineZoom";
|
||||
import { createKeyframeSlice, type KeyframeCacheEntry, type KeyframeSlice } from "./keyframeSlice";
|
||||
import {
|
||||
createAutomationSelectionSlice,
|
||||
type AutomationSelectionSlice,
|
||||
} from "./automationSelectionSlice";
|
||||
import { createTimelineFocusRequest, type TimelineFocusRequest } from "./timelineFocusState";
|
||||
import { createThumbnailSlice, type ThumbnailSlice } from "./thumbnailSlice";
|
||||
|
||||
@@ -43,7 +47,7 @@ function resolveElementSelection(
|
||||
};
|
||||
}
|
||||
|
||||
interface PlayerState extends KeyframeSlice, ThumbnailSlice {
|
||||
interface PlayerState extends KeyframeSlice, AutomationSelectionSlice, ThumbnailSlice {
|
||||
isPlaying: boolean;
|
||||
currentTime: number;
|
||||
duration: number;
|
||||
@@ -282,6 +286,8 @@ export const usePlayerStore = create<PlayerState>((set, get) => ({
|
||||
})),
|
||||
...createThumbnailSlice(set),
|
||||
|
||||
...createAutomationSelectionSlice(set),
|
||||
|
||||
activeKeyframePct: null,
|
||||
setActiveKeyframePct: (pct) => set({ activeKeyframePct: pct }),
|
||||
motionPathArmed: false,
|
||||
|
||||
Reference in New Issue
Block a user