ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-11-12 20:47:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

merge: pull in the wet/dry dedupe fix

Browse Source
This commit is contained in:
Vance Ingalls
2026-08-12 14:12:17 -07:00
parent 04520a03e5 04205bfa94
commit 5dead7f3cc
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/audio/audioFxGraph.ts
+8 -4
View File
@@ -94,6 +94,12 @@ function mixTargets(wet: AudioParam, dry: AudioParam): FxParamTarget[] {
return [{ param: wet }, { param: dry, map: (v) => 1 - v }];
}
/** Linear crossfade: dry falls as wet rises, in lockstep. */
function setWetDryMix(wet: GainNode, dry: GainNode, mix: number): void {
wet.gain.value = mix;
dry.gain.value = 1 - mix;
}
/** A node that is its own input and output and has nothing to tear down. */
function simple(
node: AudioNode,
@@ -243,8 +249,7 @@ const delayFeedback: Builder = (ctx, p) => {
const apply = (v: HfAudioFxParamValues): void => {
dl.delayTime.value = Math.min(5, n(v.time) / 1000);
fb.gain.value = n(v.feedback);
wet.gain.value = n(v.mix);
dry.gain.value = 1 - n(v.mix);
setWetDryMix(wet, dry, n(v.mix));
};
apply(p);
return {
@@ -276,8 +281,7 @@ const chorusLfo: Builder = (ctx, p) => {
dl.delayTime.value = n(v.delay) / 1000;
depth.gain.value = n(v.depth) / 1000;
lfo.frequency.value = n(v.speed);
wet.gain.value = n(v.mix);
dry.gain.value = 1 - n(v.mix);
setWetDryMix(wet, dry, n(v.mix));
};
apply(p);
return {