fix(cli): doctor shows platform-correct install hints (#319)

The "FFmpeg not found" hint was hardcoded to `sudo apt install ffmpeg`
for any non-macOS platform — Windows users would see an apt command that
doesn't exist on their system, and Red Hat / Arch users got the wrong
package manager too.

`getFFmpegInstallHint()` already exists in browser/ffmpeg.ts (and is
already used by render.ts) and handles darwin / linux / win32 correctly.
Use it here too.

Also rewrite checkFFprobe:
- it previously used `which ffprobe` which is not available on Windows
  (cmd uses `where`), so on Windows the check always reported "Not
  found" even when ffprobe was on PATH
- run `ffprobe -version` directly instead, which works cross-platform
  whenever ffprobe is resolvable on PATH, and surfaces the version
  string in the same style as the FFmpeg check
This commit is contained in:
Dylanwoo
2026-04-18 11:59:49 -07:00
committed by GitHub
parent 03bf1e69f4
commit 64e3735100
+8 -5
View File
@@ -6,7 +6,7 @@ export const examples: Example[] = [["Check system dependencies", "hyperframes d
import { freemem, platform } from "node:os";
import { c } from "../ui/colors.js";
import { findBrowser } from "../browser/manager.js";
import { findFFmpeg } from "../browser/ffmpeg.js";
import { findFFmpeg, getFFmpegInstallHint } from "../browser/ffmpeg.js";
import { VERSION } from "../version.js";
import { getUpdateMeta } from "../utils/updateCheck.js";
import { getSystemMeta, getShmSizeMb, getFreeDiskMb, bytesToMb } from "../telemetry/system.js";
@@ -36,19 +36,22 @@ function checkFFmpeg(): CheckResult {
return {
ok: false,
detail: "Not found",
hint: process.platform === "darwin" ? "brew install ffmpeg" : "sudo apt install ffmpeg",
hint: getFFmpegInstallHint(),
};
}
function checkFFprobe(): CheckResult {
// `ffprobe -version` works cross-platform if it's on PATH — no need for
// `which`/`where` shell detection, which differs by OS.
try {
const result = execSync("which ffprobe", { encoding: "utf-8", timeout: 5000 }).trim();
return { ok: true, detail: result };
const version =
execSync("ffprobe -version", { encoding: "utf-8", timeout: 5000 }).split("\n")[0] ?? "";
return { ok: true, detail: version.trim() };
} catch {
return {
ok: false,
detail: "Not found",
hint: "Installed with ffmpeg",
hint: `Installed with ffmpeg — ${getFFmpegInstallHint()}`,
};
}
}