mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-18 07:50:13 +00:00
fix(cli): a render's lint runs at normal priority, so a busy Windows PC no longer stalls it (#7268)
This commit is contained in:
@@ -627,7 +627,7 @@ async function printStartupLint(dir: string, verbose: boolean): Promise<void> {
|
||||
try {
|
||||
const lintResult = await runRenderSetupWorker<ProjectLintResult>(
|
||||
"lint",
|
||||
{ projectDir: dir },
|
||||
{ projectDir: dir, background: true },
|
||||
{ maxBufferBytes: 8 * 1024 * 1024 },
|
||||
);
|
||||
if (lintResult.totalErrors === 0 && lintResult.totalWarnings === 0) return;
|
||||
|
||||
@@ -12,11 +12,14 @@ beforeEach(() => {
|
||||
vi.resetModules();
|
||||
os.setPriority.mockReset();
|
||||
process.argv[2] = "lint";
|
||||
process.env.HYPERFRAMES_RENDER_SETUP_INPUT = JSON.stringify({ projectDir: "/project" });
|
||||
process.env.HYPERFRAMES_RENDER_SETUP_INPUT = JSON.stringify({
|
||||
projectDir: "/project",
|
||||
background: true,
|
||||
});
|
||||
});
|
||||
afterEach(() => vi.restoreAllMocks());
|
||||
|
||||
it("lints at the lowest CPU priority so it never competes with a Studio boot", async () => {
|
||||
it("a background lint runs at the lowest CPU priority so it never competes with a Studio boot", async () => {
|
||||
const write = vi.spyOn(process.stdout, "write").mockImplementation(() => true);
|
||||
|
||||
await import("./renderSetupWorker.js");
|
||||
@@ -25,6 +28,17 @@ it("lints at the lowest CPU priority so it never competes with a Studio boot", a
|
||||
expect(write).toHaveBeenCalledWith(expect.stringContaining('{"ok":true}'));
|
||||
});
|
||||
|
||||
// fails without the fix: a render waits on its lint, and at idle priority a busy Windows PC starved it for minutes.
|
||||
it("a render's lint keeps normal priority", async () => {
|
||||
process.env.HYPERFRAMES_RENDER_SETUP_INPUT = JSON.stringify({ projectDir: "/project" });
|
||||
const write = vi.spyOn(process.stdout, "write").mockImplementation(() => true);
|
||||
|
||||
await import("./renderSetupWorker.js");
|
||||
|
||||
expect(os.setPriority).not.toHaveBeenCalled();
|
||||
expect(write).toHaveBeenCalledWith(expect.stringContaining('{"ok":true}'));
|
||||
});
|
||||
|
||||
const nodeSystemErrorWithOsCodeInInfo = (code: string) =>
|
||||
Object.assign(new Error(`A system error occurred: uv_os_setpriority returned ${code}`), {
|
||||
code: "ERR_SYSTEM_ERROR",
|
||||
|
||||
@@ -36,8 +36,8 @@ async function runMode(): Promise<unknown> {
|
||||
if (mode === "browser") return ensureBrowser(input);
|
||||
if (mode === "browser-install") return runBrowserInstall(input);
|
||||
if (mode === "lint") {
|
||||
// Nobody waits on a background lint the way they wait on a Studio boot, so it takes idle CPU only.
|
||||
lowerPriority();
|
||||
// A background lint (Studio's, preview's) takes idle CPU only; a render waits on its lint, so that one does not.
|
||||
if (input.background) lowerPriority();
|
||||
return lintProject(
|
||||
input.projectDir,
|
||||
input.entryFile,
|
||||
|
||||
@@ -593,7 +593,7 @@ export function createStudioServer(options: StudioServerOptions): StudioServer {
|
||||
lintProject: (dir: string) =>
|
||||
runRenderSetupWorker<ProjectLintResult>(
|
||||
"lint",
|
||||
{ projectDir: dir, host: "studio" },
|
||||
{ projectDir: dir, host: "studio", background: true },
|
||||
{ maxBufferBytes: 8 * 1024 * 1024 },
|
||||
),
|
||||
|
||||
|
||||
Reference in New Issue
Block a user