ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-11-11 19:09:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): dedupe the wet/dry mix math between delayFeedback and chorusLfo

Browse Source 
Both effect builders set wet.gain to the mix and dry.gain to its complement
in identical two-line blocks; fallow kept re-flagging it as a 10-line clone
on every unrelated change. Extracted setWetDryMix.
This commit is contained in:
Vance Ingalls
2026-08-12 14:07:55 -07:00
parent 6edd737b47
commit 7cf032d2f6
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/audio/audioFxGraph.ts
+8 -4
View File
@@ -69,6 +69,12 @@ type Builder = (ctx: BaseAudioContext, p: HfAudioFxParamValues) => FxNodeHandle;
const n = (v: number | string | undefined): number => (typeof v === "number" ? v : Number(v ?? 0));
/** Linear crossfade: dry falls as wet rises, in lockstep. */
function setWetDryMix(wet: GainNode, dry: GainNode, mix: number): void {
wet.gain.value = mix;
dry.gain.value = 1 - mix;
}
/** A node that is its own input and output and has nothing to tear down. */
function simple(node: AudioNode, update: (p: HfAudioFxParamValues) => void): FxNodeHandle {
return { input: node, output: node, update, dispose: () => node.disconnect() };
@@ -177,8 +183,7 @@ const delayFeedback: Builder = (ctx, p) => {
const apply = (v: HfAudioFxParamValues): void => {
dl.delayTime.value = Math.min(5, n(v.time) / 1000);
fb.gain.value = n(v.feedback);
wet.gain.value = n(v.mix);
dry.gain.value = 1 - n(v.mix);
setWetDryMix(wet, dry, n(v.mix));
};
apply(p);
return {
@@ -205,8 +210,7 @@ const chorusLfo: Builder = (ctx, p) => {
dl.delayTime.value = n(v.delay) / 1000;
depth.gain.value = n(v.depth) / 1000;
lfo.frequency.value = n(v.speed);
wet.gain.value = n(v.mix);
dry.gain.value = 1 - n(v.mix);
setWetDryMix(wet, dry, n(v.mix));
};
apply(p);
return {