feat(studio-server): an opaque preview loads its images, media and fetched files (#7806)

* feat(studio-server): an opaque preview loads its images, media and fetched files

* refactor(studio-server): the fetch grant's reach is named, not commented

* test(studio-server): the main preview loads under the frame-token path
This commit is contained in:
Miguel Ángel
2026-11-15 16:43:08 +00:00
committed by GitHub
parent ce18c3a102
commit 88ffe087ca
2 changed files with 48 additions and 16 deletions
@@ -1,9 +1,15 @@
import { createHmac, randomBytes, timingSafeEqual } from "node:crypto";
import type { Context, Hono, Next } from "hono";
import { getMimeType } from "./mime.js";
const GRANTED_LOADS = new Map([
["font", { path: /\.(woff2?|ttf|otf)$/i, type: /^font\// }],
["script", { path: /\.m?js$/i, type: /^text\/javascript\b/ }],
const ANY_FILE_THE_PREVIEW_SERVES = /./;
const GRANTED_TYPES = new Map([
["font", /^font\//],
["script", /^text\/javascript\b/],
["image", /^image\//],
["video", /^video\//],
["audio", /^audio\//],
["empty", ANY_FILE_THE_PREVIEW_SERVES],
]);
const TOKEN_SEGMENT = /^~([\w-]{43})$/;
@@ -16,10 +22,10 @@ interface OpaqueFrameLoad {
}
function opaqueFrameLoadGranted(load: OpaqueFrameLoad): boolean {
const grant = load.origin === "null" ? GRANTED_LOADS.get(load.dest ?? "") : undefined;
if (!grant?.path.test(load.pathname)) return false;
const type = load.origin === "null" ? GRANTED_TYPES.get(load.dest ?? "") : undefined;
if (!type?.test(getMimeType(load.pathname))) return false;
const keepsStoredContentType = load.status === 304;
return keepsStoredContentType || grant.type.test(load.contentType ?? "");
return keepsStoredContentType || type.test(load.contentType ?? "");
}
export function createFrameTokens() {
@@ -21,6 +21,8 @@ writeFileSync(join(projectDir, "scene.js"), "export const scene = 1;");
writeFileSync(join(projectDir, "scene.mjs"), "export const scene = 2;");
writeFileSync(join(projectDir, "data.json"), '{"secret":true}');
writeFileSync(join(projectDir, "logo.png"), Buffer.from([0x89, 0x50, 0x4e, 0x47]));
writeFileSync(join(projectDir, "clip.mp4"), Buffer.from("mp4-bytes"));
writeFileSync(join(projectDir, "music.mp3"), Buffer.from("mp3-bytes"));
writeFileSync(join(root, "other", "index.html"), '<div data-composition-id="main"></div>');
afterAll(() => rmSync(root, { recursive: true, force: true }));
afterEach(() => vi.useRealTimers());
@@ -91,6 +93,14 @@ describe("an opaque preview frame's loads under its token", () => {
["font", "fonts/Brand.ttf", "font/ttf"],
["script", "scene.js", "text/javascript"],
["script", "scene.mjs", "text/javascript"],
["image", "logo.png", "image/png"],
["video", "clip.mp4", "video/mp4"],
["audio", "music.mp3", "audio/mpeg"],
// The runtime fetches captions, sub-compositions, grades and audio from its own frame.
["empty", "data.json", "application/json"],
["empty", "comp/scene.html", "text/html"],
["empty", "music.mp3", "audio/mpeg"],
["empty", "fonts/Brand.woff2", "font/woff2"],
])("lets a %s load of %s through", async (dest, path, type) => {
const res = await load(path, { origin: "null", "sec-fetch-dest": dest });
expect(res.status).toBe(200);
@@ -138,14 +148,15 @@ describe("an opaque preview frame's loads under its token", () => {
});
it.each([
["empty", "fonts/Brand.woff2"],
["empty", "scene.js"],
["empty", "data.json"],
["empty", "scene.html"],
["document", "scene.html"],
["iframe", "scene.html"],
["image", "logo.png"],
["style", "fonts/Brand.woff2"],
["image", "data.json"],
["image", "clip.mp4"],
["video", "music.mp3"],
["video", "logo.png"],
["audio", "clip.mp4"],
["audio", "comp/music.mp3"],
["font", "data.json"],
["font", "scene.js"],
["script", "data.json"],
@@ -163,7 +174,7 @@ describe("an opaque preview frame's loads under its token", () => {
expectNotGranted(res);
});
it("refuses a page's own fetch, which carries no Sec-Fetch-Dest it can choose", async () => {
it("refuses a load that names no Sec-Fetch-Dest", async () => {
expectNotGranted(await load("fonts/Brand.woff2", { origin: "null" }));
});
@@ -194,6 +205,16 @@ describe("an opaque preview frame's loads under its token", () => {
expect(html).toContain(`<base href="${tokened}">`);
expect(html.replaceAll(tokened, "")).not.toContain("/api/projects/demo/preview/");
});
it("serves the main preview under the token, re-based", async () => {
const res = await api.request(`http://localhost/projects/demo/preview/~${token}`, {
headers: { "sec-fetch-site": "same-origin", "sec-fetch-dest": "iframe" },
});
expect(res.status).toBe(200);
const html = await res.text();
expect(html).toContain('data-composition-id="main"');
expect(html).toContain(`<base href="/api/projects/demo/preview/~${token}/">`);
});
});
describe("a frame without the project's token", () => {
@@ -203,11 +224,13 @@ describe("a frame without the project's token", () => {
["a guessed token", `~${guessed}/`],
["another project's token", () => `~${otherToken}/`],
["a token of the wrong length", `~${"A".repeat(42)}/`],
])("gets no grant for a font or module script on %s", async (_name, prefix) => {
])("gets no grant for any load on %s", async (_name, prefix) => {
const at = typeof prefix === "function" ? prefix() : prefix;
for (const [dest, path] of [
["font", "fonts/Brand.woff2"],
["script", "scene.js"],
["image", "logo.png"],
["empty", "data.json"],
]) {
const res = await load(path!, { origin: "null", "sec-fetch-dest": dest! }, at);
expectNotGranted(res);
@@ -232,9 +255,12 @@ describe("a frame without the project's token", () => {
expectNotGranted(res);
});
it("refuses a font outside the preview path", async () => {
const res = await api.request("http://localhost/projects/demo/files/fonts/Brand.woff2", {
headers: { origin: "null", "sec-fetch-dest": "font", "sec-fetch-site": "cross-site" },
it.each([
["font", "fonts/Brand.woff2"],
["empty", "data.json"],
])("refuses a %s load of %s outside the preview path", async (dest, path) => {
const res = await api.request(`http://localhost/projects/demo/files/${path}`, {
headers: { origin: "null", "sec-fetch-dest": dest, "sec-fetch-site": "cross-site" },
});
expectNotGranted(res);
});