mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-04 21:17:30 +00:00
fix(skills): say a video carries its own data-start, not its wrapper
This commit is contained in:
@@ -24,7 +24,7 @@ Build what was asked: no voiceover or captions and no new aspect ratio unless th
|
||||
5. Never tween `display`, `visibility` or `autoAlpha` on a `.clip`; animate a child.
|
||||
6. No CSS `transform` on an element GSAP transforms; animate transforms, not `left`/`top`/`width`/`height`.
|
||||
7. Never `play()`, `pause()` or seek media. A `<video>` keeps its sound with `data-has-audio="true"`, else it is `muted`; music, voice, replacement sound and J/L cuts are a separate `<audio>`.
|
||||
8. Every `<audio>` has an `id` or it is left out of the mix. No `crossorigin` on media. Time a `<video>` or its wrapper, never both.
|
||||
8. Every `<audio>` has an `id` or it is left out of the mix. No `crossorigin` on media. Time the `<video>`, never its wrapper.
|
||||
9. Only the bundled fonts (`references/format.md`) resolve by name; any other family needs `@font-face` to a file in `assets/fonts/`.
|
||||
10. Asset paths: `assets/...` (no leading `/`), in sub-compositions too.
|
||||
11. Grades, grain, blur and vignettes on footage go through `npx hyperframes media-treatment` (`/media-use`), never CSS filters.
|
||||
|
||||
@@ -146,7 +146,7 @@ Studio's Detach audio writes a muted `<video>` and an `<audio>` of the same file
|
||||
| `video_missing_muted` | A timed `<video>` gets `data-has-audio="true"` or `muted` |
|
||||
| `gsap_css_transform_conflict` | Set the start inside the tween (`gsap.fromTo`) instead of a CSS `transform` |
|
||||
| `gsap_animates_clip_element` | Animate a child of the `.clip`, or its `opacity` |
|
||||
| `video_nested_in_timed_element` | Time the `<video>` or its wrapper, not both |
|
||||
| `video_nested_in_timed_element` | Keep `data-start` on the `<video>`; leave its wrapper untimed |
|
||||
| `media_missing_id`, `media_crossorigin_breaks_preview` | Give every `<audio>` an `id`; drop `crossorigin` |
|
||||
| `gsap_timeline_registered_before_async_build` | Register the timeline at the end of the async callback |
|
||||
| `standalone_composition_wrapped_in_template` | Only scene files use `<template>` |
|
||||
|
||||
Reference in New Issue
Block a user