ci(publish): name npm-publish as the approval gate for every publish (#7870)

* ci(publish): publish prebuilt tarballs from a job that runs no release-commit code

Builds, lifecycle scripts and packing move to a pack job with a read-only
token and no secrets. The publish job, which holds the npm token and the
write token, checks each tarball's name and version against the release and
uploads it with lifecycle scripts off. A version already on npm with other
contents fails the first attempt instead of being skipped.

* ci(publish): prerelease tag pushes publish only after a maintainer approves

A prerelease tag can come from any prerelease branch, which no PR review
covers. Tag-push runs now use the npm-prerelease environment, which requires
a maintainer's approval. Merged release PRs keep the npm-publish environment.

* ci(publish): keep every publish in the approval-gated npm-publish environment

npm's trusted publishers are pinned to npm-publish, and that environment now
requires a maintainer's approval with self-review prevented. A second
environment would fail npm auth, so the workflow keeps npm-publish for every
trigger. The docs and test name it as the approval gate.
This commit is contained in:
Michael Wang
2026-11-16 00:04:25 +00:00
committed by GitHub
parent b856a1d63f
commit a54de748ee
3 changed files with 16 additions and 1 deletions
+3
View File
@@ -299,6 +299,9 @@ jobs:
needs: [pack]
runs-on: ubuntu-latest
timeout-minutes: 30
# npm-publish requires a maintainer's approval. That approval is the only
# review a prerelease tag gets, because prerelease branches have no PR review.
# npm's trusted publishers name this environment, so every trigger uses it.
environment: npm-publish
# This job holds the release credentials, so it runs no code from the
# release commit: no install, no build, no repo scripts. It checks the
+4 -1
View File
@@ -32,7 +32,7 @@ On the first run, `release:prepare` drafts missing changelog artifacts and exits
See [Changelog process](/contributing/changelog-process) for the full workflow. For stable releases, `bun run set-version <version>` still enforces this checkpoint when maintainers run the lower-level release command directly.
Push the release branch without its local tag, open a PR to `main`, and merge it after approval and CI. The publish workflow checks out the exact PR merge SHA, verifies it before publishing, creates the stable tag at that commit, publishes npm packages, and creates the GitHub release.
Push the release branch without its local tag, open a PR to `main`, and merge it after approval and CI. The publish workflow checks out the exact PR merge SHA, verifies it before publishing, creates the stable tag at that commit, publishes npm packages, and creates the GitHub release. Before it publishes, the run waits for a maintainer to approve it in the `npm-publish` environment.
If that workflow needs recovery, rerun its original merged-PR event. Stable tag pushes and manual dispatches do not publish, so recovery cannot select a different commit.
@@ -50,6 +50,8 @@ git push origin next
git push origin v0.4.25-alpha.1
```
The tag push starts the publish workflow. It builds and packs the release, then waits for approval in the `npm-publish` environment. A maintainer other than the person who pushed the tag approves the run on the workflow page, and only then is anything published. A prerelease branch has no PR review, so this approval is its review.
Consumers can install alpha builds explicitly:
```bash
@@ -65,6 +67,7 @@ The publish workflow validates release channel boundaries before publishing:
- Prerelease versions must publish with the prerelease dist-tag, such as `alpha`.
- Stable releases must come from a merged, reviewed `release/vX.Y.Z` PR.
- Prerelease tags must be reachable from a prerelease branch.
- Every publish, stable or prerelease, waits for a maintainer other than the one who started it to approve the run in the `npm-publish` environment.
- Merged `release/vX.Y.Z` PRs publish stable releases only.
- Every publish job verifies that its checkout matches the immutable event SHA.
- Builds, lifecycle scripts and `npm pack` run in a job with a read-only token and no secrets.
+9
View File
@@ -483,3 +483,12 @@ test("publishing skips only identical uploads and fails on a version it did not
assert.match(rerun.stdout, /::warning::/);
assert.doesNotMatch(rerun.calls, /npm publish/);
});
test("every publish runs in the approval-gated npm-publish environment", () => {
assert.equal(publish.environment, "npm-publish");
const jobsWithEnvironment = Object.entries(config.jobs).filter(([, job]) => job.environment);
assert.deepEqual(
jobsWithEnvironment.map(([name]) => name),
["publish"],
);
});