ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-11-14 05:13:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(studio): revert handleHistoryHotkey scope creep per review

Browse Source 
Restore the original `const key = event.key.toLowerCase()` extraction
and drop the fallow-ignore-next-line that was only needed because the
rewrite introduced extra inline calls. The cross-origin fix lives in
syncPreviewHistoryHotkey, not in the handler body.
This commit is contained in:
Miguel Ángel
2026-05-21 17:28:30 -04:00
parent da69a25812
commit bf49d4887d
1 changed files with 14 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/studio/src/hooks/useAppHotkeys.ts
+14 -22
View File
@@ -351,28 +351,20 @@ export function useAppHotkeys({
// ── History hotkey for iframe forwarding ──
const handleHistoryHotkey = useCallback(
// fallow-ignore-next-line complexity
(event: KeyboardEvent) => {
if (!(event.metaKey || event.ctrlKey)) return;
if (shouldIgnoreHistoryShortcut(event.target)) return;
// Undo: Cmd/Ctrl+Z
if (event.key.toLowerCase() === "z" && !event.shiftKey) {
event.preventDefault();
void handleUndoRef.current();
return;
}
// Redo: Cmd/Ctrl+Shift+Z or Ctrl+Y
if (
(event.key.toLowerCase() === "z" && event.shiftKey) ||
(event.ctrlKey && !event.metaKey && event.key.toLowerCase() === "y")
) {
event.preventDefault();
void handleRedoRef.current();
}
},
[],
);
const handleHistoryHotkey = useCallback((event: KeyboardEvent) => {
if (!(event.metaKey || event.ctrlKey)) return;
if (shouldIgnoreHistoryShortcut(event.target)) return;
const key = event.key.toLowerCase();
if (key === "z" && !event.shiftKey) {
event.preventDefault();
void handleUndoRef.current();
return;
}
if ((key === "z" && event.shiftKey) || (event.ctrlKey && !event.metaKey && key === "y")) {
event.preventDefault();
void handleRedoRef.current();
}
}, []);
const syncPreviewHistoryHotkey = useCallback(
(iframe: HTMLIFrameElement | null) => {