fix(core): free a preview clip's decoder when the playhead leaves it (#7679)

* fix(core): free a preview clip's decoder when the playhead leaves it

* fix(core): keep audio buffered when the playhead leaves it, free only video decoders

* fix(core): leave Safari's loaded video alone when the playhead leaves it
This commit is contained in:
Miguel Ángel
2026-11-14 01:54:54 +00:00
committed by GitHub
parent affa03b60f
commit f7b49f1207
5 changed files with 53 additions and 42 deletions
@@ -278,13 +278,4 @@ describe("openSettledCompositionPage when nothing may listen", () => {
"window.__HF_REPLAY_SKIPPED_FRAMES = true",
);
});
it("asks the page to free clips the playhead left, so a long film does not hold every decoder", async () => {
const opened = fakeBrowser();
mocks.launch.mockResolvedValue(opened.browser);
await openSettledCompositionPage(HTML, "http://127.0.0.1:3000", OPTIONS);
expect(opened.page.evaluateOnNewDocument).toHaveBeenCalledWith(
"window.__HF_RELEASE_PASSED_MEDIA = true",
);
});
});
@@ -344,7 +344,6 @@ export async function openSettledCompositionPage(
await installMediaRenderIdBridge(page);
await page.evaluateOnNewDocument(forcePreservedDrawingBuffer);
await page.evaluateOnNewDocument("window.__HF_REPLAY_SKIPPED_FRAMES = true");
await page.evaluateOnNewDocument("window.__HF_RELEASE_PASSED_MEDIA = true");
await page.setViewport(viewport);
if (answer) await answerPageInProcess(page, url, answer);
await options.beforeNavigate?.(page);
+33 -22
View File
@@ -67,7 +67,6 @@ function resetRuntimeGlobals(): void {
window.__timelines = {};
delete window.__player;
delete window.__playerReady;
delete window.__HF_RELEASE_PASSED_MEDIA;
delete window.__renderReady;
delete window.__hfTimelinesBuilding;
const win = window as {
@@ -713,27 +712,37 @@ describe("runtime entry", () => {
expect(loadsOf(queued)).toEqual([1]);
});
it.each([
[true, 2],
[false, 1],
])(
"with a capture page flag %s, a fully buffered clip the playhead left is reloaded %s times",
async (flag, loadCount) => {
spyLoad();
servePreview();
window.__HF_RELEASE_PASSED_MEDIA = flag;
const [now, later] = videos(mountRoot(), "0", "9");
Object.defineProperty(now, "duration", { value: 5 });
Object.defineProperty(now, "buffered", {
value: { length: 1, start: () => 0, end: () => 5 },
});
it("frees a fully buffered clip the playhead has left, so it holds no decoder", async () => {
spyLoad();
servePreview();
const [now, later] = videos(mountRoot(), "0", "9");
Object.defineProperty(now, "duration", { value: 5 });
Object.defineProperty(now, "buffered", {
value: { length: 1, start: () => 0, end: () => 5 },
});
await evaluateRuntime();
window.__player?.seek(7.6);
expect(armed(now, later)).toEqual([false, true]);
expect(loadsOf(now)).toEqual([loadCount]);
},
);
await evaluateRuntime();
window.__player?.seek(7.6);
expect(armed(now, later)).toEqual([false, true]);
expect(loadsOf(now)).toEqual([2]);
});
it("keeps a fully buffered audio clip's buffer when the playhead leaves it", async () => {
spyLoad();
servePreview();
const root = mountRoot();
const now = timed(root, "audio", "0");
const later = timed(root, "audio", "9");
Object.defineProperty(now, "duration", { value: 5 });
Object.defineProperty(now, "buffered", {
value: { length: 1, start: () => 0, end: () => 5 },
});
await evaluateRuntime();
window.__player?.seek(7.6);
expect(armed(now, later)).toEqual([false, true]);
expect(loadsOf(now)).toEqual([1]);
});
it("frees a clip the playhead has passed while it is still downloading, and keeps one that finished", async () => {
spyLoad();
@@ -802,9 +811,11 @@ describe("runtime entry", () => {
servePreview();
const [, next] = videos(mountRoot(), "0", "5");
next.setAttribute("data-media-start", "6");
Object.defineProperty(next, "readyState", { value: 4 });
let readyState = 0;
Object.defineProperty(next, "readyState", { get: () => readyState });
await evaluateRuntime();
readyState = 4;
window.__player?.seek(3.5);
expect(next.currentTime).toBe(mediaElementTime(6));
expect(next.paused).toBe(true);
+19 -8
View File
@@ -2735,6 +2735,16 @@ export function initSandboxRuntimeModular(): void {
state.mediaForceSyncNextTick = true;
syncMediaForCurrentState();
};
// Chromium's software decoders cost threads per loaded video; WebKit's reload of a shared file stalls audio.
const freesBufferedVideo = (el: unknown): el is HTMLVideoElement =>
isVideoElement(el) && !isWebKit();
// A far clip can finish a load the parser started before its window was decided.
const onMediaLoadedWhileFar = (event: Event) => {
const el = event.currentTarget;
if (!freesBufferedVideo(el) || mediaNearPlayhead.get(el) !== false || el.readyState === 0)
return;
withoutOwnTimingRecords(el, () => releaseMedia(el, true));
};
const onMediaErrorForProxy = (event: Event) => {
if (isMediaElement(event.currentTarget)) {
handleErrorForProxy(event.currentTarget);
@@ -2765,6 +2775,7 @@ export function initSandboxRuntimeModular(): void {
mediaEl.removeEventListener("durationchange", scheduleMetadataDurationHydration);
mediaEl.removeEventListener("loadedmetadata", onMediaLoadedMetadataForProxy);
mediaEl.removeEventListener("loadedmetadata", onMediaLoadedMetadataForPlayhead);
mediaEl.removeEventListener("loadedmetadata", onMediaLoadedWhileFar);
mediaEl.removeEventListener("loadedmetadata", onMediaLoadedMetadataForRoute);
mediaEl.removeEventListener("error", onMediaErrorForProxy);
metadataBoundMedia.delete(mediaEl);
@@ -2822,6 +2833,7 @@ export function initSandboxRuntimeModular(): void {
// for <audio> — all guarded inside mediaProxy.ts itself.
mediaEl.addEventListener("loadedmetadata", onMediaLoadedMetadataForProxy);
mediaEl.addEventListener("loadedmetadata", onMediaLoadedMetadataForPlayhead);
mediaEl.addEventListener("loadedmetadata", onMediaLoadedWhileFar);
mediaEl.addEventListener("error", onMediaErrorForProxy);
// Proactive proxy-fallback trigger: consult the codec map and swap
@@ -3275,14 +3287,13 @@ export function initSandboxRuntimeModular(): void {
}
mediaNearPlayhead.set(el, near);
if (!near) {
if (el.preload !== "none") {
el.preload = "none";
// Frees a clip the window armed; on one the parser started, it would only restart the fetch.
if (decided)
withoutOwnTimingRecords(el, () =>
releaseMedia(el, !loadsAhead || window.__HF_RELEASE_PASSED_MEDIA === true),
);
}
const wasPreloading = el.preload !== "none";
el.preload = "none";
const video = freesBufferedVideo(el);
const holdsPipeline = video
? decided || el.readyState > 0 || el.networkState === 2
: wasPreloading && decided;
if (holdsPipeline) withoutOwnTimingRecords(el, () => releaseMedia(el, video || !loadsAhead));
} else if (!visible || decided === undefined) {
// Not a clip a jump lands on: the media sync arms that one, and load() would undo its seek.
if (visible) preloadMedia(el);
+1 -2
View File
@@ -122,8 +122,7 @@ declare global {
__HF_PARITY_MODE?: boolean;
/** Set by still-capture pages: seeks replay skipped frames at the composition fps, as a render does. */
__HF_REPLAY_SKIPPED_FRAMES?: boolean;
/** Set by check and snapshot, which seek through a film: a clip that leaves its window is freed. */
__HF_RELEASE_PASSED_MEDIA?: boolean;
/** Legacy debug-only fps hint. Render-mode runtime fps uses __HF_EXPORT_RENDER_SEEK_CONFIG.fps. */
__HF_FPS?: number;
__HF_MAX_DURATION_SEC?: number;