Commit Graph
2686 Commits
Author SHA1 Message Date
Vance IngallsandClaude Sonnet 5 1c3ebfea0c fix(studio): widen FlatSlider's click/drag hit area vertically
The track's visible line was only 2px tall, and pointerdown was bound
directly to that thin element, making it hard to grab. The hit area is
now 20px tall (a wrapping div) with the visible line rendered as a
thin decorative child, centered inside it — the ratio math only reads
left/width so click accuracy is unaffected.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:07:02 -07:00
Vance Ingalls 023b3263c7 fix(studio): animate the implicitly-closed group too, add regression test 2026-07-13 16:07:02 -07:00
Vance Ingalls 459a4fe3d1 feat(studio): animate flat inspector group expand/collapse
Adds a fast (120ms) CSS entrance animation for flat inspector accordion
group headers/body, gated to the group actually toggling (not derived
from remounting alone) to avoid a Chromium reflow quirk that otherwise
replays the animation on untouched collapsed siblings.
2026-07-13 16:07:02 -07:00
Vance Ingalls b337c330b3 refactor(studio): remove section pinning from the flat inspector 2026-07-13 16:06:53 -07:00
Vance IngallsandClaude Sonnet 5 e850ab2ec1 refactor(studio): scroll only the open group's body, keep headers fixed
Collapsed group headers render in fixed, non-scrolling document flow
above and below the open group; only the open group's own content
scrolls, in a dedicated region. Also fixes the flat inspector footer's
missing background.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:06:09 -07:00
Vance IngallsandClaude Sonnet 5 c8d1d59a49 fix(studio): restore capitalize, end-align, live-commit size, and autofocus in flat Text
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:06:09 -07:00
Vance Ingalls 6156621372 fix(studio): restore zero-strength revive, keyboard hold, and HDR detail in flat Grade 2026-07-13 16:06:09 -07:00
Vance Ingalls 628108cdce docs(studio): fix stale radius-row comment after unlink fix 2026-07-13 16:06:09 -07:00
Vance Ingalls dfbf05b609 fix(studio): restore stroke color, radius unlink, and mask inset in flat Style 2026-07-13 16:06:09 -07:00
Vance Ingalls cbbe2ae792 fix(studio): retire legacy Style and Grade sections from flat inspector
The flat inspector rendered its new Style/Grade groups AND the legacy
ColorGradingSection/StyleSections components a second time below them,
visibly doubling every control. Remove the now-redundant legacy render
call sites (and their now-unused imports) from PropertyPanelFlat.tsx;
those components stay intact for the legacy (flag-off) PropertyPanel.
2026-07-13 16:06:08 -07:00
Vance IngallsandClaude Sonnet 5 ef3e937a04 feat(studio): flatten multi-field Text, retiring TextSection fallback
FlatTextSection's multi-field branch (textFields.length > 1) now renders
FlatTextLayerList (Task 5) + the existing single-field FlatTextFieldEditor
for the active field, tracked via new local activeFieldKey state that
resyncs (useEffect) when the active field disappears from props. This
retires the legacy TextSection delegation entirely for that case; the
TextSection import is removed from propertyPanelFlatTextSection.tsx since
nothing else in the file referenced it.

Also updates propertyPanelSections.test.tsx and PropertyPanel.test.tsx,
which exercised/documented the old multi-field-falls-back-to-legacy-
TextSection behavior in comments and test titles — reworded to describe
the new flat path (assertions were already compatible and still pass).

Flag for reviewer: hideOwnHeading on the legacy TextSection component
(propertyPanelSections.tsx) was added in an earlier plan specifically for
this now-removed call site. It has no remaining consumer after this task
lands (PropertyPanel.tsx's legacy caller doesn't pass it). Left in place
per brief instruction — not deleting unilaterally, since that's a scope
decision for whoever reviews this task.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:06:01 -07:00
Vance IngallsandClaude Sonnet 5 28b5da94ab test(studio): assert stopPropagation prevents onSelect on remove click
Review proved the existing test didn't catch a broken stopPropagation
by temporarily removing it and confirming the suite still passed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:06:01 -07:00
Vance IngallsandClaude Sonnet 5 6c89167a00 feat(studio): add FlatTextLayerList for multi-field text
Originated layout, no design mock exists — flag for design review.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:06:00 -07:00
Vance IngallsandClaude Sonnet 5 f8460f7dbf test(studio): rename unpin test to match what it actually verifies
Review of the pin-aware group list refactor flagged the test name
claiming the group "closes" on unpin — it doesn't assert that, and
structurally the group re-opens (togglePin never touches openGroupId).
Retitled to describe only the return-to-stack behavior actually tested.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:06:00 -07:00
Vance Ingalls ae92364a4e feat(studio): render pinned groups first with a persisted, per-element-kind pin zone 2026-07-13 16:06:00 -07:00
Vance Ingalls 53c7a4f580 feat(studio): add PinnedGroupRow always-open pinned-group primitive 2026-07-13 16:06:00 -07:00
Vance Ingalls fe33895b5f feat(studio): add usePersistedPinnedGroups hook
Reads/writes the per-element-kind pinned-groups map added to
studioUiPreferences in the prior task, read-modify-writing the whole
map since writeStudioUiPreferences only shallow-merges top-level keys.
2026-07-13 16:05:59 -07:00
Vance IngallsandClaude Sonnet 5 42539ac335 feat(studio): persist per-element-type pinned groups in studioUiPreferences
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:05:59 -07:00
Vance IngallsandClaude Sonnet 5 e2b46b3fd5 feat(studio): wire the flat Grade group into the one-open accordion
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:04:28 -07:00
Vance IngallsandClaude Sonnet 5 a15a8d6ee5 feat(studio): add HDR warning banner and Apply-to-scope row, completing FlatColorGradingSection
Also adds a not-busy click assertion for the Apply button so
onApplyToScope is exercised end-to-end, not just its disabled state.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:04:28 -07:00
Vance Ingalls d66ba59317 feat(studio): add Blur and Pixelate effect sliders 2026-07-13 16:04:28 -07:00
Vance IngallsandClaude Sonnet 5 a2e2ddb17e feat(studio): add Vignette and Grain rows with tuned-settings sub-panel
Also hoists the pointerdown-drag/reset-click test scaffold shared by the
new Roundness tests and the existing Contrast/Exposure tests into helpers
(findRowByText/dragSliderTrack/clickSliderReset), and exempts pre-existing,
branch-inherited fallow findings unrelated to this task (TextFieldEditor
complexity from earlier Text-inspector commits; test-scaffold duplication
across four flat-inspector-series test files from Plans 2-4) via
.fallowrc.jsonc, per this repo's established convention for line-shift/
inherited findings.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:04:27 -07:00
Vance IngallsandClaude Sonnet 5 09ce465cfa refactor(studio): collapse dead-branch scale ternary in Adjust sliders
Review of Task 6 flagged the exposure/other-key scale ternary as always
resolving to 100 on both arms.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:04:27 -07:00
Vance Ingalls 6550f656b9 feat(studio): add the 10 Adjust sliders to FlatColorGradingSection 2026-07-13 16:04:27 -07:00
Vance Ingalls d9a12f017d feat(studio): add FlatColorGradingSection Preset and Custom LUT rows 2026-07-13 16:04:26 -07:00
Vance Ingalls 492cd89008 feat(studio): add FlatColorGradingAccessory (compare, status dot, reset) 2026-07-13 16:04:26 -07:00
Vance Ingalls 96fd16a5ed feat(studio): widen FlatSelectRow options to support label!=value entries 2026-07-13 16:04:26 -07:00
Vance Ingalls 8cc6bdb8d1 feat(studio): add centerTick and reset-slot to FlatSlider for bipolar grade rows 2026-07-13 16:04:25 -07:00
Vance Ingalls 2a6cd33059 refactor(studio): extract useColorGradingController from ColorGradingSection 2026-07-13 16:04:25 -07:00
Vance Ingalls 69c2dca46b feat(studio): wire the flat Media group into the one-open accordion 2026-07-13 16:00:56 -07:00
Vance Ingalls 7942f9d3d7 feat(studio): add fit/position rows to FlatMediaSection 2026-07-13 16:00:56 -07:00
Vance Ingalls 9637a1e768 feat(studio): add loop/muted/has-audio-track toggles to FlatMediaSection 2026-07-13 16:00:56 -07:00
Vance Ingalls ba9ad19e22 feat(studio): add volume/rate/media-start sliders to FlatMediaSection 2026-07-13 16:00:55 -07:00
Vance Ingalls 0858610073 feat(studio): add cutout sub-block to FlatMediaSection 2026-07-13 16:00:55 -07:00
Vance Ingalls b2183195e3 feat(studio): add FlatMediaSection scaffold + source/copy row 2026-07-13 16:00:55 -07:00
Vance Ingalls e3ac18da27 feat(studio): add FlatToggle primitive 2026-07-13 16:00:55 -07:00
Vance IngallsandClaude Sonnet 5 9c48c00ab6 fix(studio): recompute keyframe currentPct from the corrected timing basis in the flat Layout group
Follow-up to 684ec4e87: that fix corrected the seek target for Layout's
keyframe gutter via deriveElementTiming, but currentPct — which drives
KeyframeNavigation's diamond active/inactive state and prev/next arrow
targeting — still used PropertyPanel's naive elStart=0/elDuration=1
basis. For an element with animations but no explicit data-duration,
seeking to a keyframe's real absolute time no longer lit that
keyframe's diamond as active, and the prev/next arrows targeted the
wrong keyframes.

Thread currentTime into PropertyPanelFlat (swapping the now-redundant
currentPct prop 1-for-1, so PropertyPanel.tsx's line count is
unchanged) and recompute currentPct there from the same
deriveElementTiming basis already used for the seek fix.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:00:55 -07:00
Vance IngallsandClaude Sonnet 5 2240322050 fix(studio): reconcile keyframe-seek timing basis between flat Layout and Motion groups
Whole-plan coherence review (Plan 3a Layout + Plan 3b Motion) found that
Layout's keyframe gutter and Motion's Timing row independently derived an
element's start/duration and disagreed whenever an element had animations
but no explicit data-duration: Motion correctly inferred the range from the
element's GSAP tweens, while Layout's keyframe gutter fell back to a naive
`duration ?? 1`, so clicking a keyframe percentage in Layout could seek to a
different absolute time than what Motion's Timing row displayed.

Extract deriveElementTiming (propertyPanelFlatTimingDerivation.ts) as the
single shared basis both paths now consume: FlatTimingRow (Motion) and
PropertyPanelFlat's own elStart/elDuration (Layout's keyframe gutter and 3D
Transform block). PropertyPanelFlat now recomputes this basis itself from
its own element/gsapAnimations props instead of trusting the parent's naive
value, so PropertyPanel.tsx (and its legacy non-flat panel) is untouched.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:00:55 -07:00
Vance Ingalls 1944144705 feat(studio): wire the flat Motion group into the one-open accordion 2026-07-13 16:00:55 -07:00
Vance Ingalls 67534b1d35 feat(studio): compose FlatMotionSection from Timing and the flat effect-card list 2026-07-13 16:00:55 -07:00
Vance Ingalls 99de82565f feat(studio): add flat collapsed-header variant to AnimationCard 2026-07-13 16:00:54 -07:00
Vance Ingalls d94b906bb2 feat(studio): add FlatTimingRow for the flat Motion group 2026-07-13 16:00:54 -07:00
Vance IngallsandClaude Sonnet 5 6c06d187ec feat(studio): wire the flat Layout group into the one-open accordion
Thread the Layout-group values through PropertyPanel -> PropertyPanelFlat
and add the third FlatGroup to the one-open/pin accordion (unconditional,
matching legacy Layout). Default-open Layout when neither Text nor Style
applies.

Fix the Flex double-render: the legacy StyleSections still renders its own
Flex Section, and the new flat Layout group renders its own LayoutFlexBlock.
Add an additive optional hideFlex prop to StyleSections and pass it on the
flat path so Flex renders exactly once (from the flat Layout group). Non-flat
callers omit it and are unchanged.

Extract the shared onLivePreviewProps closure into gsapLivePreview.ts (it was
duplicated inline in the legacy path) so PropertyPanel.tsx stays within the
600-LOC studio gate.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:00:54 -07:00
Vance Ingalls db6cb2ab4c feat(studio): compose FlatLayoutSection from geometry, z-index, flex, and 3D blocks 2026-07-13 16:00:54 -07:00
Vance Ingalls ac7c0167bf feat(studio): nest the existing 3D transform sub-view in a flat wrapper 2026-07-13 16:00:54 -07:00
Vance IngallsandClaude Sonnet 5 52a099fef1 feat(studio): add flat Layout Z-index row and Flex sub-block
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-13 16:00:54 -07:00
Vance Ingalls 1eff57cc27 feat(studio): add flat Layout geometry rows (X/Y/W/H/Angle) with keyframe gutters 2026-07-13 16:00:54 -07:00
Vance Ingalls cf1442f110 feat(studio): wire the flat Style group into the one-open accordion 2026-07-13 16:00:54 -07:00
Vance Ingalls 4e5717562a feat(studio): add flat Opacity slider, completing the Style group 2026-07-13 16:00:53 -07:00
Vance Ingalls 6cf5d35abe feat(studio): add flat Overflow and Mask rows to the Style group 2026-07-13 16:00:53 -07:00